[{"id":22541,"web_url":"https://patchwork.libcamera.org/comment/22541/","msgid":"<20220401084631.GG3237525@pyrite.rasen.tech>","date":"2022-04-01T08:46:31","subject":"Re: [libcamera-devel] [PATCH 2/2] ipa: vimc: Rename\n\tprocessControls() to queueRequest()","submitter":{"id":97,"url":"https://patchwork.libcamera.org/api/people/97/","name":"Nicolas Dufresne via libcamera-devel","email":"libcamera-devel@lists.libcamera.org"},"content":"Hi Umang,\n\nOn Thu, Mar 31, 2022 at 10:27:25PM +0530, Umang Jain via libcamera-devel wrote:\n> Synchronise with other IPA intefaces (for e.g. IPU3, RkISP1)\n> that uses queueRequest() to pass in the request controls to\n> IPA.\n> \n> Signed-off-by: Umang Jain \n\nReviewed-by: Paul Elder \n\n> ---\n> include/libcamera/ipa/vimc.mojom | 2 +-\n> src/ipa/vimc/vimc.cpp | 6 +++---\n> src/libcamera/pipeline/vimc/vimc.cpp | 2 +-\n> 3 files changed, 5 insertions(+), 5 deletions(-)\n> \n> diff --git a/include/libcamera/ipa/vimc.mojom b/include/libcamera/ipa/vimc.mojom\n> index e3b14e38..e5ac3609 100644\n> --- a/include/libcamera/ipa/vimc.mojom\n> +++ b/include/libcamera/ipa/vimc.mojom\n> @@ -37,7 +37,7 @@ interface IPAVimcInterface {\n> \t * handle parameters at runtime.\n> \t */\n> \t[async] fillParams(uint32 frame, uint32 bufferId);\n> -\t[async] processControls(uint32 frame, libcamera.ControlList controls);\n> +\t[async] queueRequest(uint32 frame, libcamera.ControlList controls);\n> };\n> \n> interface IPAVimcEventInterface {\n> diff --git a/src/ipa/vimc/vimc.cpp b/src/ipa/vimc/vimc.cpp\n> index 8481b82b..315302c6 100644\n> --- a/src/ipa/vimc/vimc.cpp\n> +++ b/src/ipa/vimc/vimc.cpp\n> @@ -44,7 +44,7 @@ public:\n> \tvoid unmapBuffers(const std::vector &ids) override;\n> \n> \tvoid fillParams(uint32_t frame, uint32_t bufferId) override;\n> -\tvoid processControls(uint32_t frame, const ControlList &controls) override;\n> +\tvoid queueRequest(uint32_t frame, const ControlList &controls) override;\n> \n> private:\n> \tvoid initTrace();\n> @@ -140,8 +140,8 @@ void IPAVimc::fillParams([[maybe_unused]] uint32_t frame, uint32_t bufferId)\n> \tparamsFilled.emit(bufferId);\n> }\n> \n> -void IPAVimc::processControls([[maybe_unused]] uint32_t frame,\n> -\t\t\t [[maybe_unused]] const ControlList &controls)\n> +void IPAVimc::queueRequest([[maybe_unused]] uint32_t frame,\n> +\t\t\t [[maybe_unused]] const ControlList &controls)\n> {\n> }\n> \n> diff --git a/src/libcamera/pipeline/vimc/vimc.cpp b/src/libcamera/pipeline/vimc/vimc.cpp\n> index 29960fe3..69b83d07 100644\n> --- a/src/libcamera/pipeline/vimc/vimc.cpp\n> +++ b/src/libcamera/pipeline/vimc/vimc.cpp\n> @@ -432,7 +432,7 @@ int PipelineHandlerVimc::queueRequestDevice(Camera *camera, Request *request)\n> \tif (ret < 0)\n> \t\treturn ret;\n> \n> -\tdata->ipa_->processControls(request->sequence(), request->controls());\n> +\tdata->ipa_->queueRequest(request->sequence(), request->controls());\n> \n> \treturn 0;\n> }\n> -- \n> 2.31.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 45DEBC0F1B\n\tfor ;\n\tFri, 1 Apr 2022 08:46:41 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9C3C365633;\n\tFri, 1 Apr 2022 10:46:40 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 34ABB604B9\n\tfor ;\n\tFri, 1 Apr 2022 10:46:39 +0200 (CEST)","from pyrite.rasen.tech (h175-177-042-148.catv02.itscom.jp\n\t[175.177.42.148])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C9E5E486;\n\tFri, 1 Apr 2022 10:46:37 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1648802800;\n\tbh=+sxV5FC83sPiBE5O2IUt3KH5wsdyQBL8/lNXA7hm13w=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=DGy4TCqnXCB/tM/GuRMUNIKhQ2bQSONg6AyrnmduTnfSVCFF+9YfG55Ti8w1i7Fqc\n\tKQ0sd14YtzGZz9Ors8aOh4fgbsYC/Rfeq/vmeh47nc8IS2WKbaHTOJX6M/hkJlqpzq\n\tuHw265RKnNrRUY7YAQ6Y8Oq+6F+CGY4iYQe9Kmv4yVPBLgGokRwWK6bGPt2g4vfZkK\n\tj/RXdvALfDs5+YmV9A4l//LXR9pWxSa803b28+PS895Dm1O4IkHB5pJWXJo9HBGuj/\n\tkf1hcYLkzPT4kaNanoESRWswXm/1ykdXWiTPPHoiW7haeOgDwDLifVYWcNwpCpfMKc\n\tDVJdBzQ+eEyIg==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1648802798;\n\tbh=+sxV5FC83sPiBE5O2IUt3KH5wsdyQBL8/lNXA7hm13w=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=Q2pXbTzqmuPyGcz8YCvfF+BDAhS1hUhkNexzFxjq6HdWioHaYLHAC0gHpvjJlQieq\n\tGOg9OaSH6JwzRlIvldQtip0hpr5Yzi9gkCbAA3p69oFmR8PuQvRvoMOOsU13KNZA25\n\tjWgIyBxxZeUc9Dyi5BwfY/Y3JfrrXZYCeiNBwKeU="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"Q2pXbTzq\"; dkim-atps=neutral","Date":"Fri, 1 Apr 2022 17:46:31 +0900","To":"Umang Jain ","Message-ID":"<20220401084631.GG3237525@pyrite.rasen.tech>","References":"<20220331165725.188364-1-umang.jain@ideasonboard.com>\n\t<20220331165725.188364-3-umang.jain@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20220331165725.188364-3-umang.jain@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 2/2] ipa: vimc: Rename\n\tprocessControls() to queueRequest()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Paul Elder via libcamera-devel ","Reply-To":"paul.elder@ideasonboard.com","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":22546,"web_url":"https://patchwork.libcamera.org/comment/22546/","msgid":"","date":"2022-04-01T12:02:58","subject":"Re: [libcamera-devel] [PATCH 2/2] ipa: vimc: Rename\n\tprocessControls() to queueRequest()","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Umang,\n\nThank you for the patch.\n\nOn Thu, Mar 31, 2022 at 10:27:25PM +0530, Umang Jain via libcamera-devel wrote:\n> Synchronise with other IPA intefaces (for e.g. IPU3, RkISP1)\n\ns/intefaces/interfaces/\n\n> that uses queueRequest() to pass in the request controls to\n> IPA.\n> \n> Signed-off-by: Umang Jain \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> include/libcamera/ipa/vimc.mojom | 2 +-\n> src/ipa/vimc/vimc.cpp | 6 +++---\n> src/libcamera/pipeline/vimc/vimc.cpp | 2 +-\n> 3 files changed, 5 insertions(+), 5 deletions(-)\n> \n> diff --git a/include/libcamera/ipa/vimc.mojom b/include/libcamera/ipa/vimc.mojom\n> index e3b14e38..e5ac3609 100644\n> --- a/include/libcamera/ipa/vimc.mojom\n> +++ b/include/libcamera/ipa/vimc.mojom\n> @@ -37,7 +37,7 @@ interface IPAVimcInterface {\n> \t * handle parameters at runtime.\n> \t */\n> \t[async] fillParams(uint32 frame, uint32 bufferId);\n> -\t[async] processControls(uint32 frame, libcamera.ControlList controls);\n> +\t[async] queueRequest(uint32 frame, libcamera.ControlList controls);\n> };\n> \n> interface IPAVimcEventInterface {\n> diff --git a/src/ipa/vimc/vimc.cpp b/src/ipa/vimc/vimc.cpp\n> index 8481b82b..315302c6 100644\n> --- a/src/ipa/vimc/vimc.cpp\n> +++ b/src/ipa/vimc/vimc.cpp\n> @@ -44,7 +44,7 @@ public:\n> \tvoid unmapBuffers(const std::vector &ids) override;\n> \n> \tvoid fillParams(uint32_t frame, uint32_t bufferId) override;\n> -\tvoid processControls(uint32_t frame, const ControlList &controls) override;\n> +\tvoid queueRequest(uint32_t frame, const ControlList &controls) override;\n> \n> private:\n> \tvoid initTrace();\n> @@ -140,8 +140,8 @@ void IPAVimc::fillParams([[maybe_unused]] uint32_t frame, uint32_t bufferId)\n> \tparamsFilled.emit(bufferId);\n> }\n> \n> -void IPAVimc::processControls([[maybe_unused]] uint32_t frame,\n> -\t\t\t [[maybe_unused]] const ControlList &controls)\n> +void IPAVimc::queueRequest([[maybe_unused]] uint32_t frame,\n> +\t\t\t [[maybe_unused]] const ControlList &controls)\n> {\n> }\n> \n> diff --git a/src/libcamera/pipeline/vimc/vimc.cpp b/src/libcamera/pipeline/vimc/vimc.cpp\n> index 29960fe3..69b83d07 100644\n> --- a/src/libcamera/pipeline/vimc/vimc.cpp\n> +++ b/src/libcamera/pipeline/vimc/vimc.cpp\n> @@ -432,7 +432,7 @@ int PipelineHandlerVimc::queueRequestDevice(Camera *camera, Request *request)\n> \tif (ret < 0)\n> \t\treturn ret;\n> \n> -\tdata->ipa_->processControls(request->sequence(), request->controls());\n> +\tdata->ipa_->queueRequest(request->sequence(), request->controls());\n> \n> \treturn 0;\n> }","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3FC7FC3256\n\tfor ;\n\tFri, 1 Apr 2022 12:03:04 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8983B633A7;\n\tFri, 1 Apr 2022 14:03:03 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E461F633A6\n\tfor ;\n\tFri, 1 Apr 2022 14:03:01 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 4ED30486;\n\tFri, 1 Apr 2022 14:03:01 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1648814583;\n\tbh=VE83jMqE5wJmSErtWb4rKUTkb0c0Dh4YhTkedSYcE3I=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=rJbTx6N4WFfetUZuMjUbqqZ4OSOuceT0ct/0sZg3ysSN2sTioPzi+stMJ28Mg/zwY\n\ttTJ3xsPEbvKLFSGkQiIqXfAWDLMY0FcxXZiBiNF0YCZbJbRS6bGmmiXMSW1NE0OoWU\n\t1GtXfrMro+CuDziIqMtOwXnmBaIPDekf3IO0HgQUTtlYkNRV6u/U9AYXoXeLVmilaq\n\tQfZcq/a5X7x8bBolO0It0VtfSDI3Xe8Evinq9S3ozREknMO7U6Ib7nTMX0rqzwzbR3\n\tLztuVr0U1ix4pknTvw7E/ETT2SFGUGq7/7woMaM2jputh7U82x6MmknOhn8rmQ7rC8\n\tJXUuLQ0VYxYqA==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1648814581;\n\tbh=VE83jMqE5wJmSErtWb4rKUTkb0c0Dh4YhTkedSYcE3I=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=ESql/Z0QfGRpnMi3BQm7/zm7sxUBjIzpF4Stref5K9+DDKOh4c1hIgAbmh0a+Oeqp\n\tytKc5ltsLPZaH9Zr2wo03nAjv3BvedlVTXmqeDyF0WvzAqgsp7klbgpW0Lv0ikGjOR\n\t9G04o4FHm4h1LTBuqCryw9OE9vK5Z9eIiBOqUCzU="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"ESql/Z0Q\"; dkim-atps=neutral","Date":"Fri, 1 Apr 2022 15:02:58 +0300","To":"Umang Jain ","Message-ID":"","References":"<20220331165725.188364-1-umang.jain@ideasonboard.com>\n\t<20220331165725.188364-3-umang.jain@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20220331165725.188364-3-umang.jain@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 2/2] ipa: vimc: Rename\n\tprocessControls() to queueRequest()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]