[{"id":2100,"web_url":"https://patchwork.libcamera.org/comment/2100/","msgid":"<20190701233810.GC9228@bigcity.dyn.berto.se>","date":"2019-07-01T23:38:10","subject":"Re: [libcamera-devel] [PATCH v4 01/13] libcamera: v4l2_controls:\n\tAdd min and max to V4L2ControlInfo","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Laurent,\n\nThanks for your work.\n\nOn 2019-07-01 23:14:52 +0300, Laurent Pinchart wrote:\n> Add min() and max() methods to V4L2ControlInfo to report the control's\n> minimum and maximum value respectively.\n> \n> Signed-off-by: Laurent Pinchart \n> Reviewed-by: Kieran Bingham \n> Reviewed-by: Jacopo Mondi \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> src/libcamera/include/v4l2_controls.h | 6 ++++++\n> src/libcamera/v4l2_controls.cpp | 14 ++++++++++++++\n> 2 files changed, 20 insertions(+)\n> \n> diff --git a/src/libcamera/include/v4l2_controls.h b/src/libcamera/include/v4l2_controls.h\n> index 2c8cb9003f25..0047efab11fa 100644\n> --- a/src/libcamera/include/v4l2_controls.h\n> +++ b/src/libcamera/include/v4l2_controls.h\n> @@ -28,11 +28,17 @@ public:\n> \tsize_t size() const { return size_; }\n> \tconst std::string &name() const { return name_; }\n> \n> +\tint64_t min() const { return min_; }\n> +\tint64_t max() const { return max_; }\n> +\n> private:\n> \tunsigned int id_;\n> \tunsigned int type_;\n> \tsize_t size_;\n> \tstd::string name_;\n> +\n> +\tint64_t min_;\n> +\tint64_t max_;\n> };\n> \n> class V4L2Control\n> diff --git a/src/libcamera/v4l2_controls.cpp b/src/libcamera/v4l2_controls.cpp\n> index 78888de29642..af017bce48ba 100644\n> --- a/src/libcamera/v4l2_controls.cpp\n> +++ b/src/libcamera/v4l2_controls.cpp\n> @@ -74,6 +74,8 @@ V4L2ControlInfo::V4L2ControlInfo(const struct v4l2_query_ext_ctrl &ctrl)\n> \ttype_ = ctrl.type;\n> \tname_ = static_cast(ctrl.name);\n> \tsize_ = ctrl.elem_size * ctrl.elems;\n> +\tmin_ = ctrl.minimum;\n> +\tmax_ = ctrl.maximum;\n> }\n> \n> /**\n> @@ -100,6 +102,18 @@ V4L2ControlInfo::V4L2ControlInfo(const struct v4l2_query_ext_ctrl &ctrl)\n> * \\return The V4L2 control user readable name\n> */\n> \n> +/**\n> + * \\fn V4L2ControlInfo::min()\n> + * \\brief Retrieve the control minimum value\n> + * \\return The V4L2 control minimum value\n> + */\n> +\n> +/**\n> + * \\fn V4L2ControlInfo::max()\n> + * \\brief Retrieve the control maximum value\n> + * \\return The V4L2 control maximum value\n> + */\n> +\n> /**\n> * \\class V4L2Control\n> * \\brief A V4L2 control value\n> -- \n> Regards,\n> \n> Laurent Pinchart\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from mail-lf1-x142.google.com (mail-lf1-x142.google.com\n\t[IPv6:2a00:1450:4864:20::142])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 82A0A60BF8\n\tfor ;\n\tTue, 2 Jul 2019 01:38:12 +0200 (CEST)","by mail-lf1-x142.google.com with SMTP id j29so9928183lfk.10\n\tfor ;\n\tMon, 01 Jul 2019 16:38:12 -0700 (PDT)","from localhost (customer-145-14-112-32.stosn.net. [145.14.112.32])\n\tby smtp.gmail.com with ESMTPSA id\n\t137sm3486779ljj.46.2019.07.01.16.38.11\n\t(version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256);\n\tMon, 01 Jul 2019 16:38:11 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to\n\t:user-agent; bh=CNab+xLtlSsuMNCuVtn1oqf2jcmFyd4TY5xhOBhlycs=;\n\tb=Jp6u9T+I2+koDhFJUjRVYlhK8bOxt4S3fx5zP31kBvyepQHjBr0ItkEi6RLypdRvkC\n\t0EcP0P9Wf4yMeazBKkB0YC8kFZOlfm306sxKFybLGih3l302LuT4iVtjZCgHfH42wA4V\n\tgFiI+fmhFANLWjphNOAk66dFEftk0TXTuPzN/TDr3MJ4frqkAY6/SKV0FrrAuypeoKbp\n\tpAwd2EuVMm/Bm5ZAfZZJzQ9B8mTiMP3yinH9o3uIvbNxye+hAFG/J2xMS8yMnYNanP9+\n\tjxROQinFi/aDG4zookppkqi8VkpCaj5GTa2JaqjtEBzNGXxfE1edOZzNSUvnLjhZhxyQ\n\tgL9g==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to:user-agent;\n\tbh=CNab+xLtlSsuMNCuVtn1oqf2jcmFyd4TY5xhOBhlycs=;\n\tb=mUt1ogIeDW1mD/QbXpsfqTANJ1fRQa0cCOLbeT75WQdGSvju0iXriX5gA27x2F4zWW\n\tBvekU0x0roQpGRgBMeItKhewTRdigZz2D6MfYEaYDYvORAz9LEEb0PFo8oW7/ELDCSI/\n\tqcnLYbsmKHGvhy1IkHuGX7e/LFUs3TPHU66U5dhhPTYF+AASnEwfH3eO9plBLjPOgIxo\n\tGiBnhssr6wRcIq3MBP7lPl+6gZEXEAAGRT4ueEtSSxU11sqN6Is477bxuNBdtumUVi6r\n\tjR3R/iVgTtbfMDERA13xI3oNouNcKxo2gmbuOMO6+AOl3W7tRgqIv2izh+sGalimNRth\n\tkJrQ==","X-Gm-Message-State":"APjAAAV5P3UMi9zZuKiuVIjLIjnS0flp9eyKENvdc9jhiotO6j0osPWt\n\tPEG6+UIEGrc7y7jd6eWvyxD4RnL2ASs=","X-Google-Smtp-Source":"APXvYqztoPrkbDXt/QQeAobDcdTZA0VSdvqShutQlrUdKszWsI0/5MtyrMBABqOQG83MTk+7Nnpjgg==","X-Received":"by 2002:ac2:4890:: with SMTP id\n\tx16mr8158457lfc.183.1562024291972; \n\tMon, 01 Jul 2019 16:38:11 -0700 (PDT)","Date":"Tue, 2 Jul 2019 01:38:10 +0200","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190701233810.GC9228@bigcity.dyn.berto.se>","References":"<20190701201504.28487-1-laurent.pinchart@ideasonboard.com>\n\t<20190701201504.28487-2-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20190701201504.28487-2-laurent.pinchart@ideasonboard.com>","User-Agent":"Mutt/1.12.1 (2019-06-15)","Subject":"Re: [libcamera-devel] [PATCH v4 01/13] libcamera: v4l2_controls:\n\tAdd min and max to V4L2ControlInfo","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Mon, 01 Jul 2019 23:38:12 -0000"}}]