[{"id":22480,"web_url":"https://patchwork.libcamera.org/comment/22480/","msgid":"<20220328125526.gyantkyxwc66cnps@uno.localdomain>","date":"2022-03-28T12:55:26","subject":"Re: [libcamera-devel] [PATCH] libipa: camera_sensor_helper: Add\n\tOV5640 helper","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Laurent,\n\nOn Mon, Mar 28, 2022 at 03:04:04PM +0300, Laurent Pinchart via libcamera-devel wrote:\n> From: Paul Elder <paul.elder@ideasonboard.com>\n>\n> The OV5640 is am OmniVision sensor with a linear gain model, expressed\n> in 1/16 steps.\n>\n> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n\n\nReviewed-by: Jacopo Mondi <jacopo@jmondi.org>\n\nThanks\n   j\n\n> ---\n>  src/ipa/libipa/camera_sensor_helper.cpp | 11 +++++++++++\n>  1 file changed, 11 insertions(+)\n>\n> diff --git a/src/ipa/libipa/camera_sensor_helper.cpp b/src/ipa/libipa/camera_sensor_helper.cpp\n> index 0ec51f4e0753..c098e48cdfe0 100644\n> --- a/src/ipa/libipa/camera_sensor_helper.cpp\n> +++ b/src/ipa/libipa/camera_sensor_helper.cpp\n> @@ -407,6 +407,17 @@ public:\n>  };\n>  REGISTER_CAMERA_SENSOR_HELPER(\"ov2740\", CameraSensorHelperOv2740)\n>\n> +class CameraSensorHelperOv5640 : public CameraSensorHelper\n> +{\n> +public:\n> +\tCameraSensorHelperOv5640()\n> +\t{\n> +\t\tgainType_ = AnalogueGainLinear;\n> +\t\tgainConstants_.linear = { 1, 0, 0, 16 };\n> +\t}\n> +};\n> +REGISTER_CAMERA_SENSOR_HELPER(\"ov5640\", CameraSensorHelperOv5640)\n> +\n>  class CameraSensorHelperOv5670 : public CameraSensorHelper\n>  {\n>  public:\n> --\n> Regards,\n>\n> Laurent Pinchart\n>","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9A85CC3256\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 28 Mar 2022 12:55:30 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 069FD601F5;\n\tMon, 28 Mar 2022 14:55:30 +0200 (CEST)","from relay12.mail.gandi.net (relay12.mail.gandi.net\n\t[217.70.178.232])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6A36660135\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 28 Mar 2022 14:55:28 +0200 (CEST)","(Authenticated sender: jacopo@jmondi.org)\n\tby mail.gandi.net (Postfix) with ESMTPSA id CCBBB200012;\n\tMon, 28 Mar 2022 12:55:27 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1648472130;\n\tbh=VBrw0vDNuY80/TfXl/2RM+BGYONZ34x9k6qQvzy3cUk=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=rODIuxA6JDLo7LG8cTtrzpHvTJK4xoYEF+waCB7cN9lAJePaL5MTfzre3TCpLowb4\n\tOzbxi+tvPFz9fxGS8+Gy0bS/205RbH6qbOCe2SXaus8oy26Ucd7ErGBx4E4pmhy9s+\n\t5LpjvIWgOv9fH8TCZrcUBK0fWiSbw01HdSsJx5q7UeFRXUZMIOp8xveeKBVqrHgPNF\n\toz1bMeB5+UVw2Tc3M/XMVpvqK50YoaVc0F30TSbi4xYKEblVXDl4bvrlxzC5UMttLu\n\tMSvQowgQaCFIxEqBeDcETQDwnbzJAKKQDQT3LdFJzPdwEBnthmb3wyzwL54R+MKefS\n\tUpCaZc4eKQwew==","Date":"Mon, 28 Mar 2022 14:55:26 +0200","To":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","Message-ID":"<20220328125526.gyantkyxwc66cnps@uno.localdomain>","References":"<20220328120404.10880-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20220328120404.10880-1-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH] libipa: camera_sensor_helper: Add\n\tOV5640 helper","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","From":"Jacopo Mondi via libcamera-devel <libcamera-devel@lists.libcamera.org>","Reply-To":"Jacopo Mondi <jacopo@jmondi.org>","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":22482,"web_url":"https://patchwork.libcamera.org/comment/22482/","msgid":"<164847369385.15275.3185716339382849642@Monstersaurus>","date":"2022-03-28T13:21:33","subject":"Re: [libcamera-devel] [PATCH] libipa: camera_sensor_helper: Add\n\tOV5640 helper","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Laurent Pinchart via libcamera-devel (2022-03-28 13:04:04)\n> From: Paul Elder <paul.elder@ideasonboard.com>\n\nMissing SoB.\n\n> \n> The OV5640 is am OmniVision sensor with a linear gain model, expressed\n> in 1/16 steps.\n> \n\n/am/an/\n\n\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n\n> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n> ---\n>  src/ipa/libipa/camera_sensor_helper.cpp | 11 +++++++++++\n>  1 file changed, 11 insertions(+)\n> \n> diff --git a/src/ipa/libipa/camera_sensor_helper.cpp b/src/ipa/libipa/camera_sensor_helper.cpp\n> index 0ec51f4e0753..c098e48cdfe0 100644\n> --- a/src/ipa/libipa/camera_sensor_helper.cpp\n> +++ b/src/ipa/libipa/camera_sensor_helper.cpp\n> @@ -407,6 +407,17 @@ public:\n>  };\n>  REGISTER_CAMERA_SENSOR_HELPER(\"ov2740\", CameraSensorHelperOv2740)\n>  \n> +class CameraSensorHelperOv5640 : public CameraSensorHelper\n> +{\n> +public:\n> +       CameraSensorHelperOv5640()\n> +       {\n> +               gainType_ = AnalogueGainLinear;\n> +               gainConstants_.linear = { 1, 0, 0, 16 };\n> +       }\n> +};\n> +REGISTER_CAMERA_SENSOR_HELPER(\"ov5640\", CameraSensorHelperOv5640)\n> +\n>  class CameraSensorHelperOv5670 : public CameraSensorHelper\n>  {\n>  public:\n> -- \n> Regards,\n> \n> Laurent Pinchart\n>","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 564FEC0F1B\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 28 Mar 2022 13:21:38 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9790965631;\n\tMon, 28 Mar 2022 15:21:37 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0656160135\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 28 Mar 2022 15:21:37 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 903B32F7;\n\tMon, 28 Mar 2022 15:21:36 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1648473697;\n\tbh=b3dzMtKQuYpifHpkzKR79ZqEzKjLyjWtBA5tl6Mn+Ps=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=36WfXqtDtkV0L0XFwiePpC2pRnISwRu4xuAnZiVaTX3MnS7aA2jWv+Dn0TCdLiNNX\n\tzOjr5b6UuZ25CX2VViZ/DJeWeO2iJ1g+92tEm+L3iO3CB6u55PvE6AZkLvBmJ1MH78\n\t+M+2sDZ6eaQwKYOlKzYOZnJO+oEyAbXgQyrcjpZxCIJmAf1ZgAQWic+1OU2t/xCtI+\n\tb0fAo6tsHnfAFb7cWbTxOlR0lZF/GLJrQCnTV6RyC2PhFd86Ngipvw24cSS5V2p+ry\n\tUj+k4IFD/1qYFlfQlO1HXOBji8oTiYqb+hOLv3ssCaGrkwJ76gG0w4u6V0IthKapea\n\tPFwzI3EY49QiQ==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1648473696;\n\tbh=b3dzMtKQuYpifHpkzKR79ZqEzKjLyjWtBA5tl6Mn+Ps=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=DvGMNTsmI5sclLaus//GQi5GL1we6mjXUWMSNufEg/G1KtLQ2S57MbAPUE3VZiY+S\n\tFLlO48385phOYTqGLIjjZZ5LfJRS6h4P7PKZB69fIOJLzYjxZ1VcrgqcsERAq2yJOx\n\tOI8OZSWuOB4cdGRfJ/itIYPuXJlwMrk7oVKh5AYA="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"DvGMNTsm\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20220328120404.10880-1-laurent.pinchart@ideasonboard.com>","References":"<20220328120404.10880-1-laurent.pinchart@ideasonboard.com>","To":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>,\n\tlibcamera-devel@lists.libcamera.org","Date":"Mon, 28 Mar 2022 14:21:33 +0100","Message-ID":"<164847369385.15275.3185716339382849642@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH] libipa: camera_sensor_helper: Add\n\tOV5640 helper","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","From":"Kieran Bingham via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>","Reply-To":"Kieran Bingham <kieran.bingham@ideasonboard.com>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":22487,"web_url":"https://patchwork.libcamera.org/comment/22487/","msgid":"<YkG66CBs1BY48Dpa@pendragon.ideasonboard.com>","date":"2022-03-28T13:40:56","subject":"Re: [libcamera-devel] [PATCH] libipa: camera_sensor_helper: Add\n\tOV5640 helper","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Mon, Mar 28, 2022 at 02:21:33PM +0100, Kieran Bingham wrote:\n> Quoting Laurent Pinchart via libcamera-devel (2022-03-28 13:04:04)\n> > From: Paul Elder <paul.elder@ideasonboard.com>\n> \n> Missing SoB.\n\nOops. Paul, could you please reply with your SoB line ?\n\n> > The OV5640 is am OmniVision sensor with a linear gain model, expressed\n> > in 1/16 steps.\n> \n> /am/an/\n> \n> Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n> \n> > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n> > ---\n> >  src/ipa/libipa/camera_sensor_helper.cpp | 11 +++++++++++\n> >  1 file changed, 11 insertions(+)\n> > \n> > diff --git a/src/ipa/libipa/camera_sensor_helper.cpp b/src/ipa/libipa/camera_sensor_helper.cpp\n> > index 0ec51f4e0753..c098e48cdfe0 100644\n> > --- a/src/ipa/libipa/camera_sensor_helper.cpp\n> > +++ b/src/ipa/libipa/camera_sensor_helper.cpp\n> > @@ -407,6 +407,17 @@ public:\n> >  };\n> >  REGISTER_CAMERA_SENSOR_HELPER(\"ov2740\", CameraSensorHelperOv2740)\n> >  \n> > +class CameraSensorHelperOv5640 : public CameraSensorHelper\n> > +{\n> > +public:\n> > +       CameraSensorHelperOv5640()\n> > +       {\n> > +               gainType_ = AnalogueGainLinear;\n> > +               gainConstants_.linear = { 1, 0, 0, 16 };\n> > +       }\n> > +};\n> > +REGISTER_CAMERA_SENSOR_HELPER(\"ov5640\", CameraSensorHelperOv5640)\n> > +\n> >  class CameraSensorHelperOv5670 : public CameraSensorHelper\n> >  {\n> >  public:","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D2361C3256\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 28 Mar 2022 13:40:59 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 89BA565631;\n\tMon, 28 Mar 2022 15:40:59 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 706DE60135\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 28 Mar 2022 15:40:58 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 012D12F7;\n\tMon, 28 Mar 2022 15:40:57 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1648474859;\n\tbh=cmH3dwVWmAO70CHkY/vOPvy2iJTf1GvYJQIlShFBfv8=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=WOIHqIWj01sCsQHWjxymp7h1N2g0rOc64wfhyFI48p1ZSJOmwuYBHPaau7O555JP5\n\t+rDBcQoYuLkNGie5y4J5WPs5t/6i/Pvo0Ds8+KOCcUSK0Ub2IGcwnzxMUViVJCNOyV\n\tI6lJCxVof00/fEdUyM82/hrXmEFU5wmCTVcavYsyD9LhZnN/lk5OOnryNgcJEp2/wv\n\tSOQtwy8kofha7T82V/MVKsjF47YkxywLgFR+H9mSMFP9cCNcftc9DwG9t6ZfmiUXw8\n\tepBOWbpJgDfKXRpwuT/6ctBcW8uGRXxiOtn4YjFPjojmTJPiMUrxE2vWtaf8b6PNxf\n\tFgLbbzhkJqjwQ==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1648474858;\n\tbh=cmH3dwVWmAO70CHkY/vOPvy2iJTf1GvYJQIlShFBfv8=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=jE8w6gPad7R6c/39RNV+hjYlTaUm/iPoU7Rc28PCpSTEvHhKNoA7dgn1IvYD21Cl1\n\tFvWhm4EojLoqb9xy2waQ8Bmu5vBdUWwcRP/BLh+U7RP2NYmWNVZ45INtvmzL9keIzq\n\tpJ13eSCkdg5OX+v83uAwzas50VC3ZwsMEi9xxoaM="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"jE8w6gPa\"; dkim-atps=neutral","Date":"Mon, 28 Mar 2022 16:40:56 +0300","To":"Kieran Bingham <kieran.bingham@ideasonboard.com>","Message-ID":"<YkG66CBs1BY48Dpa@pendragon.ideasonboard.com>","References":"<20220328120404.10880-1-laurent.pinchart@ideasonboard.com>\n\t<164847369385.15275.3185716339382849642@Monstersaurus>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<164847369385.15275.3185716339382849642@Monstersaurus>","Subject":"Re: [libcamera-devel] [PATCH] libipa: camera_sensor_helper: Add\n\tOV5640 helper","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","From":"Laurent Pinchart via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>","Reply-To":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":22508,"web_url":"https://patchwork.libcamera.org/comment/22508/","msgid":"<20220329075906.GG3036343@pyrite.rasen.tech>","date":"2022-03-29T07:59:06","subject":"Re: [libcamera-devel] [PATCH] libipa: camera_sensor_helper: Add\n\tOV5640 helper","submitter":{"id":97,"url":"https://patchwork.libcamera.org/api/people/97/","name":"Nicolas Dufresne via libcamera-devel","email":"libcamera-devel@lists.libcamera.org"},"content":"On Mon, Mar 28, 2022 at 04:40:56PM +0300, Laurent Pinchart wrote:\n> On Mon, Mar 28, 2022 at 02:21:33PM +0100, Kieran Bingham wrote:\n> > Quoting Laurent Pinchart via libcamera-devel (2022-03-28 13:04:04)\n> > > From: Paul Elder <paul.elder@ideasonboard.com>\n> > \n> > Missing SoB.\n> \n> Oops. Paul, could you please reply with your SoB line ?\n\nSigned-off-by: Paul Elder <paul.elder@ideasonboard.com>\n\n> \n> > > The OV5640 is am OmniVision sensor with a linear gain model, expressed\n> > > in 1/16 steps.\n> > \n> > /am/an/\n> > \n> > Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n> > \n> > > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n> > > ---\n> > >  src/ipa/libipa/camera_sensor_helper.cpp | 11 +++++++++++\n> > >  1 file changed, 11 insertions(+)\n> > > \n> > > diff --git a/src/ipa/libipa/camera_sensor_helper.cpp b/src/ipa/libipa/camera_sensor_helper.cpp\n> > > index 0ec51f4e0753..c098e48cdfe0 100644\n> > > --- a/src/ipa/libipa/camera_sensor_helper.cpp\n> > > +++ b/src/ipa/libipa/camera_sensor_helper.cpp\n> > > @@ -407,6 +407,17 @@ public:\n> > >  };\n> > >  REGISTER_CAMERA_SENSOR_HELPER(\"ov2740\", CameraSensorHelperOv2740)\n> > >  \n> > > +class CameraSensorHelperOv5640 : public CameraSensorHelper\n> > > +{\n> > > +public:\n> > > +       CameraSensorHelperOv5640()\n> > > +       {\n> > > +               gainType_ = AnalogueGainLinear;\n> > > +               gainConstants_.linear = { 1, 0, 0, 16 };\n> > > +       }\n> > > +};\n> > > +REGISTER_CAMERA_SENSOR_HELPER(\"ov5640\", CameraSensorHelperOv5640)\n> > > +\n> > >  class CameraSensorHelperOv5670 : public CameraSensorHelper\n> > >  {\n> > >  public:\n> \n> -- \n> Regards,\n> \n> Laurent Pinchart","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 38B85C0F1B\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 29 Mar 2022 07:59:15 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7A91265633;\n\tTue, 29 Mar 2022 09:59:14 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 50C77604BE\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 29 Mar 2022 09:59:13 +0200 (CEST)","from pyrite.rasen.tech (h175-177-042-148.catv02.itscom.jp\n\t[175.177.42.148])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id CE5EE2F7;\n\tTue, 29 Mar 2022 09:59:11 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1648540754;\n\tbh=KsFhF23d2Q7pLOopoinye0ZfmoC35x1bE7RSx+CEmng=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=Tj1Vt6lC7AJTRcjQMz5jaHUG1saFSjm64r10BQvu+gDbmWYLIsMiZk3EgeXSGW6k2\n\tDR3Zz9eivQ5A1H86/nS/hGL9cQ6C7GGo+/69s5TeYP3/omRn687tDmUfhMgAWwVond\n\teO75/Xiu6L4Cy3X2vnnulO2xNdB4E/lSRryu1a1yYtSJbAnonkjJ8ZT6pZl2uPhehw\n\tHlO3CQApwX5Os78PG1BJoX/RmCbVxflR6DzV2G98k2nSG/e+djpjLiXyL/4GQGcvMM\n\tke1ImAsfSli+yy2g7gtucHqcNNP1rygcHOkh7kRtNzSmaq9ogWkI5s6XFiGZZ4BLFu\n\tNebLw2eOfAVyg==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1648540753;\n\tbh=KsFhF23d2Q7pLOopoinye0ZfmoC35x1bE7RSx+CEmng=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=aLp0jaxSf/amNhFkkpIH3p+1sSkAguQeMDe9taCLyyjMnjlyPlF+cNcfj1t6hksuV\n\tULem/3BbjABaMU8YsiBZoQ0uXlcZM7XMNrgJwV99rIECtqKREmM0DZ4nifn5biL3oG\n\tQ+wZPsg4UFkgw7UJNLzWNFAWh84W+P794gsJ5niM="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"aLp0jaxS\"; dkim-atps=neutral","Date":"Tue, 29 Mar 2022 16:59:06 +0900","To":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","Message-ID":"<20220329075906.GG3036343@pyrite.rasen.tech>","References":"<20220328120404.10880-1-laurent.pinchart@ideasonboard.com>\n\t<164847369385.15275.3185716339382849642@Monstersaurus>\n\t<YkG66CBs1BY48Dpa@pendragon.ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<YkG66CBs1BY48Dpa@pendragon.ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH] libipa: camera_sensor_helper: Add\n\tOV5640 helper","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","From":"Paul Elder via libcamera-devel <libcamera-devel@lists.libcamera.org>","Reply-To":"paul.elder@ideasonboard.com","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}}]