[{"id":22512,"web_url":"https://patchwork.libcamera.org/comment/22512/","msgid":"<20220329143540.qu5jbq5mmoxxiadm@uno.localdomain>","date":"2022-03-29T14:35:40","subject":"Re: [libcamera-devel] [PATCH 4/4] libipa: camera_sensor_helper: Add\n\tIMX296 helper","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Laurent\n\nOn Mon, Mar 28, 2022 at 03:03:36PM +0300, Laurent Pinchart via libcamera-devel wrote:\n> The IMX296 is a Sony sensor that expresses its gain in 0.1dB units. It\n> thus maps to the exponential gain model.\n>\n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n> ---\n> src/ipa/libipa/camera_sensor_helper.cpp | 11 +++++++++++\n> 1 file changed, 11 insertions(+)\n>\n> diff --git a/src/ipa/libipa/camera_sensor_helper.cpp b/src/ipa/libipa/camera_sensor_helper.cpp\n> index 136b9f6bc3c5..0ec51f4e0753 100644\n> --- a/src/ipa/libipa/camera_sensor_helper.cpp\n> +++ b/src/ipa/libipa/camera_sensor_helper.cpp\n> @@ -385,6 +385,17 @@ public:\n> };\n> REGISTER_CAMERA_SENSOR_HELPER(\"imx290\", CameraSensorHelperImx290)\n>\n> +class CameraSensorHelperImx296 : public CameraSensorHelper\n> +{\n> +public:\n> +\tCameraSensorHelperImx296()\n> +\t{\n> +\t\tgainType_ = AnalogueGainExponential;\n> +\t\tgainConstants_.exp = { 1.0, expGainDb(0.1) };\n> +\t}\n> +};\n> +REGISTER_CAMERA_SENSOR_HELPER(\"imx296\", CameraSensorHelperImx296)\n> +\n> class CameraSensorHelperOv2740 : public CameraSensorHelper\n> {\n> public:\n> --\n> Regards,\n>\n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 17DAEC3256\n\tfor ;\n\tTue, 29 Mar 2022 14:35:45 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5C986601F8;\n\tTue, 29 Mar 2022 16:35:44 +0200 (CEST)","from relay5-d.mail.gandi.net (relay5-d.mail.gandi.net\n\t[217.70.183.197])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 865A260135\n\tfor ;\n\tTue, 29 Mar 2022 16:35:42 +0200 (CEST)","(Authenticated sender: jacopo@jmondi.org)\n\tby mail.gandi.net (Postfix) with ESMTPSA id 05DF71C0003;\n\tTue, 29 Mar 2022 14:35:41 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1648564544;\n\tbh=AEH/FakLdL/DiRh1sdb8UiiGLTQzyZ5y4llDBS/LhLo=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=SRZIyuSFDA5UYOv1SSejM6MYFJYhvmDa8tGEWt166G/Ar+urbG/UoiK1lyhj0+Wu+\n\tB7s1XMQkOPbVPJxhSQjGin3P2vhQTic6z+OAorg1WBIikuSZlBvReByGYlWKg//L95\n\ts4wcOJ8E8rqSkCj8l3Ytzdof/KpIpzCeJDe7JlXAHqfOt2VPVhazFGhuqXteI5/AOp\n\tY99Tngfy1xQTPTF/WQTfnOrXv2BvSLN33sixl6PfuGTDBWfQETzi+ZmcdZDYD5zcFS\n\tspazq02pNZ63hJzGGaw7WGIp8kIpUg4vl3EH1R+Zrb0hBcNsiLhluWAbf7oqwrtWKl\n\tKUCRQS5osVHmA==","Date":"Tue, 29 Mar 2022 16:35:40 +0200","To":"Laurent Pinchart ","Message-ID":"<20220329143540.qu5jbq5mmoxxiadm@uno.localdomain>","References":"<20220328120336.10834-1-laurent.pinchart@ideasonboard.com>\n\t<20220328120336.10834-5-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20220328120336.10834-5-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 4/4] libipa: camera_sensor_helper: Add\n\tIMX296 helper","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Jacopo Mondi via libcamera-devel ","Reply-To":"Jacopo Mondi ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":22524,"web_url":"https://patchwork.libcamera.org/comment/22524/","msgid":"<4cb93c96-5175-9081-355d-5835136fee04@ideasonboard.com>","date":"2022-03-30T08:42:39","subject":"Re: [libcamera-devel] [PATCH 4/4] libipa: camera_sensor_helper: Add\n\tIMX296 helper","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"content":"Hi,\n\nOn 3/28/22 17:33, Laurent Pinchart via libcamera-devel wrote:\n> The IMX296 is a Sony sensor that expresses its gain in 0.1dB units. It\n> thus maps to the exponential gain model.\n>\n> Signed-off-by: Laurent Pinchart \n\n\nReviewed-by: Umang Jain \n\n> ---\n> src/ipa/libipa/camera_sensor_helper.cpp | 11 +++++++++++\n> 1 file changed, 11 insertions(+)\n>\n> diff --git a/src/ipa/libipa/camera_sensor_helper.cpp b/src/ipa/libipa/camera_sensor_helper.cpp\n> index 136b9f6bc3c5..0ec51f4e0753 100644\n> --- a/src/ipa/libipa/camera_sensor_helper.cpp\n> +++ b/src/ipa/libipa/camera_sensor_helper.cpp\n> @@ -385,6 +385,17 @@ public:\n> };\n> REGISTER_CAMERA_SENSOR_HELPER(\"imx290\", CameraSensorHelperImx290)\n> \n> +class CameraSensorHelperImx296 : public CameraSensorHelper\n> +{\n> +public:\n> +\tCameraSensorHelperImx296()\n> +\t{\n> +\t\tgainType_ = AnalogueGainExponential;\n> +\t\tgainConstants_.exp = { 1.0, expGainDb(0.1) };\n> +\t}\n> +};\n> +REGISTER_CAMERA_SENSOR_HELPER(\"imx296\", CameraSensorHelperImx296)\n> +\n> class CameraSensorHelperOv2740 : public CameraSensorHelper\n> {\n> public:","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8E241C3256\n\tfor ;\n\tWed, 30 Mar 2022 08:42:51 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3F12665635;\n\tWed, 30 Mar 2022 10:42:51 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0B51C60397\n\tfor ;\n\tWed, 30 Mar 2022 10:42:50 +0200 (CEST)","from [192.168.1.105] (unknown [103.74.73.208])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 9F42059D;\n\tWed, 30 Mar 2022 10:42:48 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1648629771;\n\tbh=EK36vu8VCuczPYN5IqTFr7NANkMquNqRc0UDLFU6l70=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=i47yGbx3MCiBVvfwlkcHLbcIr7y8XhtTn6m5XDYvMssqFwQSaklxLp9DyfIWBd4rp\n\tGabzr/jaPxK+7k7Ofo1xfYhx4EyDPbDbWgwbsudi+uptxgPLFaaqYdymz+aiKDsQp2\n\toBgSFyYHYVwjK0n8rvztCQ23WbFApA3hgAln2kjiiCyLfmIA2R8MEFxjgpPHPXO0HD\n\t8nKsSvlzUsNtQv4qcL3Yy+pkMejjGbF/SUPGhmL8IJJy9kB656Ozfgtv2CXt2BTcyc\n\tKEb3LJ7AjLmIHLLVH1Sq+DhetTyPbimEGvzXOykRTgyMZOoU8wlzvstNwxxnJRswf8\n\tqWB102K95esjw==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1648629769;\n\tbh=EK36vu8VCuczPYN5IqTFr7NANkMquNqRc0UDLFU6l70=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=MGXLbzNir1c+b+8EG4LfG05e8KXbf0Ib+u4bEP5xhqbEnvr+FDNG0JXcl5TrZVx+U\n\t24wzEkbKvGI+eznSOatpAh3cA88149hDtPjRnoK43dfK5IzmTx/m9o80BQ7NAgG+1z\n\ts/OZK/CATmtRrLuYm1xoSxGeYPMLEJz1Om3wq49s="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"MGXLbzNi\"; dkim-atps=neutral","Message-ID":"<4cb93c96-5175-9081-355d-5835136fee04@ideasonboard.com>","Date":"Wed, 30 Mar 2022 14:12:39 +0530","MIME-Version":"1.0","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101\n\tThunderbird/91.4.1","Content-Language":"en-US","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20220328120336.10834-1-laurent.pinchart@ideasonboard.com>\n\t<20220328120336.10834-5-laurent.pinchart@ideasonboard.com>","In-Reply-To":"<20220328120336.10834-5-laurent.pinchart@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH 4/4] libipa: camera_sensor_helper: Add\n\tIMX296 helper","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Umang Jain via libcamera-devel ","Reply-To":"Umang Jain ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":22526,"web_url":"https://patchwork.libcamera.org/comment/22526/","msgid":"<20220330084632.GC3237525@pyrite.rasen.tech>","date":"2022-03-30T08:46:32","subject":"Re: [libcamera-devel] [PATCH 4/4] libipa: camera_sensor_helper: Add\n\tIMX296 helper","submitter":{"id":97,"url":"https://patchwork.libcamera.org/api/people/97/","name":"Nicolas Dufresne via libcamera-devel","email":"libcamera-devel@lists.libcamera.org"},"content":"Hi Laurent,\n\nOn Mon, Mar 28, 2022 at 03:03:36PM +0300, Laurent Pinchart via libcamera-devel wrote:\n> The IMX296 is a Sony sensor that expresses its gain in 0.1dB units. It\n> thus maps to the exponential gain model.\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Paul Elder \n\n> ---\n> src/ipa/libipa/camera_sensor_helper.cpp | 11 +++++++++++\n> 1 file changed, 11 insertions(+)\n> \n> diff --git a/src/ipa/libipa/camera_sensor_helper.cpp b/src/ipa/libipa/camera_sensor_helper.cpp\n> index 136b9f6bc3c5..0ec51f4e0753 100644\n> --- a/src/ipa/libipa/camera_sensor_helper.cpp\n> +++ b/src/ipa/libipa/camera_sensor_helper.cpp\n> @@ -385,6 +385,17 @@ public:\n> };\n> REGISTER_CAMERA_SENSOR_HELPER(\"imx290\", CameraSensorHelperImx290)\n> \n> +class CameraSensorHelperImx296 : public CameraSensorHelper\n> +{\n> +public:\n> +\tCameraSensorHelperImx296()\n> +\t{\n> +\t\tgainType_ = AnalogueGainExponential;\n> +\t\tgainConstants_.exp = { 1.0, expGainDb(0.1) };\n> +\t}\n> +};\n> +REGISTER_CAMERA_SENSOR_HELPER(\"imx296\", CameraSensorHelperImx296)\n> +\n> class CameraSensorHelperOv2740 : public CameraSensorHelper\n> {\n> public:","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5EADFC0F1B\n\tfor ;\n\tWed, 30 Mar 2022 08:46:40 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1884365635;\n\tWed, 30 Mar 2022 10:46:40 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 68D8A60397\n\tfor ;\n\tWed, 30 Mar 2022 10:46:39 +0200 (CEST)","from pyrite.rasen.tech (h175-177-042-148.catv02.itscom.jp\n\t[175.177.42.148])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 3938B59D;\n\tWed, 30 Mar 2022 10:46:37 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1648630000;\n\tbh=6hDByB5ENSzVeYTMqjaw76uODO6DBRvZsjMZWyUxcAU=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=x5RNOjz/3OCOG8p72RfDe7sXddS+pPVhXU19JT3o/1Cr+7bwD7Ou9MmRmjOqvTOh1\n\tL3zS2DoTCkP6JmCqK9XVmXFORWmr7sC9YaOUk9rAnuAZ6yUt7phWPvjpXR3WDpwiez\n\t6alxYbsa70Dj1GjZdqLQvlJIFU/jOTIGTGIHj9xMK9gnuv26m0TYa5UT2hr909LZUg\n\t0UHemnHXtwJq39njFeiDsuK3MSLeoWskvehqG8viPIM/DYOZuQPpHb/IfyXkhHqU76\n\tzD2Vno2IffzM/lMof4FiXyu+DKEtTWMt2VGBJ+mkUn7fTbhvry9JMmnagXfDtM8M7B\n\tVdfkSFay9Ek7g==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1648629999;\n\tbh=6hDByB5ENSzVeYTMqjaw76uODO6DBRvZsjMZWyUxcAU=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=luFgEtkmbyPDyyGaNsut/g+1+SsTXd7vU7Fat6EoulJY7zO3CuURhVydu4O/7+wS7\n\tUmlihvq8G7scN0deXj5xw6v+SvGYZ7z1MGvpZblgbasejPi4XyUwF4AXmimF2yyxo1\n\tOgJUTDt+VjzFUMPQtu5h9YK1TlUcGRWDtQYUnt5U="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"luFgEtkm\"; dkim-atps=neutral","Date":"Wed, 30 Mar 2022 17:46:32 +0900","To":"Laurent Pinchart ","Message-ID":"<20220330084632.GC3237525@pyrite.rasen.tech>","References":"<20220328120336.10834-1-laurent.pinchart@ideasonboard.com>\n\t<20220328120336.10834-5-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20220328120336.10834-5-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 4/4] libipa: camera_sensor_helper: Add\n\tIMX296 helper","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Paul Elder via libcamera-devel ","Reply-To":"paul.elder@ideasonboard.com","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]