[{"id":22481,"web_url":"https://patchwork.libcamera.org/comment/22481/","msgid":"<20220328125638.zjtqgvjtyzf2lhw5@uno.localdomain>","date":"2022-03-28T12:56:38","subject":"Re: [libcamera-devel] [PATCH] libcamera: camera_sensor: Add IMX290\n\tsensor properties","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Laurent,\n\nOn Mon, Mar 28, 2022 at 02:56:42PM +0300, Laurent Pinchart via libcamera-devel wrote:\n> The Sony IMX290 is a rolling shutter sensor with a 1945x1109 pixel array\n> size, with a recommended resolution after CFA interpolation of\n> 1920x1080.\n>\n> Signed-off-by: Laurent Pinchart \n\nI don't have a datasheet so I trust your calculations\n\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n> ---\n> src/libcamera/camera_sensor_properties.cpp | 4 ++++\n> 1 file changed, 4 insertions(+)\n>\n> diff --git a/src/libcamera/camera_sensor_properties.cpp b/src/libcamera/camera_sensor_properties.cpp\n> index 80a0bbac8901..7a3490125e11 100644\n> --- a/src/libcamera/camera_sensor_properties.cpp\n> +++ b/src/libcamera/camera_sensor_properties.cpp\n> @@ -90,6 +90,10 @@ const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen\n> \t\t\t\t{ controls::draft::TestPatternModePn9, 4 },\n> \t\t\t},\n> \t\t} },\n> +\t\t{ \"imx290\", {\n> +\t\t\t.unitCellSize = { 2900, 2900 },\n> +\t\t\t.testPatternModes = {},\n> +\t\t} },\n> \t\t{ \"imx296\", {\n> \t\t\t.unitCellSize = { 3450, 3450 },\n> \t\t\t.testPatternModes = {},\n> --\n> Regards,\n>\n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B9C87C3256\n\tfor ;\n\tMon, 28 Mar 2022 12:56:42 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 77D27601F5;\n\tMon, 28 Mar 2022 14:56:42 +0200 (CEST)","from relay5-d.mail.gandi.net (relay5-d.mail.gandi.net\n\t[217.70.183.197])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6BAFF60135\n\tfor ;\n\tMon, 28 Mar 2022 14:56:40 +0200 (CEST)","(Authenticated sender: jacopo@jmondi.org)\n\tby mail.gandi.net (Postfix) with ESMTPSA id 00BC11C0002;\n\tMon, 28 Mar 2022 12:56:39 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1648472202;\n\tbh=/0b6///YmYoWZwau7NgQp8ej7QpA35d/Bbcr2OCepqY=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=KLcjikE+DfG72YJ2gTb85tK10x4Tm9x866e+dug40fK0gg0BOnQPHdblbKKKygAvB\n\tfJVCPsv9/cMOHyiVyhKZi6NK/v58IN/PkXoibiH2FkSliODmUbusAg2HTJYM+okDnJ\n\tzndP7Rm0Xq1eQnudkm9+8xeHDYt6u4Kg5bjB92b9/rJGgqOf2P6HnGOyscjcsft4Tm\n\t73eRTseOQnjI+ztq1EEvodCr186riCQ2Bx5WnFj19wk94kGTdt6sK1ct+Be4GjSCMo\n\tzBdDoBMdZtbkJ+ySEL8croFccv8V0rSnDAJMG9t5Ot55ek+P6xNJZJOGs41q+8BItW\n\tUuA4y0tO+/8FA==","Date":"Mon, 28 Mar 2022 14:56:38 +0200","To":"Laurent Pinchart ","Message-ID":"<20220328125638.zjtqgvjtyzf2lhw5@uno.localdomain>","References":"<20220328115642.10601-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20220328115642.10601-1-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH] libcamera: camera_sensor: Add IMX290\n\tsensor properties","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Jacopo Mondi via libcamera-devel ","Reply-To":"Jacopo Mondi ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":22484,"web_url":"https://patchwork.libcamera.org/comment/22484/","msgid":"<164847436152.15275.9314891089166350678@Monstersaurus>","date":"2022-03-28T13:32:41","subject":"Re: [libcamera-devel] [PATCH] libcamera: camera_sensor: Add IMX290\n\tsensor properties","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Jacopo Mondi via libcamera-devel (2022-03-28 13:56:38)\n> Hi Laurent,\n> \n> On Mon, Mar 28, 2022 at 02:56:42PM +0300, Laurent Pinchart via libcamera-devel wrote:\n> > The Sony IMX290 is a rolling shutter sensor with a 1945x1109 pixel array\n> > size, with a recommended resolution after CFA interpolation of\n> > 1920x1080.\n> >\n> > Signed-off-by: Laurent Pinchart \n> \n> I don't have a datasheet so I trust your calculations\n> \n> Reviewed-by: Jacopo Mondi \n> \n> Thanks\n> j\n> \n> > ---\n> > src/libcamera/camera_sensor_properties.cpp | 4 ++++\n> > 1 file changed, 4 insertions(+)\n> >\n> > diff --git a/src/libcamera/camera_sensor_properties.cpp b/src/libcamera/camera_sensor_properties.cpp\n> > index 80a0bbac8901..7a3490125e11 100644\n> > --- a/src/libcamera/camera_sensor_properties.cpp\n> > +++ b/src/libcamera/camera_sensor_properties.cpp\n> > @@ -90,6 +90,10 @@ const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen\n> > { controls::draft::TestPatternModePn9, 4 },\n> > },\n> > } },\n> > + { \"imx290\", {\n> > + .unitCellSize = { 2900, 2900 },\n\nMatches the values reported in \nhttps://www.sony-semicon.co.jp/products/common/pdf/IMX226CLJ_CQJ_Flyer.pdf\n\nInterestingly it also says: \n\n> \"Number of effective pixels: 1945 (H) × 1097 (V)\"\n\nWhich I guess is the 1109 - some vertical blanking. But I haven't see\nthose values yet. Perhaps they're hidden in more complete datasheets\nthat I don't have access to.\n\nBut I don't see any reason to doubt this otherwise so:\n\nReviewed-by: Kieran Bingham \n\n> > + .testPatternModes = {},\n> > + } },\n> > { \"imx296\", {\n> > .unitCellSize = { 3450, 3450 },\n> > .testPatternModes = {},\n> > --\n> > Regards,\n> >\n> > Laurent Pinchart\n> >","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D61A0C0F1B\n\tfor ;\n\tMon, 28 Mar 2022 13:32:46 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3C5FC65631;\n\tMon, 28 Mar 2022 15:32:46 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 01C3360135\n\tfor ;\n\tMon, 28 Mar 2022 15:32:43 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 71F402F7;\n\tMon, 28 Mar 2022 15:32:43 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1648474366;\n\tbh=drAoC4NBBcNFD2yci4f4wxsP4eSu42p+MPbTZUc7YUc=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=ak5m96T/v3hRTJYvcHSU/w4cAxHMhHaywX3TXHMCH1K9K58/vTLGcHVn3/F2uEBWw\n\tv+8BCKnsrWEi2VlfEU9swcjwCcvlagejDJ+zK4fyfnTL22VwXrvZSg083nNyhHnemb\n\tJTkf2fpOImjfJ+uAUPrUZLCpXlb2WuA4M9EUcIbLciJ2VExZOk/Sne6ctGDSUfIMM/\n\t/QJLUysjU+cPfV9eUun9yrV0H6AsCjbgGL9tHX7f93bsq+HIE1oBBGdW1ib0xcis0Q\n\toiI4T4WAAs1pMMaA96UbQ0TYYsDD3/n2HTt5DXmPgAyK86sK3BJReBc8Sj3NbyudAn\n\t4xC3vg0sXtXoA==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1648474363;\n\tbh=drAoC4NBBcNFD2yci4f4wxsP4eSu42p+MPbTZUc7YUc=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=U8dFGHHpuQVXwbDp8PKYlRh68gQyfXbNsIEzQV/z2kv3d1M/yr6uoD/ZtERmybVlf\n\thk4Oedt00NS1gM5yZb0lGT1/JNwesNO3CElkdR6mcYzI3F9BBSL7d+GaekwuivLBnk\n\tjlkMSy4eAXLn8zqPvW70YNXHDmoRtyRGN96L8c3E="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"U8dFGHHp\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20220328125638.zjtqgvjtyzf2lhw5@uno.localdomain>","References":"<20220328115642.10601-1-laurent.pinchart@ideasonboard.com>\n\t<20220328125638.zjtqgvjtyzf2lhw5@uno.localdomain>","To":"Jacopo Mondi , Jacopo Mondi via libcamera-devel\n\t, \n\tLaurent Pinchart ","Date":"Mon, 28 Mar 2022 14:32:41 +0100","Message-ID":"<164847436152.15275.9314891089166350678@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH] libcamera: camera_sensor: Add IMX290\n\tsensor properties","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kieran Bingham via libcamera-devel\n\t","Reply-To":"Kieran Bingham ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":22486,"web_url":"https://patchwork.libcamera.org/comment/22486/","msgid":"","date":"2022-03-28T13:40:14","subject":"Re: [libcamera-devel] [PATCH] libcamera: camera_sensor: Add IMX290\n\tsensor properties","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nOn Mon, Mar 28, 2022 at 02:32:41PM +0100, Kieran Bingham wrote:\n> Quoting Jacopo Mondi via libcamera-devel (2022-03-28 13:56:38)\n> > On Mon, Mar 28, 2022 at 02:56:42PM +0300, Laurent Pinchart via libcamera-devel wrote:\n> > > The Sony IMX290 is a rolling shutter sensor with a 1945x1109 pixel array\n> > > size, with a recommended resolution after CFA interpolation of\n> > > 1920x1080.\n> > >\n> > > Signed-off-by: Laurent Pinchart \n> > \n> > I don't have a datasheet so I trust your calculations\n> > \n> > Reviewed-by: Jacopo Mondi \n> > \n> > > ---\n> > > src/libcamera/camera_sensor_properties.cpp | 4 ++++\n> > > 1 file changed, 4 insertions(+)\n> > >\n> > > diff --git a/src/libcamera/camera_sensor_properties.cpp b/src/libcamera/camera_sensor_properties.cpp\n> > > index 80a0bbac8901..7a3490125e11 100644\n> > > --- a/src/libcamera/camera_sensor_properties.cpp\n> > > +++ b/src/libcamera/camera_sensor_properties.cpp\n> > > @@ -90,6 +90,10 @@ const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen\n> > > { controls::draft::TestPatternModePn9, 4 },\n> > > },\n> > > } },\n> > > + { \"imx290\", {\n> > > + .unitCellSize = { 2900, 2900 },\n> \n> Matches the values reported in \n> https://www.sony-semicon.co.jp/products/common/pdf/IMX226CLJ_CQJ_Flyer.pdf\n> \n> Interestingly it also says: \n> \n> > \"Number of effective pixels: 1945 (H) × 1097 (V)\"\n> \n> Which I guess is the 1109 - some vertical blanking. But I haven't see\n> those values yet. Perhaps they're hidden in more complete datasheets\n> that I don't have access to.\n\nThere are also 10 rows of usable optical blank, and 2 rows of ignored\noptical blank.\n\n> But I don't see any reason to doubt this otherwise so:\n> \n> Reviewed-by: Kieran Bingham \n> \n> > > + .testPatternModes = {},\n> > > + } },\n> > > { \"imx296\", {\n> > > .unitCellSize = { 3450, 3450 },\n> > > .testPatternModes = {},","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B5137C3256\n\tfor ;\n\tMon, 28 Mar 2022 13:40:18 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 139E065631;\n\tMon, 28 Mar 2022 15:40:18 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E944C60135\n\tfor ;\n\tMon, 28 Mar 2022 15:40:16 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 4C8A82F7;\n\tMon, 28 Mar 2022 15:40:16 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1648474818;\n\tbh=5/zGjO82XZQaHJ+hAic57WGgF3PAD3ukJ4gCJnsl3D0=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=flWKDkRukfUBX5Iyen8TLnOMo1h72YelSbU2XEL1LMr6qgjRY55Be2cmdykEW2Uvl\n\t/WktX2ePYcdsHvjY0fZ8drFFTOFu0IiEwGv1mEPl3/QHDitRXtktO8mZImST+nIqzf\n\tosQ7HN0Uyj6liPEtbFborAokxHM/QX+AXZc0TaW92cz2zqKyqWFSc4mi4hUn/eoIa/\n\tMi3Ale6wrMXF/c4OBWgE1kig0YEE1SniDqvlgtbLV9sv/wOa6cqpwyojFS2LeXTWm6\n\tU5RDcpKTrzwhe4ItZBlqFIDD4nzZ0csx8PlMVtmjHJsqS9uC4/akMhiacEf1OU63sG\n\tMB3MUh0EPkYXg==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1648474816;\n\tbh=5/zGjO82XZQaHJ+hAic57WGgF3PAD3ukJ4gCJnsl3D0=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=PZdTP5CcpZKCxjxRi5W/wfTu+NbLQmq8AiOgkFURf9y3Njh+bco20wxoBMqPrrxao\n\trowZDkfUzs3w3Y2INRreynS0dSXHpbh0a9zzKHpStPLWzNe/bwNBGGc/00UYFECLem\n\tctqz1NFZrCwmn+9vIYw4eLcuiMEWg/Svywcf9elg="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"PZdTP5Cc\"; dkim-atps=neutral","Date":"Mon, 28 Mar 2022 16:40:14 +0300","To":"Kieran Bingham ","Message-ID":"","References":"<20220328115642.10601-1-laurent.pinchart@ideasonboard.com>\n\t<20220328125638.zjtqgvjtyzf2lhw5@uno.localdomain>\n\t<164847436152.15275.9314891089166350678@Monstersaurus>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<164847436152.15275.9314891089166350678@Monstersaurus>","Subject":"Re: [libcamera-devel] [PATCH] libcamera: camera_sensor: Add IMX290\n\tsensor properties","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"Jacopo Mondi via libcamera-devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]