[{"id":2091,"web_url":"https://patchwork.libcamera.org/comment/2091/","msgid":"<20190701174529.GN5018@pendragon.ideasonboard.com>","date":"2019-07-01T17:45:29","subject":"Re: [libcamera-devel] [PATCH v2 1/2] libcamera: ipa_module: add\n\tpath to module loading error message","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Paul,\n\nThank you for the patch.\n\nOn Mon, Jul 01, 2019 at 11:13:35PM +0900, Paul Elder wrote:\n> Add an error message to tell, if an IPA module failed to load, the\n> path to the IPA module shared object that was attempted to be loaded.\n> \n> Signed-off-by: Paul Elder <paul.elder@ideasonboard.com>\n> ---\n> Changes in v2: don't show module version\n> \n>  src/libcamera/ipa_module.cpp | 5 +++++\n>  1 file changed, 5 insertions(+)\n> \n> diff --git a/src/libcamera/ipa_module.cpp b/src/libcamera/ipa_module.cpp\n> index 58e8d1d..5a46ec3 100644\n> --- a/src/libcamera/ipa_module.cpp\n> +++ b/src/libcamera/ipa_module.cpp\n> @@ -286,6 +286,11 @@ int IPAModule::loadIPAModuleInfo()\n>  \t\tret = -EINVAL;\n>  \t}\n>  \n> +\tif (ret)\n> +\t\tLOG(IPAModule, Error)\n> +\t\t\t<< \"Error loading IPA module at \"\n\nI would s/at //\n\n> +\t\t\t<< libPath_;\n> +\n\nWould it make sensor to move this under the close: label ?\n\nWhile at it, I think you need a\n\n\tif (ret)\n\t\tgoto unmap;\n\nafter the elfLoadSymbol() calls.\n\n>  unmap:\n>  \tmunmap(map, soSize);\n>  close:","headers":{"Return-Path":"<laurent.pinchart@ideasonboard.com>","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DE26660BF8\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon,  1 Jul 2019 19:45:48 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(dfj612yhrgyx302h3jwwy-3.rev.dnainternet.fi\n\t[IPv6:2001:14ba:21f5:5b00:ce28:277f:58d7:3ca4])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 8B510524;\n\tMon,  1 Jul 2019 19:45:48 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1562003148;\n\tbh=BwKeYwZ7bAkDBxRjxXC0O8iPUu3HzIuNhITxlElHjOQ=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=Kx07FEPbwzeIV6v/BydWHcHe7jXreI6dfFDGhVbk4NYI273Zb0FXNGxgX3mF0nXdM\n\tsKKUALVU1ATMS6lqZdiC2XjhpATVNAzkYA+zPIx80tM5Pxi+PFqdYQUu32PY9Bl0ah\n\t8MpD2o9yOLTIB0F/oZ+G3kdmGV4bZiT5eIQdqhgk=","Date":"Mon, 1 Jul 2019 20:45:29 +0300","From":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","To":"Paul Elder <paul.elder@ideasonboard.com>","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190701174529.GN5018@pendragon.ideasonboard.com>","References":"<20190701141336.10273-1-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20190701141336.10273-1-paul.elder@ideasonboard.com>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH v2 1/2] libcamera: ipa_module: add\n\tpath to module loading error message","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","X-List-Received-Date":"Mon, 01 Jul 2019 17:45:49 -0000"}}]