[{"id":22479,"web_url":"https://patchwork.libcamera.org/comment/22479/","msgid":"","date":"2022-03-28T10:13:13","subject":"Re: [libcamera-devel] [PATCH] ipa: raspberrypi: Correct some of the\n\tControlInfo ranges and defaults","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi David,\n\nThank you for the patch.\n\nOn Mon, Mar 28, 2022 at 11:05:44AM +0100, David Plowman via libcamera-devel wrote:\n> Some of the values were listed incorrectly. Specifically:\n> \n> ExposureValue: the range is now centred correctly on zero\n> Brightness: the default value (0.0) is made explicit\n> Contrast: the default value is corrected to be 1.0\n> Saturation: the default value is corrected to be 1.0\n> \n> Signed-off-by: David Plowman \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> include/libcamera/ipa/raspberrypi.h | 8 ++++----\n> 1 file changed, 4 insertions(+), 4 deletions(-)\n> \n> diff --git a/include/libcamera/ipa/raspberrypi.h b/include/libcamera/ipa/raspberrypi.h\n> index 7f705e49..6a56b008 100644\n> --- a/include/libcamera/ipa/raspberrypi.h\n> +++ b/include/libcamera/ipa/raspberrypi.h\n> @@ -34,13 +34,13 @@ static const ControlInfoMap Controls({\n> \t\t{ &controls::AeMeteringMode, ControlInfo(controls::AeMeteringModeValues) },\n> \t\t{ &controls::AeConstraintMode, ControlInfo(controls::AeConstraintModeValues) },\n> \t\t{ &controls::AeExposureMode, ControlInfo(controls::AeExposureModeValues) },\n> -\t\t{ &controls::ExposureValue, ControlInfo(0.0f, 16.0f) },\n> +\t\t{ &controls::ExposureValue, ControlInfo(-8.0f, 8.0f, 0.0f) },\n> \t\t{ &controls::AwbEnable, ControlInfo(false, true) },\n> \t\t{ &controls::ColourGains, ControlInfo(0.0f, 32.0f) },\n> \t\t{ &controls::AwbMode, ControlInfo(controls::AwbModeValues) },\n> -\t\t{ &controls::Brightness, ControlInfo(-1.0f, 1.0f) },\n> -\t\t{ &controls::Contrast, ControlInfo(0.0f, 32.0f) },\n> -\t\t{ &controls::Saturation, ControlInfo(0.0f, 32.0f) },\n> +\t\t{ &controls::Brightness, ControlInfo(-1.0f, 1.0f, 0.0f) },\n> +\t\t{ &controls::Contrast, ControlInfo(0.0f, 32.0f, 1.0f) },\n> +\t\t{ &controls::Saturation, ControlInfo(0.0f, 32.0f, 1.0f) },\n> \t\t{ &controls::Sharpness, ControlInfo(0.0f, 16.0f, 1.0f) },\n> \t\t{ &controls::ColourCorrectionMatrix, ControlInfo(-16.0f, 16.0f) },\n> \t\t{ &controls::ScalerCrop, ControlInfo(Rectangle{}, Rectangle(65535, 65535, 65535, 65535), Rectangle{}) },","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4BE6CC0F1B\n\tfor ;\n\tMon, 28 Mar 2022 10:13:17 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id ABE4A601F5;\n\tMon, 28 Mar 2022 12:13:16 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3D47260135\n\tfor ;\n\tMon, 28 Mar 2022 12:13:15 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B17C7B9C;\n\tMon, 28 Mar 2022 12:13:14 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1648462396;\n\tbh=eOnqzIJ7exW6XOW9EbHpzXaholgOuKvj6Qf6hiWfPAk=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=FO6c7p3B7vTqlU4t0I3lac+Wv3AA76VGwpZId8HqCOMDbIYg5Ql5iCqIx0xfUCUZX\n\t5hCV0/O1mtBPHgQ9v54paOjjWhB53VbuJIim/eyeXekIBhTR1pi+CqXybIadBt9fFb\n\tWmnuHd9wtZ60YR+1x/bU8TQP1uwbKsKmf8ETphyWmzVpoL/ttcpYQJP0dxCOG3K9Kc\n\tTKVoj6VTdOTxW9/Imx/ELH89wZOTJST7G5FfCHS6ldMJOYUCCCZCSU/6IgfRjQmis3\n\tADBwS3UYfqwrmpfNujwzKnONatBCFv1x5uTIR/Uswz/L3CM1YTCsq4GaUSuAc+UcEt\n\talG6szrI+FXaw==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1648462394;\n\tbh=eOnqzIJ7exW6XOW9EbHpzXaholgOuKvj6Qf6hiWfPAk=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=AqY4SPef2zBQ9BcAKjU0h60556hg+WTDnJJSaQnqpeoQZg53YcrYyD7yOmSlOtq/m\n\tdLGLftmSpyPiu9rV5xntTcrlqPdbMKAVEMAI9FYZ9Tan8DNLwtEHLtF57muW5WhaUm\n\tU9ZtDFzPBtz1UV0s2pPVmJX2VRSXTVR5nhds4wyQ="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"AqY4SPef\"; dkim-atps=neutral","Date":"Mon, 28 Mar 2022 13:13:13 +0300","To":"David Plowman ","Message-ID":"","References":"<20220328100544.13477-1-david.plowman@raspberrypi.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20220328100544.13477-1-david.plowman@raspberrypi.com>","Subject":"Re: [libcamera-devel] [PATCH] ipa: raspberrypi: Correct some of the\n\tControlInfo ranges and defaults","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":22557,"web_url":"https://patchwork.libcamera.org/comment/22557/","msgid":"<164890568595.15275.18301274113335066511@Monstersaurus>","date":"2022-04-02T13:21:25","subject":"Re: [libcamera-devel] [PATCH] ipa: raspberrypi: Correct some of the\n\tControlInfo ranges and defaults","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting David Plowman via libcamera-devel (2022-03-28 11:05:44)\n> Some of the values were listed incorrectly. Specifically:\n> \n> ExposureValue: the range is now centred correctly on zero\n> Brightness: the default value (0.0) is made explicit\n> Contrast: the default value is corrected to be 1.0\n> Saturation: the default value is corrected to be 1.0\n> \n\nLooks reasonable to me - but I think a review from Naush is probably\nmore important than me.\n\nEither way:\n\nReviewed-by: Kieran Bingham \n\n> Signed-off-by: David Plowman \n> ---\n> include/libcamera/ipa/raspberrypi.h | 8 ++++----\n> 1 file changed, 4 insertions(+), 4 deletions(-)\n> \n> diff --git a/include/libcamera/ipa/raspberrypi.h b/include/libcamera/ipa/raspberrypi.h\n> index 7f705e49..6a56b008 100644\n> --- a/include/libcamera/ipa/raspberrypi.h\n> +++ b/include/libcamera/ipa/raspberrypi.h\n> @@ -34,13 +34,13 @@ static const ControlInfoMap Controls({\n> { &controls::AeMeteringMode, ControlInfo(controls::AeMeteringModeValues) },\n> { &controls::AeConstraintMode, ControlInfo(controls::AeConstraintModeValues) },\n> { &controls::AeExposureMode, ControlInfo(controls::AeExposureModeValues) },\n> - { &controls::ExposureValue, ControlInfo(0.0f, 16.0f) },\n> + { &controls::ExposureValue, ControlInfo(-8.0f, 8.0f, 0.0f) },\n> { &controls::AwbEnable, ControlInfo(false, true) },\n> { &controls::ColourGains, ControlInfo(0.0f, 32.0f) },\n> { &controls::AwbMode, ControlInfo(controls::AwbModeValues) },\n> - { &controls::Brightness, ControlInfo(-1.0f, 1.0f) },\n> - { &controls::Contrast, ControlInfo(0.0f, 32.0f) },\n> - { &controls::Saturation, ControlInfo(0.0f, 32.0f) },\n> + { &controls::Brightness, ControlInfo(-1.0f, 1.0f, 0.0f) },\n> + { &controls::Contrast, ControlInfo(0.0f, 32.0f, 1.0f) },\n> + { &controls::Saturation, ControlInfo(0.0f, 32.0f, 1.0f) },\n> { &controls::Sharpness, ControlInfo(0.0f, 16.0f, 1.0f) },\n> { &controls::ColourCorrectionMatrix, ControlInfo(-16.0f, 16.0f) },\n> { &controls::ScalerCrop, ControlInfo(Rectangle{}, Rectangle(65535, 65535, 65535, 65535), Rectangle{}) },\n> -- \n> 2.30.2\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D4ED3C0F1B\n\tfor ;\n\tSat, 2 Apr 2022 13:21:30 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2FA7565640;\n\tSat, 2 Apr 2022 15:21:30 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 05D59604BE\n\tfor ;\n\tSat, 2 Apr 2022 15:21:29 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 995712E4;\n\tSat, 2 Apr 2022 15:21:28 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1648905690;\n\tbh=L8Ui413zqLNyp67ciGrKwIyMNcIq8IHWRhcpjJfn9Us=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=a262ixtxJS0LYejl76OvgDJJ9r0MFjZmP7vgKwBx+DChjR/vALaA/iQ2DR3hf3Y2k\n\tdW71ki97IdvT95kpz8WRQV629lBijdAWK5ShENAeeDZIMzj5JhPr8ORjSbj5+VhzzX\n\tOYdxCsL5AEaV/d8AtsofMO57LNhYCvGJ3SGjJB49JyGctTP5QyRCX6sH11MjpXqGLd\n\tdrg21/Rycz5cF8qVFF0EXbtIZA43C/JP6WaLgsGFqSHReibL0tHROthVtfPojcFq1J\n\tD5vhyIi611scEeiuWyT2paW93fMn7k5p/YrpSeK6+slEwzcGPWfvJnMYTK9EOjaCeb\n\tosAXYWG6f/DRA==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1648905688;\n\tbh=L8Ui413zqLNyp67ciGrKwIyMNcIq8IHWRhcpjJfn9Us=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=bIXbgsJKY+tNFnSmcPfk69jFSGQWEGEW89W+tlT3VcUHKBwDS6YzdhBXZi58gMQhj\n\tG32U3uzMK5v8QtLmyAkzIxjpg7JOAVzYzZO1qJLoURS3XCR5bNJlXImJ2nmM2oxZB0\n\tXzvhPjXHnOGrepgBJxXuHvQtJFO2BuWUWcp0s0SA="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"bIXbgsJK\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20220328100544.13477-1-david.plowman@raspberrypi.com>","References":"<20220328100544.13477-1-david.plowman@raspberrypi.com>","To":"David Plowman ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Sat, 02 Apr 2022 14:21:25 +0100","Message-ID":"<164890568595.15275.18301274113335066511@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH] ipa: raspberrypi: Correct some of the\n\tControlInfo ranges and defaults","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kieran Bingham via libcamera-devel\n\t","Reply-To":"Kieran Bingham ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":22592,"web_url":"https://patchwork.libcamera.org/comment/22592/","msgid":"","date":"2022-04-05T23:12:36","subject":"Re: [libcamera-devel] [PATCH] ipa: raspberrypi: Correct some of the\n\tControlInfo ranges and defaults","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Sat, Apr 02, 2022 at 02:21:25PM +0100, Kieran Bingham via libcamera-devel wrote:\n> Quoting David Plowman via libcamera-devel (2022-03-28 11:05:44)\n> > Some of the values were listed incorrectly. Specifically:\n> > \n> > ExposureValue: the range is now centred correctly on zero\n> > Brightness: the default value (0.0) is made explicit\n> > Contrast: the default value is corrected to be 1.0\n> > Saturation: the default value is corrected to be 1.0\n> \n> Looks reasonable to me - but I think a review from Naush is probably\n> more important than me.\n\nNaush, do you plan to review this ? Otherwise I'll merge it as-is.\n\n> Either way:\n> \n> Reviewed-by: Kieran Bingham \n> \n> > Signed-off-by: David Plowman \n> > ---\n> > include/libcamera/ipa/raspberrypi.h | 8 ++++----\n> > 1 file changed, 4 insertions(+), 4 deletions(-)\n> > \n> > diff --git a/include/libcamera/ipa/raspberrypi.h b/include/libcamera/ipa/raspberrypi.h\n> > index 7f705e49..6a56b008 100644\n> > --- a/include/libcamera/ipa/raspberrypi.h\n> > +++ b/include/libcamera/ipa/raspberrypi.h\n> > @@ -34,13 +34,13 @@ static const ControlInfoMap Controls({\n> > { &controls::AeMeteringMode, ControlInfo(controls::AeMeteringModeValues) },\n> > { &controls::AeConstraintMode, ControlInfo(controls::AeConstraintModeValues) },\n> > { &controls::AeExposureMode, ControlInfo(controls::AeExposureModeValues) },\n> > - { &controls::ExposureValue, ControlInfo(0.0f, 16.0f) },\n> > + { &controls::ExposureValue, ControlInfo(-8.0f, 8.0f, 0.0f) },\n> > { &controls::AwbEnable, ControlInfo(false, true) },\n> > { &controls::ColourGains, ControlInfo(0.0f, 32.0f) },\n> > { &controls::AwbMode, ControlInfo(controls::AwbModeValues) },\n> > - { &controls::Brightness, ControlInfo(-1.0f, 1.0f) },\n> > - { &controls::Contrast, ControlInfo(0.0f, 32.0f) },\n> > - { &controls::Saturation, ControlInfo(0.0f, 32.0f) },\n> > + { &controls::Brightness, ControlInfo(-1.0f, 1.0f, 0.0f) },\n> > + { &controls::Contrast, ControlInfo(0.0f, 32.0f, 1.0f) },\n> > + { &controls::Saturation, ControlInfo(0.0f, 32.0f, 1.0f) },\n> > { &controls::Sharpness, ControlInfo(0.0f, 16.0f, 1.0f) },\n> > { &controls::ColourCorrectionMatrix, ControlInfo(-16.0f, 16.0f) },\n> > { &controls::ScalerCrop, ControlInfo(Rectangle{}, Rectangle(65535, 65535, 65535, 65535), Rectangle{}) },","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4746FC0F1B\n\tfor ;\n\tTue, 5 Apr 2022 23:12:42 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9CD1165640;\n\tWed, 6 Apr 2022 01:12:41 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 078066563F\n\tfor ;\n\tWed, 6 Apr 2022 01:12:40 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(117.145-247-81.adsl-dyn.isp.belgacom.be [81.247.145.117])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id AC408482;\n\tWed, 6 Apr 2022 01:12:39 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1649200361;\n\tbh=03ltPU3NjpOV1SJnooh8RMU1rro+H9jA3N5U2fdlIas=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=B16bnJs+aY9LG5IQ0oHC+KKG2H8sh6c/i5TEM5GS/V1Sb9B7AEoZRA+HwfAPK22Bi\n\t3bWGyFtdRjOBDZ/8sNgrqROImSaj1fX66PLUZBknV94cHSagF8+7IRMXI736FljIy8\n\tN7ecU65WD9/5e8Yquuc6lszm6P+7R1ltfqofGqHpwGnDFr1lLe57eGvRN9WllGcF0h\n\tYXi5a0KG8w25SqQO/oM/NIM80VudB31cVcGJVIfVaPMli9x6pezBfpJAEdAfpF2eBM\n\tppU6Qq/xNQaPdVmN4o9HsbqCHTCOqFZFKiE1SyoEn4m267nlWh+JDZtj8DVrTJlTfy\n\tsGncPy3/LRPVA==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1649200359;\n\tbh=03ltPU3NjpOV1SJnooh8RMU1rro+H9jA3N5U2fdlIas=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=vOW+5nkBaxi6DKWnHw6Ua1moPop/oIYHP9Z2XLIHLypAz86FHT0P7jrde0HtJknDu\n\t1O6vSkCIlD+lwKPD1eHxXCe46AiqN893w31A/yl9LX2mHWFi3EFEvgXXzlUuL3MYUw\n\tPgWVaUb/l+QTdWZYDas0DxaWGrOUFSvS61i7nL44="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"vOW+5nkB\"; dkim-atps=neutral","Date":"Wed, 6 Apr 2022 02:12:36 +0300","To":"Kieran Bingham ","Message-ID":"","References":"<20220328100544.13477-1-david.plowman@raspberrypi.com>\n\t<164890568595.15275.18301274113335066511@Monstersaurus>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<164890568595.15275.18301274113335066511@Monstersaurus>","Subject":"Re: [libcamera-devel] [PATCH] ipa: raspberrypi: Correct some of the\n\tControlInfo ranges and defaults","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":22604,"web_url":"https://patchwork.libcamera.org/comment/22604/","msgid":"","date":"2022-04-06T06:56:45","subject":"Re: [libcamera-devel] [PATCH] ipa: raspberrypi: Correct some of the\n\tControlInfo ranges and defaults","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"content":"Hi David,\n\nThank you for your work.\n\nOn Mon, 28 Mar 2022 at 11:06, David Plowman via libcamera-devel <\nlibcamera-devel@lists.libcamera.org> wrote:\n\n> Some of the values were listed incorrectly. Specifically:\n>\n> ExposureValue: the range is now centred correctly on zero\n> Brightness: the default value (0.0) is made explicit\n> Contrast: the default value is corrected to be 1.0\n> Saturation: the default value is corrected to be 1.0\n>\n> Signed-off-by: David Plowman \n>\n\nReviewed-by: Naushir Patuck \n\n\n> ---\n> include/libcamera/ipa/raspberrypi.h | 8 ++++----\n> 1 file changed, 4 insertions(+), 4 deletions(-)\n>\n> diff --git a/include/libcamera/ipa/raspberrypi.h\n> b/include/libcamera/ipa/raspberrypi.h\n> index 7f705e49..6a56b008 100644\n> --- a/include/libcamera/ipa/raspberrypi.h\n> +++ b/include/libcamera/ipa/raspberrypi.h\n> @@ -34,13 +34,13 @@ static const ControlInfoMap Controls({\n> { &controls::AeMeteringMode,\n> ControlInfo(controls::AeMeteringModeValues) },\n> { &controls::AeConstraintMode,\n> ControlInfo(controls::AeConstraintModeValues) },\n> { &controls::AeExposureMode,\n> ControlInfo(controls::AeExposureModeValues) },\n> - { &controls::ExposureValue, ControlInfo(0.0f, 16.0f) },\n> + { &controls::ExposureValue, ControlInfo(-8.0f, 8.0f, 0.0f)\n> },\n> { &controls::AwbEnable, ControlInfo(false, true) },\n> { &controls::ColourGains, ControlInfo(0.0f, 32.0f) },\n> { &controls::AwbMode, ControlInfo(controls::AwbModeValues)\n> },\n> - { &controls::Brightness, ControlInfo(-1.0f, 1.0f) },\n> - { &controls::Contrast, ControlInfo(0.0f, 32.0f) },\n> - { &controls::Saturation, ControlInfo(0.0f, 32.0f) },\n> + { &controls::Brightness, ControlInfo(-1.0f, 1.0f, 0.0f) },\n> + { &controls::Contrast, ControlInfo(0.0f, 32.0f, 1.0f) },\n> + { &controls::Saturation, ControlInfo(0.0f, 32.0f, 1.0f) },\n> { &controls::Sharpness, ControlInfo(0.0f, 16.0f, 1.0f) },\n> { &controls::ColourCorrectionMatrix, ControlInfo(-16.0f,\n> 16.0f) },\n> { &controls::ScalerCrop, ControlInfo(Rectangle{},\n> Rectangle(65535, 65535, 65535, 65535), Rectangle{}) },\n> --\n> 2.30.2\n>\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B45ACC3256\n\tfor ;\n\tWed, 6 Apr 2022 06:57:03 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0FD8E65644;\n\tWed, 6 Apr 2022 08:57:03 +0200 (CEST)","from mail-lf1-x12b.google.com (mail-lf1-x12b.google.com\n\t[IPv6:2a00:1450:4864:20::12b])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 16DFC604B6\n\tfor ;\n\tWed, 6 Apr 2022 08:57:01 +0200 (CEST)","by mail-lf1-x12b.google.com with SMTP id k21so2441977lfe.4\n\tfor ;\n\tTue, 05 Apr 2022 23:57:01 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1649228223;\n\tbh=aZuG2CxiQ53EWTUM/8rjYdbvGyrrR1JYnvrwbLKBpgc=;\n\th=References:In-Reply-To:Date:To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=GK7x+hilm0/LzO6q2iUKQa4cmCsPOXG291LaLmqdIMQYleqfAlcqARhhMVBzFTixN\n\tc8la6TQZyFRDUr4CY9dxJb+9fVlWBRJHAnKz8T+5LN8MFo0HZ+WyO3HX1Q45KxdaXC\n\tx0ETqbGRP+Xz4JbEDhY9IWoSYQd4gQKjMh3VmQhU/DYvUmWjusm3/1hn8oPo6SHTKD\n\tavEdqTHUBRFW1+Y3K5iJq9OePp7mKMR1LK1jyJ4Mfn1dDj/wq3B/4JoIFVjMC8RjOd\n\tqj881aLJuG9guXbIQTdpdcpGh1X8JpyrdnchjDxqGcCJmlY0S9XO8shW2B+QvC4jCT\n\tg8RtmXk3XbISQ==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=H3dndKLAclNK6npCq0pcVBL5aOe2a0B3nn36tsJAaz4=;\n\tb=L0i43kfvGiIOpeaij/Rv8Na68338EHAaOudOUwM8gCQOE6vbEhBASU+NISbBvKi0gm\n\tawi6v9VJSjxZWtJNmtwcAO9PI8JdbO0Y+5/1/UyoLsDeRGIYRAxaBscmQWSEjbrKFzPz\n\t053eiRgJNp3IudaWq/BHAnOAE4a8/EF1UYVYahpbvyd+LpbtiG7/qMiOmo4sZ5eFp+P7\n\t1px/UX/ADTsDMpYhnYkODK73Yz9kTlRKYJTFZbR7gV5Jwr48n7peaL2JmryruDLI/prp\n\t6BilZOcbkOFYEw5RVLEv9scPNQImmsPAcIWPhjGc9D7vmQaPS1s2qU4f9nKuqy6x2NIR\n\t7pkA=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=raspberrypi.com\n\theader.i=@raspberrypi.com\n\theader.b=\"L0i43kfv\"; dkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=H3dndKLAclNK6npCq0pcVBL5aOe2a0B3nn36tsJAaz4=;\n\tb=dci88lqPWoIDTeCdLairtlZuR25jPE9qkMcbUDvaDtTnNzZBkE40d9alrH6HgYks5z\n\tXnKWQVfMJu7HO+xu75qkrbG1bOQYY/e7EvMlO8oToMI8/eZWMEtsTy5K0/qPerBxWKxM\n\tdL77tVW7KsU8w8FSTqgNsB/mrbmozM4neffplNG7CVd15mRIFvkb/Kuhr2p70x69ZNeD\n\tKOn7l5KVqumJkvyxD7RU9jb3ytt96U+T9FQsezfh7qG/IEB2RiDhwjiYQ/tTkZPIkym8\n\tPrUNoM7NQQlH9MxLiy33n6ZHNugLrwHrFsx9HlZyb39tg4wm2wYH2YZnmMlyYIVNpiK5\n\tnE5g==","X-Gm-Message-State":"AOAM530IVKoVbIakDjAPXIecx/A6aK6YB+c+YjoaIy+c4ZkG/opfvNFv\n\tnMAz16c0WotSc0lZMlUu33TJ4PmJTQqTfVL5SrsiRw==","X-Google-Smtp-Source":"ABdhPJwYivfW8lD/DpoTjcBK8yocIJX/qjd9ZjHyc2MSSL4vTOcR2XUHy4Dsia3Try7ivXRFc1qL62A85prbZ8UhvQg=","X-Received":"by 2002:a05:6512:25a:b0:44a:3f55:1746 with SMTP id\n\tb26-20020a056512025a00b0044a3f551746mr5010130lfo.122.1649228221278;\n\tTue, 05 Apr 2022 23:57:01 -0700 (PDT)","MIME-Version":"1.0","References":"<20220328100544.13477-1-david.plowman@raspberrypi.com>","In-Reply-To":"<20220328100544.13477-1-david.plowman@raspberrypi.com>","Date":"Wed, 6 Apr 2022 07:56:45 +0100","Message-ID":"","To":"David Plowman ","Content-Type":"multipart/alternative; boundary=\"00000000000048812905dbf6dec0\"","Subject":"Re: [libcamera-devel] [PATCH] ipa: raspberrypi: Correct some of the\n\tControlInfo ranges and defaults","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Naushir Patuck via libcamera-devel\n\t","Reply-To":"Naushir Patuck ","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]