[{"id":22453,"web_url":"https://patchwork.libcamera.org/comment/22453/","msgid":"<164833457098.15275.4298924097072751438@Monstersaurus>","date":"2022-03-26T22:42:50","subject":"Re: [libcamera-devel] [PATCH] gstreamer: Fix typo in comment","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Laurent Pinchart via libcamera-devel (2022-03-26 15:31:16)\n> Possibly the most trivial patch.\n\nProbably don't need that line when pushing ;-) but I can look the other\nway.\nFix is correct so:\n\nReviewed-by: Kieran Bingham \n\n> \n> Signed-off-by: Laurent Pinchart \n> ---\n> src/gstreamer/gstlibcamerasrc.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/gstreamer/gstlibcamerasrc.cpp b/src/gstreamer/gstlibcamerasrc.cpp\n> index c7292f66b17b..46fd02d207be 100644\n> --- a/src/gstreamer/gstlibcamerasrc.cpp\n> +++ b/src/gstreamer/gstlibcamerasrc.cpp\n> @@ -284,7 +284,7 @@ gst_libcamera_src_task_run(gpointer user_data)\n> &buffer, nullptr);\n> if (ret != GST_FLOW_OK) {\n> /*\n> - * RequestWrap has ownership of the rquest, and we\n> + * RequestWrap has ownership of the request, and we\n> * won't be queueing this one due to lack of buffers.\n> */\n> wrap.release();\n> -- \n> Regards,\n> \n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 99A15C0F1B\n\tfor ;\n\tSat, 26 Mar 2022 22:42:56 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id ECF35604C5;\n\tSat, 26 Mar 2022 23:42:55 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E8CF3604C4\n\tfor ;\n\tSat, 26 Mar 2022 23:42:53 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 8A26E332;\n\tSat, 26 Mar 2022 23:42:53 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1648334576;\n\tbh=5q/ae5pBK63igvnuWLcoY8dxw/xJ4HOjxIkcHByMmFo=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=pil/mrY/As1s/lq6I5ducgJAfEvDdPr8Wkz9++KYqvHVrbuIIJvsKBmtS6vc0Ju+9\n\tRuOQdcYCVzldvpV/aR2ApvRm+9JU+jq/ixokF1NG1rwCC0ZkPrqah8E/Ao8bs43nwD\n\thjw25ZTckQCUK2T98lpNh1X3RxtZrugQAyMBPslq+ZlZc8FFKNI9q8w6opxzYsXb87\n\tTlIPW7vWdxRW+t6pGAsqG2SUNbrQsC/f5MyNfai6US6ttL1YdYZhhnqbPmuiuZ9CtE\n\t/BHqnwaaStc9EQwJvM0iLAbKjj824kKoz0PsO2NHFz68KGKTUgWF9leBYt5ii9EqMX\n\tro4M5OQD2sweQ==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1648334573;\n\tbh=5q/ae5pBK63igvnuWLcoY8dxw/xJ4HOjxIkcHByMmFo=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=dUZeYhJ0uiqxqBruHqF63+CkllgV64F/KcWCh5j3NilkWaaK8cW6vWebRScw3+TCG\n\t/4zRSn+60rNBdONzcSACMU7eBHij04DkMLZHSTFSKG3BehJdmpxSHkTsDWyYOIIJnb\n\tGLcyznlNF5FUy3kIVEtXAanSeOizUC2BADlToLoI="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"dUZeYhJ0\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20220326153116.11460-1-laurent.pinchart@ideasonboard.com>","References":"<20220326153116.11460-1-laurent.pinchart@ideasonboard.com>","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Sat, 26 Mar 2022 22:42:50 +0000","Message-ID":"<164833457098.15275.4298924097072751438@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH] gstreamer: Fix typo in comment","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kieran Bingham via libcamera-devel\n\t","Reply-To":"Kieran Bingham ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":22455,"web_url":"https://patchwork.libcamera.org/comment/22455/","msgid":"","date":"2022-03-27T01:35:24","subject":"Re: [libcamera-devel] [PATCH] gstreamer: Fix typo in comment","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Sat, Mar 26, 2022 at 10:42:50PM +0000, Kieran Bingham wrote:\n> Quoting Laurent Pinchart via libcamera-devel (2022-03-26 15:31:16)\n> > Possibly the most trivial patch.\n> \n> Probably don't need that line when pushing ;-) but I can look the other\n> way.\n\nI was struggling finding anything else relevant to write :-)\n\n> Fix is correct so:\n> \n> Reviewed-by: Kieran Bingham \n> \n> > \n> > Signed-off-by: Laurent Pinchart \n> > ---\n> > src/gstreamer/gstlibcamerasrc.cpp | 2 +-\n> > 1 file changed, 1 insertion(+), 1 deletion(-)\n> > \n> > diff --git a/src/gstreamer/gstlibcamerasrc.cpp b/src/gstreamer/gstlibcamerasrc.cpp\n> > index c7292f66b17b..46fd02d207be 100644\n> > --- a/src/gstreamer/gstlibcamerasrc.cpp\n> > +++ b/src/gstreamer/gstlibcamerasrc.cpp\n> > @@ -284,7 +284,7 @@ gst_libcamera_src_task_run(gpointer user_data)\n> > &buffer, nullptr);\n> > if (ret != GST_FLOW_OK) {\n> > /*\n> > - * RequestWrap has ownership of the rquest, and we\n> > + * RequestWrap has ownership of the request, and we\n> > * won't be queueing this one due to lack of buffers.\n> > */\n> > wrap.release();","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9539CC3256\n\tfor ;\n\tSun, 27 Mar 2022 01:35:29 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E9B42604C7;\n\tSun, 27 Mar 2022 03:35:28 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1E5E8601F8\n\tfor ;\n\tSun, 27 Mar 2022 03:35:27 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 7A8776D93;\n\tSun, 27 Mar 2022 03:35:26 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1648344929;\n\tbh=iGARZBE+OMEDlI4OCLEK1e75EhJMjn/epXB01YbbOkc=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=iACBIkfLUj/t4HEDNdkF9rkgHVumM71i8bBRxCzB5r5f9d+7uzifP59grKC2sixfL\n\tePneOIAk2Z4JrmCOWHJ2BQu6URB1+3Uln4v3p6Yzd4afN71/OkGB2qGS1QDpRjSosB\n\tSwk48GYK28vJ9RXS3Ik7m7Vl7vw6UoVDy2lyvgASeUsDrX+qZZCYACz5+VKSjIREYm\n\tbIYCB31BeO2MMqDjvnS98ygK7oD0e8JxL7r2y5iVZVg+5NZlfm2khTJPkMl+331JLr\n\tOsMNjLIPBBI3Vj0UaRieMseMnTP8iDmkqd0qwoszh9fORWg4awqjFP6/rPcNo6PcCc\n\tykfHgW31aUsyA==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1648344926;\n\tbh=iGARZBE+OMEDlI4OCLEK1e75EhJMjn/epXB01YbbOkc=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=dFO5WSwgX1sTbrAGIyztn0nJT+G7jnxOlqLl2O+PcfSOqDkU8LtYZgd/yVCAp6w7o\n\tPo6QTniWsGd681Sv5ko1JFXOy8BztjP8GTqQfTaklak74HEFVAVhVopzroqZ6Hyft8\n\tllIbW3Sad4pEr7E3q4m1et7ndd3b68FK3S5+lilw="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"dFO5WSwg\"; dkim-atps=neutral","Date":"Sun, 27 Mar 2022 04:35:24 +0300","To":"Kieran Bingham ","Message-ID":"","References":"<20220326153116.11460-1-laurent.pinchart@ideasonboard.com>\n\t<164833457098.15275.4298924097072751438@Monstersaurus>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<164833457098.15275.4298924097072751438@Monstersaurus>","Subject":"Re: [libcamera-devel] [PATCH] gstreamer: Fix typo in comment","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]