[{"id":22505,"web_url":"https://patchwork.libcamera.org/comment/22505/","msgid":"<4241231b-7c00-2b8a-f261-e9f1c096f70f@ideasonboard.com>","date":"2022-03-29T05:57:32","subject":"Re: [libcamera-devel] [PATCH v3 5/5] ipa: ipu3: af: Simplify\n\taccumulations of y_items","submitter":{"id":75,"url":"https://patchwork.libcamera.org/api/people/75/","name":"Jean-Michel Hautbois","email":"jeanmichel.hautbois@ideasonboard.com"},"content":"Hi Kieran,\n\nThanks for the patch !\n\nOn 25/03/2022 10:25, Kieran Bingham wrote:\n> Simplify the accumulation of the total and variance with a ternary\n> operator.\n> \n> Signed-off-by: Kieran Bingham \n> Reviewed-by: Laurent Pinchart \n\nReviewed-by: Jean-Michel Hautbois \n\n> ---\n> src/ipa/ipu3/algorithms/af.cpp | 14 ++++----------\n> 1 file changed, 4 insertions(+), 10 deletions(-)\n> \n> diff --git a/src/ipa/ipu3/algorithms/af.cpp b/src/ipa/ipu3/algorithms/af.cpp\n> index c0f2d34368cb..6c25d02ec7f0 100644\n> --- a/src/ipa/ipu3/algorithms/af.cpp\n> +++ b/src/ipa/ipu3/algorithms/af.cpp\n> @@ -341,20 +341,14 @@ double Af::afEstimateVariance(Span y_items, bool isY1)\n> \tdouble mean;\n> \tdouble var_sum = 0;\n> \n> -\tfor (auto y : y_items) {\n> -\t\tif (isY1)\n> -\t\t\ttotal += y.y1_avg;\n> -\t\telse\n> -\t\t\ttotal += y.y2_avg;\n> -\t}\n> +\tfor (auto y : y_items)\n> +\t\ttotal += isY1 ? y.y1_avg : y.y2_avg;\n> \n> \tmean = total / y_items.size();\n> \n> \tfor (auto y : y_items) {\n> -\t\tif (isY1)\n> -\t\t\tvar_sum += pow(y.y1_avg - mean, 2);\n> -\t\telse\n> -\t\t\tvar_sum += pow(y.y2_avg - mean, 2);\n> +\t\tdouble avg = isY1 ? y.y1_avg : y.y2_avg;\n> +\t\tvar_sum += pow(avg - mean, 2);\n> \t}\n> \n> \treturn var_sum / y_items.size();","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E39E0C0F1B\n\tfor ;\n\tTue, 29 Mar 2022 05:57:36 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9C57365634;\n\tTue, 29 Mar 2022 07:57:36 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DDD3C604BC\n\tfor ;\n\tTue, 29 Mar 2022 07:57:35 +0200 (CEST)","from [IPV6:2a01:e0a:169:7140:46c7:900e:3d98:76e7] (unknown\n\t[IPv6:2a01:e0a:169:7140:46c7:900e:3d98:76e7])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 98556888;\n\tTue, 29 Mar 2022 07:57:35 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1648533456;\n\tbh=0nyU1PIW6fo2yR7Z5pKHXEVEx6TKyuVZQyAAe+3jrV8=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=lIVkjybNRK5GA9n0NETRwsFNSHfUsrIM7uEs/Q/P2BoGjz0dQgT2EJ7Wp0AfrUEP0\n\tT9vqleQVne0JLO0MPLh1x+DzMBzKrHEoTXS58EKsFaEfQyejuZaQYM/JmgaqiQAZa3\n\tJP2ejY5veFzFmX7nELxhu407gYZ3W0lyYc56E0ehvtgIKx1u4FH6PvO/ZzvbjiPLJT\n\t1cRX/AJTQzfumKjAWiiHD9ZDPzT36AnSVyF4PJimBN4Xqy8/uo0TjY+irauf3f37O7\n\tpo9eqf4+2lro8J1TC/ww1U2H/8lUaP9YI2vCsvG3PJWvg9WBKiPndF3JQvNSGJfA4S\n\tFwjq8oniYqdSw==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1648533455;\n\tbh=0nyU1PIW6fo2yR7Z5pKHXEVEx6TKyuVZQyAAe+3jrV8=;\n\th=Date:Subject:To:Cc:References:From:In-Reply-To:From;\n\tb=Vut2/kQTexFvHZ7s0TdyFQvoRcATT8yjhMDq5YMKcKBIHF5E9nDcpmHBtEIncGWxs\n\twciD/eMXkwMNjG74MRF9JbRj433vM2d1EICv/42ZkW9rsXLYVCtQ/fx24PPpnbMqY6\n\trjS8hL8AfimiGwRcxIHk8nE1h+Zw2kFdOrhzEiLE="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"Vut2/kQT\"; dkim-atps=neutral","Message-ID":"<4241231b-7c00-2b8a-f261-e9f1c096f70f@ideasonboard.com>","Date":"Tue, 29 Mar 2022 07:57:32 +0200","MIME-Version":"1.0","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101\n\tThunderbird/91.7.0","Content-Language":"en-US","To":"Kieran Bingham ,\n\tlibcamera devel ,\n\tKate Hsuan ","References":"<20220325092555.1799897-1-kieran.bingham@ideasonboard.com>\n\t<20220325092555.1799897-6-kieran.bingham@ideasonboard.com>","In-Reply-To":"<20220325092555.1799897-6-kieran.bingham@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH v3 5/5] ipa: ipu3: af: Simplify\n\taccumulations of y_items","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Jean-Michel Hautbois via libcamera-devel\n\t","Reply-To":"Jean-Michel Hautbois ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]