[{"id":22504,"web_url":"https://patchwork.libcamera.org/comment/22504/","msgid":"","date":"2022-03-29T05:57:04","subject":"Re: [libcamera-devel] [PATCH v3 4/5] ipa: ipu3: af: Use Span for\n\ty_table_item_t","submitter":{"id":75,"url":"https://patchwork.libcamera.org/api/people/75/","name":"Jean-Michel Hautbois","email":"jeanmichel.hautbois@ideasonboard.com"},"content":"Hi Kieran,\n\nThanks for the patch !\n\nOn 25/03/2022 10:25, Kieran Bingham wrote:\n> Convert the y_table_item_t to a Span and use that for iteration when\n> estimating variance of the table.\n> \n> Signed-off-by: Kieran Bingham \n> Reviewed-by: Laurent Pinchart \n\nReviewed-by: Jean-Michel Hautbois \n\n> \n> ---\n> v3:\n> - Remove parentheses and casting in afEstimateVariance\n> \n> src/ipa/ipu3/algorithms/af.cpp | 34 +++++++++++++++++-----------------\n> src/ipa/ipu3/algorithms/af.h | 4 ++--\n> 2 files changed, 19 insertions(+), 19 deletions(-)\n> \n> diff --git a/src/ipa/ipu3/algorithms/af.cpp b/src/ipa/ipu3/algorithms/af.cpp\n> index 6893a15fdc07..c0f2d34368cb 100644\n> --- a/src/ipa/ipu3/algorithms/af.cpp\n> +++ b/src/ipa/ipu3/algorithms/af.cpp\n> @@ -335,29 +335,29 @@ void Af::afIgnoreFrameReset()\n> *\n> * \\return The variance of the values in the data set \\a y_item selected by \\a isY1\n> */\n> -double Af::afEstimateVariance(const y_table_item_t *y_item, uint32_t len,\n> -\t\t\t bool isY1)\n> +double Af::afEstimateVariance(Span y_items, bool isY1)\n> {\n> -\tuint32_t z = 0;\n> \tuint32_t total = 0;\n> \tdouble mean;\n> \tdouble var_sum = 0;\n> \n> -\tfor (z = 0; z < len; z++) {\n> +\tfor (auto y : y_items) {\n> \t\tif (isY1)\n> -\t\t\ttotal += y_item[z].y1_avg;\n> +\t\t\ttotal += y.y1_avg;\n> \t\telse\n> -\t\t\ttotal += y_item[z].y2_avg;\n> +\t\t\ttotal += y.y2_avg;\n> \t}\n> -\tmean = total / len;\n> -\tfor (z = 0; z < len; z++) {\n> +\n> +\tmean = total / y_items.size();\n> +\n> +\tfor (auto y : y_items) {\n> \t\tif (isY1)\n> -\t\t\tvar_sum += pow((y_item[z].y1_avg - mean), 2);\n> +\t\t\tvar_sum += pow(y.y1_avg - mean, 2);\n> \t\telse\n> -\t\t\tvar_sum += pow((y_item[z].y2_avg - mean), 2);\n> +\t\t\tvar_sum += pow(y.y2_avg - mean, 2);\n> \t}\n> \n> -\treturn var_sum / static_cast(len);\n> +\treturn var_sum / y_items.size();\n> }\n> \n> /**\n> @@ -405,21 +405,21 @@ bool Af::afIsOutOfFocus(IPAContext context)\n> */\n> void Af::process(IPAContext &context, const ipu3_uapi_stats_3a *stats)\n> {\n> -\tconst y_table_item_t *y_item = reinterpret_cast(&stats->af_raw_buffer.y_table);\n> -\tuint32_t afRawBufferLen;\n> -\n> \t/* Evaluate the AF buffer length */\n> -\tafRawBufferLen = context.configuration.af.afGrid.width *\n> -\t\t\t context.configuration.af.afGrid.height;\n> +\tuint32_t afRawBufferLen = context.configuration.af.afGrid.width *\n> +\t\t\t\t context.configuration.af.afGrid.height;\n> \n> \tASSERT(afRawBufferLen < IPU3_UAPI_AF_Y_TABLE_MAX_SIZE);\n> \n> +\tSpan y_items(reinterpret_cast(&stats->af_raw_buffer.y_table),\n> +\t\t\t\t\t afRawBufferLen);\n> +\n> \t/*\n> \t * Calculate the mean and the variance of AF statistics for a given grid.\n> \t * For coarse: y1 are used.\n> \t * For fine: y2 results are used.\n> \t */\n> -\tcurrentVariance_ = afEstimateVariance(y_item, afRawBufferLen, !coarseCompleted_);\n> +\tcurrentVariance_ = afEstimateVariance(y_items, !coarseCompleted_);\n> \n> \tif (!context.frameContext.af.stable) {\n> \t\tafCoarseScan(context);\n> diff --git a/src/ipa/ipu3/algorithms/af.h b/src/ipa/ipu3/algorithms/af.h\n> index 3b5758e868ea..b85cf94163ff 100644\n> --- a/src/ipa/ipu3/algorithms/af.h\n> +++ b/src/ipa/ipu3/algorithms/af.h\n> @@ -41,8 +41,8 @@ private:\n> \tvoid afReset(IPAContext &context);\n> \tbool afNeedIgnoreFrame();\n> \tvoid afIgnoreFrameReset();\n> -\tdouble afEstimateVariance(const y_table_item_t *y_item, uint32_t len,\n> -\t\t\t\t bool isY1);\n> +\tdouble afEstimateVariance(Span y_items, bool isY1);\n> +\n> \tbool afIsOutOfFocus(IPAContext context);\n> \n> \t/* VCM step configuration. It is the current setting of the VCM step. */","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6DCBEC0F1B\n\tfor ;\n\tTue, 29 Mar 2022 05:57:09 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2772265631;\n\tTue, 29 Mar 2022 07:57:09 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 999EF604BC\n\tfor ;\n\tTue, 29 Mar 2022 07:57:07 +0200 (CEST)","from [IPV6:2a01:e0a:169:7140:46c7:900e:3d98:76e7] (unknown\n\t[IPv6:2a01:e0a:169:7140:46c7:900e:3d98:76e7])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 58C9B888;\n\tTue, 29 Mar 2022 07:57:07 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1648533429;\n\tbh=yJ1vJlRHFRi4hK2R8aogWVvI4duaNyMq6ImE5aGfZTY=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=oLtMKRCBj+m1UQWyhJ05XLi9N4Kn6bT2zazuxzWAxeKhNw92NJfEOqiDXY/j+8uI7\n\tCLbf3IyRu5zBxR6rRnrT+PdUEh+j/3ZMoSQZSHAN4KEHDyMduwDkthRbA73sChPCUp\n\tTmMPqAR+YvvO1SnrM5lwzRO1Jlb4/RvlHpiuRH0AUetl7tIR4s4cmxeTW/IhqLl2nv\n\tlRHJTLTsMpCHUasDMNW1DdIudsgMDztdNJPS/LaykUpzKqPumA76F9Ss7nMxD3DHH4\n\tMCtzcIIJ6gxlq7ofPx20Dmbyp8KeYLuk4qz8PinhoPUbtHQc3l+6B9n3Dl1ZVr/3KK\n\tyX4hzfBn5jS/Q==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1648533427;\n\tbh=yJ1vJlRHFRi4hK2R8aogWVvI4duaNyMq6ImE5aGfZTY=;\n\th=Date:Subject:To:Cc:References:From:In-Reply-To:From;\n\tb=sSLGuKZsn7U5UffkEI5thhDuYOAjPb/p3Rx6lWsujbzJ0vCShTgYV8Lg0zITFJhBa\n\tG9zQsZbtAFWJwgkzu6A7KDUn0vGpLNMKh8kY/8bp+IsCgQlyE8x/xiRiEFhLgWoeb+\n\tUB6zbv32Wa8rBWE0Bm6jyAzpTTEVNoP1uyS/KD5o="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"sSLGuKZs\"; dkim-atps=neutral","Message-ID":"","Date":"Tue, 29 Mar 2022 07:57:04 +0200","MIME-Version":"1.0","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101\n\tThunderbird/91.7.0","Content-Language":"en-US","To":"Kieran Bingham ,\n\tlibcamera devel ,\n\tKate Hsuan ","References":"<20220325092555.1799897-1-kieran.bingham@ideasonboard.com>\n\t<20220325092555.1799897-5-kieran.bingham@ideasonboard.com>","In-Reply-To":"<20220325092555.1799897-5-kieran.bingham@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH v3 4/5] ipa: ipu3: af: Use Span for\n\ty_table_item_t","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Jean-Michel Hautbois via libcamera-devel\n\t","Reply-To":"Jean-Michel Hautbois ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]