{"id":15551,"url":"https://patchwork.libcamera.org/api/patches/15551/?format=json","web_url":"https://patchwork.libcamera.org/patch/15551/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20220325092555.1799897-2-kieran.bingham@ideasonboard.com>","date":"2022-03-25T09:25:51","name":"[libcamera-devel,v3,1/5] ipa: ipu3: af: Move constants to implementation","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"0183c0070886643abbd1dc1c62025a442338642b","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/?format=json","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/15551/mbox/","series":[{"id":3000,"url":"https://patchwork.libcamera.org/api/series/3000/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3000","date":"2022-03-25T09:25:50","name":"ipa: ipu3: af: Small improvements","version":3,"mbox":"https://patchwork.libcamera.org/series/3000/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/15551/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/15551/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 57671BD80A\n\tfor ;\n\tFri, 25 Mar 2022 09:26:04 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 934DE604E6;\n\tFri, 25 Mar 2022 10:26:02 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C72AC60136\n\tfor ;\n\tFri, 25 Mar 2022 10:26:00 +0100 (CET)","from Monstersaurus.ksquared.org.uk.beta.tailscale.net\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 3DBBBA1B;\n\tFri, 25 Mar 2022 10:26:00 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1648200362;\n\tbh=43NIJj+5hiFsqIBc/AOVO2guQQtSCWxiznrx5wLbua4=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=PBtnxHriowvaCA2pwJyBCNmmHbcGwQLKikUy6C5CA9ZNKhJirQvMq1i3bK5VhS+Zl\n\tncCaFBHjXgj2fhs64DNFSYk3tif1+nK2cT0atENJXA0h0hMmJ4pGv/4nSYs1VkPmZv\n\tmGczGRN6HiqBdr0SfmaM1u8OoaGV73k8mlQgt5aDiFEHzMUOPJz/dhm2s2IY/3llgR\n\thJps+9TxBWaRRhzCRqOtzzws9+TQbFJYF7gzykWYGFIwoEtle6lbp6DEcmTH/Va/MU\n\tNAXGbOZSC29wQKtpwzT5bJu8KEQV4IWAbs7Gi/a8YG55vK29uBfnLzaCVnAH4qQ8ZX\n\tsouuD2fDnHwTQ==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1648200360;\n\tbh=43NIJj+5hiFsqIBc/AOVO2guQQtSCWxiznrx5wLbua4=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=r0gJsfpxNUyZmwTYjsAuVMAXAPyva5qbTU50KQ4qjBHTiRjybhfdKgkHBJufoljIN\n\tqgdUphjVVp2remuBM+qMCS3aeUlViXUD6SI0SAtkxwGUd0orXzvB9rBIvT+vi82yM4\n\t3QjxdkrI/PaW8Hf2ClLVzdkbsb9+RriMHb+PKFI4="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"r0gJsfpx\"; dkim-atps=neutral","To":"libcamera devel ,\n\tKate Hsuan ,\n\tJean-Michel Hautbois ","Date":"Fri, 25 Mar 2022 09:25:51 +0000","Message-Id":"<20220325092555.1799897-2-kieran.bingham@ideasonboard.com>","X-Mailer":"git-send-email 2.32.0","In-Reply-To":"<20220325092555.1799897-1-kieran.bingham@ideasonboard.com>","References":"<20220325092555.1799897-1-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v3 1/5] ipa: ipu3: af: Move constants to\n\timplementation","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kieran Bingham via libcamera-devel\n\t","Reply-To":"Kieran Bingham ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"A selection of constants are imported from ChromiumOS.\n\nMove these out of the header, and simplify their documentation. Further\nmore, add a direct reference to the location they were obtained from.\n\nReviewed-by: Laurent Pinchart \nSigned-off-by: Kieran Bingham \n---\n src/ipa/ipu3/algorithms/af.cpp | 73 ++++++++++------------------------\n src/ipa/ipu3/algorithms/af.h | 11 -----\n 2 files changed, 22 insertions(+), 62 deletions(-)","diff":"diff --git a/src/ipa/ipu3/algorithms/af.cpp b/src/ipa/ipu3/algorithms/af.cpp\nindex 0170a3728892..634d0f2e3176 100644\n--- a/src/ipa/ipu3/algorithms/af.cpp\n+++ b/src/ipa/ipu3/algorithms/af.cpp\n@@ -29,59 +29,30 @@\n * \\file af.h\n */\n \n-/**\n- * \\var kAfMinGridWidth\n- * \\brief the minimum width of AF grid.\n- * The minimum grid horizontal dimensions.\n- */\n-\n-/**\n- * \\var kAfMinGridHeight\n- * \\brief the minimum height of AF grid.\n- * The minimum grid vertical dimensions.\n- */\n-\n-/**\n- * \\var kAfMaxGridWidth\n- * \\brief the maximum width of AF grid.\n- * The maximum grid horizontal dimensions.\n- */\n-\n-/**\n- * \\var kAfMaxGridHeight\n- * \\brief The maximum height of AF grid.\n- * The maximum grid vertical dimensions.\n- */\n-\n-/**\n- * \\var kAfMinGridBlockWidth\n- * \\brief The minimum block size of the width.\n- * The minimum value of Log2 of the width of the grid cell.\n- */\n-\n-/**\n- * \\var kAfMinGridBlockHeight\n- * \\brief The minimum block size of the height.\n- * The minimum value of Log2 of the height of the grid cell.\n- */\n-\n-/**\n- * \\def kAfMaxGridBlockWidth\n- * \\brief The maximum block size of the width.\n- * The maximum value of Log2 of the width of the grid cell.\n- */\n-\n-/**\n- * \\var kAfMaxGridBlockHeight\n- * \\brief The maximum block size of the height.\n- * The maximum value of Log2 of the height of the grid cell.\n+/*\n+ * Static variables from ChromiumOS Intel Camera HAL and ia_imaging library:\n+ * - https://chromium.googlesource.com/chromiumos/platform/arc-camera/+/master/hal/intel/psl/ipu3/statsConverter/ipu3-stats.h\n+ * - https://chromium.googlesource.com/chromiumos/platform/camera/+/refs/heads/main/hal/intel/ipu3/include/ia_imaging/af_public.h\n */\n \n-/**\n- * \\var kAfDefaultHeightPerSlice\n- * \\brief The default number of blocks in vertical axis per slice.\n- * The number of blocks in vertical axis per slice.\n- */\n+/** The minimum horizontal grid dimension. */\n+static constexpr uint8_t kAfMinGridWidth = 16;\n+/** The minimum vertical grid dimension. */\n+static constexpr uint8_t kAfMinGridHeight = 16;\n+/** The maximum horizontal grid dimension. */\n+static constexpr uint8_t kAfMaxGridWidth = 32;\n+/** The maximum vertical grid dimension. */\n+static constexpr uint8_t kAfMaxGridHeight = 24;\n+/** The minimum value of Log2 of the width of the grid cell. */\n+static constexpr uint16_t kAfMinGridBlockWidth = 4;\n+/** The minimum value of Log2 of the height of the grid cell. */\n+static constexpr uint16_t kAfMinGridBlockHeight = 3;\n+/** The maximum value of Log2 of the width of the grid cell. */\n+static constexpr uint16_t kAfMaxGridBlockWidth = 6;\n+/** The maximum value of Log2 of the height of the grid cell. */\n+static constexpr uint16_t kAfMaxGridBlockHeight = 6;\n+/** The number of blocks in vertical axis per slice. */\n+static constexpr uint16_t kAfDefaultHeightPerSlice = 2;\n \n namespace libcamera {\n \ndiff --git a/src/ipa/ipu3/algorithms/af.h b/src/ipa/ipu3/algorithms/af.h\nindex 13c7e0e877fd..906f2843dd49 100644\n--- a/src/ipa/ipu3/algorithms/af.h\n+++ b/src/ipa/ipu3/algorithms/af.h\n@@ -15,17 +15,6 @@\n \n #include \"algorithm.h\"\n \n-/* Static variables from repo of chromium */\n-static constexpr uint8_t kAfMinGridWidth = 16;\n-static constexpr uint8_t kAfMinGridHeight = 16;\n-static constexpr uint8_t kAfMaxGridWidth = 32;\n-static constexpr uint8_t kAfMaxGridHeight = 24;\n-static constexpr uint16_t kAfMinGridBlockWidth = 4;\n-static constexpr uint16_t kAfMinGridBlockHeight = 3;\n-static constexpr uint16_t kAfMaxGridBlockWidth = 6;\n-static constexpr uint16_t kAfMaxGridBlockHeight = 6;\n-static constexpr uint16_t kAfDefaultHeightPerSlice = 2;\n-\n namespace libcamera {\n \n namespace ipa::ipu3::algorithms {\n","prefixes":["libcamera-devel","v3","1/5"]}