[{"id":22441,"web_url":"https://patchwork.libcamera.org/comment/22441/","msgid":"<164814027654.1484799.10911285640609787102@Monstersaurus>","date":"2022-03-24T16:44:36","subject":"Re: [libcamera-devel] [PATCH] cam: Fix indentation in meson.build","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Laurent Pinchart via libcamera-devel (2022-03-24 16:03:51)\n> One if...endif block is incorrectly indented. Fix it.\n> \n> Signed-off-by: Laurent Pinchart \n\n\nReviewed-by: Kieran Bingham \n\n> ---\n> src/cam/meson.build | 10 +++++-----\n> 1 file changed, 5 insertions(+), 5 deletions(-)\n> \n> diff --git a/src/cam/meson.build b/src/cam/meson.build\n> index e8e2ae57d3f4..5bab8c9e331b 100644\n> --- a/src/cam/meson.build\n> +++ b/src/cam/meson.build\n> @@ -25,11 +25,11 @@ cam_cpp_args = []\n> libdrm = dependency('libdrm', required : false)\n> \n> if libdrm.found()\n> -cam_cpp_args += [ '-DHAVE_KMS' ]\n> -cam_sources += files([\n> - 'drm.cpp',\n> - 'kms_sink.cpp'\n> -])\n> + cam_cpp_args += [ '-DHAVE_KMS' ]\n> + cam_sources += files([\n> + 'drm.cpp',\n> + 'kms_sink.cpp'\n> + ])\n> endif\n> \n> cam = executable('cam', cam_sources,\n> -- \n> Regards,\n> \n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0FD93BD80A\n\tfor ;\n\tThu, 24 Mar 2022 16:44:40 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 10E86604DB;\n\tThu, 24 Mar 2022 17:44:40 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7C49260397\n\tfor ;\n\tThu, 24 Mar 2022 17:44:38 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 0FC7E1844;\n\tThu, 24 Mar 2022 17:44:38 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1648140280;\n\tbh=hA2IBZiXucX2i6QOrPSzkaJUumQ/yB+49GvjZwtinkc=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=y25O+jtQzwKKOgWtHAD+IVIEADik/1OuX4EjvF4kT6T122kVv+yPmDfHuRmS5BbSl\n\tlXZcnjLodUwCJyXmCaEktzvxygPa3BjxRK4BGQA/O050zdbO46TcIWimQn1Wx1VOWz\n\tUyP0TAtpQvo509pCkhoPARXDNZ2NM8rFoFcu9jJXUAZJGqqQ87twBABo9ftNwp5aB8\n\tIEhex+lcH4ODyNzzUcKfkKeeXgElkltHhYgP+5uKORGnqLbWJI5hwiUwk1nJZm/kmZ\n\tzutCF7psLsQhuTwRi1SE2LANIotxR/CzuXmRh5wPeXucj6dJy8/v63Iifc8X0sYFxT\n\tEgxx0f1U5Z2YA==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1648140278;\n\tbh=hA2IBZiXucX2i6QOrPSzkaJUumQ/yB+49GvjZwtinkc=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=nmipB9uKUZuM52JYQrVazg+eoQkIwk+4u/VrU+XLgPoigd/R3dOa2B1bOITg6gzAR\n\tnLgJ6XkTx9owFpFmd+75r1fMuk3Kut6Wms+vWVeowe8sZDt9ciRMzZeTgOK1eRXOXr\n\tJ+gyNs+colKhzcuhzmdUKHY0OY24Qh6pSAN/ZQZQ="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"nmipB9uK\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20220324160351.2731-1-laurent.pinchart@ideasonboard.com>","References":"<20220324160351.2731-1-laurent.pinchart@ideasonboard.com>","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Thu, 24 Mar 2022 16:44:36 +0000","Message-ID":"<164814027654.1484799.10911285640609787102@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH] cam: Fix indentation in meson.build","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kieran Bingham via libcamera-devel\n\t","Reply-To":"Kieran Bingham ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":22446,"web_url":"https://patchwork.libcamera.org/comment/22446/","msgid":"<20220325051209.GB3036343@pyrite.rasen.tech>","date":"2022-03-25T05:12:09","subject":"Re: [libcamera-devel] [PATCH] cam: Fix indentation in meson.build","submitter":{"id":97,"url":"https://patchwork.libcamera.org/api/people/97/","name":"Nicolas Dufresne via libcamera-devel","email":"libcamera-devel@lists.libcamera.org"},"content":"Hi Laurent,\n\nOn Thu, Mar 24, 2022 at 06:03:51PM +0200, Laurent Pinchart via libcamera-devel wrote:\n> One if...endif block is incorrectly indented. Fix it.\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Paul Elder \n\n> ---\n> src/cam/meson.build | 10 +++++-----\n> 1 file changed, 5 insertions(+), 5 deletions(-)\n> \n> diff --git a/src/cam/meson.build b/src/cam/meson.build\n> index e8e2ae57d3f4..5bab8c9e331b 100644\n> --- a/src/cam/meson.build\n> +++ b/src/cam/meson.build\n> @@ -25,11 +25,11 @@ cam_cpp_args = []\n> libdrm = dependency('libdrm', required : false)\n> \n> if libdrm.found()\n> -cam_cpp_args += [ '-DHAVE_KMS' ]\n> -cam_sources += files([\n> - 'drm.cpp',\n> - 'kms_sink.cpp'\n> -])\n> + cam_cpp_args += [ '-DHAVE_KMS' ]\n> + cam_sources += files([\n> + 'drm.cpp',\n> + 'kms_sink.cpp'\n> + ])\n> endif\n> \n> cam = executable('cam', cam_sources,\n> -- \n> Regards,\n> \n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B6E45C0F1B\n\tfor ;\n\tFri, 25 Mar 2022 05:12:18 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1CA44604D4;\n\tFri, 25 Mar 2022 06:12:18 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E4DC3604C0\n\tfor ;\n\tFri, 25 Mar 2022 06:12:15 +0100 (CET)","from pyrite.rasen.tech (h175-177-042-148.catv02.itscom.jp\n\t[175.177.42.148])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 967D46F3;\n\tFri, 25 Mar 2022 06:12:14 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1648185138;\n\tbh=uPw3Uf1RxGTBa8qINYZPU6VSbVUmcsKc+h9NHAlCFek=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=4N5Ga7E7rpcztXxEX9InyEC6bkCHlXdsRbk8nOK1wLQ/FnPzx+28hQXss32J4O8Hc\n\tWsYxDFPvdywf4xhSKRrQcdI3sbUQ9H8howQcRne4O9JNDtR3b4P5RIWecGPDfSee1w\n\tw1Q5sEBlMvuupHY+6Jbq86dO1xt59uzsODL6HjUhSPyNcZOKnnsscodU/lGOwotWs6\n\tQjDyGPLgsLUfXHrBa4u97VlBEF2a65rjGrjIJ6AOwsHxLNlcfGB2hyepwib3kL4hFY\n\t2HNfuCqzxsDm4gppcMtEM7EB8cAE3ier/UdcLrlhI19U8yxV/cWR106sKpKIQs5bog\n\tVyu+T1PfV6Q2w==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1648185135;\n\tbh=uPw3Uf1RxGTBa8qINYZPU6VSbVUmcsKc+h9NHAlCFek=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=XWWhFSeUe5siuZeA1HA+sa8BJF+tmoMr6G5cCmDhaWPv+pSAczoAqze/Xhj0HVEgY\n\t//bVhb1JbgCqkDU+NkXALi8hALQtKQeEI742CVMlcAewY81cqmjy03mGQmGv2MxA4W\n\tvTs2rVXncNOF+FTbWZ603zmRYMRc+mwLt+fveGMc="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"XWWhFSeU\"; dkim-atps=neutral","Date":"Fri, 25 Mar 2022 14:12:09 +0900","To":"Laurent Pinchart ","Message-ID":"<20220325051209.GB3036343@pyrite.rasen.tech>","References":"<20220324160351.2731-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20220324160351.2731-1-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH] cam: Fix indentation in meson.build","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Paul Elder via libcamera-devel ","Reply-To":"paul.elder@ideasonboard.com","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]