[{"id":22420,"web_url":"https://patchwork.libcamera.org/comment/22420/","msgid":"","date":"2022-03-24T00:27:11","subject":"Re: [libcamera-devel] [PATCH v2 4/5] ipa: ipu3: af: Use Span for\n\ty_table_item_t","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nThank you for the patch.\n\nOn Wed, Mar 23, 2022 at 01:56:13PM +0000, Kieran Bingham via libcamera-devel wrote:\n> Convert the y_table_item_t to a Span and use that for iteration when\n> estimating variance of the table.\n> \n> Signed-off-by: Kieran Bingham \n> ---\n> src/ipa/ipu3/algorithms/af.cpp | 34 +++++++++++++++++-----------------\n> src/ipa/ipu3/algorithms/af.h | 4 ++--\n> 2 files changed, 19 insertions(+), 19 deletions(-)\n> \n> diff --git a/src/ipa/ipu3/algorithms/af.cpp b/src/ipa/ipu3/algorithms/af.cpp\n> index 68e100fdc504..ff5e9fb5b3c5 100644\n> --- a/src/ipa/ipu3/algorithms/af.cpp\n> +++ b/src/ipa/ipu3/algorithms/af.cpp\n> @@ -336,29 +336,29 @@ void Af::afIgnoreFrameReset()\n> *\n> * \\return The variance of the values in the data set \\a y_item selected by \\a isY1\n> */\n> -double Af::afEstimateVariance(const y_table_item_t *y_item, uint32_t len,\n> -\t\t\t bool isY1)\n> +double Af::afEstimateVariance(Span y_items, bool isY1)\n> {\n> -\tuint32_t z = 0;\n> \tuint32_t total = 0;\n> \tdouble mean;\n> \tdouble var_sum = 0;\n> \n> -\tfor (z = 0; z < len; z++) {\n> +\tfor (auto y : y_items) {\n> \t\tif (isY1)\n> -\t\t\ttotal += y_item[z].y1_avg;\n> +\t\t\ttotal += y.y1_avg;\n> \t\telse\n> -\t\t\ttotal += y_item[z].y2_avg;\n> +\t\t\ttotal += y.y2_avg;\n> \t}\n> -\tmean = total / len;\n> -\tfor (z = 0; z < len; z++) {\n> +\n> +\tmean = total / y_items.size();\n> +\n> +\tfor (auto y : y_items) {\n> \t\tif (isY1)\n> -\t\t\tvar_sum += pow((y_item[z].y1_avg - mean), 2);\n> +\t\t\tvar_sum += pow((y.y1_avg - mean), 2);\n\nWhile at it you could remove the extra parentheses.\n\n> \t\telse\n> -\t\t\tvar_sum += pow((y_item[z].y2_avg - mean), 2);\n> +\t\t\tvar_sum += pow((y.y2_avg - mean), 2);\n\nSame here.\n\n> \t}\n> \n> -\treturn var_sum / static_cast(len);\n> +\treturn var_sum / static_cast(y_items.size());\n\nThe cast could also be dropped.\n\nReviewed-by: Laurent Pinchart \n\nDid I mention I like the span class ? :-)\n\n> }\n> \n> /**\n> @@ -406,21 +406,21 @@ bool Af::afIsOutOfFocus(IPAContext context)\n> */\n> void Af::process(IPAContext &context, const ipu3_uapi_stats_3a *stats)\n> {\n> -\tconst y_table_item_t *y_item = reinterpret_cast(&stats->af_raw_buffer.y_table);\n> -\tuint32_t afRawBufferLen;\n> -\n> \t/* Evaluate the AF buffer length */\n> -\tafRawBufferLen = context.configuration.af.afGrid.width *\n> -\t\t\t context.configuration.af.afGrid.height;\n> +\tuint32_t afRawBufferLen = context.configuration.af.afGrid.width *\n> +\t\t\t\t context.configuration.af.afGrid.height;\n> \n> \tASSERT(afRawBufferLen < IPU3_UAPI_AF_Y_TABLE_MAX_SIZE);\n> \n> +\tSpan y_items(reinterpret_cast(&stats->af_raw_buffer.y_table),\n> +\t\t\t\t\t afRawBufferLen);\n> +\n> \t/*\n> \t * Calculate the mean and the variance of AF statistics for a given grid.\n> \t * For coarse: y1 are used.\n> \t * For fine: y2 results are used.\n> \t */\n> -\tcurrentVariance_ = afEstimateVariance(y_item, afRawBufferLen, !coarseCompleted_);\n> +\tcurrentVariance_ = afEstimateVariance(y_items, !coarseCompleted_);\n> \n> \tif (!context.frameContext.af.stable) {\n> \t\tafCoarseScan(context);\n> diff --git a/src/ipa/ipu3/algorithms/af.h b/src/ipa/ipu3/algorithms/af.h\n> index 3b5758e868ea..b85cf94163ff 100644\n> --- a/src/ipa/ipu3/algorithms/af.h\n> +++ b/src/ipa/ipu3/algorithms/af.h\n> @@ -41,8 +41,8 @@ private:\n> \tvoid afReset(IPAContext &context);\n> \tbool afNeedIgnoreFrame();\n> \tvoid afIgnoreFrameReset();\n> -\tdouble afEstimateVariance(const y_table_item_t *y_item, uint32_t len,\n> -\t\t\t\t bool isY1);\n> +\tdouble afEstimateVariance(Span y_items, bool isY1);\n> +\n> \tbool afIsOutOfFocus(IPAContext context);\n> \n> \t/* VCM step configuration. It is the current setting of the VCM step. */","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 97395C0F1B\n\tfor ;\n\tThu, 24 Mar 2022 00:27:15 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8D5FA604DA;\n\tThu, 24 Mar 2022 01:27:14 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 61285604C5\n\tfor ;\n\tThu, 24 Mar 2022 01:27:13 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C339C12E9;\n\tThu, 24 Mar 2022 01:27:12 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1648081634;\n\tbh=Fy3ik5K7PbXgMohmb/XtVBnE4vIlN+tWh2UxVfr+BCM=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=mGV7Ju3T/toKJ6N6TBlkhRhX5INWOIrhI0NOj35doObt60W0jhdW0lTPii1PiFnmA\n\tbFfB03fIcKR6ZqQG8+BTxcp8/LrCC3K4a6eKm7pUefrliR60voqkX7NJrb/6qNXH6E\n\tFta1urFBI3LTJlZ8EIh8AjyH1RkAAWNWFZdrn6yELu6Bly1JVdRKzrPXfAA9uCuRAb\n\tpBtqLjyA1EXPmx8H9AkWBfQRK0IJ8FFPu2lOWt09DiwwxbvxAoTWO7FRYdNgjjOTEZ\n\t2mOvfzXmmOhVlfDDJtkia2mjUdiyjeEvZXtUxQJifDohVzjfi2yW0efpdYdaVjCsZU\n\tBpaNurMM1/TgQ==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1648081633;\n\tbh=Fy3ik5K7PbXgMohmb/XtVBnE4vIlN+tWh2UxVfr+BCM=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=VgPdQgSNK3Xp5lgzCz8uY7VeHbrGpTV1QGY+qNYWui92o3XAiDudBj7Qf8QBJ1qNl\n\tnnzt0HwtusW3JRYZ2lbJYiMeSE2ZtX9jt7Pjgvy6o2Su0ALay8q4mNpToNP8Bp0pkd\n\tKMNyltlsKtOvqHpjObjmGUocyhMdgdDcx9EMGH/8="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"VgPdQgSN\"; dkim-atps=neutral","Date":"Thu, 24 Mar 2022 02:27:11 +0200","To":"Kieran Bingham ","Message-ID":"","References":"<20220323135614.865252-1-kieran.bingham@ideasonboard.com>\n\t<20220323135614.865252-5-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20220323135614.865252-5-kieran.bingham@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v2 4/5] ipa: ipu3: af: Use Span for\n\ty_table_item_t","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]