{"id":15521,"url":"https://patchwork.libcamera.org/api/patches/15521/?format=json","web_url":"https://patchwork.libcamera.org/patch/15521/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20220323135614.865252-4-kieran.bingham@ideasonboard.com>","date":"2022-03-23T13:56:12","name":"[libcamera-devel,v2,3/5] ipa: ipu3: af: Remove redundant memcpy","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"cc8d6fe36d7efcd1eb3257541f8dc11c7f5b25ee","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/?format=json","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/15521/mbox/","series":[{"id":2989,"url":"https://patchwork.libcamera.org/api/series/2989/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2989","date":"2022-03-23T13:56:09","name":"ipa: ipu3: af: Small improvements","version":2,"mbox":"https://patchwork.libcamera.org/series/2989/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/15521/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/15521/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 046BAC3265\n\tfor ;\n\tWed, 23 Mar 2022 13:56:25 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id ACE1A632E5;\n\tWed, 23 Mar 2022 14:56:25 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 347F9604C6\n\tfor ;\n\tWed, 23 Mar 2022 14:56:21 +0100 (CET)","from Monstersaurus.ksquared.org.uk.beta.tailscale.net\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D8C1F9DE;\n\tWed, 23 Mar 2022 14:56:20 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1648043785;\n\tbh=A1g4kuQaYiTSdeq7im294Vu8hMz13VzXpGOkDfCbC/4=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=Ho1AYEp+lf3NFms67ZDwiD04PYTaWTZ1KAcf6cVwoFFeeVD7R8g0B93oH75W0YGM5\n\tW0+W0ZzbIONWhzHrkowfurHPjpDY2MivgcVtRlXXf+X8oJ5HJePFoUCJ/1x4oDBA7R\n\t5cSJqCeatwuBrdPQdvRBZlYOVtFjAxAs/LVvUYF4dBwK3N2nyuoDOoz19j5bL8r7pj\n\tbepvlMGANajbTSp5DEPmip0eD+x1tFe49sR/TTEQfl/WJHZDDM/HxrOToBtOrElGrR\n\tdb3CqyVENyAJcZEtdZc66zWE4URUYUmYwVIeDCjq9XS/C+T8k7wayavKkVz25qHI3U\n\tIirrmi7YOAi8g==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1648043781;\n\tbh=A1g4kuQaYiTSdeq7im294Vu8hMz13VzXpGOkDfCbC/4=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=deuwMcakgvVcudhenUGDSt0mhe1rM40nWIgxmH0BI4zfM7RsCxX3cLtKMsIJhver7\n\tdZVBf3C2nSA1CdwGoUC3NU5ExyXNqd2Cyu0AtbwSrMYhHAEZyrjRVyMAEXfGvwsRY7\n\tZXo3WmAdb8bQuFiXlbzo1JXkrfGCOLDpyQlQnmtM="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"deuwMcak\"; dkim-atps=neutral","To":"libcamera devel ","Date":"Wed, 23 Mar 2022 13:56:12 +0000","Message-Id":"<20220323135614.865252-4-kieran.bingham@ideasonboard.com>","X-Mailer":"git-send-email 2.32.0","In-Reply-To":"<20220323135614.865252-1-kieran.bingham@ideasonboard.com>","References":"<20220323135614.865252-1-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v2 3/5] ipa: ipu3: af: Remove redundant\n\tmemcpy","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kieran Bingham via libcamera-devel\n\t","Reply-To":"Kieran Bingham ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The af statistics can be accessed directly from the mapped buffer.\nRemove the redundant memcpy, and simplify the call to\nafEstimateVariance().\n\nReviewed-by: Laurent Pinchart \nSigned-off-by: Kieran Bingham \n\n---\nv2:\n - Fix ASSERT\n\n src/ipa/ipu3/algorithms/af.cpp | 12 ++++--------\n src/ipa/ipu3/algorithms/af.h | 2 +-\n 2 files changed, 5 insertions(+), 9 deletions(-)","diff":"diff --git a/src/ipa/ipu3/algorithms/af.cpp b/src/ipa/ipu3/algorithms/af.cpp\nindex f5a489412a9e..68e100fdc504 100644\n--- a/src/ipa/ipu3/algorithms/af.cpp\n+++ b/src/ipa/ipu3/algorithms/af.cpp\n@@ -336,7 +336,7 @@ void Af::afIgnoreFrameReset()\n *\n * \\return The variance of the values in the data set \\a y_item selected by \\a isY1\n */\n-double Af::afEstimateVariance(y_table_item_t *y_item, uint32_t len,\n+double Af::afEstimateVariance(const y_table_item_t *y_item, uint32_t len,\n \t\t\t bool isY1)\n {\n \tuint32_t z = 0;\n@@ -406,25 +406,21 @@ bool Af::afIsOutOfFocus(IPAContext context)\n */\n void Af::process(IPAContext &context, const ipu3_uapi_stats_3a *stats)\n {\n-\ty_table_item_t y_item[IPU3_UAPI_AF_Y_TABLE_MAX_SIZE / sizeof(y_table_item_t)];\n+\tconst y_table_item_t *y_item = reinterpret_cast(&stats->af_raw_buffer.y_table);\n \tuint32_t afRawBufferLen;\n \n \t/* Evaluate the AF buffer length */\n \tafRawBufferLen = context.configuration.af.afGrid.width *\n \t\t\t context.configuration.af.afGrid.height;\n \n-\tmemcpy(y_item, stats->af_raw_buffer.y_table,\n-\t afRawBufferLen * sizeof(y_table_item_t));\n+\tASSERT(afRawBufferLen < IPU3_UAPI_AF_Y_TABLE_MAX_SIZE);\n \n \t/*\n \t * Calculate the mean and the variance of AF statistics for a given grid.\n \t * For coarse: y1 are used.\n \t * For fine: y2 results are used.\n \t */\n-\tif (coarseCompleted_)\n-\t\tcurrentVariance_ = afEstimateVariance(y_item, afRawBufferLen, false);\n-\telse\n-\t\tcurrentVariance_ = afEstimateVariance(y_item, afRawBufferLen, true);\n+\tcurrentVariance_ = afEstimateVariance(y_item, afRawBufferLen, !coarseCompleted_);\n \n \tif (!context.frameContext.af.stable) {\n \t\tafCoarseScan(context);\ndiff --git a/src/ipa/ipu3/algorithms/af.h b/src/ipa/ipu3/algorithms/af.h\nindex 906f2843dd49..3b5758e868ea 100644\n--- a/src/ipa/ipu3/algorithms/af.h\n+++ b/src/ipa/ipu3/algorithms/af.h\n@@ -41,7 +41,7 @@ private:\n \tvoid afReset(IPAContext &context);\n \tbool afNeedIgnoreFrame();\n \tvoid afIgnoreFrameReset();\n-\tdouble afEstimateVariance(y_table_item_t *y_item, uint32_t len,\n+\tdouble afEstimateVariance(const y_table_item_t *y_item, uint32_t len,\n \t\t\t\t bool isY1);\n \tbool afIsOutOfFocus(IPAContext context);\n \n","prefixes":["libcamera-devel","v2","3/5"]}