{"id":15493,"url":"https://patchwork.libcamera.org/api/patches/15493/?format=json","web_url":"https://patchwork.libcamera.org/patch/15493/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20220322024155.6528-2-hpa@redhat.com>","date":"2022-03-22T02:41:52","name":"[libcamera-devel,1/4] ipa: ipu3: af: Introduce AWB and AE lock when AF scanning","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"7b362baadf7f794cbb506f825b541755d39b20fc","submitter":{"id":105,"url":"https://patchwork.libcamera.org/api/people/105/?format=json","name":"Kate Hsuan","email":"hpa@redhat.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/15493/mbox/","series":[{"id":2981,"url":"https://patchwork.libcamera.org/api/series/2981/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2981","date":"2022-03-22T02:41:51","name":"ipa: ipu3: af: Temporarily suspend AWB and AE during AF scanning","version":1,"mbox":"https://patchwork.libcamera.org/series/2981/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/15493/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/15493/checks/","tags":{},"headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 786E4C0F1B\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 22 Mar 2022 02:42:17 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 22665604D4;\n\tTue, 22 Mar 2022 03:42:17 +0100 (CET)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.129.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 44FE5604C7\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 22 Mar 2022 03:42:15 +0100 (CET)","from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com\n\t[66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS\n\t(version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n\tus-mta-453-Pppxhb0tP-u67_TGKvh1hw-1; Mon, 21 Mar 2022 22:42:13 -0400","from smtp.corp.redhat.com\n\t(int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mimecast-mx02.redhat.com (Postfix) with ESMTPS id ED57A1011597\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 22 Mar 2022 02:42:12 +0000 (UTC)","from fedora.redhat.com (unknown [10.39.192.3])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 4D052C26E9D;\n\tTue, 22 Mar 2022 02:42:10 +0000 (UTC)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1647916937;\n\tbh=h4BHMgiI5B28amHJMMXvmLOVOH702jWuC8HBaN6O15k=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=EFHPxrA9BNtk4zsdi2TcDgFq49qlWsty6aLOKoJtlKln3CopXFgqrfvDOpS5ZiKog\n\tG5uH3/4t1MXf8eiYvG56DpJCFHwziKXUwCaZvnwBvft781aHBpQJWTuV5w6PPnTtHu\n\t08m1dofy3V8aSgayO9xn1Zyn6uCYZtRkGehgctLX8qLTTP15T1tiFmcjMJEn4ONUmp\n\tcqZ3eZ2TEquBgZxjnfmE3cC2rNpgQDY/mBAErneVOHyTBIYQvthM+7AGswCe2bvSRG\n\tpPx7h3r3hmOsq1w0gHw9aedQmxExQKmtlAucMWsa6mJpojrIs4TFk3bwvAfmPt666g\n\tBVzesuRBCrZ2Q==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1647916934;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=qcb+NA1kw5u7J4J9utP+Unh3CF4y0UiuQDQMbDT1H4s=;\n\tb=G9QdJ84Kwhrv9b1dbDIPYoAGdUWfLQR1YbsZobo6q0uyQqVVplXMODJSb4ldXLbR9io2wK\n\t6FAJdJgvIbiRT+7Clofb7pqLqSuoP7pHmRZMSE2LsLjI0FFJoseKs2QGeKq995rRZ+GwuS\n\tSfrXTiL5NYWZEQCxH/D/5EUWC0w6Nt0="],"Authentication-Results":["lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=redhat.com\n\theader.i=@redhat.com header.b=\"G9QdJ84K\"; \n\tdkim-atps=neutral","relay.mimecast.com;\n\tauth=pass smtp.auth=CUSA124A263 smtp.mailfrom=hpa@redhat.com"],"X-MC-Unique":"Pppxhb0tP-u67_TGKvh1hw-1","To":"libcamera devel <libcamera-devel@lists.libcamera.org>","Date":"Tue, 22 Mar 2022 10:41:52 +0800","Message-Id":"<20220322024155.6528-2-hpa@redhat.com>","In-Reply-To":"<20220322024155.6528-1-hpa@redhat.com>","References":"<20220322024155.6528-1-hpa@redhat.com>","MIME-Version":"1.0","X-Scanned-By":"MIMEDefang 2.85 on 10.11.54.8","X-Mimecast-Spam-Score":"0","X-Mimecast-Originator":"redhat.com","Content-Transfer-Encoding":"8bit","Content-Type":"text/plain; charset=\"US-ASCII\"","Subject":"[libcamera-devel] [PATCH 1/4] ipa: ipu3: af: Introduce AWB and AE\n\tlock when AF scanning","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","From":"Kate Hsuan via libcamera-devel <libcamera-devel@lists.libcamera.org>","Reply-To":"Kate Hsuan <hpa@redhat.com>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"},"content":"The floating AWB and AE results significantly impact the AF performance since the\nfocus value is determined by the image contrast. This lock is used to suspend\nthe AWB and AE during AF scanning.\n\nSigned-off-by: Kate Hsuan <hpa@redhat.com>\n---\n src/ipa/ipu3/algorithms/af.cpp | 3 +++\n src/ipa/ipu3/ipa_context.h     | 1 +\n 2 files changed, 4 insertions(+)","diff":"diff --git a/src/ipa/ipu3/algorithms/af.cpp b/src/ipa/ipu3/algorithms/af.cpp\nindex 0170a372..40a8ddae 100644\n--- a/src/ipa/ipu3/algorithms/af.cpp\n+++ b/src/ipa/ipu3/algorithms/af.cpp\n@@ -170,6 +170,9 @@ int Af::configure(IPAContext &context, const IPAConfigInfo &configInfo)\n \tgrid.block_height_log2 = kAfMinGridBlockHeight;\n \tgrid.height_per_slice = kAfDefaultHeightPerSlice;\n \n+\t/* Initial AE and AWB lock */\n+\tcontext.configuration.af.requireAeAwbLock = false;\n+\n \t/* x_start and y start are default to BDS center */\n \tgrid.x_start = (configInfo.bdsOutputSize.width / 2) -\n \t\t       (((grid.width << grid.block_width_log2) / 2));\ndiff --git a/src/ipa/ipu3/ipa_context.h b/src/ipa/ipu3/ipa_context.h\nindex 6b7a512e..8cc64c3e 100644\n--- a/src/ipa/ipu3/ipa_context.h\n+++ b/src/ipa/ipu3/ipa_context.h\n@@ -27,6 +27,7 @@ struct IPASessionConfiguration {\n \n \tstruct {\n \t\tipu3_uapi_grid_config afGrid;\n+\t\tbool requireAeAwbLock;\n \t} af;\n \n \tstruct {\n","prefixes":["libcamera-devel","1/4"]}