{"id":15484,"url":"https://patchwork.libcamera.org/api/patches/15484/?format=json","web_url":"https://patchwork.libcamera.org/patch/15484/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20220321102702.1753800-2-naush@raspberrypi.com>","date":"2022-03-21T10:26:58","name":"[libcamera-devel,v3,1/5] pipeline: raspberrypi: Avoid over-allocation for ISP Output 1","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"53af004f828588596acebb54539b9c11ac8383f7","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/?format=json","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/15484/mbox/","series":[{"id":2977,"url":"https://patchwork.libcamera.org/api/series/2977/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2977","date":"2022-03-21T10:26:57","name":"Raspberry Pi: Efficient start/stop/start sequences","version":3,"mbox":"https://patchwork.libcamera.org/series/2977/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/15484/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/15484/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D3783BD80A\n\tfor ;\n\tMon, 21 Mar 2022 10:27:08 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 794A9604EA;\n\tMon, 21 Mar 2022 11:27:08 +0100 (CET)","from mail-wm1-x329.google.com (mail-wm1-x329.google.com\n\t[IPv6:2a00:1450:4864:20::329])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 60A0E604C4\n\tfor ;\n\tMon, 21 Mar 2022 11:27:06 +0100 (CET)","by mail-wm1-x329.google.com with SMTP id r64so8208631wmr.4\n\tfor ;\n\tMon, 21 Mar 2022 03:27:06 -0700 (PDT)","from naush-laptop.pitowers.org\n\t([2a00:1098:3142:14:77bd:7c6c:a8b9:8855])\n\tby smtp.gmail.com with ESMTPSA id\n\tv10-20020a056000144a00b00203df06cf9bsm13530115wrx.106.2022.03.21.03.27.05\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 21 Mar 2022 03:27:05 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1647858428;\n\tbh=i63d6hUH3isSXt4iyQ9OeO4uzCK+/jYWFH31E+5m1HE=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=ILkxIULU0q1llinUYi0zFAJtw1LznHogSKQuvNcnOOAnmAHEkx8PYo08FJKUYns8c\n\tjkZNTaOaz6hA7S39W4cyeuWDeG1ePzhDJ03671h86iLe6POmYu/vQn28ofGGZGebgu\n\tSOJbCV40Qms7kfYzd5ArmACx028c2thxlql3vBSo8yQ1p3dAojuY1QGjFEBRICzbDx\n\tpxSeBYn0UelSXzfGZl8uD5c1PJAff6oQkFx85ejQoPmAR3If6wz37VQOmOEttUHD/W\n\to0z7rI6/Q30u8FPqGV3oyeEwybXMWkHGwtoJZ5qi8pR1KYn7KNZa0UGYT74vRg03CY\n\tttrOt1qNnfkLw==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=jcfkXUDyQsMHFwrfe/cenXQcfke3b/k+swts4GnZTjQ=;\n\tb=do6lP/L6+wRR6gJMX4dfdCcVlPupIQYowN7ZGpGXd7EJV55aAuNdbqd3FyWaG2cium\n\tSfj5T+vvO+OtBSY1lAbqru6qOqjsO2+eVFfRduUKsxiXM2Wl3VaFwBalzfiVTqEJ3lFT\n\t1/C33S7L/y2ndZ1XcGt9QkIAWzfApzMe/MdExIvJX2K1SFK6kIcTXSDpBctGtaLiBB5G\n\tGwp4qDNsLz37JNPKZs0ESov7tXj4zkd27ExypD5kjbdT7gAy9FjpPsgEW3I7gMApFLNa\n\tyyIr5O7FxKVEguAHWAsbpEDs0T4/dMyHLnIeeaee1g6JzLaCi9jdDRJoqUJU/jcbnheA\n\tErww=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=raspberrypi.com\n\theader.i=@raspberrypi.com\n\theader.b=\"do6lP/L6\"; dkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=jcfkXUDyQsMHFwrfe/cenXQcfke3b/k+swts4GnZTjQ=;\n\tb=lmeShbnJvk+1wWYYtoK0ICI3e2HE9VMc/TGIZy96iRoU+p53t+aJb4Ot9mos4WNRj/\n\tnMl52eXYrx/bMw3nkWwTow56xoFjhQ3JL2d1EJZ43DnvzpUhms5kMYAlVkhIJepmmwXb\n\tjB17dmGlVqid9S73/eCr7uA3YmMICpj6auZ6gB0yGBN5rC/k6xbmc6ZOJISu5mVYDVOx\n\tg3M+GAnCw28nJtPIQ7Vhv2JHBzB+piW9Y+GBwt+r6n/yYTNHXoGEBP6G+DShLWkQKLTn\n\tquPlPxWbZ5YARBrR180yETzfbVX14ERhM+wfE4y5EOFwvXiEGmTGDu59nZ4NTP5n2koo\n\t2EEQ==","X-Gm-Message-State":"AOAM533MrsVaq4M9Vf1FnhyhOQ6WaoyMOwlcwGxQiNlqUPZNalArQfSN\n\t4IqU+WxiBGLmRDzs6qY8s9em9AaPVTMTCg==","X-Google-Smtp-Source":"ABdhPJwDbOo1A8fldnrC1myj31l7VO02PiBOvZRkIWGrrEoq6CBH8VACShy0XNp1CQsfL3X8KAXQ7Q==","X-Received":"by 2002:a05:600c:49a9:b0:38c:987d:d692 with SMTP id\n\th41-20020a05600c49a900b0038c987dd692mr8798819wmp.166.1647858425878; \n\tMon, 21 Mar 2022 03:27:05 -0700 (PDT)","To":"libcamera-devel@lists.libcamera.org","Date":"Mon, 21 Mar 2022 10:26:58 +0000","Message-Id":"<20220321102702.1753800-2-naush@raspberrypi.com>","X-Mailer":"git-send-email 2.25.1","In-Reply-To":"<20220321102702.1753800-1-naush@raspberrypi.com>","References":"<20220321102702.1753800-1-naush@raspberrypi.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v3 1/5] pipeline: raspberrypi: Avoid\n\tover-allocation for ISP Output 1","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Naushir Patuck via libcamera-devel\n\t","Reply-To":"Naushir Patuck ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The V4L2DeviceFormat structure for the ISP Output 1 node was a copy of what is\nused ISP Output 0 node, but with the size changed. However, the plane size and\nstride values were not updated. So there is a possibility that the buffer might\nbe over-sized for the requested resolution.\n\nFix this by only copying the relevant fields from the ISP Output 0\nV4L2DeviceFormat structure, and let the device driver size the planes as needed.\n\nSigned-off-by: Naushir Patuck \nReviewed-by: David Plowman \nTested-by: David Plowman \nReviewed-by: Laurent Pinchart \n---\n src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 4 +++-\n 1 file changed, 3 insertions(+), 1 deletion(-)","diff":"diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\nindex c2230199fed7..43e87a406036 100644\n--- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n+++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n@@ -845,11 +845,13 @@ int PipelineHandlerRPi::configure(Camera *camera, CameraConfiguration *config)\n \t * colour denoise will not run.\n \t */\n \tif (!output1Set) {\n-\t\tV4L2DeviceFormat output1Format = format;\n+\t\tV4L2DeviceFormat output1Format;\n \t\tconstexpr Size maxDimensions(1200, 1200);\n \t\tconst Size limit = maxDimensions.boundedToAspectRatio(format.size);\n \n \t\toutput1Format.size = (format.size / 2).boundedTo(limit).alignedDownTo(2, 2);\n+\t\toutput1Format.colorSpace = format.colorSpace;\n+\t\toutput1Format.fourcc = V4L2PixelFormat::fromPixelFormat(formats::YUV420);\n \n \t\tLOG(RPI, Debug) << \"Setting ISP Output1 (internal) to \"\n \t\t\t\t<< output1Format.toString();\n","prefixes":["libcamera-devel","v3","1/5"]}