[{"id":22368,"web_url":"https://patchwork.libcamera.org/comment/22368/","msgid":"","date":"2022-03-22T23:23:26","subject":"Re: [libcamera-devel] [PATCH 2/2] media: staging/intel-ipu3:\n\tCleanup dummy buffers via helper","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Umang,\n\nThank you for the patch.\n\nOn Fri, Mar 18, 2022 at 05:48:26PM +0530, Umang Jain via libcamera-devel wrote:\n> Use an existing helper imgu_video_nodes_exit() on imgu-video-node\n> initialization failure path to cleanup dummy buffers.\n> \n> Signed-off-by: Umang Jain \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> drivers/staging/media/ipu3/ipu3.c | 25 +++++++++++--------------\n> 1 file changed, 11 insertions(+), 14 deletions(-)\n> \n> diff --git a/drivers/staging/media/ipu3/ipu3.c b/drivers/staging/media/ipu3/ipu3.c\n> index 8e1e9e46e604..0c453b37f8c4 100644\n> --- a/drivers/staging/media/ipu3/ipu3.c\n> +++ b/drivers/staging/media/ipu3/ipu3.c\n> @@ -440,6 +440,16 @@ int imgu_s_stream(struct imgu_device *imgu, int enable)\n> \treturn r;\n> }\n> \n> +static void imgu_video_nodes_exit(struct imgu_device *imgu)\n> +{\n> +\tint i;\n> +\n> +\tfor (i = 0; i < IMGU_MAX_PIPE_NUM; i++)\n> +\t\timgu_dummybufs_cleanup(imgu, i);\n> +\n> +\timgu_v4l2_unregister(imgu);\n> +}\n> +\n> static int imgu_video_nodes_init(struct imgu_device *imgu)\n> {\n> \tstruct v4l2_pix_format_mplane *fmts[IPU3_CSS_QUEUES] = { NULL };\n> @@ -489,24 +499,11 @@ static int imgu_video_nodes_init(struct imgu_device *imgu)\n> \treturn 0;\n> \n> out_cleanup:\n> -\tfor (j = 0; j < IMGU_MAX_PIPE_NUM; j++)\n> -\t\timgu_dummybufs_cleanup(imgu, j);\n> -\n> -\timgu_v4l2_unregister(imgu);\n> +\timgu_video_nodes_exit(imgu);\n> \n> \treturn r;\n> }\n> \n> -static void imgu_video_nodes_exit(struct imgu_device *imgu)\n> -{\n> -\tint i;\n> -\n> -\tfor (i = 0; i < IMGU_MAX_PIPE_NUM; i++)\n> -\t\timgu_dummybufs_cleanup(imgu, i);\n> -\n> -\timgu_v4l2_unregister(imgu);\n> -}\n> -\n> /**************** PCI interface ****************/\n> \n> static irqreturn_t imgu_isr_threaded(int irq, void *imgu_ptr)","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8FB00BD80A\n\tfor ;\n\tTue, 22 Mar 2022 23:23:46 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 491CA604DB;\n\tWed, 23 Mar 2022 00:23:46 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9C002604C6\n\tfor ;\n\tWed, 23 Mar 2022 00:23:44 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 3AFEC1273;\n\tWed, 23 Mar 2022 00:23:44 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1647991426;\n\tbh=pLN3KqefIsV8sQozUTnPBHAlnhpX9AuzCKXrNyseVh8=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=rZ6q99822tWLLZpcf3zhuZVsS6Qt5nuA9JhgoJfjr6K2uirw3+6L3MhI+lBEfXdgZ\n\tyzOTazrNlXFoBceXmysP5pDFCbTpTFDXQeIXAGeOUGeKaDALAtidwdV/5qw7NjTqCg\n\tcKjfCOgizsFbL3WDYaS4NOhMzRmf3RzXuVd8x2pPKVkY31TghLcyZYlKoqToJ/40OH\n\tj4K2kVFkObswNyVIhFUIZCw/hVRD7+7Jr0MUzoGNTB4UdvlR0SmMcjXYGtHLWbHgpH\n\tmJU3eJaUhvEzvLzUZbcb33noNQnmRR+5w6LJgiDARQ8qKxiFwAiRK+rb19feFTRqbT\n\tfGu74psnB5pSA==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1647991424;\n\tbh=pLN3KqefIsV8sQozUTnPBHAlnhpX9AuzCKXrNyseVh8=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=o2Op7fByiPNZeSJNUbJZRaS0w22guzJOmP7dlnnLcbvKkoYQSjN959uRp0sdTYcv8\n\tWeEkMNeMVwh4oIjKIsSXyiGGxgAPFBFptGBttmQ6ymKfm3K7sFXqIeAsv04IQbQ9cz\n\t/+sQwdG1RXYb1IKm6MQLW0hv7pyGxm6vLMVByVns="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"o2Op7fBy\"; dkim-atps=neutral","Date":"Wed, 23 Mar 2022 01:23:26 +0200","To":"Umang Jain ","Message-ID":"","References":"<20220318121826.877187-1-umang.jain@ideasonboard.com>\n\t<20220318121826.877187-3-umang.jain@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20220318121826.877187-3-umang.jain@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 2/2] media: staging/intel-ipu3:\n\tCleanup dummy buffers via helper","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"bingbu.cao@intel.com, libcamera-devel@lists.libcamera.org,\n\tsakari.ailus@linux.intel.com, linux-media@vger.kernel.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]