{"id":15481,"url":"https://patchwork.libcamera.org/api/patches/15481/?format=json","web_url":"https://patchwork.libcamera.org/patch/15481/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20220318121826.877187-3-umang.jain@ideasonboard.com>","date":"2022-03-18T12:18:26","name":"[libcamera-devel,2/2] media: staging/intel-ipu3: Cleanup dummy buffers via helper","commit_ref":null,"pull_url":null,"state":"not-applicable","archived":false,"hash":"466a0023450920b3d4ca1b26b20b1ed5f56c9fb9","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/?format=json","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"delegate":{"id":12,"url":"https://patchwork.libcamera.org/api/users/12/?format=json","username":"uajain","first_name":"Umang","last_name":"Jain","email":"umang.jain@ideasonboard.com"},"mbox":"https://patchwork.libcamera.org/patch/15481/mbox/","series":[{"id":2975,"url":"https://patchwork.libcamera.org/api/series/2975/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2975","date":"2022-03-18T12:18:24","name":"media: ipu3: Sequence number fix and improvements","version":1,"mbox":"https://patchwork.libcamera.org/series/2975/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/15481/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/15481/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\r\n\t[92.243.16.209])\r\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 41676BDE17\r\n\tfor ;\r\n\tFri, 18 Mar 2022 12:18:59 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\r\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id EE2EE604EA;\r\n\tFri, 18 Mar 2022 13:18:58 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\r\n\t[213.167.242.64])\r\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7610C604EA\r\n\tfor ;\r\n\tFri, 18 Mar 2022 13:18:57 +0100 (CET)","from perceval.ideasonboard.com (unknown [103.251.226.137])\r\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 89FF32E0;\r\n\tFri, 18 Mar 2022 13:18:55 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\r\n\ts=mail; t=1647605938;\r\n\tbh=KL5CdfOC2RG04Pu4/WxP5EEpFjg78Szq5z3IWkizIO8=;\r\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\r\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\r\n\tFrom;\r\n\tb=z/57MlLZ3S0W2ofwISmredlP5Oa+i5V0jrBRSwaPJCojW6Pvo3yVkT6ZZz9y2N0UG\r\n\t+9R+jh+Ond8t9PK9A/hhSa8OjIh1XcTdLi7qoEgXxAd6/KIO+uk5OS3DfMfrnXt5IH\r\n\tzze8kkPcZAIh5YEPUe2DCU+MCUNhRPGt5NkrdMPhvSj92+AezbNgTU8wQ3tQ3KZxSK\r\n\tlDmTXje/S2oLzpZzWgHc0ViPlFQ0DLE0TFQWVRTIIr/8c1kfp7nBXc3JiORgi85OXG\r\n\tyJOmYNzbpu+mAZZf7ehGB2GWxFv1ekVy7dz6DyLQtSbhvPW4kyM92ZMfqtH3ZZksuh\r\n\tSgQ9bHF0A5+Bw==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\r\n\ts=mail; t=1647605937;\r\n\tbh=KL5CdfOC2RG04Pu4/WxP5EEpFjg78Szq5z3IWkizIO8=;\r\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\r\n\tb=EdUxAYbn8078d0aSyDrE7ewXsl0nuJ5LrvbDj+QRGKxXcmjP9l+dIYdbS4T/v+54p\r\n\tpAonq9VrdjWPuBk3Nji6QF24honHZCn5VrKbEtfR3wjFwxVhHBFsOZqrzdbPQORxB8\r\n\tKz2/CkC1QzMgr9qg++LrEhhX/7p0S2LdMjknvVFI="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \r\n\tunprotected) header.d=ideasonboard.com\r\n\theader.i=@ideasonboard.com\r\n\theader.b=\"EdUxAYbn\"; dkim-atps=neutral","To":"linux-media@vger.kernel.org","Date":"Fri, 18 Mar 2022 17:48:26 +0530","Message-Id":"<20220318121826.877187-3-umang.jain@ideasonboard.com>","X-Mailer":"git-send-email 2.31.1","In-Reply-To":"<20220318121826.877187-1-umang.jain@ideasonboard.com>","References":"<20220318121826.877187-1-umang.jain@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH 2/2] media: staging/intel-ipu3: Cleanup\r\n\tdummy buffers via helper","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\r\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\r\n\t","From":"Umang Jain via libcamera-devel ","Reply-To":"Umang Jain ","Cc":"bingbu.cao@intel.com, libcamera-devel@lists.libcamera.org,\r\n\tsakari.ailus@linux.intel.com","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Use an existing helper imgu_video_nodes_exit() on imgu-video-node\ninitialization failure path to cleanup dummy buffers.\n\nSigned-off-by: Umang Jain \n---\n drivers/staging/media/ipu3/ipu3.c | 25 +++++++++++--------------\n 1 file changed, 11 insertions(+), 14 deletions(-)","diff":"diff --git a/drivers/staging/media/ipu3/ipu3.c b/drivers/staging/media/ipu3/ipu3.c\r\nindex 8e1e9e46e604..0c453b37f8c4 100644\r\n--- a/drivers/staging/media/ipu3/ipu3.c\r\n+++ b/drivers/staging/media/ipu3/ipu3.c\r\n@@ -440,6 +440,16 @@ int imgu_s_stream(struct imgu_device *imgu, int enable)\r\n \treturn r;\r\n }\r\n \r\n+static void imgu_video_nodes_exit(struct imgu_device *imgu)\r\n+{\r\n+\tint i;\r\n+\r\n+\tfor (i = 0; i < IMGU_MAX_PIPE_NUM; i++)\r\n+\t\timgu_dummybufs_cleanup(imgu, i);\r\n+\r\n+\timgu_v4l2_unregister(imgu);\r\n+}\r\n+\r\n static int imgu_video_nodes_init(struct imgu_device *imgu)\r\n {\r\n \tstruct v4l2_pix_format_mplane *fmts[IPU3_CSS_QUEUES] = { NULL };\r\n@@ -489,24 +499,11 @@ static int imgu_video_nodes_init(struct imgu_device *imgu)\r\n \treturn 0;\r\n \r\n out_cleanup:\r\n-\tfor (j = 0; j < IMGU_MAX_PIPE_NUM; j++)\r\n-\t\timgu_dummybufs_cleanup(imgu, j);\r\n-\r\n-\timgu_v4l2_unregister(imgu);\r\n+\timgu_video_nodes_exit(imgu);\r\n \r\n \treturn r;\r\n }\r\n \r\n-static void imgu_video_nodes_exit(struct imgu_device *imgu)\r\n-{\r\n-\tint i;\r\n-\r\n-\tfor (i = 0; i < IMGU_MAX_PIPE_NUM; i++)\r\n-\t\timgu_dummybufs_cleanup(imgu, i);\r\n-\r\n-\timgu_v4l2_unregister(imgu);\r\n-}\r\n-\r\n /**************** PCI interface ****************/\r\n \r\n static irqreturn_t imgu_isr_threaded(int irq, void *imgu_ptr)","prefixes":["libcamera-devel","2/2"]}