[{"id":22367,"web_url":"https://patchwork.libcamera.org/comment/22367/","msgid":"","date":"2022-03-22T23:22:28","subject":"Re: [libcamera-devel] [PATCH 1/2] media: staging/intel-ipu3: Reset\n\timgu_video_device sequence","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Umang,\n\nThank you for the patch.\n\nOn Fri, Mar 18, 2022 at 05:48:25PM +0530, Umang Jain via libcamera-devel wrote:\n> Reset the sequence number of imgu_video_device on stream start.\n> Failing to do so results in sequence number getting incremented\n> for consecutive stream on/off cycles.\n> \n> Signed-off-by: Umang Jain \n\nLooks good to me.\n\nReviewed-by: Laurent Pinchart \n\n> ---\n> drivers/staging/media/ipu3/ipu3-v4l2.c | 1 +\n> 1 file changed, 1 insertion(+)\n> \n> diff --git a/drivers/staging/media/ipu3/ipu3-v4l2.c b/drivers/staging/media/ipu3/ipu3-v4l2.c\n> index 0473457b4e64..d1c539cefba8 100644\n> --- a/drivers/staging/media/ipu3/ipu3-v4l2.c\n> +++ b/drivers/staging/media/ipu3/ipu3-v4l2.c\n> @@ -485,6 +485,7 @@ static int imgu_vb2_start_streaming(struct vb2_queue *vq, unsigned int count)\n> \n> \tpipe = node->pipe;\n> \timgu_pipe = &imgu->imgu_pipe[pipe];\n> +\tatomic_set(&node->sequence, 0);\n> \tr = media_pipeline_start(&node->vdev.entity, &imgu_pipe->pipeline);\n> \tif (r < 0)\n> \t\tgoto fail_return_bufs;","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6B10ABD80A\n\tfor ;\n\tTue, 22 Mar 2022 23:22:49 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B520D604DB;\n\tWed, 23 Mar 2022 00:22:48 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E3BC9604C6\n\tfor ;\n\tWed, 23 Mar 2022 00:22:46 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 4CE819DE;\n\tWed, 23 Mar 2022 00:22:46 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1647991368;\n\tbh=qmJvMpaWf5M/a8rBFYm0IaZrlVvN7GNHZp2bpgMBqwY=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=zezKlxPWLrn03O8J2G0u6eQ98lBAHMjqM8y7P0R8s4812eBLNSI/AvmSSHyvKVzrm\n\t3623lBBoSzvmDK6NoMRSn/WXYbojrnkU6jjpoSi90AlxAi6AiI3xC5i9qoEEJK1EgQ\n\t2bQUwKOX5Zaxn3tnI6Rzv+uOo8WJeSjWhLdXAksMGu1wB9M115YU4P8NaK/nX/d5fD\n\tEH8YajkWq2shEUZcCPOCUkz0HuWPN+Wg9kboRGnMCY5we/qI45iCYfYDSYIkmjH10n\n\t/CAgnKS5RVk5Nk4mbuyWQDgIfyaHsg5XTeePEkly/ZFWmXdi58Z6KXQ/JULMg0U7Ai\n\t4mMUdx5GJEgbA==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1647991366;\n\tbh=qmJvMpaWf5M/a8rBFYm0IaZrlVvN7GNHZp2bpgMBqwY=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=onKRmmfTYGZAcEMcMYV9keVhvLW+tyoJMTLRVHRSas2nDd+6a8sXQKlVMcp/Bv+bJ\n\tC1mSXdCATIWTgOuuE7x+G+15stqWtZFVvPqFlMi2Ezik0ok0vmAaW9o1vAE3K+GrTs\n\tTJnLKRL+oGj8pQ+hLFD7yaE5rHqewQ5k0XG7qM3c="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"onKRmmfT\"; dkim-atps=neutral","Date":"Wed, 23 Mar 2022 01:22:28 +0200","To":"Umang Jain ","Message-ID":"","References":"<20220318121826.877187-1-umang.jain@ideasonboard.com>\n\t<20220318121826.877187-2-umang.jain@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20220318121826.877187-2-umang.jain@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 1/2] media: staging/intel-ipu3: Reset\n\timgu_video_device sequence","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"bingbu.cao@intel.com, libcamera-devel@lists.libcamera.org,\n\tsakari.ailus@linux.intel.com, linux-media@vger.kernel.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]