[{"id":22322,"web_url":"https://patchwork.libcamera.org/comment/22322/","msgid":"<164753598221.1484799.6623116440529228231@Monstersaurus>","date":"2022-03-17T16:53:02","subject":"Re: [libcamera-devel] [PATCH] ipa: raspberrypi: awb: Fix typo in\n\tAWB mode conversion table","submitter":{"id":97,"url":"https://patchwork.libcamera.org/api/people/97/","name":"Nicolas Dufresne via libcamera-devel","email":"libcamera-devel@lists.libcamera.org"},"content":"Quoting David Plowman via libcamera-devel (2022-03-17 15:03:27)\n> The AwbAuto mode is defined in all the JSON tuning files as \"auto\",\n> not \"normal\". The effect of this was that you couldn't switch back to\n> \"auto\" mode once you had switched away.\n> \n> Signed-off-by: David Plowman \n\nReviewed-by: Kieran Bingham \n\n> ---\n> src/ipa/raspberrypi/raspberrypi.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/ipa/raspberrypi/raspberrypi.cpp b/src/ipa/raspberrypi/raspberrypi.cpp\n> index fd8fecb0..1bf4e270 100644\n> --- a/src/ipa/raspberrypi/raspberrypi.cpp\n> +++ b/src/ipa/raspberrypi/raspberrypi.cpp\n> @@ -604,7 +604,7 @@ static const std::map ExposureModeTable = {\n> };\n> \n> static const std::map AwbModeTable = {\n> - { controls::AwbAuto, \"normal\" },\n> + { controls::AwbAuto, \"auto\" },\n> { controls::AwbIncandescent, \"incandescent\" },\n> { controls::AwbTungsten, \"tungsten\" },\n> { controls::AwbFluorescent, \"fluorescent\" },\n> -- \n> 2.30.2\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9DB8FBDE17\n\tfor ;\n\tThu, 17 Mar 2022 16:53:07 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5C24C604DC;\n\tThu, 17 Mar 2022 17:53:07 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3C477601F8\n\tfor ;\n\tThu, 17 Mar 2022 17:53:05 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E978D493;\n\tThu, 17 Mar 2022 17:53:04 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1647535987;\n\tbh=aOyLWQTsdJmhhTWpouizLNk7FEGZMWk84YFPrCXUboU=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=Rq0f0lhUfxYsnyiknRUNZo7UF1tEJUYYSYWlP/fWbYHASYYT6qShGPyqOG3+B1HDl\n\tUr0DkFi3iNm0X7PoDVrp/+e1wtsIF8AqAOdqxW0+SHKIK6zgDqE/O0oHRsQzPbr0a9\n\tczWbzcPI7QpsCd13fh2DvCUx+T5EF0H7A1oYhJsHWA7givul05NYgptq/je4RIauCi\n\tGcVdPRbxMSgPzSR3Sy6+erXvbXbNBMQiYU4jxpMz7ODCsEU9wvvwzY51KsKYltMmNS\n\tI0r0VhbjOlgOpaEjtWUiuE/hcmykhBb3Q8+NjgqyMCtHbFAwu69EeAgc6FL33Fjmhz\n\t4UOIA58clj/pw==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1647535985;\n\tbh=aOyLWQTsdJmhhTWpouizLNk7FEGZMWk84YFPrCXUboU=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=gqjNYssA5cF8GGbfOfAa5ywG+DzLf1Ra8TJc4+qxb9D1NMCRafpp9FZ2BlneY3egw\n\tGRk6xOjHUrnbICtwty9BZUT9YyeDcvvFiJ254GSAavxFSJTvZlG9ZSOXJGtUqQzLfs\n\tNuZqUzpMJYRUfPFkzs4FxmlN4dJgGh8fdI4ytk+U="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"gqjNYssA\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20220317150327.14073-1-david.plowman@raspberrypi.com>","References":"<20220317150327.14073-1-david.plowman@raspberrypi.com>","To":"David Plowman ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Thu, 17 Mar 2022 16:53:02 +0000","Message-ID":"<164753598221.1484799.6623116440529228231@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH] ipa: raspberrypi: awb: Fix typo in\n\tAWB mode conversion table","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kieran Bingham via libcamera-devel\n\t","Reply-To":"Kieran Bingham ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":22366,"web_url":"https://patchwork.libcamera.org/comment/22366/","msgid":"","date":"2022-03-22T23:18:45","subject":"Re: [libcamera-devel] [PATCH] ipa: raspberrypi: awb: Fix typo in\n\tAWB mode conversion table","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi David,\n\nThank you for the patch.\n\nOn Thu, Mar 17, 2022 at 03:03:27PM +0000, David Plowman via libcamera-devel wrote:\n> The AwbAuto mode is defined in all the JSON tuning files as \"auto\",\n> not \"normal\". The effect of this was that you couldn't switch back to\n> \"auto\" mode once you had switched away.\n> \n> Signed-off-by: David Plowman \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/ipa/raspberrypi/raspberrypi.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/ipa/raspberrypi/raspberrypi.cpp b/src/ipa/raspberrypi/raspberrypi.cpp\n> index fd8fecb0..1bf4e270 100644\n> --- a/src/ipa/raspberrypi/raspberrypi.cpp\n> +++ b/src/ipa/raspberrypi/raspberrypi.cpp\n> @@ -604,7 +604,7 @@ static const std::map ExposureModeTable = {\n> };\n> \n> static const std::map AwbModeTable = {\n> -\t{ controls::AwbAuto, \"normal\" },\n> +\t{ controls::AwbAuto, \"auto\" },\n> \t{ controls::AwbIncandescent, \"incandescent\" },\n> \t{ controls::AwbTungsten, \"tungsten\" },\n> \t{ controls::AwbFluorescent, \"fluorescent\" },","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 674B3C0F1B\n\tfor ;\n\tTue, 22 Mar 2022 23:19:05 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A183D604DB;\n\tWed, 23 Mar 2022 00:19:04 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 196F8604C6\n\tfor ;\n\tWed, 23 Mar 2022 00:19:03 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 8CDBD6F3;\n\tWed, 23 Mar 2022 00:19:02 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1647991144;\n\tbh=Xo/uV70st4NhuCYp/WppXHXw9JKBbkrna+wpTPI0we0=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=3wvAJwwNAVY8q9woAzd7F4FsM1tieRNQ68IIRSFlb4Pxz+UPDa1IYvAAzmPcOohnc\n\tkxTBZFTiAtKHcgtELNWN8xma+c7RLHF02O88E5NWDQ0f2NgSOPGWCiq+9UJHXgHcch\n\tlafMZYbpPoogR37lUfTTx51lzYqlXs9nSIB6ZP6LTC4LOV6XQRb9PLtXtT+3aiQtDb\n\tZTJLrPGZleVAmsHOSoOU5f+WZ79Kjfm1R02qRB1mujeQb/95kEPhX7U2FSV9XdA3Kx\n\tR4w6FOJaWsF4Nh/1mBqEwyAle5lhjrFYZBsiXV82Dasa55vWmUqh4GoEDZgkONs+Vr\n\tTW5OxG1qf+f5w==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1647991142;\n\tbh=Xo/uV70st4NhuCYp/WppXHXw9JKBbkrna+wpTPI0we0=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=q04BV9Sur650ggTmWduaNr0oY+2yfzH8b3ZYAtP0yLWS2zSMBzlX8DFDI3BocRa5d\n\tlz6z1Jn+WLaVjFpfjkilQCvsWEIJt7gXMVxpv8G9gpZyX9o7+LpZAOZHwftm4qhpNi\n\t//ndVZ9lfbvzdpTX5R7/NudEaUm7VT0JWFQBW2KA="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"q04BV9Su\"; dkim-atps=neutral","Date":"Wed, 23 Mar 2022 01:18:45 +0200","To":"David Plowman ","Message-ID":"","References":"<20220317150327.14073-1-david.plowman@raspberrypi.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20220317150327.14073-1-david.plowman@raspberrypi.com>","Subject":"Re: [libcamera-devel] [PATCH] ipa: raspberrypi: awb: Fix typo in\n\tAWB mode conversion table","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]