[{"id":22323,"web_url":"https://patchwork.libcamera.org/comment/22323/","msgid":"","date":"2022-03-18T13:32:22","subject":"Re: [libcamera-devel] [PATCH] libcamera: camera: Ensure requests\n\tbelong to the camera","submitter":{"id":97,"url":"https://patchwork.libcamera.org/api/people/97/","name":"Nicolas Dufresne via libcamera-devel","email":"libcamera-devel@lists.libcamera.org"},"content":"Hello Kieran,\n\nOn 3/17/22 18:47, Kieran Bingham via libcamera-devel wrote:\n> Requests are created by a Camera, and can only be queued\n> to that specific Camera. Enforce this during the public API\n> to prevent mis-use by incorrect applications.\n>\n> Signed-off-by: Kieran Bingham \n\n\nMakes sense\n\nReviewed-by: Umang Jain \n\n> ---\n> src/libcamera/camera.cpp | 7 +++++++\n> 1 file changed, 7 insertions(+)\n>\n> diff --git a/src/libcamera/camera.cpp b/src/libcamera/camera.cpp\n> index bb856d606f4a..dd6552e83eee 100644\n> --- a/src/libcamera/camera.cpp\n> +++ b/src/libcamera/camera.cpp\n> @@ -23,6 +23,7 @@\n> #include \"libcamera/internal/camera_controls.h\"\n> #include \"libcamera/internal/formats.h\"\n> #include \"libcamera/internal/pipeline_handler.h\"\n> +#include \"libcamera/internal/request.h\"\n> \n> /**\n> * \\file libcamera/camera.h\n> @@ -1119,6 +1120,12 @@ int Camera::queueRequest(Request *request)\n> \tif (ret < 0)\n> \t\treturn ret;\n> \n> +\t/* Requests can only be queued to the camera that created them.*/\n> +\tif (request->_d()->camera() != this) {\n> +\t\tLOG(Camera, Error) << \"Request was not created by this camera\";\n> +\t\treturn -EINVAL;\n> +\t}\n> +\n> \t/*\n> \t * The camera state may change until the end of the function. No locking\n> \t * is however needed as PipelineHandler::queueRequest() will handle","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9625BBD80A\n\tfor ;\n\tFri, 18 Mar 2022 13:32:30 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C0055604E8;\n\tFri, 18 Mar 2022 14:32:29 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E0C43601F5\n\tfor ;\n\tFri, 18 Mar 2022 14:32:28 +0100 (CET)","from [192.168.1.106] (unknown [103.251.226.137])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 9F100EE;\n\tFri, 18 Mar 2022 14:32:27 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1647610349;\n\tbh=ZR7fGfZJRabjW3j7nqJKQXZ8eyu7/VqBY+h09FJUw4U=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=j0UWEdigv3UN7Tg2xqOqOFnxjpeWH/Cvzv903QbScaofKL8Saoxc8iORBfbgNXj8K\n\t2SAZ6E2IItWUwwjz2LoF0ZfBcvzbFu+dz8iQgnmoCBuBJWFexvDtjX95+Irr0QTx4g\n\tbtyybEvnfEZTMTuEavWTOMVkhHIGrKfA+wHqjSLgfQ2hMoAigKTRx///dpJyS64ZgF\n\tQMhUTT/DNzpnx/hRJ2g8Rv39QnZ3XgWQPUBoW05LdZi4As2sJ2R0OVJuORIHW79GtU\n\tU5Jhl90PCo2gq2Y8ZfXe0jOvbneksW6+gvLLDW3UvFWdYKb0++qu+9QsV5rM3pjN1Y\n\tJqIlQ0ftytqXw==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1647610348;\n\tbh=ZR7fGfZJRabjW3j7nqJKQXZ8eyu7/VqBY+h09FJUw4U=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=i2QXzMC6MGkEB5uL29L9hng9DIuO0jVz+mdVU6NCr46voy3+/yD3mae6zs48y4MsM\n\tZpUK1PTY9cIWH5rL3iT+Wv7o+lyGAGdosGqdSsftUt6kXZr0iAAnS+fnqc5yRsqFg2\n\tHf6ND3VvY16l5KbcwJv5m9KfFj0ngfMrNPluMO3w="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"i2QXzMC6\"; dkim-atps=neutral","Message-ID":"","Date":"Fri, 18 Mar 2022 19:02:22 +0530","MIME-Version":"1.0","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101\n\tThunderbird/91.4.1","Content-Language":"en-US","To":"Kieran Bingham ,\n\tlibcamera devel ","References":"<20220317131726.1483971-1-kieran.bingham@ideasonboard.com>","In-Reply-To":"<20220317131726.1483971-1-kieran.bingham@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH] libcamera: camera: Ensure requests\n\tbelong to the camera","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Umang Jain via libcamera-devel ","Reply-To":"Umang Jain ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":22518,"web_url":"https://patchwork.libcamera.org/comment/22518/","msgid":"","date":"2022-03-29T21:58:05","subject":"Re: [libcamera-devel] [PATCH] libcamera: camera: Ensure requests\n\tbelong to the camera","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nThank you for the patch.\n\nOn Thu, Mar 17, 2022 at 01:17:26PM +0000, Kieran Bingham via libcamera-devel wrote:\n> Requests are created by a Camera, and can only be queued\n> to that specific Camera. Enforce this during the public API\n> to prevent mis-use by incorrect applications.\n> \n> Signed-off-by: Kieran Bingham \n> ---\n> src/libcamera/camera.cpp | 7 +++++++\n> 1 file changed, 7 insertions(+)\n> \n> diff --git a/src/libcamera/camera.cpp b/src/libcamera/camera.cpp\n> index bb856d606f4a..dd6552e83eee 100644\n> --- a/src/libcamera/camera.cpp\n> +++ b/src/libcamera/camera.cpp\n> @@ -23,6 +23,7 @@\n> #include \"libcamera/internal/camera_controls.h\"\n> #include \"libcamera/internal/formats.h\"\n> #include \"libcamera/internal/pipeline_handler.h\"\n> +#include \"libcamera/internal/request.h\"\n> \n> /**\n> * \\file libcamera/camera.h\n> @@ -1119,6 +1120,12 @@ int Camera::queueRequest(Request *request)\n> \tif (ret < 0)\n> \t\treturn ret;\n> \n> +\t/* Requests can only be queued to the camera that created them.*/\n> +\tif (request->_d()->camera() != this) {\n> +\t\tLOG(Camera, Error) << \"Request was not created by this camera\";\n> +\t\treturn -EINVAL;\n> +\t}\n\nThis could even be worth an ASSERT(), up to you.\n\nReviewed-by: Laurent Pinchart \n\n> +\n> \t/*\n> \t * The camera state may change until the end of the function. No locking\n> \t * is however needed as PipelineHandler::queueRequest() will handle","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E43A8C3256\n\tfor ;\n\tTue, 29 Mar 2022 21:58:11 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1210565634;\n\tTue, 29 Mar 2022 23:58:11 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id EE546604BD\n\tfor ;\n\tTue, 29 Mar 2022 23:58:08 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 5EB1D2F7;\n\tTue, 29 Mar 2022 23:58:08 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1648591091;\n\tbh=yQx+WtdrYHQ3WWw+PyDKW6TMERfhvaKpFtvS71km9uk=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=SiWTIsRsQZ7Lu4ZEMMZEOSb6RmcHKhCcxu957CWZmqLiebsDjOHug4Eakao8fzIxM\n\t8MUNty0Tkyg1NDx1DtaKaco3PXxOQKYWNF5jJKanbRgq0VNlW82DU/UiZrjkMt/ltB\n\tFKpbLyButYlzH5zW1VhET+cYwB+Sz4T5EpuGY9ODl1vHMWsh/21UZ30BEsa3rcT8NW\n\tTp3bm81GsgZ5TXnwtpOIT3LUSKTzNOZF69ssXNvor93z9t5uCb64H83NvyUT9znNad\n\tDeHxUoJGbzc/zjh+3scM5pP7s70wAzUWS1pjqL26epx8Jj3hf59HF64Bx9lLvSW3mr\n\t0XCEpPnu6F16w==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1648591088;\n\tbh=yQx+WtdrYHQ3WWw+PyDKW6TMERfhvaKpFtvS71km9uk=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=TaMq5EbmuZ3XEms6m1EHiIOMMiwz9RPJjYPNI3KBzld1VIeU4Hl1xbBjev1mftPvJ\n\tDAwbnP07UvyqFxk7NaEZWRCaKrDhoCOUaSJJWKS5Lag/q+tJpXnI82ETLgqmPehQH+\n\tL61AV4ao1zDWl54Kt0o/P8dAgyR4T4vypfi7cRhM="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"TaMq5Ebm\"; dkim-atps=neutral","Date":"Wed, 30 Mar 2022 00:58:05 +0300","To":"Kieran Bingham ","Message-ID":"","References":"<20220317131726.1483971-1-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20220317131726.1483971-1-kieran.bingham@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH] libcamera: camera: Ensure requests\n\tbelong to the camera","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":22657,"web_url":"https://patchwork.libcamera.org/comment/22657/","msgid":"<164937138516.120223.3737295307049494881@Monstersaurus>","date":"2022-04-07T22:43:05","subject":"Re: [libcamera-devel] [PATCH] libcamera: camera: Ensure requests\n\tbelong to the camera","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Laurent Pinchart (2022-03-29 22:58:05)\n> Hi Kieran,\n> \n> Thank you for the patch.\n> \n> On Thu, Mar 17, 2022 at 01:17:26PM +0000, Kieran Bingham via libcamera-devel wrote:\n> > Requests are created by a Camera, and can only be queued\n> > to that specific Camera. Enforce this during the public API\n> > to prevent mis-use by incorrect applications.\n> > \n> > Signed-off-by: Kieran Bingham \n> > ---\n> > src/libcamera/camera.cpp | 7 +++++++\n> > 1 file changed, 7 insertions(+)\n> > \n> > diff --git a/src/libcamera/camera.cpp b/src/libcamera/camera.cpp\n> > index bb856d606f4a..dd6552e83eee 100644\n> > --- a/src/libcamera/camera.cpp\n> > +++ b/src/libcamera/camera.cpp\n> > @@ -23,6 +23,7 @@\n> > #include \"libcamera/internal/camera_controls.h\"\n> > #include \"libcamera/internal/formats.h\"\n> > #include \"libcamera/internal/pipeline_handler.h\"\n> > +#include \"libcamera/internal/request.h\"\n> > \n> > /**\n> > * \\file libcamera/camera.h\n> > @@ -1119,6 +1120,12 @@ int Camera::queueRequest(Request *request)\n> > if (ret < 0)\n> > return ret;\n> > \n> > + /* Requests can only be queued to the camera that created them.*/\n> > + if (request->_d()->camera() != this) {\n> > + LOG(Camera, Error) << \"Request was not created by this camera\";\n> > + return -EINVAL;\n> > + }\n> \n> This could even be worth an ASSERT(), up to you.\n\nIf this was the other direction, such as a libcamera request getting\ncompleted on the wrong camera, I would agree, that would be a fatal /\nassert - but this check is on the incoming public API - where I think\nit's better to just reject an invalid input.\n\n> Reviewed-by: Laurent Pinchart \n\nThanks\n\n> \n> > +\n> > /*\n> > * The camera state may change until the end of the function. No locking\n> > * is however needed as PipelineHandler::queueRequest() will handle\n> \n> -- \n> Regards,\n> \n> Laurent Pinchart","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 60B42C0F1B\n\tfor ;\n\tThu, 7 Apr 2022 22:43:10 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C220F65640;\n\tFri, 8 Apr 2022 00:43:09 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0A4FE604B8\n\tfor ;\n\tFri, 8 Apr 2022 00:43:08 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 80FE4880;\n\tFri, 8 Apr 2022 00:43:07 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1649371389;\n\tbh=WRYSz9/ocngzCFdAa3e0RovfIxtkdfqPme09TxMa+X0=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=CPzJcVoQs3o7q71c15ihAl6ufU1TLx0XZg3H8HuojrHvL/GLM8FtDrXtn9xxezsgX\n\tyFyc02pvNrNVtE/2ggrz/5IMyHBL8n+4CBPotojNJyu4uG16VPr3ju2PH+3V48syVn\n\t3jbO3nid9uDrcZJYrx/rhJbzzuy7LErO8kbN39mDi6EeHA4OZCawYcxgqPj67e9tkE\n\tm5qctumYzyaSRoANfYiSIi6rg2bmFuN9yHT5gkNdjn6Y/S2ajllg4RWUKWgVWwC7K1\n\tTVfupnR8U6WeS+WcLytHcK1gdgH0t5mo7fKKRYaqEY7QaWL6qncVy2IuiGnAJJu0zn\n\t2vYV0OggdOKlg==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1649371387;\n\tbh=WRYSz9/ocngzCFdAa3e0RovfIxtkdfqPme09TxMa+X0=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=DlUmWmqiM5GMTHIaUxyEGtg2ZgVLzqsSkl52LJ3hIiC//qbvUuwA+P+2XYKUyjpwy\n\t3rsE0iLmXRfjdSeKQ/eu+ZXh+JgKMS5zmvpP4W9WSzmL8LlYa7XnVj/S/dE62Vp6kL\n\tj4c7kj43QUoeceue3dd4r4gzJ2jnAQPVjAy9dLNY="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"DlUmWmqi\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"","References":"<20220317131726.1483971-1-kieran.bingham@ideasonboard.com>\n\t","To":"Laurent Pinchart ","Date":"Thu, 07 Apr 2022 23:43:05 +0100","Message-ID":"<164937138516.120223.3737295307049494881@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH] libcamera: camera: Ensure requests\n\tbelong to the camera","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kieran Bingham via libcamera-devel\n\t","Reply-To":"Kieran Bingham ","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":22675,"web_url":"https://patchwork.libcamera.org/comment/22675/","msgid":"<164962228926.22830.13661460371737398821@Monstersaurus>","date":"2022-04-10T20:24:49","subject":"Re: [libcamera-devel] [PATCH] libcamera: camera: Ensure requests\n\tbelong to the camera","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Kieran Bingham (2022-03-17 13:17:26)\n> Requests are created by a Camera, and can only be queued\n> to that specific Camera. Enforce this during the public API\n> to prevent mis-use by incorrect applications.\n> \n> Signed-off-by: Kieran Bingham \n> ---\n> src/libcamera/camera.cpp | 7 +++++++\n> 1 file changed, 7 insertions(+)\n> \n> diff --git a/src/libcamera/camera.cpp b/src/libcamera/camera.cpp\n> index bb856d606f4a..dd6552e83eee 100644\n> --- a/src/libcamera/camera.cpp\n> +++ b/src/libcamera/camera.cpp\n> @@ -23,6 +23,7 @@\n> #include \"libcamera/internal/camera_controls.h\"\n> #include \"libcamera/internal/formats.h\"\n> #include \"libcamera/internal/pipeline_handler.h\"\n> +#include \"libcamera/internal/request.h\"\n> \n> /**\n> * \\file libcamera/camera.h\n> @@ -1119,6 +1120,12 @@ int Camera::queueRequest(Request *request)\n> if (ret < 0)\n> return ret;\n> \n> + /* Requests can only be queued to the camera that created them.*/\n> + if (request->_d()->camera() != this) {\n> + LOG(Camera, Error) << \"Request was not created by this camera\";\n> + return -EINVAL;\n\nI have two tags so I'm ready to merge this but ... I'm tempted to make\nthis a distinct return code:\n\n EXDEV 18 Invalid cross-device link\n\nAdding \n+ * \\retval -EXDEV The request does not belong to this camera\n\nto the doxygen accordingly.\n\nAny comments, either a +1 or a -1 on whether I should or should not post\na v2 with this?\n\n--\nKieran\n\n\n> + }\n> +\n> /*\n> * The camera state may change until the end of the function. No locking\n> * is however needed as PipelineHandler::queueRequest() will handle\n> -- \n> 2.32.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 51548C0F1B\n\tfor ;\n\tSun, 10 Apr 2022 20:24:54 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5049465644;\n\tSun, 10 Apr 2022 22:24:53 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1A0EB61FBB\n\tfor ;\n\tSun, 10 Apr 2022 22:24:52 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A1B6F30C\n\tfor ;\n\tSun, 10 Apr 2022 22:24:51 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1649622293;\n\tbh=3voVfwhpg6D6lObyCVv8l9ONYsFcW4ptJImriXbPAik=;\n\th=In-Reply-To:References:Cc:To:Date:Subject:List-Id:\n\tList-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe:\n\tFrom:Reply-To:From;\n\tb=ZxAMB8HQV4mxn3sgM/7XovIkCJpvSCC7OMgDmLDEt8+31YYdrAdkooIcy/4kpSMYq\n\tXJNTJ+GMyueoSyo8dtv+tQAUBUDBdhOIMsHrSrigd4ih2eCBppeYffFEQ4SDtFQzYl\n\tJTX3GVqLTautpXAYy+hpVRh8PN035vqQ7Q0V5PV23JzynRRAoAuL07KO7Z48F0RU3v\n\tqfSlbsqxjhjbYdyb+q1B287n15cgllZqyK0zH7wuqd72ZaCMDuNvh4aZtYts8TB7F7\n\tLE7b0BBQdAjkArjLNIAJWbsmDJksoNPRfkWVS/c2Hbv+G1G+dHIzdn/qHImImYgCPt\n\tSeBDkxUwFh8kg==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1649622291;\n\tbh=3voVfwhpg6D6lObyCVv8l9ONYsFcW4ptJImriXbPAik=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=YSHEMCF3oc5ZqOoBm3ydMI7NzifSSAWPf7V4DwvmZ1CmuVscSXEJfz78IK4iGr0Pr\n\txYa0j6vFAA9Y/CSBJfd3xTVacgSWW/Z3d5/WmjcyqVlaBXaa8UQK+/wzYI/58Gccfu\n\tp+nXV3hl+Fd3/BXVJH55tGupVB2vP56PVd9DwXW0="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"YSHEMCF3\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20220317131726.1483971-1-kieran.bingham@ideasonboard.com>","References":"<20220317131726.1483971-1-kieran.bingham@ideasonboard.com>","Cc":"","To":"libcamera devel ","Date":"Sun, 10 Apr 2022 21:24:49 +0100","Message-ID":"<164962228926.22830.13661460371737398821@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH] libcamera: camera: Ensure requests\n\tbelong to the camera","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kieran Bingham via libcamera-devel\n\t","Reply-To":"Kieran Bingham ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":22677,"web_url":"https://patchwork.libcamera.org/comment/22677/","msgid":"","date":"2022-04-11T09:32:07","subject":"Re: [libcamera-devel] [PATCH] libcamera: camera: Ensure requests\n\tbelong to the camera","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"content":"Hi Kieran,\n\nOn 4/11/22 01:54, Kieran Bingham via libcamera-devel wrote:\n> Quoting Kieran Bingham (2022-03-17 13:17:26)\n>> Requests are created by a Camera, and can only be queued\n>> to that specific Camera. Enforce this during the public API\n>> to prevent mis-use by incorrect applications.\n>>\n>> Signed-off-by: Kieran Bingham \n>> ---\n>> src/libcamera/camera.cpp | 7 +++++++\n>> 1 file changed, 7 insertions(+)\n>>\n>> diff --git a/src/libcamera/camera.cpp b/src/libcamera/camera.cpp\n>> index bb856d606f4a..dd6552e83eee 100644\n>> --- a/src/libcamera/camera.cpp\n>> +++ b/src/libcamera/camera.cpp\n>> @@ -23,6 +23,7 @@\n>> #include \"libcamera/internal/camera_controls.h\"\n>> #include \"libcamera/internal/formats.h\"\n>> #include \"libcamera/internal/pipeline_handler.h\"\n>> +#include \"libcamera/internal/request.h\"\n>> \n>> /**\n>> * \\file libcamera/camera.h\n>> @@ -1119,6 +1120,12 @@ int Camera::queueRequest(Request *request)\n>> if (ret < 0)\n>> return ret;\n>> \n>> + /* Requests can only be queued to the camera that created them.*/\n>> + if (request->_d()->camera() != this) {\n>> + LOG(Camera, Error) << \"Request was not created by this camera\";\n>> + return -EINVAL;\n> I have two tags so I'm ready to merge this but ... I'm tempted to make\n> this a distinct return code:\n>\n> EXDEV 18 Invalid cross-device link\n>\n> Adding\n> + * \\retval -EXDEV The request does not belong to this camera\n>\n> to the doxygen accordingly.\n>\n> Any comments, either a +1 or a -1 on whether I should or should not post\n> a v2 with this?\n\n\n-1 (i.e. shouldn't need a v2 on the list).\n\nI am okay returning with EXDEV as the error code.\n\n>\n> --\n> Kieran\n>\n>\n>> + }\n>> +\n>> /*\n>> * The camera state may change until the end of the function. No locking\n>> * is however needed as PipelineHandler::queueRequest() will handle\n>> -- \n>> 2.32.0\n>>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4CF86C0F1B\n\tfor ;\n\tMon, 11 Apr 2022 09:32:15 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 314F665644;\n\tMon, 11 Apr 2022 11:32:14 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4E3D36563F\n\tfor ;\n\tMon, 11 Apr 2022 11:32:12 +0200 (CEST)","from [IPV6:2409:4040:e16:6279:c4eb:ba90:d19e:9558] (unknown\n\t[IPv6:2409:4040:e16:6279:c4eb:ba90:d19e:9558])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 2D38030C;\n\tMon, 11 Apr 2022 11:32:10 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1649669534;\n\tbh=NqWaToqiF06j5RH8yp+eSHGxF1YKSpuxfRNW6MgCbXA=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=Tbke2OwJVMmrrj+o2EBXNGjmr5cGVzoZfBay8R93zCWDA3WrrA/Hq3DRN4g4rBXYi\n\tdqAyAaHgRgTntvvbkAhIpg7mT/Bvep8RVWb6NReE8iNlDsyAcqk6UpvUcFFI1RButR\n\tnwCMjk5zNBCvuT5kZjPn2RtNewOf19WbgDKo/Xi41wacDpbWoC0VWMyOtgJ7XvDsqf\n\tiRf0eQhVjK/VSBr2JMHHRvductIjg6+xbDQ8d3WVOnSELZHl6/T3AhJ/T1Y9vUkQEs\n\tNG0rrWuKohm+UhR4T/s4kqz2jolKinf3iHH4gjIoTEjIQb1gMYZHVUUecJ2nWuEd08\n\tz7Ud5KYu1Vnfw==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1649669531;\n\tbh=NqWaToqiF06j5RH8yp+eSHGxF1YKSpuxfRNW6MgCbXA=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=KwE3Yh7wxAdbdnJV2ZAXd965NKuxEDIHL61jjFdGsL9GmQNFQY0H4FXdlguBgrdy3\n\tU71DKS9CXTA9/eohPcN5zZP32SlBRDfvKxJ5Xf9NcLqDcLg0szOZW4ORjnXqRHVbSE\n\tUppgBXCG9Do+eYxMshuMmMMJNCUlEoC75QNI5KuU="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"KwE3Yh7w\"; dkim-atps=neutral","Message-ID":"","Date":"Mon, 11 Apr 2022 15:02:07 +0530","MIME-Version":"1.0","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101\n\tThunderbird/91.4.1","Content-Language":"en-US","To":"Kieran Bingham ,\n\tlibcamera devel ","References":"<20220317131726.1483971-1-kieran.bingham@ideasonboard.com>\n\t<164962228926.22830.13661460371737398821@Monstersaurus>","In-Reply-To":"<164962228926.22830.13661460371737398821@Monstersaurus>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH] libcamera: camera: Ensure requests\n\tbelong to the camera","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Umang Jain via libcamera-devel ","Reply-To":"Umang Jain ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":22678,"web_url":"https://patchwork.libcamera.org/comment/22678/","msgid":"","date":"2022-04-11T11:38:32","subject":"Re: [libcamera-devel] [PATCH] libcamera: camera: Ensure requests\n\tbelong to the camera","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Mon, Apr 11, 2022 at 03:02:07PM +0530, Umang Jain via libcamera-devel wrote:\n> Hi Kieran,\n> \n> On 4/11/22 01:54, Kieran Bingham via libcamera-devel wrote:\n> > Quoting Kieran Bingham (2022-03-17 13:17:26)\n> >> Requests are created by a Camera, and can only be queued\n> >> to that specific Camera. Enforce this during the public API\n> >> to prevent mis-use by incorrect applications.\n> >>\n> >> Signed-off-by: Kieran Bingham \n> >> ---\n> >> src/libcamera/camera.cpp | 7 +++++++\n> >> 1 file changed, 7 insertions(+)\n> >>\n> >> diff --git a/src/libcamera/camera.cpp b/src/libcamera/camera.cpp\n> >> index bb856d606f4a..dd6552e83eee 100644\n> >> --- a/src/libcamera/camera.cpp\n> >> +++ b/src/libcamera/camera.cpp\n> >> @@ -23,6 +23,7 @@\n> >> #include \"libcamera/internal/camera_controls.h\"\n> >> #include \"libcamera/internal/formats.h\"\n> >> #include \"libcamera/internal/pipeline_handler.h\"\n> >> +#include \"libcamera/internal/request.h\"\n> >> \n> >> /**\n> >> * \\file libcamera/camera.h\n> >> @@ -1119,6 +1120,12 @@ int Camera::queueRequest(Request *request)\n> >> if (ret < 0)\n> >> return ret;\n> >> \n> >> + /* Requests can only be queued to the camera that created them.*/\n> >> + if (request->_d()->camera() != this) {\n> >> + LOG(Camera, Error) << \"Request was not created by this camera\";\n> >> + return -EINVAL;\n> > I have two tags so I'm ready to merge this but ... I'm tempted to make\n> > this a distinct return code:\n> >\n> > EXDEV 18 Invalid cross-device link\n> >\n> > Adding\n> > + * \\retval -EXDEV The request does not belong to this camera\n> >\n> > to the doxygen accordingly.\n> >\n> > Any comments, either a +1 or a -1 on whether I should or should not post\n> > a v2 with this?\n> \n> \n> -1 (i.e. shouldn't need a v2 on the list).\n> \n> I am okay returning with EXDEV as the error code.\n\nAgreed, -EXDEV looks good to me too.\n\n> >> + }\n> >> +\n> >> /*\n> >> * The camera state may change until the end of the function. No locking\n> >> * is however needed as PipelineHandler::queueRequest() will handle","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 133B5C3256\n\tfor ;\n\tMon, 11 Apr 2022 11:38:38 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3B35E65644;\n\tMon, 11 Apr 2022 13:38:37 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9A3C5604B5\n\tfor ;\n\tMon, 11 Apr 2022 13:38:35 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(153.162-64-87.adsl-dyn.isp.belgacom.be [87.64.162.153])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 1AC8C30C;\n\tMon, 11 Apr 2022 13:38:35 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1649677117;\n\tbh=K9tOIGyyoxQuIqkd3M1xIVWH02x5uFCdo//KzOWDzuw=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=TJO+Ie8Oen2km25RUfj7vnefT7KxlOtECgRdiHBSbu5aGpQYDEoulsVo6fNjk5DUr\n\tqMvu8HtttVHV3489Ry0N452LDwDsiHAnAyjdF72ETvV2KKUvfGrCcRjfaIQkmXFMko\n\tqvXcMIORSs4uBpWAOWW0v8vwiy9PRT5kcrQqNiyzartCZCOJHwHChWsf/RBt4i3D18\n\tPLfnYg/DZrnzN9K9QtRmzj6b5IPdAJtWczU6UM/nZu0yKl48wU/+pX+tXO06f0hhrG\n\tvxUHeDPg9YqSkaLaqx8cqjRmun0fxuROEHy+1VDhfO3q/3lNDU/5fbrYTfrw1zNe7b\n\tiG+LAGPfyYOuA==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1649677115;\n\tbh=K9tOIGyyoxQuIqkd3M1xIVWH02x5uFCdo//KzOWDzuw=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=lvlt1WwL8wJcDNQaI5TTdZZubexi0CxDcmAPbzQY36BNnC8nTVpMIdKtUL271z9Oi\n\tmq5snDiTN2Gr4yajRCcvbkY7tAexQz72ULx7gUfen1lkU46P+yJqtAaukFQtfFfG5S\n\tp1KXPfimVekmYbT9sjCn/YzwcyDe3I6m4qQmEDMw="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"lvlt1WwL\"; dkim-atps=neutral","Date":"Mon, 11 Apr 2022 14:38:32 +0300","To":"Umang Jain ","Message-ID":"","References":"<20220317131726.1483971-1-kieran.bingham@ideasonboard.com>\n\t<164962228926.22830.13661460371737398821@Monstersaurus>\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"","Subject":"Re: [libcamera-devel] [PATCH] libcamera: camera: Ensure requests\n\tbelong to the camera","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]