[{"id":22375,"web_url":"https://patchwork.libcamera.org/comment/22375/","msgid":"","date":"2022-03-23T00:17:52","subject":"Re: [libcamera-devel] [PATCH 3/3] libcamera: framebuffer: Add a\n\tmissing space in documentation","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Umang,\n\nThank you for the patch.\n\nOn Thu, Mar 17, 2022 at 04:17:40PM +0530, Umang Jain via libcamera-devel wrote:\n> s/bytesused/bytes used/\n> \n> Signed-off-by: Umang Jain \n> ---\n> src/libcamera/framebuffer.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/framebuffer.cpp b/src/libcamera/framebuffer.cpp\n> index 049b1c7e..142e2af7 100644\n> --- a/src/libcamera/framebuffer.cpp\n> +++ b/src/libcamera/framebuffer.cpp\n> @@ -30,7 +30,7 @@ LOG_DEFINE_CATEGORY(Buffer)\n> * \\brief Metadata related to a captured frame\n> *\n> * The FrameMetadata structure stores all metadata related to a captured frame,\n> - * as stored in a FrameBuffer, such as capture status, timestamp and bytesused.\n> + * as stored in a FrameBuffer, such as capture status, timestamp and bytes used.\n\nThis may have been meant to refer to FrameMetadata::Plane::bytesused,\nbut a space doesn't hurt.\n\nReviewed-by: Laurent Pinchart \n\n> */\n> \n> /**","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6313FBD80A\n\tfor ;\n\tWed, 23 Mar 2022 00:18:12 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 91843604C7;\n\tWed, 23 Mar 2022 01:18:11 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 88155604C6\n\tfor ;\n\tWed, 23 Mar 2022 01:18:10 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 02B289DE;\n\tWed, 23 Mar 2022 01:18:09 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1647994691;\n\tbh=zQfWXt5S9s0yFExTHg/HLlwUfUp+chDUW/T+SHrJphY=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=O6hgCOUaW64R+GBXOX+l2CipimhaqhuMSUISk/yr0xP6jqBauU7fzT6kQ0EZ37fQV\n\tnkRlelUtRd6ts2PilkN+DN+0PinAvbp9/zkeqWlQA6XXda1Nst1m+Y9yHuBhtiZSAA\n\tqwuEX6ShnGxBr0lStKeU3tbAjyvONoN85417ZK9P5sZ7uO35gqgMmtpmIOA/f3ZeCB\n\tUT1iKT5mQt+I7fPX4ZIOpVGvBqes2yzrays6P/XPzl54jSk3sZfZfEpkKpVTD7ovwI\n\tZK4jnm0Dw4vWMN+zzLr2pN9a4G9lVjWtnFpFiH4YthZzg++Rh/EY13xh3Q05V1pLnm\n\tPYw9HTKS6YrTA==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1647994690;\n\tbh=zQfWXt5S9s0yFExTHg/HLlwUfUp+chDUW/T+SHrJphY=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=eros4AAcw9OptIEB10SZB/Nfj2DoXLwxnV/RbzMCTEipdSCcGl6qATg7MO/f8HOty\n\ttJKyk8V3il7trq1z0aIeMTTPtv8E3fZPLFdoAqCfxDtH6K3u9NvZtmFM+hh+kXjDio\n\t6BBDsnRJLwvxxWkW0hsWUh4u3tn5GI9zWRXVAgDE="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"eros4AAc\"; dkim-atps=neutral","Date":"Wed, 23 Mar 2022 02:17:52 +0200","To":"Umang Jain ","Message-ID":"","References":"<20220317104740.569310-1-umang.jain@ideasonboard.com>\n\t<20220317104740.569310-4-umang.jain@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20220317104740.569310-4-umang.jain@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 3/3] libcamera: framebuffer: Add a\n\tmissing space in documentation","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":22399,"web_url":"https://patchwork.libcamera.org/comment/22399/","msgid":"<164803167726.2130830.1407833565602359097@Monstersaurus>","date":"2022-03-23T10:34:37","subject":"Re: [libcamera-devel] [PATCH 3/3] libcamera: framebuffer: Add a\n\tmissing space in documentation","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Laurent Pinchart via libcamera-devel (2022-03-23 00:17:52)\n> Hi Umang,\n> \n> Thank you for the patch.\n> \n> On Thu, Mar 17, 2022 at 04:17:40PM +0530, Umang Jain via libcamera-devel wrote:\n> > s/bytesused/bytes used/\n> > \n> > Signed-off-by: Umang Jain \n> > ---\n> > src/libcamera/framebuffer.cpp | 2 +-\n> > 1 file changed, 1 insertion(+), 1 deletion(-)\n> > \n> > diff --git a/src/libcamera/framebuffer.cpp b/src/libcamera/framebuffer.cpp\n> > index 049b1c7e..142e2af7 100644\n> > --- a/src/libcamera/framebuffer.cpp\n> > +++ b/src/libcamera/framebuffer.cpp\n> > @@ -30,7 +30,7 @@ LOG_DEFINE_CATEGORY(Buffer)\n> > * \\brief Metadata related to a captured frame\n> > *\n> > * The FrameMetadata structure stores all metadata related to a captured frame,\n> > - * as stored in a FrameBuffer, such as capture status, timestamp and bytesused.\n> > + * as stored in a FrameBuffer, such as capture status, timestamp and bytes used.\n> \n> This may have been meant to refer to FrameMetadata::Plane::bytesused,\n> but a space doesn't hurt.\n\nI would say it does refer to that, so I don't think this patch is\nneeded.\n\nBut if you want to keep it, I don't mind either...\n\nAcked-by: Kieran Bingham \n\n> \n> Reviewed-by: Laurent Pinchart \n> \n> > */\n> > \n> > /**\n> \n> -- \n> Regards,\n> \n> Laurent Pinchart","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id F0D57BD80A\n\tfor ;\n\tWed, 23 Mar 2022 10:34:41 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id AA6DF604D5;\n\tWed, 23 Mar 2022 11:34:41 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 981CB601F8\n\tfor ;\n\tWed, 23 Mar 2022 11:34:40 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 503169DE;\n\tWed, 23 Mar 2022 11:34:40 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1648031681;\n\tbh=iXZVDXyiyL2pOR8YF2Ji6yzFqxX5ObpVkpFNkj5jPFo=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=bSiVgANMO23ohAXvFjuI0wFJ+RBmksU1retO7tqfN+IPIEy5wCRaOPafjdeyigsSJ\n\tN0R86dSDF8tDIU9PisYDIA/IhHiOZKJX4IU9xGExdSJ0wunb5lGml0B1XY+cAQAeht\n\tyjlECmLaXvXhB3AejRP5SEz7jDP3KKP914Ia692EHfTA6vco0hLVJ2w18uoPyuY132\n\ton72jc4Wk3A5UR9mTVUbXnuPe1uXfcUd0uHS6sbXCBI3PSsSVJkk+H2u8C/wtSHOPK\n\tE0ND+V+EsS3gLyVCipOXhhoVZyruYZKx8vwh4u5uayMBUwo2FnR1IMlo52/YySEqtl\n\tQVgE9hOIWQ/Uw==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1648031680;\n\tbh=iXZVDXyiyL2pOR8YF2Ji6yzFqxX5ObpVkpFNkj5jPFo=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=qzS9JAioC5JQQWH6ZVgQKj9nk5Nj04hgDPXIwMSVsMUvLrTS4nRkhEUNtyW8bPfRJ\n\tCpHMaL6hvoitM4T19x4JNimac+YDiykcIAtjBLJyVA0vUpMN8Hw6mmX5M7Yspxn16Q\n\tVN604moH6E4HEub5qbh97HwIEqWGJSzRdEx3L4X4="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"qzS9JAio\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"","References":"<20220317104740.569310-1-umang.jain@ideasonboard.com>\n\t<20220317104740.569310-4-umang.jain@ideasonboard.com>\n\t","To":"Laurent Pinchart ,\n\tLaurent Pinchart via libcamera-devel\n\t, \n\tUmang Jain ","Date":"Wed, 23 Mar 2022 10:34:37 +0000","Message-ID":"<164803167726.2130830.1407833565602359097@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH 3/3] libcamera: framebuffer: Add a\n\tmissing space in documentation","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kieran Bingham via libcamera-devel\n\t","Reply-To":"Kieran Bingham ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]