[{"id":22373,"web_url":"https://patchwork.libcamera.org/comment/22373/","msgid":"","date":"2022-03-23T00:12:09","subject":"Re: [libcamera-devel] [PATCH 1/3] libcamera: v4l2_videodevice:\n\tRemove setting of buffer sequence","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Umang,\n\nThank you for the patch.\n\nOn Thu, Mar 17, 2022 at 04:17:38PM +0530, Umang Jain via libcamera-devel wrote:\n> The struct v4l2_buffer documentation [1] clearly states\n> that setting of the sequence is done by the driver. libcamera does\n> not really need to set this field while queuing the buffer(s).\n> \n> [1]: https://www.kernel.org/doc/html/latest/userspace-api/media/v4l/buffer.html#struct-v4l2-buffer\n> \n> Signed-off-by: Umang Jain \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/libcamera/v4l2_videodevice.cpp | 1 -\n> 1 file changed, 1 deletion(-)\n> \n> diff --git a/src/libcamera/v4l2_videodevice.cpp b/src/libcamera/v4l2_videodevice.cpp\n> index 5f36ee20..5580269f 100644\n> --- a/src/libcamera/v4l2_videodevice.cpp\n> +++ b/src/libcamera/v4l2_videodevice.cpp\n> @@ -1600,7 +1600,6 @@ int V4L2VideoDevice::queueBuffer(FrameBuffer *buffer)\n> \t\t\tbuf.length = planes[0].length;\n> \t\t}\n> \n> -\t\tbuf.sequence = metadata.sequence;\n> \t\tbuf.timestamp.tv_sec = metadata.timestamp / 1000000000;\n> \t\tbuf.timestamp.tv_usec = (metadata.timestamp / 1000) % 1000000;\n> \t}","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0544CC0F1B\n\tfor ;\n\tWed, 23 Mar 2022 00:12:29 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4BD41604C7;\n\tWed, 23 Mar 2022 01:12:28 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 03FB0604C6\n\tfor ;\n\tWed, 23 Mar 2022 01:12:26 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 75E389DE;\n\tWed, 23 Mar 2022 01:12:26 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1647994348;\n\tbh=8SGPl47++OmCVlvWl1jCSdDLKXHMekFhWrV87b+DDQw=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=PWtz/dgW9rZ/kM2MNXEWB70EjzjRbenG27HYIQ94zu5n/ZRsUWpnTdCByuZz3xI7B\n\tQ0FHT/X2WnFApmAKgQ0i2wnQyE+IETnxrBD9vCfATOoep2pSSfsN1Syt7DG8asOKEf\n\tOPnJwZqncYkE1gkZkN0qIlXKZlp2IbBYF3p7uo5AEZCPYlJ9Z/RsDJMl+651d6DDrR\n\th/+70uq4y20AcNlatG6dEkSDLUslJ3X4uC9b7D45S+K7bkt1sqqk2UbEZLAg4h9tVW\n\tQJ8CCCDsJsUOzI5xz4giwiqtYwqnHBPMuOCuAyaiJLG1Mz37ot+6M2Z7sEFCKCsqXd\n\tUIHm/LjEUh3nQ==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1647994346;\n\tbh=8SGPl47++OmCVlvWl1jCSdDLKXHMekFhWrV87b+DDQw=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=KT6p8JO3qSYohyR9ueVPEL7437g1nEys3+rlE2gVgNJXWbtfdHH/CwTaYbwmQwCbh\n\tLuroKZ8wZ86M1cTueLncNqJk/LnKMkY5s+oS/jl3AszTIDhkCTmaZ02RSyyVuD9mDT\n\tgwdVwoeGLc62LsG1qtJJVublcbYRwXxJh+iyvjmw="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"KT6p8JO3\"; dkim-atps=neutral","Date":"Wed, 23 Mar 2022 02:12:09 +0200","To":"Umang Jain ","Message-ID":"","References":"<20220317104740.569310-1-umang.jain@ideasonboard.com>\n\t<20220317104740.569310-2-umang.jain@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20220317104740.569310-2-umang.jain@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 1/3] libcamera: v4l2_videodevice:\n\tRemove setting of buffer sequence","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":22397,"web_url":"https://patchwork.libcamera.org/comment/22397/","msgid":"<164803150281.2130830.2406134152542968346@Monstersaurus>","date":"2022-03-23T10:31:42","subject":"Re: [libcamera-devel] [PATCH 1/3] libcamera: v4l2_videodevice:\n\tRemove setting of buffer sequence","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Laurent Pinchart via libcamera-devel (2022-03-23 00:12:09)\n> Hi Umang,\n> \n> Thank you for the patch.\n> \n> On Thu, Mar 17, 2022 at 04:17:38PM +0530, Umang Jain via libcamera-devel wrote:\n> > The struct v4l2_buffer documentation [1] clearly states\n> > that setting of the sequence is done by the driver. libcamera does\n> > not really need to set this field while queuing the buffer(s).\n> > \n> > [1]: https://www.kernel.org/doc/html/latest/userspace-api/media/v4l/buffer.html#struct-v4l2-buffer\n> > \n> > Signed-off-by: Umang Jain \n> \n> Reviewed-by: Laurent Pinchart \n\nI always thought sequence numbers should be propogated like the\ntimestamp, but if the kernel doesn't do it - then no point setting it\nindeed.\n\n\nReviewed-by: Kieran Bingham \n\n> \n> > ---\n> > src/libcamera/v4l2_videodevice.cpp | 1 -\n> > 1 file changed, 1 deletion(-)\n> > \n> > diff --git a/src/libcamera/v4l2_videodevice.cpp b/src/libcamera/v4l2_videodevice.cpp\n> > index 5f36ee20..5580269f 100644\n> > --- a/src/libcamera/v4l2_videodevice.cpp\n> > +++ b/src/libcamera/v4l2_videodevice.cpp\n> > @@ -1600,7 +1600,6 @@ int V4L2VideoDevice::queueBuffer(FrameBuffer *buffer)\n> > buf.length = planes[0].length;\n> > }\n> > \n> > - buf.sequence = metadata.sequence;\n> > buf.timestamp.tv_sec = metadata.timestamp / 1000000000;\n> > buf.timestamp.tv_usec = (metadata.timestamp / 1000) % 1000000;\n> > }\n> \n> -- \n> Regards,\n> \n> Laurent Pinchart","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 123FABD80A\n\tfor ;\n\tWed, 23 Mar 2022 10:31:47 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6820F604D5;\n\tWed, 23 Mar 2022 11:31:46 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6DCB4601F8\n\tfor ;\n\tWed, 23 Mar 2022 11:31:45 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 0CC6A9DE;\n\tWed, 23 Mar 2022 11:31:45 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1648031506;\n\tbh=za0nGS3me8XYpNptRABwMUloV0S7iI9cOBdBFc0QJMM=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=Gr8U4wk0Rg/QK4WbxAkebuX+aGAuIzc3pLy/aXlg5Ef4mHUgTxgeLEFPYuYdRDH+Q\n\tj+VjFSlGEWThuAY5/iobwzMI5f+0taxE8JaVFGU6a3EeBfo/UrjFOBn9NQIS3TAQHA\n\tTq+x9ogOBjxOOuu5tBmFq/1gW8VF9/FO5KO8nuSej6E+weqDWVlMaPnqyh2ZF76kyg\n\tOWAKpfhPI+pEGt60Tfo0BGhtZV2G+ly3HvGeaRelcUSzLBLtnIP8T0/XhOInwLdjlJ\n\txg2Vw7LR5HUl9Q6Y0fVP9j9tEDf5yRBw/hshxENnwLbk+In5SOpH4cE4dpPapB/C2W\n\tgaV6anlv6YKhA==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1648031505;\n\tbh=za0nGS3me8XYpNptRABwMUloV0S7iI9cOBdBFc0QJMM=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=B85gz6XKnbB6MlTAITeT1WQBlpqe2ez2cMTb07Lg3yIHtiU/BRt3ZQduUN+DSwj/v\n\tHmGJWvCziWcxIjjENwtjEJZ7Ceb1kfAnmw70dDVGoC5M/uXhmjC1j9hHhoj9VsfXG2\n\tGZeOZUH1W+s8XJKJA6VfofkjzUDBpsc/Ip48yWrs="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"B85gz6XK\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"","References":"<20220317104740.569310-1-umang.jain@ideasonboard.com>\n\t<20220317104740.569310-2-umang.jain@ideasonboard.com>\n\t","To":"Laurent Pinchart ,\n\tLaurent Pinchart via libcamera-devel\n\t, \n\tUmang Jain ","Date":"Wed, 23 Mar 2022 10:31:42 +0000","Message-ID":"<164803150281.2130830.2406134152542968346@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH 1/3] libcamera: v4l2_videodevice:\n\tRemove setting of buffer sequence","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kieran Bingham via libcamera-devel\n\t","Reply-To":"Kieran Bingham ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]