{"id":15466,"url":"https://patchwork.libcamera.org/api/patches/15466/?format=json","web_url":"https://patchwork.libcamera.org/patch/15466/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20220317104740.569310-2-umang.jain@ideasonboard.com>","date":"2022-03-17T10:47:38","name":"[libcamera-devel,1/3] libcamera: v4l2_videodevice: Remove setting of buffer sequence","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"395b421f5fa9fd930564d46a2d499db553e22a70","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/?format=json","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"delegate":{"id":12,"url":"https://patchwork.libcamera.org/api/users/12/?format=json","username":"uajain","first_name":"Umang","last_name":"Jain","email":"umang.jain@ideasonboard.com"},"mbox":"https://patchwork.libcamera.org/patch/15466/mbox/","series":[{"id":2970,"url":"https://patchwork.libcamera.org/api/series/2970/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2970","date":"2022-03-17T10:47:37","name":"v4l2_videodevice: Small fixup & clarifications","version":1,"mbox":"https://patchwork.libcamera.org/series/2970/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/15466/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/15466/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\r\n\t[92.243.16.209])\r\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E192DBF415\r\n\tfor ;\r\n\tThu, 17 Mar 2022 10:47:57 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\r\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A3FD96118A;\r\n\tThu, 17 Mar 2022 11:47:57 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\r\n\t[213.167.242.64])\r\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1FBB1604DC\r\n\tfor ;\r\n\tThu, 17 Mar 2022 11:47:55 +0100 (CET)","from perceval.ideasonboard.com (unknown [103.251.226.83])\r\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 14AE8493;\r\n\tThu, 17 Mar 2022 11:47:53 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\r\n\ts=mail; t=1647514077;\r\n\tbh=iLKkBESaGqHiZkbB40yEdcQIhCZYhi0GVbSkfENnjas=;\r\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\r\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\r\n\tFrom;\r\n\tb=YU2DdhN9NcOdnbwYYUzWIJdESCZnHaGzdy3QqmqIAWZcL2Yw5lIA5Kc5GAhR3sE83\r\n\tPvpjM+WGWh0lBEZqEuqU1y+UdcnFn0xBJhKMCdYLN7tRHJInpQTLFoyuYIY9ed40Gu\r\n\tPAjpb7PpBh9syck/LjXEWgIq626C9Y+QvWaUjdcQ48kAbCxsKsv6hvIBoCnd39f9sL\r\n\tqdHivxN8SVGbXdYZ1dN/YuE6s3RFt3Jmlyr0sGqCgOfXi1GkbJF3wCYpSXnOjX0aEm\r\n\t9iSMhTevXtcXqkMdAE2I/D7qmgfSTi7ftXKQysoZMbgHE17og4T5nUB+QdMI3csDm7\r\n\tZT+8XKBFVHCEg==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\r\n\ts=mail; t=1647514074;\r\n\tbh=iLKkBESaGqHiZkbB40yEdcQIhCZYhi0GVbSkfENnjas=;\r\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\r\n\tb=XRThBQomj2J9ne2/GFkiMd2ba4kw03EniPBz8bAsidGVGx4PMxNh1uo7uB1b2AXX2\r\n\tIoaGUGnFMaJp1EsBJg59MC6YKWNrkHQSitR6iryck4N2OCxSCcr7HMXg5jWu3ycYIB\r\n\tV0eLFsmf0UqkUpycHL7JFCVZBsTdeS/A7zUr4LhA="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \r\n\tunprotected) header.d=ideasonboard.com\r\n\theader.i=@ideasonboard.com\r\n\theader.b=\"XRThBQom\"; dkim-atps=neutral","To":"libcamera-devel@lists.libcamera.org","Date":"Thu, 17 Mar 2022 16:17:38 +0530","Message-Id":"<20220317104740.569310-2-umang.jain@ideasonboard.com>","X-Mailer":"git-send-email 2.31.1","In-Reply-To":"<20220317104740.569310-1-umang.jain@ideasonboard.com>","References":"<20220317104740.569310-1-umang.jain@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH 1/3] libcamera: v4l2_videodevice: Remove\r\n\tsetting of buffer sequence","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\r\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\r\n\t","From":"Umang Jain via libcamera-devel ","Reply-To":"Umang Jain ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The struct v4l2_buffer documentation [1] clearly states\nthat setting of the sequence is done by the driver. libcamera does\nnot really need to set this field while queuing the buffer(s).\n\n[1]: https://www.kernel.org/doc/html/latest/userspace-api/media/v4l/buffer.html#struct-v4l2-buffer\n\nSigned-off-by: Umang Jain \n---\n src/libcamera/v4l2_videodevice.cpp | 1 -\n 1 file changed, 1 deletion(-)","diff":"diff --git a/src/libcamera/v4l2_videodevice.cpp b/src/libcamera/v4l2_videodevice.cpp\r\nindex 5f36ee20..5580269f 100644\r\n--- a/src/libcamera/v4l2_videodevice.cpp\r\n+++ b/src/libcamera/v4l2_videodevice.cpp\r\n@@ -1600,7 +1600,6 @@ int V4L2VideoDevice::queueBuffer(FrameBuffer *buffer)\r\n \t\t\tbuf.length = planes[0].length;\r\n \t\t}\r\n \r\n-\t\tbuf.sequence = metadata.sequence;\r\n \t\tbuf.timestamp.tv_sec = metadata.timestamp / 1000000000;\r\n \t\tbuf.timestamp.tv_usec = (metadata.timestamp / 1000) % 1000000;\r\n \t}","prefixes":["libcamera-devel","1/3"]}