[{"id":22293,"web_url":"https://patchwork.libcamera.org/comment/22293/","msgid":"<164747063913.11309.7650783290600653213@Monstersaurus>","date":"2022-03-16T22:43:59","subject":"Re: [libcamera-devel] [PATCH 2/2] libipa: Add CameraSensorHelper\n\tfor OV2740","submitter":{"id":97,"url":"https://patchwork.libcamera.org/api/people/97/","name":"Nicolas Dufresne via libcamera-devel","email":"libcamera-devel@lists.libcamera.org"},"content":"Quoting Daniel Scally via libcamera-devel (2022-03-16 22:22:45)\n> The datasheet for the OV2740 gives 0x80 as 1x gain, so real gain\n> is GainCode / 128.\n> \n> Signed-off-by: Daniel Scally \n\nI can't confirm this, but I can't see any reason for it to be wrong\ncurrently, and we'll soon know if it's wrong when it's tested.\n\nAcked-by: Kieran Bingham \n\n> ---\n> src/ipa/libipa/camera_sensor_helper.cpp | 10 ++++++++++\n> 1 file changed, 10 insertions(+)\n> \n> diff --git a/src/ipa/libipa/camera_sensor_helper.cpp b/src/ipa/libipa/camera_sensor_helper.cpp\n> index 5d052612..c953def0 100644\n> --- a/src/ipa/libipa/camera_sensor_helper.cpp\n> +++ b/src/ipa/libipa/camera_sensor_helper.cpp\n> @@ -305,6 +305,16 @@ public:\n> };\n> REGISTER_CAMERA_SENSOR_HELPER(\"imx258\", CameraSensorHelperImx258)\n> \n> +class CameraSensorHelperOv2740 : public CameraSensorHelper\n> +{\n> +public:\n> + CameraSensorHelperOv2740()\n> + {\n> + analogueGainConstants_ = { AnalogueGainLinear, 1, 0, 0, 128 };\n> + }\n> +};\n> +REGISTER_CAMERA_SENSOR_HELPER(\"ov2740\", CameraSensorHelperOv2740)\n> +\n> class CameraSensorHelperOv5670 : public CameraSensorHelper\n> {\n> public:\n> -- \n> 2.25.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 00363BF415\n\tfor ;\n\tWed, 16 Mar 2022 22:44:03 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 681B5604DB;\n\tWed, 16 Mar 2022 23:44:03 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 42F3560475\n\tfor ;\n\tWed, 16 Mar 2022 23:44:02 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C8CF4A67;\n\tWed, 16 Mar 2022 23:44:01 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1647470643;\n\tbh=cmO64UrAHQe+Zdi7AyIVp/eWQWxY1cdVp4U71J3RGAs=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=Lt7LvI3w8DnU6DeyAnuUWIlJxnO50wwIxs1oQyko1IMum7LV7+PF53FRyOEBPIDlC\n\tuk3CZwA1z8mXlPvwZFBolQqT2GeTeoHjvMLBNi7nwfMEKjqyFRHizAewlvEllO1V3y\n\t45PwL4zEd9c+WSMyQdyJpkHOVgYL642BqtFSx0UNCdGGWSW3rCLnQ5Ojtj4FgarBuz\n\tw8PW7zRbK6BpCf9WQ4ZZhJfxf4ucvb0T6bMAjnbFEDr1Su4e1bJztgYEDk3JhUuITM\n\tGpFzMk9kIgqwFUXYZ2cFVWNp3hJaR75/JxFiIRgLBkzTdZUgS9nmr65sagiKZyqXO8\n\tyKzmxTKjP2Low==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1647470641;\n\tbh=cmO64UrAHQe+Zdi7AyIVp/eWQWxY1cdVp4U71J3RGAs=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=vtZjVftsuSg4H5bLBBRFyy2CPMX72tps87vzMHH9p1MFwm0GA9Pfshf4LeUOMC1+j\n\t4I1po/knXFmEZ8fgo+f1VDNW9GrJoHYRCriejdGeOgB2ySVgp2gff5VlrfL1xOPE3h\n\t8sMMnlhpebazq27zsIGS7Eaq49bnyS6I2xTOTxiA="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"vtZjVfts\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20220316222245.132315-3-djrscally@gmail.com>","References":"<20220316222245.132315-1-djrscally@gmail.com>\n\t<20220316222245.132315-3-djrscally@gmail.com>","To":"Daniel Scally , libcamera-devel@lists.libcamera.org","Date":"Wed, 16 Mar 2022 22:43:59 +0000","Message-ID":"<164747063913.11309.7650783290600653213@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH 2/2] libipa: Add CameraSensorHelper\n\tfor OV2740","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kieran Bingham via libcamera-devel\n\t","Reply-To":"Kieran Bingham ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":22295,"web_url":"https://patchwork.libcamera.org/comment/22295/","msgid":"","date":"2022-03-17T07:57:25","subject":"Re: [libcamera-devel] [PATCH 2/2] libipa: Add CameraSensorHelper\n\tfor OV2740","submitter":{"id":97,"url":"https://patchwork.libcamera.org/api/people/97/","name":"Nicolas Dufresne via libcamera-devel","email":"libcamera-devel@lists.libcamera.org"},"content":"On Wed, Mar 16, 2022 at 10:43:59PM +0000, Kieran Bingham via libcamera-devel wrote:\n> Quoting Daniel Scally via libcamera-devel (2022-03-16 22:22:45)\n> > The datasheet for the OV2740 gives 0x80 as 1x gain, so real gain\n> > is GainCode / 128.\n> > \n> > Signed-off-by: Daniel Scally \n> \n> I can't confirm this, but I can't see any reason for it to be wrong\n> currently, and we'll soon know if it's wrong when it's tested.\n> \n> Acked-by: Kieran Bingham \n\nReviewed-by: Laurent Pinchart \n\n> > ---\n> > src/ipa/libipa/camera_sensor_helper.cpp | 10 ++++++++++\n> > 1 file changed, 10 insertions(+)\n> > \n> > diff --git a/src/ipa/libipa/camera_sensor_helper.cpp b/src/ipa/libipa/camera_sensor_helper.cpp\n> > index 5d052612..c953def0 100644\n> > --- a/src/ipa/libipa/camera_sensor_helper.cpp\n> > +++ b/src/ipa/libipa/camera_sensor_helper.cpp\n> > @@ -305,6 +305,16 @@ public:\n> > };\n> > REGISTER_CAMERA_SENSOR_HELPER(\"imx258\", CameraSensorHelperImx258)\n> > \n> > +class CameraSensorHelperOv2740 : public CameraSensorHelper\n> > +{\n> > +public:\n> > + CameraSensorHelperOv2740()\n> > + {\n> > + analogueGainConstants_ = { AnalogueGainLinear, 1, 0, 0, 128 };\n> > + }\n> > +};\n> > +REGISTER_CAMERA_SENSOR_HELPER(\"ov2740\", CameraSensorHelperOv2740)\n> > +\n> > class CameraSensorHelperOv5670 : public CameraSensorHelper\n> > {\n> > public:","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 88C81BF415\n\tfor ;\n\tThu, 17 Mar 2022 07:57:43 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3CDBE604E7;\n\tThu, 17 Mar 2022 08:57:43 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 25ABE604C7\n\tfor ;\n\tThu, 17 Mar 2022 08:57:42 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id BAAC8493;\n\tThu, 17 Mar 2022 08:57:41 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1647503863;\n\tbh=gzqdfpHHFURBQXLntLCXVnE7Rd/LjhY82PEfNmGfYfs=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=yz8FyN7hpQ4LhDExOXXgzqYKV075S4L4oqXww08p+5droInL2riZNQsF9pGEV2iDq\n\tgMfB7u4/cHLMxDzX1A5Jm1vhU4Z7TvBAKzEpNONTP+A94SbrWP8teP3W5NU5iexQFB\n\t0MrhOnGoR6YaSTHVGLW9unKScJGM1p90aPyVrPZk5TePM23rz9oNaE2LnlJKtqfPf0\n\t6O6Zbv+8toFJ+Xii0Zup3kcvzPBO50zvMnmEG/L/DucEYHJQSiwttYc438Bjf9h4z3\n\teG+m4GDhqNoJeVC2DrrMKbVsWQaTmC5leGd+Grzn0r7BU68z3FbHxxDP5hVKGFAr47\n\txCjdGgbYe9/Aw==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1647503861;\n\tbh=gzqdfpHHFURBQXLntLCXVnE7Rd/LjhY82PEfNmGfYfs=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=k1GLTH/bKXyptBujmqXH4EbdgGsGx699WXDyZcX/qW3lCaGZDMmMs7jkpHSshKBmi\n\tTllaxUvDBHRb/E4UbRAAHtCWoRS0fFs7sazU42rd3mc5Di1EL2VGjEw8JFm4yyfGWA\n\t/JSMJukLttm89tEGr2AGRWjZZ4mS/duhRUPrW1NU="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"k1GLTH/b\"; dkim-atps=neutral","Date":"Thu, 17 Mar 2022 09:57:25 +0200","To":"Kieran Bingham ","Message-ID":"","References":"<20220316222245.132315-1-djrscally@gmail.com>\n\t<20220316222245.132315-3-djrscally@gmail.com>\n\t<164747063913.11309.7650783290600653213@Monstersaurus>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<164747063913.11309.7650783290600653213@Monstersaurus>","Subject":"Re: [libcamera-devel] [PATCH 2/2] libipa: Add CameraSensorHelper\n\tfor OV2740","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]