[{"id":22292,"web_url":"https://patchwork.libcamera.org/comment/22292/","msgid":"<164746995195.11309.4416212083703626942@Monstersaurus>","date":"2022-03-16T22:32:31","subject":"Re: [libcamera-devel] [PATCH 1/2] libcamera: Add OV2740 camera\n\tsensor properties","submitter":{"id":97,"url":"https://patchwork.libcamera.org/api/people/97/","name":"Nicolas Dufresne via libcamera-devel","email":"libcamera-devel@lists.libcamera.org"},"content":"Hi Dan,\n\nQuoting Daniel Scally via libcamera-devel (2022-03-16 22:22:44)\n> Add camera sensor property entries for the OmniVision 2740 camera\n> sensor.\n> \n> Signed-off-by: Daniel Scally \n> ---\n> src/libcamera/camera_sensor_properties.cpp | 7 +++++++\n> 1 file changed, 7 insertions(+)\n> \n> diff --git a/src/libcamera/camera_sensor_properties.cpp b/src/libcamera/camera_sensor_properties.cpp\n> index 48305ac4..9bdfd417 100644\n> --- a/src/libcamera/camera_sensor_properties.cpp\n> +++ b/src/libcamera/camera_sensor_properties.cpp\n> @@ -90,6 +90,13 @@ const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen\n> { controls::draft::TestPatternModePn9, 4 },\n> },\n> } },\n> + { \"ov2740\", {\n> + .unitCellSize = { 1400, 1400 },\n\nhttps://www.ovt.com/wp-content/uploads/2022/01/OV2740-PB-v1.3-WEB.pdf\nconfirms this,\n\n> + .testPatternModes = {\n> + { controls::draft::TestPatternModeOff, 0 },\n> + { controls::draft::TestPatternModeColorBars, 1},\n\nand drivers/media/i2c/ov2740.c confirms this.\n\nReviewed-by: Kieran Bingham \n\n> + },\n> + } },\n> { \"ov5647\", {\n> .unitCellSize = { 1400, 1400 },\n> .testPatternModes = {},\n> -- \n> 2.25.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B4DCBBDE17\n\tfor ;\n\tWed, 16 Mar 2022 22:32:36 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 28064604DB;\n\tWed, 16 Mar 2022 23:32:36 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 69EF660475\n\tfor ;\n\tWed, 16 Mar 2022 23:32:34 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E9798929;\n\tWed, 16 Mar 2022 23:32:33 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1647469956;\n\tbh=oV+bqX3Shja/9Ju2I4LmttFlk1S3jnaQJ+o+jSNxESY=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=g2nEl3Z9NJpjiepQJMbJKEUyKdUoDNDyGfZF+KEC49fArHG7R0jWQ7+nTeX2n/oC7\n\tFjkKXJ9tEM4F44g2/7X0jTlbXHUs+ylW2LTuro0LY5NW+N35S8xKBszGPdEu9ACJYy\n\tlpWt7Z6DH2Av+mE1wzQ8l5DrJR7GPL++RGEwzlJKHiCGHiv3OaS1trd55aOowesIGC\n\t2mQ4n9uJlVLyj34eT1UJpeQIryalrc74LA2baKoTPhsfMp7lySt8opwTQ0O1b2Od9K\n\t1qe8cz8kDkuEjl/pgsnznzB23kyLLj463Xm8m+9t7xQpewaANTH4Kdssxv1FqtqzsM\n\tad08gi4cK/lkg==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1647469954;\n\tbh=oV+bqX3Shja/9Ju2I4LmttFlk1S3jnaQJ+o+jSNxESY=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=PYwkeeID5ESq85TIt6KZqoqyFRR6uB0ITPb2zr+07JPUQgWFZi0e75054Fugbmqmj\n\tK3e3DyCgJaXMAiXDCJCp8n+JopFeCYI5SyREghEkO64QjHqsF7mwdzJFqsGWeHFa7m\n\t2BL6pmMuE/t0bk9RuHGW8FeH1KNU8ecZt5qbBYqw="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"PYwkeeID\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20220316222245.132315-2-djrscally@gmail.com>","References":"<20220316222245.132315-1-djrscally@gmail.com>\n\t<20220316222245.132315-2-djrscally@gmail.com>","To":"Daniel Scally , libcamera-devel@lists.libcamera.org","Date":"Wed, 16 Mar 2022 22:32:31 +0000","Message-ID":"<164746995195.11309.4416212083703626942@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH 1/2] libcamera: Add OV2740 camera\n\tsensor properties","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kieran Bingham via libcamera-devel\n\t","Reply-To":"Kieran Bingham ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":22294,"web_url":"https://patchwork.libcamera.org/comment/22294/","msgid":"","date":"2022-03-17T07:57:02","subject":"Re: [libcamera-devel] [PATCH 1/2] libcamera: Add OV2740 camera\n\tsensor properties","submitter":{"id":97,"url":"https://patchwork.libcamera.org/api/people/97/","name":"Nicolas Dufresne via libcamera-devel","email":"libcamera-devel@lists.libcamera.org"},"content":"On Wed, Mar 16, 2022 at 10:32:31PM +0000, Kieran Bingham via libcamera-devel wrote:\n> Quoting Daniel Scally via libcamera-devel (2022-03-16 22:22:44)\n> > Add camera sensor property entries for the OmniVision 2740 camera\n> > sensor.\n> > \n> > Signed-off-by: Daniel Scally \n> > ---\n> > src/libcamera/camera_sensor_properties.cpp | 7 +++++++\n> > 1 file changed, 7 insertions(+)\n> > \n> > diff --git a/src/libcamera/camera_sensor_properties.cpp b/src/libcamera/camera_sensor_properties.cpp\n> > index 48305ac4..9bdfd417 100644\n> > --- a/src/libcamera/camera_sensor_properties.cpp\n> > +++ b/src/libcamera/camera_sensor_properties.cpp\n> > @@ -90,6 +90,13 @@ const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen\n> > { controls::draft::TestPatternModePn9, 4 },\n> > },\n> > } },\n> > + { \"ov2740\", {\n> > + .unitCellSize = { 1400, 1400 },\n> \n> https://www.ovt.com/wp-content/uploads/2022/01/OV2740-PB-v1.3-WEB.pdf\n> confirms this,\n> \n> > + .testPatternModes = {\n> > + { controls::draft::TestPatternModeOff, 0 },\n> > + { controls::draft::TestPatternModeColorBars, 1},\n> \n> and drivers/media/i2c/ov2740.c confirms this.\n\nIs this the standard colour bars pattern (as specified in the control\ndocumentation, referencing the MIPI CCS specification) ?\n\n> Reviewed-by: Kieran Bingham \n> \n> > + },\n> > + } },\n> > { \"ov5647\", {\n> > .unitCellSize = { 1400, 1400 },\n> > .testPatternModes = {},","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 22C76BF415\n\tfor ;\n\tThu, 17 Mar 2022 07:57:22 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 832A1604DB;\n\tThu, 17 Mar 2022 08:57:21 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A7769604C7\n\tfor ;\n\tThu, 17 Mar 2022 08:57:19 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 11F2C493;\n\tThu, 17 Mar 2022 08:57:19 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1647503841;\n\tbh=JAjcW9DnxbEsM74ahhkd6l46Vg7RQ+xZfvKkTzrbYN0=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=U0EWzNy2pFK2mgY8GTttdf3eog6PwqE4vyjEpmVj6L4hsy2WVaOtT4Y3sx3sbZMGp\n\tuKJBbRsu0pwHBpmmS8qFR+76qNGdOs1M6rYCVinkQZDUAjobbwKwD8fau0g5r5DLPo\n\tyrE4r43jygF3Cj+Yvp/ymGCsz+dZUjBRV2o8FlTteFM0AS4oIDiMDw4iYH/tgO4Umo\n\t+n7oZcpFHWfwAywuS9PPAITVIwhlQFleeIkMEHpBv2PF07oPw9Fm7k3w1FbWicgogL\n\tROd+55NNG0sk9l75rFfTy4GFn1fRio91444IzemMvyzd3SgIAxwAmm38fLszReBy1E\n\temTP5TwTyUe5Q==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1647503839;\n\tbh=JAjcW9DnxbEsM74ahhkd6l46Vg7RQ+xZfvKkTzrbYN0=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=UIz41QZRxOk+q6NO6Rk4GA3owavrfhFdqdIrK6Ey+QCDmKxjGSH3Y9h7eIVVmu3bT\n\tX/j5XjC1CzJT0zMOo80GeBvK8bVJiP/ibNw3F+aaLQrg6vxaBZxO3iZ+hi1SRA8LkS\n\tCvWZhKO8RW9l6OomQjpKDrO4S1lEHC3xDGa1oqu4="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"UIz41QZR\"; dkim-atps=neutral","Date":"Thu, 17 Mar 2022 09:57:02 +0200","To":"Kieran Bingham ","Message-ID":"","References":"<20220316222245.132315-1-djrscally@gmail.com>\n\t<20220316222245.132315-2-djrscally@gmail.com>\n\t<164746995195.11309.4416212083703626942@Monstersaurus>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<164746995195.11309.4416212083703626942@Monstersaurus>","Subject":"Re: [libcamera-devel] [PATCH 1/2] libcamera: Add OV2740 camera\n\tsensor properties","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":22299,"web_url":"https://patchwork.libcamera.org/comment/22299/","msgid":"<110f88d4-c5a6-974d-2c07-2e7ea5f17547@gmail.com>","date":"2022-03-17T09:49:12","subject":"Re: [libcamera-devel] [PATCH 1/2] libcamera: Add OV2740 camera\n\tsensor properties","submitter":{"id":97,"url":"https://patchwork.libcamera.org/api/people/97/","name":"Nicolas Dufresne via libcamera-devel","email":"libcamera-devel@lists.libcamera.org"},"content":"Morning Laurent\n\nOn 17/03/2022 07:57, Laurent Pinchart wrote:\n> On Wed, Mar 16, 2022 at 10:32:31PM +0000, Kieran Bingham via libcamera-devel wrote:\n>> Quoting Daniel Scally via libcamera-devel (2022-03-16 22:22:44)\n>>> Add camera sensor property entries for the OmniVision 2740 camera\n>>> sensor.\n>>>\n>>> Signed-off-by: Daniel Scally \n>>> ---\n>>> src/libcamera/camera_sensor_properties.cpp | 7 +++++++\n>>> 1 file changed, 7 insertions(+)\n>>>\n>>> diff --git a/src/libcamera/camera_sensor_properties.cpp b/src/libcamera/camera_sensor_properties.cpp\n>>> index 48305ac4..9bdfd417 100644\n>>> --- a/src/libcamera/camera_sensor_properties.cpp\n>>> +++ b/src/libcamera/camera_sensor_properties.cpp\n>>> @@ -90,6 +90,13 @@ const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen\n>>> { controls::draft::TestPatternModePn9, 4 },\n>>> },\n>>> } },\n>>> + { \"ov2740\", {\n>>> + .unitCellSize = { 1400, 1400 },\n>> https://www.ovt.com/wp-content/uploads/2022/01/OV2740-PB-v1.3-WEB.pdf\n>> confirms this,\n>>\n>>> + .testPatternModes = {\n>>> + { controls::draft::TestPatternModeOff, 0 },\n>>> + { controls::draft::TestPatternModeColorBars, 1},\n>> and drivers/media/i2c/ov2740.c confirms this.\n> Is this the standard colour bars pattern (as specified in the control\n> documentation, referencing the MIPI CCS specification) ?\n\n\nThis mode matches the specification in the control documentation yes\n(there are 3 other \"color bar\" test patterns in the driver that don't\nthough).\n\n>\n>> Reviewed-by: Kieran Bingham \n>>\n>>> + },\n>>> + } },\n>>> { \"ov5647\", {\n>>> .unitCellSize = { 1400, 1400 },\n>>> .testPatternModes = {},","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B6423BF415\n\tfor ;\n\tThu, 17 Mar 2022 09:49:16 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 78986604DC;\n\tThu, 17 Mar 2022 10:49:16 +0100 (CET)","from mail-wr1-x42f.google.com (mail-wr1-x42f.google.com\n\t[IPv6:2a00:1450:4864:20::42f])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C389F604DB\n\tfor ;\n\tThu, 17 Mar 2022 10:49:14 +0100 (CET)","by mail-wr1-x42f.google.com with SMTP id p9so6490881wra.12\n\tfor ;\n\tThu, 17 Mar 2022 02:49:14 -0700 (PDT)","from [192.168.0.14]\n\t(cpc141996-chfd3-2-0-cust928.12-3.cable.virginm.net. [86.13.91.161])\n\tby smtp.gmail.com with ESMTPSA id\n\ti11-20020a05600c354b00b00389f440512esm7745462wmq.32.2022.03.17.02.49.13\n\t(version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n\tThu, 17 Mar 2022 02:49:13 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1647510556;\n\tbh=XQzW7jHQAgqD5or9e/HVFOCiSiMN0/FH0F0mgn2w80U=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=An3xzeV8vvhvdWkMYnEtA5aUD85iLhI2iSUzM5bK5s5FcPVl+pYJeaiiKsv4BslxG\n\tEk0tOaochz42j7gE2J0UWeBRSJYSiDJi+gF3AedXVgpTMM4mX2CxvXeAa60OrYdk+I\n\tgPkdb/027E0cPdDd48cwFSXIwWeHx69qyz74bQOBALdOBDbF60feMXrg/osqznCANd\n\tazQZFg6JXsLUGPY4QA9hdg5kloJvJRxUBBi3MYVP0W2U/WSu6cC2lxe4yUt3exsUak\n\tnkbrG/X3nFl7B6YjVUoCObojhEoLP10DOZw1f3z6GGdJ4SzM6WFVBSnBahniDCVwVO\n\t7gVT3bQhl/p6Q==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;\n\th=message-id:date:mime-version:user-agent:subject:content-language:to\n\t:cc:references:from:in-reply-to:content-transfer-encoding;\n\tbh=NZagqMFtPZa1b8ZMv1E2vKrv2DUOhu3o5mfLUUx5Ejo=;\n\tb=Oq5/DqISB6Nk2sEp96BtJuViKzhFUuYWmt5VXPYoWcnu1pcSyWwtpg5s3KB+2G0I8P\n\t5kww7r9f0mAyaY6DwI3vRH4wPcFVMGZ1LWI36DnPcTCAHSuN2w3p2rrfE83M0VupTyKd\n\tRC4JJCpodFHEUCClxNmC/zoafmvZxsDMQYCN8Smpp4jpyLyUlOdKNxFfjlNBPpawbPOK\n\tSJVT8BPnqei4O8T73dhsxHoHj5y615FJloP5KIZORIfe+jqWaMDqDctA/mOfHvHP1T1r\n\ttsZjqZCXH8GA5M9lJw5H8FBdMfF7hSp+1/ZxrghSQ2lkq/GE6Xoi0ls8oc4gftCGehim\n\tWOvg=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"Oq5/DqIS\"; dkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:message-id:date:mime-version:user-agent:subject\n\t:content-language:to:cc:references:from:in-reply-to\n\t:content-transfer-encoding;\n\tbh=NZagqMFtPZa1b8ZMv1E2vKrv2DUOhu3o5mfLUUx5Ejo=;\n\tb=d5xD1ew+brsnLICW9vXAEpffQu9tUaLUD9+kOfVOrRNmwn9VsTad5jznGk3oyrxG7n\n\tbprZ8/kvqwYzR/S9Leb1/LmIHOyEgYofHXC6Y1DXTuIK1+6i0Eoq9FjmonxLC3Vj/wlH\n\t2ntL/bCv2QFwuvCRHQEFRNOJ7qc3HWhDaeFfVdPAOciCLJdLRTF6D/7cmI2hncgykhuh\n\tBvp5wx3y8xZ73hwjP0yiWkyJ6Zgc2xKz+ykVeNz8INSjQlFZxVlsqXGBk4pXgV0a0dX8\n\tiAZm0gez0EJe3qtYvuFVeBcaui6pYvMpvnlbH/t1P1KRUsYF9x2pj7/2zjalAO7CabL0\n\tVt8w==","X-Gm-Message-State":"AOAM5327X/qm2dBB33+DCX6qaYXIQKeicm5I2M1yoF98PqaJVkDfHIUU\n\tZY14UJe9bI2Mt9stnYqqbKpdQg7gXlE=","X-Google-Smtp-Source":"ABdhPJww8S9HCMWwA2lCeUm/cGESootJMF8ws/3xYdfiKGRmdFdNsPsIalmtig/7bAbk2mXO8mQFzA==","X-Received":"by 2002:a05:6000:100a:b0:203:d9e5:3ba7 with SMTP id\n\ta10-20020a056000100a00b00203d9e53ba7mr3184152wrx.447.1647510554358; \n\tThu, 17 Mar 2022 02:49:14 -0700 (PDT)","Message-ID":"<110f88d4-c5a6-974d-2c07-2e7ea5f17547@gmail.com>","Date":"Thu, 17 Mar 2022 09:49:12 +0000","MIME-Version":"1.0","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101\n\tThunderbird/91.5.0","Content-Language":"en-US","To":"Laurent Pinchart ,\n\tKieran Bingham ","References":"<20220316222245.132315-1-djrscally@gmail.com>\n\t<20220316222245.132315-2-djrscally@gmail.com>\n\t<164746995195.11309.4416212083703626942@Monstersaurus>\n\t","In-Reply-To":"","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH 1/2] libcamera: Add OV2740 camera\n\tsensor properties","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Daniel Scally via libcamera-devel ","Reply-To":"Daniel Scally ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":22301,"web_url":"https://patchwork.libcamera.org/comment/22301/","msgid":"","date":"2022-03-17T09:57:21","subject":"Re: [libcamera-devel] [PATCH 1/2] libcamera: Add OV2740 camera\n\tsensor properties","submitter":{"id":97,"url":"https://patchwork.libcamera.org/api/people/97/","name":"Nicolas Dufresne via libcamera-devel","email":"libcamera-devel@lists.libcamera.org"},"content":"Hi Dan,\n\nOn Thu, Mar 17, 2022 at 09:49:12AM +0000, Daniel Scally wrote:\n> On 17/03/2022 07:57, Laurent Pinchart wrote:\n> > On Wed, Mar 16, 2022 at 10:32:31PM +0000, Kieran Bingham via libcamera-devel wrote:\n> >> Quoting Daniel Scally via libcamera-devel (2022-03-16 22:22:44)\n> >>> Add camera sensor property entries for the OmniVision 2740 camera\n> >>> sensor.\n> >>>\n> >>> Signed-off-by: Daniel Scally \n> >>> ---\n> >>> src/libcamera/camera_sensor_properties.cpp | 7 +++++++\n> >>> 1 file changed, 7 insertions(+)\n> >>>\n> >>> diff --git a/src/libcamera/camera_sensor_properties.cpp b/src/libcamera/camera_sensor_properties.cpp\n> >>> index 48305ac4..9bdfd417 100644\n> >>> --- a/src/libcamera/camera_sensor_properties.cpp\n> >>> +++ b/src/libcamera/camera_sensor_properties.cpp\n> >>> @@ -90,6 +90,13 @@ const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen\n> >>> { controls::draft::TestPatternModePn9, 4 },\n> >>> },\n> >>> } },\n> >>> + { \"ov2740\", {\n> >>> + .unitCellSize = { 1400, 1400 },\n> >>\n> >> https://www.ovt.com/wp-content/uploads/2022/01/OV2740-PB-v1.3-WEB.pdf\n> >> confirms this,\n> >>\n> >>> + .testPatternModes = {\n> >>> + { controls::draft::TestPatternModeOff, 0 },\n> >>> + { controls::draft::TestPatternModeColorBars, 1},\n> >> and drivers/media/i2c/ov2740.c confirms this.\n> >\n> > Is this the standard colour bars pattern (as specified in the control\n> > documentation, referencing the MIPI CCS specification) ?\n> \n> This mode matches the specification in the control documentation yes\n> (there are 3 other \"color bar\" test patterns in the driver that don't\n> though).\n\nThank you for the confirmation.\n\nReviewed-by: Laurent Pinchart \n\n> >> Reviewed-by: Kieran Bingham \n> >>\n> >>> + },\n> >>> + } },\n> >>> { \"ov5647\", {\n> >>> .unitCellSize = { 1400, 1400 },\n> >>> .testPatternModes = {},","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B2C05BDE17\n\tfor ;\n\tThu, 17 Mar 2022 09:57:40 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 19037604DC;\n\tThu, 17 Mar 2022 10:57:40 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 93A90604DB\n\tfor ;\n\tThu, 17 Mar 2022 10:57:38 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 058EA493;\n\tThu, 17 Mar 2022 10:57:37 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1647511060;\n\tbh=gVzfAULrp2c58ogCJVzQRX7RqsKQub5ttEVNPO1NDII=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=rfDtso0om/3L/W9784TIfb3QXvpi4ZeTLlPrFUmph0nx61mAFSF8KSfsLK3K5/Qdv\n\t1ZlgSY3ku3Ku5pfBXDe8liLVmPtoktj14hXCeTaZrkhLxhf2ewJtpYUSOoOzK3uFi4\n\tq33DDsuSLcckaiZLfUUzrKSnBqP1YSalNFeC/xMtPpW6+P8kl/G/IdTFx5bi4ZIKWM\n\tmzqkjDI0xGFimMBHNA8dZZYrHLZ+q90to7ISJk4uzBH+EHS3la9DTN/PPJW7m2RBuO\n\tCXCaT+p88PkVjjzCtSPo3Ts06+dPLwI00/c5DB0Srl5kKdkC4TGbbN8iFFZY+X/iWL\n\t1pornt4R+4kIg==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1647511058;\n\tbh=gVzfAULrp2c58ogCJVzQRX7RqsKQub5ttEVNPO1NDII=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=EQPCE+rkUPrldaVRSiPpB6G9Xbait64y0gm3YIZnuOVR9TebybGe66yswiVXXzxsm\n\txhOiGEaAy+jVvK0HZMn1SjLAofyRefe1JL083tOCKQwjwGDVHlVejzMl9m0LyUnucP\n\t0oyBBWjLlTIYvNn30vGLYg3z/q7iPy50sirL0HKo="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"EQPCE+rk\"; dkim-atps=neutral","Date":"Thu, 17 Mar 2022 11:57:21 +0200","To":"Daniel Scally ","Message-ID":"","References":"<20220316222245.132315-1-djrscally@gmail.com>\n\t<20220316222245.132315-2-djrscally@gmail.com>\n\t<164746995195.11309.4416212083703626942@Monstersaurus>\n\t\n\t<110f88d4-c5a6-974d-2c07-2e7ea5f17547@gmail.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<110f88d4-c5a6-974d-2c07-2e7ea5f17547@gmail.com>","Subject":"Re: [libcamera-devel] [PATCH 1/2] libcamera: Add OV2740 camera\n\tsensor properties","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]