[{"id":22285,"web_url":"https://patchwork.libcamera.org/comment/22285/","msgid":"<164742437838.11309.15210012726770381503@Monstersaurus>","date":"2022-03-16T09:52:58","subject":"Re: [libcamera-devel] [PATCH] libcamera: camera_sensor: Add OV5640\n\tsensor properties","submitter":{"id":97,"url":"https://patchwork.libcamera.org/api/people/97/","name":"Nicolas Dufresne via libcamera-devel","email":"libcamera-devel@lists.libcamera.org"},"content":"Quoting Paul Elder via libcamera-devel (2022-03-16 08:16:58)\n> Add an entry to the sensor properties for the ov5640. Only the first\n> test pattern is included as the others that are exposed by the kernel\n> don't correspond to any that are defined in the libcamera control.\n\nIndeed, I see: \n static const char * const test_pattern_menu[] = {\n \"Disabled\",\n \"Color bars\",\n \"Color bars w/ rolling bar\",\n \"Color squares\",\n \"Color squares w/ rolling bar\",\n };\n\nI think this patch is fine so \n\nReviewed-by: Kieran Bingham \n\nBut I wonder how we're going to map so many potential combinations of\ntest pattern.\n\nA test pattern with motion is probably useful to be able to enable but\nhow do we then define the motion etc...\n\nI almost wish we could just represent test patterns as a string menu and\nreport the underlying V4L2 strings directly to applications ... then the\nusers could choose directly.\n\n> \n> Signed-off-by: Paul Elder \n> ---\n> src/libcamera/camera_sensor_properties.cpp | 7 +++++++\n> 1 file changed, 7 insertions(+)\n> \n> diff --git a/src/libcamera/camera_sensor_properties.cpp b/src/libcamera/camera_sensor_properties.cpp\n> index 48305ac4..027d74e1 100644\n> --- a/src/libcamera/camera_sensor_properties.cpp\n> +++ b/src/libcamera/camera_sensor_properties.cpp\n> @@ -90,6 +90,13 @@ const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen\n> { controls::draft::TestPatternModePn9, 4 },\n> },\n> } },\n> + { \"ov5640\", {\n> + .unitCellSize = { 1400, 1400 },\n> + .testPatternModes = {\n> + { controls::draft::TestPatternModeOff, 0 },\n> + { controls::draft::TestPatternModeColorBars, 1 },\n> + },\n> + } },\n> { \"ov5647\", {\n> .unitCellSize = { 1400, 1400 },\n> .testPatternModes = {},\n> -- \n> 2.30.2\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2EF25BF415\n\tfor ;\n\tWed, 16 Mar 2022 09:53:03 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7E5D2604E9;\n\tWed, 16 Mar 2022 10:53:02 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id F1048601F5\n\tfor ;\n\tWed, 16 Mar 2022 10:53:00 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 902D2EE;\n\tWed, 16 Mar 2022 10:53:00 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1647424382;\n\tbh=zWJk1fCKCTpnd+HSWS659tcu8AKnfod+WctamOVYIkk=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=XJTw+d6fZ3sw+c9staYHOjdePO406X4oq55Yehw0Mkfys9kKgDpiL1+GSkGX5La6e\n\tADCbfyZ6QCJ9KuZsdbvtOEN5xaW7VWlae2xoZyAMUMfTd1VPkDFHEUfpG91z/zT49q\n\tmtDtov7SciQTZsYOkeDXo6tthtHAIz+plrb+n9ahfb2TordcdaK59lPEND8KHHMr9o\n\t9i8fRqJxYZEsU6NUDJ4sB6k534TjCy/XW9fBkaCND86xEUEHAcZOhwfClelEeRSBZE\n\t/gjw/ffHJ8Xo1GYSuDaaXkEihcdG60l/f25YjIXSrCx3cg7n9tEx7KNp0nGCEAE/qI\n\t/Gb8oM4O5vieg==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1647424380;\n\tbh=zWJk1fCKCTpnd+HSWS659tcu8AKnfod+WctamOVYIkk=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=aX8hbqtIKPXUzB7yeapeobrTAOB3vQqEx3d45OyHa1wn0U7t3+Sq8nxJKDGk8bBil\n\tXH0TaddvtEo1/xYJ2S9JJCNKHlKpxdsWoI23JW9aCNRkKTLiKopJzA+yp47Flnsw2S\n\tU2FqGE/uRY6y71fi8G+QUsOP6u+xp/ewZoUgerFA="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"aX8hbqtI\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20220316081658.3103994-1-paul.elder@ideasonboard.com>","References":"<20220316081658.3103994-1-paul.elder@ideasonboard.com>","To":"Paul Elder ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Wed, 16 Mar 2022 09:52:58 +0000","Message-ID":"<164742437838.11309.15210012726770381503@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH] libcamera: camera_sensor: Add OV5640\n\tsensor properties","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kieran Bingham via libcamera-devel\n\t","Reply-To":"Kieran Bingham ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":22377,"web_url":"https://patchwork.libcamera.org/comment/22377/","msgid":"","date":"2022-03-23T00:42:00","subject":"Re: [libcamera-devel] [PATCH] libcamera: camera_sensor: Add OV5640\n\tsensor properties","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Paul,\n\nThank you for the patch.\n\nOn Wed, Mar 16, 2022 at 05:16:58PM +0900, Paul Elder via libcamera-devel wrote:\n> Add an entry to the sensor properties for the ov5640. Only the first\n> test pattern is included as the others that are exposed by the kernel\n> don't correspond to any that are defined in the libcamera control.\n> \n> Signed-off-by: Paul Elder \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/libcamera/camera_sensor_properties.cpp | 7 +++++++\n> 1 file changed, 7 insertions(+)\n> \n> diff --git a/src/libcamera/camera_sensor_properties.cpp b/src/libcamera/camera_sensor_properties.cpp\n> index 48305ac4..027d74e1 100644\n> --- a/src/libcamera/camera_sensor_properties.cpp\n> +++ b/src/libcamera/camera_sensor_properties.cpp\n> @@ -90,6 +90,13 @@ const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen\n> \t\t\t\t{ controls::draft::TestPatternModePn9, 4 },\n> \t\t\t},\n> \t\t} },\n> +\t\t{ \"ov5640\", {\n> +\t\t\t.unitCellSize = { 1400, 1400 },\n> +\t\t\t.testPatternModes = {\n> +\t\t\t\t{ controls::draft::TestPatternModeOff, 0 },\n> +\t\t\t\t{ controls::draft::TestPatternModeColorBars, 1 },\n> +\t\t\t},\n> +\t\t} },\n> \t\t{ \"ov5647\", {\n> \t\t\t.unitCellSize = { 1400, 1400 },\n> \t\t\t.testPatternModes = {},","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E1DC7BD80A\n\tfor ;\n\tWed, 23 Mar 2022 00:42:19 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4402D604E6;\n\tWed, 23 Mar 2022 01:42:19 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E8754604C6\n\tfor ;\n\tWed, 23 Mar 2022 01:42:17 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 681699DE;\n\tWed, 23 Mar 2022 01:42:17 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1647996139;\n\tbh=UM5r34r9GWT3Oqb3Pgn6OhFQrTrBjgBB+f3zO7O/jBQ=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=HjM3PSHzvhmY2Jx2XjH8cGdYUumoZJSXzmb16gUDrltY/Xe4zKL292886YdeWUG+p\n\t7c19/A15cbAFg77qPU47eHjvxMI/rFk0d3LYGT/T7CZ57KXT5QrZrqaf0aWeddsZfx\n\tilm6ConnMnxsvlbLdvFf4gjLqCTek2vQ4sHDy67CBd8wUHQZcBIRE5pPmPYH64/3Bx\n\tTsyY4PxTv+ZukPRuNHkUtl2esa9laBQvtQnDyLT/MpsjJYcil9jxJ7/MTLL8wG92wn\n\tAC6WYhE2BjrTQHTSZSJdtdvD1S7k57x9UA8+/nfz5sNTvukHU6yonKn/tC9Sw82XMP\n\t8Ro4Ro91aSEeQ==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1647996137;\n\tbh=UM5r34r9GWT3Oqb3Pgn6OhFQrTrBjgBB+f3zO7O/jBQ=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=kQmCagXSCHOfq2gm1aHd0dM5QLjwuZWE8YQZCpYz1RL8VtYlI3+HeiofSu1Kx6xhy\n\tKBbfRTecRRT2gEAjuh2Lk7GcrVHzWu5mMROyuL3UsfYZm4jUgtWurHxK0QO89UU1g2\n\tBaU/vlVF41RVNsMM6Z631SVIVSFTceHm1veQ5fmk="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"kQmCagXS\"; dkim-atps=neutral","Date":"Wed, 23 Mar 2022 02:42:00 +0200","To":"Paul Elder ","Message-ID":"","References":"<20220316081658.3103994-1-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20220316081658.3103994-1-paul.elder@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH] libcamera: camera_sensor: Add OV5640\n\tsensor properties","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]