[{"id":22277,"web_url":"https://patchwork.libcamera.org/comment/22277/","msgid":"<4c055ac7-123c-d927-6138-6d9fc70c23db@ideasonboard.com>","date":"2022-03-15T13:38:35","subject":"Re: [libcamera-devel] [PATCH 1/2] ipa: ipu3: agc: Reset frame count\n\twhen configuring AGC","submitter":{"id":97,"url":"https://patchwork.libcamera.org/api/people/97/","name":"Nicolas Dufresne via libcamera-devel","email":"libcamera-devel@lists.libcamera.org"},"content":"Hi Laurent,\n\nOn 15/03/2022 14:34, Laurent Pinchart via libcamera-devel wrote:\n> The frame count is used to skip the gain and exposure filtering when\n> starting. It thus needs to be reset when configuring the algorithm, to\n> avoid slower convergence when stopping and restarting.\n> \n> Signed-off-by: Laurent Pinchart \nReviewed-by: Jean-Michel Hautbois \n\n> ---\n> src/ipa/ipu3/algorithms/agc.cpp | 1 +\n> 1 file changed, 1 insertion(+)\n> \n> diff --git a/src/ipa/ipu3/algorithms/agc.cpp b/src/ipa/ipu3/algorithms/agc.cpp\n> index 1eb1bcef2f02..70cff3fed43c 100644\n> --- a/src/ipa/ipu3/algorithms/agc.cpp\n> +++ b/src/ipa/ipu3/algorithms/agc.cpp\n> @@ -102,6 +102,7 @@ int Agc::configure(IPAContext &context,\n> \tframeContext.agc.gain = std::max(minAnalogueGain_, kMinAnalogueGain);\n> \tframeContext.agc.exposure = 10ms / configuration.sensor.lineDuration;\n> \n> +\tframeCount_ = 0;\n> \treturn 0;\n> }\n> \n> \n> base-commit: e41854a4e6fde2dd9e2a2a7290670943235776cd","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 78372BF415\n\tfor ;\n\tTue, 15 Mar 2022 13:38:40 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C082F604DC;\n\tTue, 15 Mar 2022 14:38:39 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 55551604DA\n\tfor ;\n\tTue, 15 Mar 2022 14:38:38 +0100 (CET)","from [IPV6:2a01:e0a:169:7140:e38:1788:50cc:d433] (unknown\n\t[IPv6:2a01:e0a:169:7140:e38:1788:50cc:d433])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 040061BBB;\n\tTue, 15 Mar 2022 14:38:37 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1647351519;\n\tbh=aAFXRqlmtwtq+SuWVoLCiPW+wv6JoyqSlusxDjjbRh8=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=U3upB01d781FYofqGrlsx0dA0wPY06n0lVQEvQgBlnVz0XGlqNuhrfIiCv66WuSYq\n\tMtz/HiFKRNKAX0kf96QXdQz/nkLfGw5qAMrKPLS+6h6VYa20Ik0iiFrIL7luhb8hLW\n\tcp6qAW4ELUDj8ABIUWwa4yJk9mQcull+Ovv+Pob9FDRrXRH79PrCaqLwc+5vjwIy60\n\tymADh6se6uHoPQv70xI3fwjFIJmggzvMRcjrLT6ik8Otf/MlAnU5GbdZxyKABlNtP0\n\td68rQkUkkO9CukCvmtd4t2C75nVO5aY/DlZJ/RHZlNBzXv5QzdD0G7nVwKFIXG959C\n\tiN1jvs2lkqwvQ==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1647351518;\n\tbh=aAFXRqlmtwtq+SuWVoLCiPW+wv6JoyqSlusxDjjbRh8=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=sdP1ioK+WU88quwgZ4k8FFHUqOjrchMvLgOrIg/IqNlCtF7W4+RB2aQ79TuoRyzFm\n\tfjXrtipy3g1NjXpNVTWo/kDlOKRaF/8J/wV3VrCib+r/p//+sw1sUZfkA36HIUtigh\n\t9slZrkMMNBfzrLNxgM890Mv7S6azYX86yCDGZvIM="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"sdP1ioK+\"; dkim-atps=neutral","Message-ID":"<4c055ac7-123c-d927-6138-6d9fc70c23db@ideasonboard.com>","Date":"Tue, 15 Mar 2022 14:38:35 +0100","MIME-Version":"1.0","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101\n\tThunderbird/91.5.0","Content-Language":"en-US","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20220315133407.32348-1-laurent.pinchart@ideasonboard.com>","In-Reply-To":"<20220315133407.32348-1-laurent.pinchart@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH 1/2] ipa: ipu3: agc: Reset frame count\n\twhen configuring AGC","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Jean-Michel Hautbois via libcamera-devel\n\t","Reply-To":"Jean-Michel Hautbois ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":22279,"web_url":"https://patchwork.libcamera.org/comment/22279/","msgid":"<264ca03f-5ce3-f399-2178-3e6299cc589e@ideasonboard.com>","date":"2022-03-15T13:52:59","subject":"Re: [libcamera-devel] [PATCH 1/2] ipa: ipu3: agc: Reset frame count\n\twhen configuring AGC","submitter":{"id":97,"url":"https://patchwork.libcamera.org/api/people/97/","name":"Nicolas Dufresne via libcamera-devel","email":"libcamera-devel@lists.libcamera.org"},"content":"Hi Laurent,\n\nOn 3/15/22 19:04, Laurent Pinchart via libcamera-devel wrote:\n> The frame count is used to skip the gain and exposure filtering when\n> starting. It thus needs to be reset when configuring the algorithm, to\n> avoid slower convergence when stopping and restarting.\n>\n> Signed-off-by: Laurent Pinchart \n\n\nReviewed-by: Umang Jain \n\n> ---\n> src/ipa/ipu3/algorithms/agc.cpp | 1 +\n> 1 file changed, 1 insertion(+)\n>\n> diff --git a/src/ipa/ipu3/algorithms/agc.cpp b/src/ipa/ipu3/algorithms/agc.cpp\n> index 1eb1bcef2f02..70cff3fed43c 100644\n> --- a/src/ipa/ipu3/algorithms/agc.cpp\n> +++ b/src/ipa/ipu3/algorithms/agc.cpp\n> @@ -102,6 +102,7 @@ int Agc::configure(IPAContext &context,\n> \tframeContext.agc.gain = std::max(minAnalogueGain_, kMinAnalogueGain);\n> \tframeContext.agc.exposure = 10ms / configuration.sensor.lineDuration;\n> \n> +\tframeCount_ = 0;\n> \treturn 0;\n> }\n> \n>\n> base-commit: e41854a4e6fde2dd9e2a2a7290670943235776cd","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4BCAEBDE17\n\tfor ;\n\tTue, 15 Mar 2022 13:53:08 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B34D7610F8;\n\tTue, 15 Mar 2022 14:53:07 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id EB956604DA\n\tfor ;\n\tTue, 15 Mar 2022 14:53:05 +0100 (CET)","from [192.168.1.106] (unknown [103.251.226.183])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 9AD931BBB;\n\tTue, 15 Mar 2022 14:53:04 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1647352387;\n\tbh=hsKcPUnda7z3goCgAerJkb6/N6p3ficToOVbXO4Oqd8=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=ROE1hFkSiR6NpHqrIC8uVQz0r6FMfZR1upeydp3ZVhwsPUtHw716jJWoByJbJESS5\n\tDUOy8lr9DGbxsfom3tWHxLwaqljVVq2jZHg6ZOxJvyXA+J3TlUJGVm7zymm9dA2mmS\n\t21JxnzVpoJg4MGBlcWqr+W4uckfZ6OHMnvyfGBYGG/5xdGzxj1BJ92Ha0rN74C4U8f\n\tWdnoBhd/Qy05XKv2EidGOLmFoUGWk0dcp0ZTqZa5LXHSGZ1RnYFVUi3Nh+Wf9DJM9G\n\tmqD2C0X0IcBg0jywxjszqRVOs1R9rkB3/9GDIrmwy5u0fEEpGpW+dpUlZZoGX85jyj\n\tr3zGH5L+rQ3ew==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1647352385;\n\tbh=hsKcPUnda7z3goCgAerJkb6/N6p3ficToOVbXO4Oqd8=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=ftff0P2yj6/K5eAs29Tv/3zqudPijAPTF4FMg4Cegi8Jm7WUHATO7DKSISDiqF5gf\n\tSw0/9xBPUNeMMc0RKu9okl0HF3hnGuhqeWlxwF+mEvOwmAgUnQADeF3Tn8oRSx4KeO\n\t5N4dVDte12yEyVPw85tr2CVqzYysu5/Q7ciTO3j0="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"ftff0P2y\"; dkim-atps=neutral","Message-ID":"<264ca03f-5ce3-f399-2178-3e6299cc589e@ideasonboard.com>","Date":"Tue, 15 Mar 2022 19:22:59 +0530","MIME-Version":"1.0","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101\n\tThunderbird/91.4.1","Content-Language":"en-US","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20220315133407.32348-1-laurent.pinchart@ideasonboard.com>","In-Reply-To":"<20220315133407.32348-1-laurent.pinchart@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH 1/2] ipa: ipu3: agc: Reset frame count\n\twhen configuring AGC","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Umang Jain via libcamera-devel ","Reply-To":"Umang Jain ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]