{"id":15448,"url":"https://patchwork.libcamera.org/api/patches/15448/?format=json","web_url":"https://patchwork.libcamera.org/patch/15448/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20220315133407.32348-1-laurent.pinchart@ideasonboard.com>","date":"2022-03-15T13:34:06","name":"[libcamera-devel,1/2] ipa: ipu3: agc: Reset frame count when configuring AGC","commit_ref":"f2624fed0467f870774386e2c947d7bfdb75ca1e","pull_url":null,"state":"accepted","archived":false,"hash":"d1d1a3f500ab31c14390e87d26a35b8d56f7ce1e","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/15448/mbox/","series":[{"id":2961,"url":"https://patchwork.libcamera.org/api/series/2961/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2961","date":"2022-03-15T13:34:06","name":"[libcamera-devel,1/2] ipa: ipu3: agc: Reset frame count when configuring AGC","version":1,"mbox":"https://patchwork.libcamera.org/series/2961/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/15448/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/15448/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\r\n\t[92.243.16.209])\r\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 456F8BDE17\r\n\tfor ;\r\n\tTue, 15 Mar 2022 13:34:34 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\r\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6FF1B604E9;\r\n\tTue, 15 Mar 2022 14:34:33 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\r\n\t[213.167.242.64])\r\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1EF15604DA\r\n\tfor ;\r\n\tTue, 15 Mar 2022 14:34:32 +0100 (CET)","from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57])\r\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A06FF1BBB\r\n\tfor ;\r\n\tTue, 15 Mar 2022 14:34:31 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\r\n\ts=mail; t=1647351273;\r\n\tbh=t/JbdkFTXorpiSOFz/PXU2UFTUTB9SNVA0hz53+Smro=;\r\n\th=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post:\r\n\tList-Help:List-Subscribe:From:Reply-To:From;\r\n\tb=Xhsg1DxH4u50xGnjJiwFEuhKCWMeXlVEJkz/H26OGNMMwxr5TEvW6LOG1zwxM02oV\r\n\tJQjr4AOXJor/f+koWQw0xuI/TRj4zfAtELx/1m5q84lQ/mpgw7Ad7A25/wvcmnVyTo\r\n\tLZYn4qtr32xIEN/HMYQ1EZ8FnuwIiaRxdnvyW2pVbPN8ezi5lVuk6MZjgkdVyv/r/Q\r\n\tI39ZvvtVm8wXx0VaZx1Jv1rDxpJEPnLke3Lfx2pi3pbepvLO9+ScTC4cAZs/GPbF/Z\r\n\tKvIQNeX8mDS3xtaVTndHyc4tDSRqyL3mX50yjFc6/QS9PM3Hl7C0R49vXLKdeAyAx/\r\n\tu0eLJoBdRUzmw==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\r\n\ts=mail; t=1647351271;\r\n\tbh=t/JbdkFTXorpiSOFz/PXU2UFTUTB9SNVA0hz53+Smro=;\r\n\th=From:To:Subject:Date:From;\r\n\tb=BpH36zLJa7owqxx61vk7TAdDOfPQpM/e2/+5z0lza76na/C0Qo63xj/3thiceNv+R\r\n\tCpKq7gX8YfOKw3BMp/iIkIb+3N7qBaTY0hrPaHEFsCm+7NQ70mj/XGI5udnv33vdPT\r\n\tCa14+5fyHceraBZFlXn7ofOu3brGuypkmLI8gUqA="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \r\n\tunprotected) header.d=ideasonboard.com\r\n\theader.i=@ideasonboard.com\r\n\theader.b=\"BpH36zLJ\"; dkim-atps=neutral","To":"libcamera-devel@lists.libcamera.org","Date":"Tue, 15 Mar 2022 15:34:06 +0200","Message-Id":"<20220315133407.32348-1-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.34.1","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH 1/2] ipa: ipu3: agc: Reset frame count\r\n\twhen configuring AGC","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\r\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\r\n\t","From":"Laurent Pinchart via libcamera-devel\r\n\t","Reply-To":"Laurent Pinchart ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The frame count is used to skip the gain and exposure filtering when\nstarting. It thus needs to be reset when configuring the algorithm, to\navoid slower convergence when stopping and restarting.\n\nSigned-off-by: Laurent Pinchart \n---\n src/ipa/ipu3/algorithms/agc.cpp | 1 +\n 1 file changed, 1 insertion(+)\n\n\nbase-commit: e41854a4e6fde2dd9e2a2a7290670943235776cd","diff":"diff --git a/src/ipa/ipu3/algorithms/agc.cpp b/src/ipa/ipu3/algorithms/agc.cpp\r\nindex 1eb1bcef2f02..70cff3fed43c 100644\r\n--- a/src/ipa/ipu3/algorithms/agc.cpp\r\n+++ b/src/ipa/ipu3/algorithms/agc.cpp\r\n@@ -102,6 +102,7 @@ int Agc::configure(IPAContext &context,\r\n \tframeContext.agc.gain = std::max(minAnalogueGain_, kMinAnalogueGain);\r\n \tframeContext.agc.exposure = 10ms / configuration.sensor.lineDuration;\r\n \r\n+\tframeCount_ = 0;\r\n \treturn 0;\r\n }","prefixes":["libcamera-devel","1/2"]}