[{"id":2063,"web_url":"https://patchwork.libcamera.org/comment/2063/","msgid":"<92d1dc6f-9473-9ba0-f8ac-4e49b74c5461@ideasonboard.com>","date":"2019-07-01T08:02:02","subject":"Re: [libcamera-devel] [PATCH v3 02/14] libcamera: v4l2_controls:\n\tAdd min and max to V4L2ControlInfo","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Laurent,\n\nOn 01/07/2019 00:38, Laurent Pinchart wrote:\n> Add min() and max() methods to V4L2ControlInfo to report the control's\n> minimum and maximum value respectively.\n\nGreat this ties in to the existing V4L2 Controls easily.\n\nReviewed-by: Kieran Bingham \n\n> \n> Signed-off-by: Laurent Pinchart \n> ---\n> src/libcamera/include/v4l2_controls.h | 6 ++++++\n> src/libcamera/v4l2_controls.cpp | 14 ++++++++++++++\n> 2 files changed, 20 insertions(+)\n> \n> diff --git a/src/libcamera/include/v4l2_controls.h b/src/libcamera/include/v4l2_controls.h\n> index 2c8cb9003f25..0047efab11fa 100644\n> --- a/src/libcamera/include/v4l2_controls.h\n> +++ b/src/libcamera/include/v4l2_controls.h\n> @@ -28,11 +28,17 @@ public:\n> \tsize_t size() const { return size_; }\n> \tconst std::string &name() const { return name_; }\n> \n> +\tint64_t min() const { return min_; }\n> +\tint64_t max() const { return max_; }\n> +\n> private:\n> \tunsigned int id_;\n> \tunsigned int type_;\n> \tsize_t size_;\n> \tstd::string name_;\n> +\n> +\tint64_t min_;\n> +\tint64_t max_;\n> };\n> \n> class V4L2Control\n> diff --git a/src/libcamera/v4l2_controls.cpp b/src/libcamera/v4l2_controls.cpp\n> index 78888de29642..af017bce48ba 100644\n> --- a/src/libcamera/v4l2_controls.cpp\n> +++ b/src/libcamera/v4l2_controls.cpp\n> @@ -74,6 +74,8 @@ V4L2ControlInfo::V4L2ControlInfo(const struct v4l2_query_ext_ctrl &ctrl)\n> \ttype_ = ctrl.type;\n> \tname_ = static_cast(ctrl.name);\n> \tsize_ = ctrl.elem_size * ctrl.elems;\n> +\tmin_ = ctrl.minimum;\n> +\tmax_ = ctrl.maximum;\n> }\n> \n> /**\n> @@ -100,6 +102,18 @@ V4L2ControlInfo::V4L2ControlInfo(const struct v4l2_query_ext_ctrl &ctrl)\n> * \\return The V4L2 control user readable name\n> */\n> \n> +/**\n> + * \\fn V4L2ControlInfo::min()\n> + * \\brief Retrieve the control minimum value\n> + * \\return The V4L2 control minimum value\n> + */\n> +\n> +/**\n> + * \\fn V4L2ControlInfo::max()\n> + * \\brief Retrieve the control maximum value\n> + * \\return The V4L2 control maximum value\n> + */\n> +\n> /**\n> * \\class V4L2Control\n> * \\brief A V4L2 control value\n>","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 37F3360C2B\n\tfor ;\n\tMon, 1 Jul 2019 10:02:06 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 7C53B524;\n\tMon, 1 Jul 2019 10:02:05 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1561968125;\n\tbh=xdjgXWjY+A21Jq4j3hiaHK/l51L0V1ZhCgG7U4qjm5U=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=NHEHBwEKYj+9xYFL7cGczeaDidEFIbv3MFFQ/a3mFUxc1CsimKkWD/QxYavVcgR0l\n\tK5b42YmRh8t0YQaUag3jDz/phSMMy2FyV3dLLAUcLTqnwEv+Ak0tLzSpMfkFLDKZJR\n\tKymM41MKiQVc4c8I/jSI2/7AaP7q2liW2yurX/Bk=","Reply-To":"kieran.bingham@ideasonboard.com","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20190630233817.10130-1-laurent.pinchart@ideasonboard.com>\n\t<20190630233817.10130-3-laurent.pinchart@ideasonboard.com>","From":"Kieran Bingham ","Openpgp":"preference=signencrypt","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAkAEEwEKACoCGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEFAlnDk/gFCQeA/YsACgkQoR5GchCkYf3X5w/9EaZ7\n\tcnUcT6dxjxrcmmMnfFPoQA1iQXr/MXQJBjFWfxRUWYzjvUJb2D/FpA8FY7y+vksoJP7pWDL7\n\tQTbksdwzagUEk7CU45iLWL/CZ/knYhj1I/+5LSLFmvZ/5Gf5xn2ZCsmg7C0MdW/GbJ8IjWA8\n\t/LKJSEYH8tefoiG6+9xSNp1p0Gesu3vhje/GdGX4wDsfAxx1rIYDYVoX4bDM+uBUQh7sQox/\n\tR1bS0AaVJzPNcjeC14MS226mQRUaUPc9250aj44WmDfcg44/kMsoLFEmQo2II9aOlxUDJ+x1\n\txohGbh9mgBoVawMO3RMBihcEjo/8ytW6v7xSF+xP4Oc+HOn7qebAkxhSWcRxQVaQYw3S9iZz\n\t2iA09AXAkbvPKuMSXi4uau5daXStfBnmOfalG0j+9Y6hOFjz5j0XzaoF6Pln0jisDtWltYhP\n\tX9LjFVhhLkTzPZB/xOeWGmsG4gv2V2ExbU3uAmb7t1VSD9+IO3Km4FtnYOKBWlxwEd8qOFpS\n\tjEqMXURKOiJvnw3OXe9MqG19XdeENA1KyhK5rqjpwdvPGfSn2V+SlsdJA0DFsobUScD9qXQw\n\tOvhapHe3XboK2+Rd7L+g/9Ud7ZKLQHAsMBXOVJbufA1AT+IaOt0ugMcFkAR5UbBg5+dZUYJj\n\t1QbPQcGmM3wfvuaWV5+SlJ+WeKIb8ta5Ag0EVgT9ZgEQAM4o5G/kmruIQJ3K9SYzmPishRHV\n\tDcUcvoakyXSX2mIoccmo9BHtD9MxIt+QmxOpYFNFM7YofX4lG0ld8H7FqoNVLd/+a0yru5Cx\n\tadeZBe3qr1eLns10Q90LuMo7/6zJhCW2w+HE7xgmCHejAwuNe3+7yt4QmwlSGUqdxl8cgtS1\n\tPlEK93xXDsgsJj/bw1EfSVdAUqhx8UQ3aVFxNug5OpoX9FdWJLKROUrfNeBE16RLrNrq2ROc\n\tiSFETpVjyC/oZtzRFnwD9Or7EFMi76/xrWzk+/b15RJ9WrpXGMrttHUUcYZEOoiC2lEXMSAF\n\tSSSj4vHbKDJ0vKQdEFtdgB1roqzxdIOg4rlHz5qwOTynueiBpaZI3PHDudZSMR5Fk6QjFooE\n\tXTw3sSl/km/lvUFiv9CYyHOLdygWohvDuMkV/Jpdkfq8XwFSjOle+vT/4VqERnYFDIGBxaRx\n\tkoBLfNDiiuR3lD8tnJ4A1F88K6ojOUs+jndKsOaQpDZV6iNFv8IaNIklTPvPkZsmNDhJMRHH\n\tIu60S7BpzNeQeT4yyY4dX9lC2JL/LOEpw8DGf5BNOP1KgjCvyp1/KcFxDAo89IeqljaRsCdP\n\t7WCIECWYem6pLwaw6IAL7oX+tEqIMPph/G/jwZcdS6Hkyt/esHPuHNwX4guqTbVEuRqbDzDI\n\t2DJO5FbxABEBAAGJAiUEGAEKAA8CGwwFAlnDlGsFCQeA/gIACgkQoR5GchCkYf1yYRAAq+Yo\n\tnbf9DGdK1kTAm2RTFg+w9oOp2Xjqfhds2PAhFFvrHQg1XfQR/UF/SjeUmaOmLSczM0s6XMeO\n\tVcE77UFtJ/+hLo4PRFKm5X1Pcar6g5m4xGqa+Xfzi9tRkwC29KMCoQOag1BhHChgqYaUH3yo\n\tUzaPwT/fY75iVI+yD0ih/e6j8qYvP8pvGwMQfrmN9YB0zB39YzCSdaUaNrWGD3iCBxg6lwSO\n\tLKeRhxxfiXCIYEf3vwOsP3YMx2JkD5doseXmWBGW1U0T/oJF+DVfKB6mv5UfsTzpVhJRgee7\n\t4jkjqFq4qsUGxcvF2xtRkfHFpZDbRgRlVmiWkqDkT4qMA+4q1y/dWwshSKi/uwVZNycuLsz+\n\t+OD8xPNCsMTqeUkAKfbD8xW4LCay3r/dD2ckoxRxtMD9eOAyu5wYzo/ydIPTh1QEj9SYyvp8\n\tO0g6CpxEwyHUQtF5oh15O018z3ZLztFJKR3RD42VKVsrnNDKnoY0f4U0z7eJv2NeF8xHMuiU\n\tRCIzqxX1GVYaNkKTnb/Qja8hnYnkUzY1Lc+OtwiGmXTwYsPZjjAaDX35J/RSKAoy5wGo/YFA\n\tJxB1gWThL4kOTbsqqXj9GLcyOImkW0lJGGR3o/fV91Zh63S5TKnf2YGGGzxki+ADdxVQAm+Q\n\tsbsRB8KNNvVXBOVNwko86rQqF9drZuw=","Organization":"Ideas on Board","Message-ID":"<92d1dc6f-9473-9ba0-f8ac-4e49b74c5461@ideasonboard.com>","Date":"Mon, 1 Jul 2019 09:02:02 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101\n\tThunderbird/60.7.0","MIME-Version":"1.0","In-Reply-To":"<20190630233817.10130-3-laurent.pinchart@ideasonboard.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"8bit","Subject":"Re: [libcamera-devel] [PATCH v3 02/14] libcamera: v4l2_controls:\n\tAdd min and max to V4L2ControlInfo","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Mon, 01 Jul 2019 08:02:06 -0000"}},{"id":2073,"web_url":"https://patchwork.libcamera.org/comment/2073/","msgid":"<20190701145625.nuhp535fyvb6tlvc@uno.localdomain>","date":"2019-07-01T14:56:26","subject":"Re: [libcamera-devel] [PATCH v3 02/14] libcamera: v4l2_controls:\n\tAdd min and max to V4L2ControlInfo","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Laurent,\n\nOn Mon, Jul 01, 2019 at 02:38:05AM +0300, Laurent Pinchart wrote:\n> Add min() and max() methods to V4L2ControlInfo to report the control's\n> minimum and maximum value respectively.\n>\n> Signed-off-by: Laurent Pinchart \n> ---\n> src/libcamera/include/v4l2_controls.h | 6 ++++++\n> src/libcamera/v4l2_controls.cpp | 14 ++++++++++++++\n> 2 files changed, 20 insertions(+)\n>\n> diff --git a/src/libcamera/include/v4l2_controls.h b/src/libcamera/include/v4l2_controls.h\n> index 2c8cb9003f25..0047efab11fa 100644\n> --- a/src/libcamera/include/v4l2_controls.h\n> +++ b/src/libcamera/include/v4l2_controls.h\n> @@ -28,11 +28,17 @@ public:\n> \tsize_t size() const { return size_; }\n> \tconst std::string &name() const { return name_; }\n>\n> +\tint64_t min() const { return min_; }\n> +\tint64_t max() const { return max_; }\n> +\n> private:\n> \tunsigned int id_;\n> \tunsigned int type_;\n> \tsize_t size_;\n> \tstd::string name_;\n> +\n> +\tint64_t min_;\n> +\tint64_t max_;\n> };\n>\n> class V4L2Control\n> diff --git a/src/libcamera/v4l2_controls.cpp b/src/libcamera/v4l2_controls.cpp\n> index 78888de29642..af017bce48ba 100644\n> --- a/src/libcamera/v4l2_controls.cpp\n> +++ b/src/libcamera/v4l2_controls.cpp\n> @@ -74,6 +74,8 @@ V4L2ControlInfo::V4L2ControlInfo(const struct v4l2_query_ext_ctrl &ctrl)\n> \ttype_ = ctrl.type;\n> \tname_ = static_cast(ctrl.name);\n> \tsize_ = ctrl.elem_size * ctrl.elems;\n> +\tmin_ = ctrl.minimum;\n> +\tmax_ = ctrl.maximum;\n\nPlease note that ctrl.minimum and ctrl.maximum are meaningful only for\nsome of the types the v4l2_device supports at enumeration time\n\n\t\tV4L2ControlInfo info(ctrl);\n\t\tswitch (info.type()) {\n\t\tcase V4L2_CTRL_TYPE_INTEGER:\n\t\tcase V4L2_CTRL_TYPE_BOOLEAN:\n\t\tcase V4L2_CTRL_TYPE_MENU:\n\t\tcase V4L2_CTRL_TYPE_BUTTON:\n\t\tcase V4L2_CTRL_TYPE_INTEGER64:\n\t\tcase V4L2_CTRL_TYPE_BITMASK:\n\t\tcase V4L2_CTRL_TYPE_INTEGER_MENU:\n\t\t\tbreak;\n\t\t/* \\todo Support compound controls. */\n\t\tdefault:\n\t\t\tLOG(V4L2, Debug) << \"Control type '\" << info.type()\n\t\t\t\t\t << \"' not supported\";\n\t\t\tcontinue;\n\t\t}\n\n\t\tcontrols_.emplace(ctrl.id, info);\n\nhttps://www.kernel.org/doc/html/v5.0/media/uapi/v4l/vidioc-queryctrl.html#c.v4l2_ctrl_type\n\nThe most problematic one seems to be the BITMASK type, but also for\nothers, the driver might report nothing.\n\nThat said, if that' fine in your opinion, please have my\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n> }\n>\n> /**\n> @@ -100,6 +102,18 @@ V4L2ControlInfo::V4L2ControlInfo(const struct v4l2_query_ext_ctrl &ctrl)\n> * \\return The V4L2 control user readable name\n> */\n>\n> +/**\n> + * \\fn V4L2ControlInfo::min()\n> + * \\brief Retrieve the control minimum value\n> + * \\return The V4L2 control minimum value\n> + */\n> +\n> +/**\n> + * \\fn V4L2ControlInfo::max()\n> + * \\brief Retrieve the control maximum value\n> + * \\return The V4L2 control maximum value\n> + */\n> +\n> /**\n> * \\class V4L2Control\n> * \\brief A V4L2 control value\n> --\n> Regards,\n>\n> Laurent Pinchart\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from relay9-d.mail.gandi.net (relay9-d.mail.gandi.net\n\t[217.70.183.199])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D592B60BF8\n\tfor ;\n\tMon, 1 Jul 2019 16:55:09 +0200 (CEST)","from uno.localdomain (2-224-242-101.ip172.fastwebnet.it\n\t[2.224.242.101]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay9-d.mail.gandi.net (Postfix) with ESMTPSA id 437CEFF813;\n\tMon, 1 Jul 2019 14:55:09 +0000 (UTC)"],"X-Originating-IP":"2.224.242.101","Date":"Mon, 1 Jul 2019 16:56:26 +0200","From":"Jacopo Mondi ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190701145625.nuhp535fyvb6tlvc@uno.localdomain>","References":"<20190630233817.10130-1-laurent.pinchart@ideasonboard.com>\n\t<20190630233817.10130-3-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\"; boundary=\"crvad3u2cckdsidk\"","Content-Disposition":"inline","In-Reply-To":"<20190630233817.10130-3-laurent.pinchart@ideasonboard.com>","User-Agent":"NeoMutt/20180716","Subject":"Re: [libcamera-devel] [PATCH v3 02/14] libcamera: v4l2_controls:\n\tAdd min and max to V4L2ControlInfo","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Mon, 01 Jul 2019 14:55:10 -0000"}},{"id":2075,"web_url":"https://patchwork.libcamera.org/comment/2075/","msgid":"<20190701155050.GG5018@pendragon.ideasonboard.com>","date":"2019-07-01T15:50:50","subject":"Re: [libcamera-devel] [PATCH v3 02/14] libcamera: v4l2_controls:\n\tAdd min and max to V4L2ControlInfo","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\n\nOn Mon, Jul 01, 2019 at 04:56:26PM +0200, Jacopo Mondi wrote:\n> Hi Laurent,\n> \n> On Mon, Jul 01, 2019 at 02:38:05AM +0300, Laurent Pinchart wrote:\n> > Add min() and max() methods to V4L2ControlInfo to report the control's\n> > minimum and maximum value respectively.\n> >\n> > Signed-off-by: Laurent Pinchart \n> > ---\n> > src/libcamera/include/v4l2_controls.h | 6 ++++++\n> > src/libcamera/v4l2_controls.cpp | 14 ++++++++++++++\n> > 2 files changed, 20 insertions(+)\n> >\n> > diff --git a/src/libcamera/include/v4l2_controls.h b/src/libcamera/include/v4l2_controls.h\n> > index 2c8cb9003f25..0047efab11fa 100644\n> > --- a/src/libcamera/include/v4l2_controls.h\n> > +++ b/src/libcamera/include/v4l2_controls.h\n> > @@ -28,11 +28,17 @@ public:\n> > \tsize_t size() const { return size_; }\n> > \tconst std::string &name() const { return name_; }\n> >\n> > +\tint64_t min() const { return min_; }\n> > +\tint64_t max() const { return max_; }\n> > +\n> > private:\n> > \tunsigned int id_;\n> > \tunsigned int type_;\n> > \tsize_t size_;\n> > \tstd::string name_;\n> > +\n> > +\tint64_t min_;\n> > +\tint64_t max_;\n> > };\n> >\n> > class V4L2Control\n> > diff --git a/src/libcamera/v4l2_controls.cpp b/src/libcamera/v4l2_controls.cpp\n> > index 78888de29642..af017bce48ba 100644\n> > --- a/src/libcamera/v4l2_controls.cpp\n> > +++ b/src/libcamera/v4l2_controls.cpp\n> > @@ -74,6 +74,8 @@ V4L2ControlInfo::V4L2ControlInfo(const struct v4l2_query_ext_ctrl &ctrl)\n> > \ttype_ = ctrl.type;\n> > \tname_ = static_cast(ctrl.name);\n> > \tsize_ = ctrl.elem_size * ctrl.elems;\n> > +\tmin_ = ctrl.minimum;\n> > +\tmax_ = ctrl.maximum;\n> \n> Please note that ctrl.minimum and ctrl.maximum are meaningful only for\n> some of the types the v4l2_device supports at enumeration time\n> \n> \t\tV4L2ControlInfo info(ctrl);\n> \t\tswitch (info.type()) {\n> \t\tcase V4L2_CTRL_TYPE_INTEGER:\n> \t\tcase V4L2_CTRL_TYPE_BOOLEAN:\n> \t\tcase V4L2_CTRL_TYPE_MENU:\n> \t\tcase V4L2_CTRL_TYPE_BUTTON:\n> \t\tcase V4L2_CTRL_TYPE_INTEGER64:\n> \t\tcase V4L2_CTRL_TYPE_BITMASK:\n> \t\tcase V4L2_CTRL_TYPE_INTEGER_MENU:\n> \t\t\tbreak;\n> \t\t/* \\todo Support compound controls. */\n> \t\tdefault:\n> \t\t\tLOG(V4L2, Debug) << \"Control type '\" << info.type()\n> \t\t\t\t\t << \"' not supported\";\n> \t\t\tcontinue;\n> \t\t}\n> \n> \t\tcontrols_.emplace(ctrl.id, info);\n> \n> https://www.kernel.org/doc/html/v5.0/media/uapi/v4l/vidioc-queryctrl.html#c.v4l2_ctrl_type\n> \n> The most problematic one seems to be the BITMASK type, but also for\n> others, the driver might report nothing.\n\nThe V4L2 control framework should report 0 in those cases, so we should\nbe fine. We will have to handle default values and step later, and these\nwill be type-dependent as well, so we may end up reworking this code,\nbut for now I don't think it's a problem.\n\n> That said, if that' fine in your opinion, please have my\n> Reviewed-by: Jacopo Mondi \n> \n> > }\n> >\n> > /**\n> > @@ -100,6 +102,18 @@ V4L2ControlInfo::V4L2ControlInfo(const struct v4l2_query_ext_ctrl &ctrl)\n> > * \\return The V4L2 control user readable name\n> > */\n> >\n> > +/**\n> > + * \\fn V4L2ControlInfo::min()\n> > + * \\brief Retrieve the control minimum value\n> > + * \\return The V4L2 control minimum value\n> > + */\n> > +\n> > +/**\n> > + * \\fn V4L2ControlInfo::max()\n> > + * \\brief Retrieve the control maximum value\n> > + * \\return The V4L2 control maximum value\n> > + */\n> > +\n> > /**\n> > * \\class V4L2Control\n> > * \\brief A V4L2 control value","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CCB7F60BF8\n\tfor ;\n\tMon, 1 Jul 2019 17:51:09 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(dfj612yhrgyx302h3jwwy-3.rev.dnainternet.fi\n\t[IPv6:2001:14ba:21f5:5b00:ce28:277f:58d7:3ca4])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 3E9FE524;\n\tMon, 1 Jul 2019 17:51:09 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1561996269;\n\tbh=uMmoqft3ch7pkGd0qpGvHLByW3LUCN3o1JQrB+GsBEQ=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=rG67ryBQdSQyeGOjAAg6wipEOa3mEgqY/mdIwnHaqw9fm5CVe+mQB9kQ/X8WlsVCn\n\tyFMqIVha0lVhYDffXakQLKN3pG9hw8gEFUBZa9fZ0IA61r/jeiXxD/gqdO/juVx2DP\n\tNdeSrsdSNJmZSkb/y1p1AHXCNcRePVeI8euWbk94=","Date":"Mon, 1 Jul 2019 18:50:50 +0300","From":"Laurent Pinchart ","To":"Jacopo Mondi ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190701155050.GG5018@pendragon.ideasonboard.com>","References":"<20190630233817.10130-1-laurent.pinchart@ideasonboard.com>\n\t<20190630233817.10130-3-laurent.pinchart@ideasonboard.com>\n\t<20190701145625.nuhp535fyvb6tlvc@uno.localdomain>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20190701145625.nuhp535fyvb6tlvc@uno.localdomain>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH v3 02/14] libcamera: v4l2_controls:\n\tAdd min and max to V4L2ControlInfo","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Mon, 01 Jul 2019 15:51:10 -0000"}}]