[{"id":22244,"web_url":"https://patchwork.libcamera.org/comment/22244/","msgid":"<164683991843.123014.18329530919006094667@Monstersaurus>","date":"2022-03-09T15:31:58","subject":"Re: [libcamera-devel] [PATCH] libcamera: Fix typo in a function\n\tname for camera lens class","submitter":{"id":97,"url":"https://patchwork.libcamera.org/api/people/97/","name":"Nicolas Dufresne via libcamera-devel","email":"libcamera-devel@lists.libcamera.org"},"content":"Quoting Jean-Michel Hautbois via libcamera-devel (2022-03-09 15:26:14)\n> The CameraLens class implements a function named \"setFocusPostion\".\n> There is a typo here, fix it.\n> While at it fix it in the IPU3 IPA as it is used only here.\n> \n> Signed-off-by: Jean-Michel Hautbois \n\n\nReviewed-by: Kieran Bingham \n\n> ---\n> include/libcamera/internal/camera_lens.h | 2 +-\n> src/libcamera/camera_lens.cpp | 2 +-\n> src/libcamera/pipeline/ipu3/ipu3.cpp | 2 +-\n> 3 files changed, 3 insertions(+), 3 deletions(-)\n> \n> diff --git a/include/libcamera/internal/camera_lens.h b/include/libcamera/internal/camera_lens.h\n> index 6f2ea1bc..ff4d066e 100644\n> --- a/include/libcamera/internal/camera_lens.h\n> +++ b/include/libcamera/internal/camera_lens.h\n> @@ -24,7 +24,7 @@ public:\n> ~CameraLens();\n> \n> int init();\n> - int setFocusPostion(int32_t position);\n> + int setFocusPosition(int32_t position);\n> \n> const std::string &model() const { return model_; }\n> \n> diff --git a/src/libcamera/camera_lens.cpp b/src/libcamera/camera_lens.cpp\n> index 189cb025..810fcffa 100644\n> --- a/src/libcamera/camera_lens.cpp\n> +++ b/src/libcamera/camera_lens.cpp\n> @@ -84,7 +84,7 @@ int CameraLens::init()\n> *\n> * \\return 0 on success or -EINVAL otherwise\n> */\n> -int CameraLens::setFocusPostion(int32_t position)\n> +int CameraLens::setFocusPosition(int32_t position)\n> {\n> ControlList lensCtrls(subdev_->controls());\n> lensCtrls.set(V4L2_CID_FOCUS_ABSOLUTE, static_cast(position));\n> diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> index 6c5617cd..03259d0e 100644\n> --- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n> +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> @@ -1267,7 +1267,7 @@ void IPU3CameraData::queueFrameAction(unsigned int id,\n> const ControlValue &focusValue =\n> lensControls.get(V4L2_CID_FOCUS_ABSOLUTE);\n> \n> - focusLens->setFocusPostion(focusValue.get());\n> + focusLens->setFocusPosition(focusValue.get());\n> \n> break;\n> }\n> -- \n> 2.32.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 827E1BF415\n\tfor ;\n\tWed, 9 Mar 2022 15:32:03 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C80106118D;\n\tWed, 9 Mar 2022 16:32:02 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8EA3A60475\n\tfor ;\n\tWed, 9 Mar 2022 16:32:01 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 1B2348C4;\n\tWed, 9 Mar 2022 16:32:01 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1646839922;\n\tbh=dRVfC5ck6NZjO7zJf+AOhpzLm99SLAqpH8RIrNU/faQ=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=w5ZAIQiOWHU+gB37p2LsqPVWZ1xn2a8myMH/4pVX7kF1VGAJ60zJzRgcOpXGBO6EB\n\tCo7AIVUgk7YVkMnwcOjiSozH+IKqds5KqefpDWeFkH09VPI46YuQ+yZV2t+uopc0Uh\n\tA2QcmpPeEQK/CbK8lIRySBLXuH26nmJ2uD8ijloICC1DDWfxgAE9/vEZ4ZDdRpCCzg\n\twd5y4O02ORligzmNwrr/aV2DmRPvSfL3vTXhHrLkTW01Nh6oZJUxptBmdzlcx3PQY4\n\tiy9kMWoHmC+Sg0R3XCQEN7KA60badPSyWtTQbFicgq73OOv1BLOPwkUFDkLCfiadLb\n\twJA99IKdJD88g==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1646839921;\n\tbh=dRVfC5ck6NZjO7zJf+AOhpzLm99SLAqpH8RIrNU/faQ=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=sFKkMA35sIWFM2TlDRdmxansGc1qtZpzPZLI9GgQHBivbb8CG4o4w5XAkN6smSO0l\n\ttq25vJUthz1qxxH8feWonzClssIBeBWlc0ZTLJuQ/sKOlji18L1PkSXRKrQakX6Jc1\n\tHAuK+W3GkpAfqrV7ZjZgK4oj2rkWANNnra3IYeEU="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"sFKkMA35\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20220309152614.776224-1-jeanmichel.hautbois@ideasonboard.com>","References":"<20220309152614.776224-1-jeanmichel.hautbois@ideasonboard.com>","To":"Jean-Michel Hautbois ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Wed, 09 Mar 2022 15:31:58 +0000","Message-ID":"<164683991843.123014.18329530919006094667@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH] libcamera: Fix typo in a function\n\tname for camera lens class","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kieran Bingham via libcamera-devel\n\t","Reply-To":"Kieran Bingham ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":22250,"web_url":"https://patchwork.libcamera.org/comment/22250/","msgid":"","date":"2022-03-09T15:59:47","subject":"Re: [libcamera-devel] [PATCH] libcamera: Fix typo in a function\n\tname for camera lens class","submitter":{"id":97,"url":"https://patchwork.libcamera.org/api/people/97/","name":"Nicolas Dufresne via libcamera-devel","email":"libcamera-devel@lists.libcamera.org"},"content":"On Wed, Mar 09, 2022 at 03:31:58PM +0000, Kieran Bingham via libcamera-devel wrote:\n> Quoting Jean-Michel Hautbois via libcamera-devel (2022-03-09 15:26:14)\n> > The CameraLens class implements a function named \"setFocusPostion\".\n> > There is a typo here, fix it.\n> > While at it fix it in the IPU3 IPA as it is used only here.\n\nIt's not really \"while at it\", if you didn't compilation would fail :-)\nI'd drop this last sentence.\n\n> > Signed-off-by: Jean-Michel Hautbois \n> \n> Reviewed-by: Kieran Bingham \n\nLikewise,\n\nReviewed-by: Laurent Pinchart \n\n> > ---\n> > include/libcamera/internal/camera_lens.h | 2 +-\n> > src/libcamera/camera_lens.cpp | 2 +-\n> > src/libcamera/pipeline/ipu3/ipu3.cpp | 2 +-\n> > 3 files changed, 3 insertions(+), 3 deletions(-)\n> > \n> > diff --git a/include/libcamera/internal/camera_lens.h b/include/libcamera/internal/camera_lens.h\n> > index 6f2ea1bc..ff4d066e 100644\n> > --- a/include/libcamera/internal/camera_lens.h\n> > +++ b/include/libcamera/internal/camera_lens.h\n> > @@ -24,7 +24,7 @@ public:\n> > ~CameraLens();\n> > \n> > int init();\n> > - int setFocusPostion(int32_t position);\n> > + int setFocusPosition(int32_t position);\n> > \n> > const std::string &model() const { return model_; }\n> > \n> > diff --git a/src/libcamera/camera_lens.cpp b/src/libcamera/camera_lens.cpp\n> > index 189cb025..810fcffa 100644\n> > --- a/src/libcamera/camera_lens.cpp\n> > +++ b/src/libcamera/camera_lens.cpp\n> > @@ -84,7 +84,7 @@ int CameraLens::init()\n> > *\n> > * \\return 0 on success or -EINVAL otherwise\n> > */\n> > -int CameraLens::setFocusPostion(int32_t position)\n> > +int CameraLens::setFocusPosition(int32_t position)\n> > {\n> > ControlList lensCtrls(subdev_->controls());\n> > lensCtrls.set(V4L2_CID_FOCUS_ABSOLUTE, static_cast(position));\n> > diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> > index 6c5617cd..03259d0e 100644\n> > --- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n> > +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> > @@ -1267,7 +1267,7 @@ void IPU3CameraData::queueFrameAction(unsigned int id,\n> > const ControlValue &focusValue =\n> > lensControls.get(V4L2_CID_FOCUS_ABSOLUTE);\n> > \n> > - focusLens->setFocusPostion(focusValue.get());\n> > + focusLens->setFocusPosition(focusValue.get());\n> > \n> > break;\n> > }","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 40798BE08A\n\tfor ;\n\tWed, 9 Mar 2022 16:00:05 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A45856118B;\n\tWed, 9 Mar 2022 17:00:04 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 78E4360475\n\tfor ;\n\tWed, 9 Mar 2022 17:00:03 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 071348C4;\n\tWed, 9 Mar 2022 17:00:01 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1646841604;\n\tbh=ml9Apm2xAkP+xvWaEP9DU8F+u+qLPnRUGzAMBn1pyeY=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=HJedKIS0hmlkaKCSRLKztlbEy6IPEUr1QtKwsKdi6M2OeO3c2kJ0q2NJkm2KGVH7V\n\tDoKZPi/xRhnjadU1/ThNu8ZZfiyOh4Co+NPpnXU5f5hV9vf0y5NjocJPahB9YhiuQx\n\toajCKRsMj3YuwPZuh97J8yB5FLf/ppfjA4tF5ZUMiBk5gNNfeDh5uGb9i6aryNuxBt\n\tgeSdmpG1N4TbE3Q6AqoKH5K9PU7/GZpqtDr6t7n8jTDU23uWqAroZgiqNp+lrsH2jQ\n\tdF0jpkjwu3UMiCBZZ1b6VPUfz+51Sfin1/VHF/ZQ+qPvCBCXMbx75ihVpCgH/spEez\n\tY+FiDqI33/Ckg==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1646841602;\n\tbh=ml9Apm2xAkP+xvWaEP9DU8F+u+qLPnRUGzAMBn1pyeY=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=pD7y37kGBnNs7J/kFMQ9xUxGNhBU632OtKb4PS5Jgtt24qQH8b+845sn62UIY4QI+\n\tXenDEdegsZM/82DLISR7BOnu5CXZihIzZ8/9NhSbxTRmB7e6AdD0kRyGe+r29ksu5Z\n\tjVFMj6thSGnmeGl65Us9P1i8poZVl0nasnuz8IYc="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"pD7y37kG\"; dkim-atps=neutral","Date":"Wed, 9 Mar 2022 17:59:47 +0200","To":"Kieran Bingham ","Message-ID":"","References":"<20220309152614.776224-1-jeanmichel.hautbois@ideasonboard.com>\n\t<164683991843.123014.18329530919006094667@Monstersaurus>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<164683991843.123014.18329530919006094667@Monstersaurus>","Subject":"Re: [libcamera-devel] [PATCH] libcamera: Fix typo in a function\n\tname for camera lens class","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]