{"id":15433,"url":"https://patchwork.libcamera.org/api/patches/15433/?format=json","web_url":"https://patchwork.libcamera.org/patch/15433/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20220308091520.34607-2-umang.jain@ideasonboard.com>","date":"2022-03-08T09:15:19","name":"[libcamera-devel,1/2] ipa: rkisp1: Drop private exposure and gain limits","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"69baf7693426f2987676b645b6a21d211d74d0cc","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/?format=json","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"delegate":{"id":12,"url":"https://patchwork.libcamera.org/api/users/12/?format=json","username":"uajain","first_name":"Umang","last_name":"Jain","email":"umang.jain@ideasonboard.com"},"mbox":"https://patchwork.libcamera.org/patch/15433/mbox/","series":[{"id":2955,"url":"https://patchwork.libcamera.org/api/series/2955/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2955","date":"2022-03-08T09:15:18","name":"ipa: rkisp1: Replace event-based ops with dedicated functions","version":1,"mbox":"https://patchwork.libcamera.org/series/2955/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/15433/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/15433/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\r\n\t[92.243.16.209])\r\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1526BBF415\r\n\tfor ;\r\n\tTue, 8 Mar 2022 09:15:37 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\r\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C7A626118D;\r\n\tTue, 8 Mar 2022 10:15:36 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\r\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\r\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3F58C604E9\r\n\tfor ;\r\n\tTue, 8 Mar 2022 10:15:34 +0100 (CET)","from perceval.ideasonboard.com (unknown [103.251.226.72])\r\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 4AD28488;\r\n\tTue, 8 Mar 2022 10:15:33 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\r\n\ts=mail; t=1646730936;\r\n\tbh=M9PmQ2YtILsBpoEt+K2LHsNLnfIj8YSeQ142ZN9DJHc=;\r\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\r\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\r\n\tFrom;\r\n\tb=AuEj51MR+IpY85S8wvQYa1rRgwxqiEPXgaK8o7KJXcmwc+fcF97enzIMftuo/IEC/\r\n\tS4dd0P9yTEqwAWSC7+wlH5LsByo+ZQb7z9MkFmHtgj1HEokDv5KEYlUTIWVmSnSlct\r\n\tbiSIeTPX7u0Sn8/xsqFBVtnSlElsXDjTltX3ZIougcwkCkHq2o155TFNjs8RdtW+97\r\n\tLmw4P3kC6DlRRDN4LKwk4jDkruP0viu5kD5skjAwpsjNN/IjuAcc3znYFgSAgxRohC\r\n\tz2bIGEshqzctZL2GEFhHN3NEIgThp5yGY0E9V4G0avviIh5LW2l9Ah1KMehEsiDzwK\r\n\tbgz/A7imDe9Ew==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\r\n\ts=mail; t=1646730934;\r\n\tbh=M9PmQ2YtILsBpoEt+K2LHsNLnfIj8YSeQ142ZN9DJHc=;\r\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\r\n\tb=baGe7POkuARZgv0RxNK4cd4qiT7zHE+lQiFg45DoaUqOvdM37D3EsiH5dsxT8U10g\r\n\tmkDUp5Dwg4+CicMPLj4cbrHEQE4VNlQNFxG5EkS02OO/eMXJeOa/RG0pJxrLFOAM4u\r\n\td9DBejgRdtgvXlAvSxs8YysNwvduEAyos1tZN1Wc="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \r\n\tunprotected) header.d=ideasonboard.com\r\n\theader.i=@ideasonboard.com\r\n\theader.b=\"baGe7POk\"; dkim-atps=neutral","To":"libcamera-devel@lists.libcamera.org","Date":"Tue, 8 Mar 2022 14:45:19 +0530","Message-Id":"<20220308091520.34607-2-umang.jain@ideasonboard.com>","X-Mailer":"git-send-email 2.31.1","In-Reply-To":"<20220308091520.34607-1-umang.jain@ideasonboard.com>","References":"<20220308091520.34607-1-umang.jain@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH 1/2] ipa: rkisp1: Drop private exposure\r\n\tand gain limits","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\r\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\r\n\t","From":"Umang Jain via libcamera-devel ","Reply-To":"Umang Jain ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The private members of exposure and gain limits can be dropped\nfrom IPARkISP1 since they are not used class-wide and can be easily\nreplaced by local counter-parts.\n\nIn case they are required to be widely available, these should then\nsit in IPASessionConfiguration.\n\nSigned-off-by: Umang Jain \n---\n src/ipa/rkisp1/rkisp1.cpp | 24 ++++++++++--------------\n 1 file changed, 10 insertions(+), 14 deletions(-)","diff":"diff --git a/src/ipa/rkisp1/rkisp1.cpp b/src/ipa/rkisp1/rkisp1.cpp\r\nindex 2d79f15f..129afddd 100644\r\n--- a/src/ipa/rkisp1/rkisp1.cpp\r\n+++ b/src/ipa/rkisp1/rkisp1.cpp\r\n@@ -69,10 +69,6 @@ private:\r\n \r\n \t/* Camera sensor controls. */\r\n \tbool autoExposure_;\r\n-\tuint32_t minExposure_;\r\n-\tuint32_t maxExposure_;\r\n-\tuint32_t minGain_;\r\n-\tuint32_t maxGain_;\r\n \r\n \t/* revision-specific data */\r\n \trkisp1_cif_isp_version hwRevision_;\r\n@@ -166,15 +162,15 @@ int IPARkISP1::configure([[maybe_unused]] const IPACameraSensorInfo &info,\r\n \r\n \tautoExposure_ = true;\r\n \r\n-\tminExposure_ = itExp->second.min().get();\r\n-\tmaxExposure_ = itExp->second.max().get();\r\n+\tint32_t minExposure = itExp->second.min().get();\r\n+\tint32_t maxExposure = itExp->second.max().get();\r\n \r\n-\tminGain_ = itGain->second.min().get();\r\n-\tmaxGain_ = itGain->second.max().get();\r\n+\tint32_t minGain = itGain->second.min().get();\r\n+\tint32_t maxGain = itGain->second.max().get();\r\n \r\n \tLOG(IPARkISP1, Info)\r\n-\t\t<< \"Exposure: \" << minExposure_ << \"-\" << maxExposure_\r\n-\t\t<< \" Gain: \" << minGain_ << \"-\" << maxGain_;\r\n+\t\t<< \"Exposure: \" << minExposure << \"-\" << maxExposure\r\n+\t\t<< \" Gain: \" << minGain << \"-\" << maxGain;\r\n \r\n \t/* Clean context at configuration */\r\n \tcontext_ = {};\r\n@@ -191,10 +187,10 @@ int IPARkISP1::configure([[maybe_unused]] const IPACameraSensorInfo &info,\r\n \t *\r\n \t * \\todo take VBLANK into account for maximum shutter speed\r\n \t */\r\n-\tcontext_.configuration.agc.minShutterSpeed = minExposure_ * context_.configuration.sensor.lineDuration;\r\n-\tcontext_.configuration.agc.maxShutterSpeed = maxExposure_ * context_.configuration.sensor.lineDuration;\r\n-\tcontext_.configuration.agc.minAnalogueGain = camHelper_->gain(minGain_);\r\n-\tcontext_.configuration.agc.maxAnalogueGain = camHelper_->gain(maxGain_);\r\n+\tcontext_.configuration.agc.minShutterSpeed = minExposure * context_.configuration.sensor.lineDuration;\r\n+\tcontext_.configuration.agc.maxShutterSpeed = maxExposure * context_.configuration.sensor.lineDuration;\r\n+\tcontext_.configuration.agc.minAnalogueGain = camHelper_->gain(minGain);\r\n+\tcontext_.configuration.agc.maxAnalogueGain = camHelper_->gain(maxGain);\r\n \r\n \tfor (auto const &algo : algorithms_) {\r\n \t\tint ret = algo->configure(context_, info);","prefixes":["libcamera-devel","1/2"]}