{"id":15428,"url":"https://patchwork.libcamera.org/api/patches/15428/?format=json","web_url":"https://patchwork.libcamera.org/patch/15428/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20220307124633.115452-4-naush@raspberrypi.com>","date":"2022-03-07T12:46:30","name":"[libcamera-devel,v1,3/6] pipeline: raspberrypi: Free buffers in the RPiCamera destructor and re-configure","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"8bd3ccc97df4d8b565289401b42d8e7abaf79a38","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/?format=json","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/15428/mbox/","series":[{"id":2954,"url":"https://patchwork.libcamera.org/api/series/2954/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2954","date":"2022-03-07T12:46:27","name":"Raspberry Pi: Efficient start/stop/start sequences","version":1,"mbox":"https://patchwork.libcamera.org/series/2954/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/15428/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/15428/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\r\n\t[92.243.16.209])\r\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C57C5C3261\r\n\tfor ;\r\n\tMon, 7 Mar 2022 12:46:44 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\r\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 87F796118E;\r\n\tMon, 7 Mar 2022 13:46:44 +0100 (CET)","from mail-wm1-x335.google.com (mail-wm1-x335.google.com\r\n\t[IPv6:2a00:1450:4864:20::335])\r\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 69E2F6118D\r\n\tfor ;\r\n\tMon, 7 Mar 2022 13:46:41 +0100 (CET)","by mail-wm1-x335.google.com with SMTP id\r\n\tm42-20020a05600c3b2a00b00382ab337e14so10083243wms.3\r\n\tfor ;\r\n\tMon, 07 Mar 2022 04:46:41 -0800 (PST)","from naush-laptop.pitowers.org\r\n\t([2a00:1098:3142:14:c644:e9b3:de0b:54c5])\r\n\tby smtp.gmail.com with ESMTPSA id\r\n\tz6-20020a1cf406000000b0037c4e2d3baesm19759582wma.19.2022.03.07.04.46.40\r\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\r\n\tMon, 07 Mar 2022 04:46:40 -0800 (PST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\r\n\ts=mail; t=1646657204;\r\n\tbh=Ny4pRakMea6WwmHE/ip3My7NZuljg35QW0IflMAlaAY=;\r\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\r\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\r\n\tFrom;\r\n\tb=02JSk1F/C/0yJgsBzLhmaJAYiZpUrPzqw8bidVHACk2YUPmgxhgrlmx/6A3XfIsFn\r\n\t4ft1p1q1t8Rjt6wsHp3mPDU79pj+WN0aGZXeMFUF1M1FZ17enHHDW2eIKJOAnvVTd4\r\n\tp7sBivsl70qXcI8BdCLP6DH9IbFprJQ6zyl4/vCwsyJLLG8Zagd2fnAQwhF2Ljm9tE\r\n\tsACN+qgwAg7nmr1KABihebxZUzDDZNMUrg5LtynySm2oOqsYiY1FoboSJxZmaGsTMq\r\n\te+zKYj1auhdMQ91bBxpxFYovLK5VheroIcfV41jp30QhjswQhyPVfLqGG65y610Zx1\r\n\ttjJqBIuzcTm2w==","v=1; a=rsa-sha256; c=relaxed/relaxed;\r\n\td=raspberrypi.com; s=google;\r\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\r\n\t:mime-version:content-transfer-encoding;\r\n\tbh=hlaMJcXVUCEb9tdJXTlISVfKaEdBnc5bcEQgwsCnoqA=;\r\n\tb=gJbUeA8aBoq0NPOhNRuKUyKjHEJUt19Lb+xzjzROFNTlIBgvC0nDy+ZYWgBOWhSnSD\r\n\tJacqFvXM4fogQti7l/gGYpNtySSqzuLxk7GqubBsAm9JhOnNhPoUW1qSoelj69S2++ax\r\n\tN37xxqLyePtrUmjmGSdD2cFxgwobTtg3/NCrKWALYZmFfbgEJDRyHOZc1Jry328SZN5L\r\n\ts07nEIfCuk1JyjNLGyH1nd6i47lr+8y5ReI11K6cDU0DCu5ZTJSwzyeimVzb8C3K5Y6F\r\n\thF06l4ulaOVdmG8fm7b7lgWDsyz0XhDwl4aDXMXhO172uIYKWFSklXwd05RUv/0o/bBe\r\n\t63Cw=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \r\n\tunprotected) header.d=raspberrypi.com\r\n\theader.i=@raspberrypi.com\r\n\theader.b=\"gJbUeA8a\"; dkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\r\n\td=1e100.net; s=20210112;\r\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\r\n\t:references:mime-version:content-transfer-encoding;\r\n\tbh=hlaMJcXVUCEb9tdJXTlISVfKaEdBnc5bcEQgwsCnoqA=;\r\n\tb=JsCVZVFScwcutrkTt8a8os1wOJ5larIrPB54d/4+IG22Kx/q99y8mmcPDkGKvFyE1e\r\n\tIWwA9lMOQ6klLHx2I7mCQBnxnvERLou2y0RSaCV8TKMQNKkbleTq51ud/IcduzOnsu+/\r\n\tHCwyXpRuYkJliW5ismhjksE3q5Dnx79LIlCHzfRucvWTUkmrmzPLL2rQZ45YdesOx2C1\r\n\tudf4a/D8JQWz9FGx/+Nm/6wL2WccrgypYLzUHR4HI4nZv6Quq6+9m1/EhuHqZ+wiudfh\r\n\tIXOct6gXeJ8vlEfd8VsGaru8pdXwqT0mtliU+QLmU1yVrJR98dV/zyE/PIFxFVQN6J8g\r\n\tqf8A==","X-Gm-Message-State":"AOAM533Z8QglRa78M3YPE6wDY64L7YvxAWiQNefy2FjCVpgnNMrb9Z3Z\r\n\t5ptQrTy3kLj1bsasjeH3lYCbezeE5G04PA==","X-Google-Smtp-Source":"ABdhPJzqOd1E3i6pfIhSxg1uBHCV03uLDuc0Re2ZmlJTJbVZE432npcqjvmy091n9tCGw/5VXWfKLA==","X-Received":"by 2002:a7b:c19a:0:b0:381:8495:9dd with SMTP id\r\n\ty26-20020a7bc19a000000b00381849509ddmr18282751wmi.33.1646657200753; \r\n\tMon, 07 Mar 2022 04:46:40 -0800 (PST)","To":"libcamera-devel@lists.libcamera.org","Date":"Mon, 7 Mar 2022 12:46:30 +0000","Message-Id":"<20220307124633.115452-4-naush@raspberrypi.com>","X-Mailer":"git-send-email 2.25.1","In-Reply-To":"<20220307124633.115452-1-naush@raspberrypi.com>","References":"<20220307124633.115452-1-naush@raspberrypi.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v1 3/6] pipeline: raspberrypi: Free\r\n\tbuffers in the RPiCamera destructor and re-configure","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\r\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\r\n\t","From":"Naushir Patuck via libcamera-devel\r\n\t","Reply-To":"Naushir Patuck ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Currently, all framebuffer allocations get freed and cleared on a stop in\nPipelineHandlerRPi::stopDevice(). If PipelineHandlerRPi::start() is then called\nwithout an intermediate PipelineHandlerRPi::configure(), it will re-allocate and\nprepare all the buffers again, which is unnecessary.\n\nFix this by not freeing the buffer in PipelineHandlerRPi::stopDevice(), but\ninsted doing it in PipelineHandlerRPi::configure(), as the buffers might have\nto be resized.\n\nSigned-off-by: Naushir Patuck \n---\n src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 10 +++++++---\n 1 file changed, 7 insertions(+), 3 deletions(-)","diff":"diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\r\nindex 3781e4e0e3c4..8bb9fc429912 100644\r\n--- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\r\n+++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\r\n@@ -189,6 +189,11 @@ public:\r\n \t{\r\n \t}\r\n \r\n+\t~RPiCameraData()\r\n+\t{\r\n+\t\tfreeBuffers();\r\n+\t}\r\n+\r\n \tvoid freeBuffers();\r\n \tvoid frameStarted(uint32_t sequence);\r\n \r\n@@ -681,7 +686,8 @@ int PipelineHandlerRPi::configure(Camera *camera, CameraConfiguration *config)\r\n \tRPiCameraData *data = cameraData(camera);\r\n \tint ret;\r\n \r\n-\t/* Start by resetting the Unicam and ISP stream states. */\r\n+\t/* Start by freeing all buffers and resetting the Unicam and ISP stream states. */\r\n+\tdata->freeBuffers();\r\n \tfor (auto const stream : data->streams_)\r\n \t\tstream->reset();\r\n \r\n@@ -1048,8 +1054,6 @@ void PipelineHandlerRPi::stopDevice(Camera *camera)\r\n \r\n \t/* Stop the IPA. */\r\n \tdata->ipa_->stop();\r\n-\r\n-\tdata->freeBuffers();\r\n }\r\n \r\n int PipelineHandlerRPi::queueRequestDevice(Camera *camera, Request *request)","prefixes":["libcamera-devel","v1","3/6"]}