[{"id":22243,"web_url":"https://patchwork.libcamera.org/comment/22243/","msgid":"","date":"2022-03-09T15:17:06","subject":"Re: [libcamera-devel] [PATCH v5 9/9] ipa: ipu3: Send lens controls\n\tto pipeline handler","submitter":{"id":97,"url":"https://patchwork.libcamera.org/api/people/97/","name":"Nicolas Dufresne via libcamera-devel","email":"libcamera-devel@lists.libcamera.org"},"content":"Hi !\n\nThanks for the patch !\n\nOn 04/03/2022 00:49, Daniel Scally wrote:\n> Pick up the focus value from the AF algorithm and send lens controls\n> along in the frame context.\n> \n> Reviewed-by: Laurent Pinchart \n> Signed-off-by: Daniel Scally \n\nReviewed-by: Jean-Michel Hautbois \n\n> ---\n> Changes in v5:\n> \n> \t- None\n> \n> Changes in v4:\n> \n> \t- Got rid of the focus variable (Laurent)\n> \n> Changes in v3:\n> \n> \t- Replaced the new focus_ member with a local variable.\n> \n> src/ipa/ipu3/ipu3.cpp | 5 +++++\n> 1 file changed, 5 insertions(+)\n> \n> diff --git a/src/ipa/ipu3/ipu3.cpp b/src/ipa/ipu3/ipu3.cpp\n> index e539d875..b8c4b30f 100644\n> --- a/src/ipa/ipu3/ipu3.cpp\n> +++ b/src/ipa/ipu3/ipu3.cpp\n> @@ -704,6 +704,11 @@ void IPAIPU3::setControls(unsigned int frame)\n> \tctrls.set(V4L2_CID_ANALOGUE_GAIN, static_cast(gain_));\n> \top.sensorControls = ctrls;\n> \n> +\tControlList lensCtrls(lensCtrls_);\n> +\tlensCtrls.set(V4L2_CID_FOCUS_ABSOLUTE,\n> +\t\t static_cast(context_.frameContext.af.focus));\n> +\top.lensControls = lensCtrls;\n> +\n> \tqueueFrameAction.emit(frame, op);\n> }\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1A92CBF415\n\tfor ;\n\tWed, 9 Mar 2022 15:17:10 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C9ABE61189;\n\tWed, 9 Mar 2022 16:17:09 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6F24860475\n\tfor ;\n\tWed, 9 Mar 2022 16:17:08 +0100 (CET)","from [IPV6:2a01:e0a:169:7140:3734:287e:1a7f:9772] (unknown\n\t[IPv6:2a01:e0a:169:7140:3734:287e:1a7f:9772])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 320578C4;\n\tWed, 9 Mar 2022 16:17:08 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1646839029;\n\tbh=gaQvy387ni5nIBmswAVqYjZhPfLeU8OvoFyxDX1F/tw=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=DIwf7TQc2VDtHjs2ETr8kcATeFbV4kcNQg0O8d8gnBAuEyYvYJpJbHsDGysPpq7EE\n\thNIVK/4EGCOM6LTYHHDyWewEf6Se1n0rj9m64ZQNwQz/i1LfeqfNJSZWllIRs5xt+8\n\tjDXdrOuavwN3yNs3i2ptkhb0zcjjUXsq31O0/BKqW3CEl8oJicEsKOc98jkN1CiERF\n\t5cT7o0+/qQxOC1N7nW9t5RYNwkeHD8SYNRAolwLy5MHyiGvnzEV9t61DAa1M8ggAbM\n\tcIj5dVrxWYQDKeSJCzCBpmDp36BDZtWendFAkSy1gvJdVveC9xWoSayYUe/d6Hxu82\n\tXn9TqRLvOaUvw==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1646839028;\n\tbh=gaQvy387ni5nIBmswAVqYjZhPfLeU8OvoFyxDX1F/tw=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=VCfAT2e+kOoCIc52WtHbPTjdNodoCDBwedAfZV+27noz9StXS5wrl1Qh+oTVcC8Kt\n\tbO0rq4sLgP1PpTxSUdd91WfC9BmVsyHgCuvMbroJFVeXJaigWYk42Ab9cC9RT3fKpa\n\tkl11Mmx3BQaR3Tygzi2eZjMQYoxmgSX9WfKlVJWA="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"VCfAT2e+\"; dkim-atps=neutral","Message-ID":"","Date":"Wed, 9 Mar 2022 16:17:06 +0100","MIME-Version":"1.0","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101\n\tThunderbird/91.5.0","Content-Language":"en-US","To":"Daniel Scally , libcamera-devel@lists.libcamera.org","References":"<20220303234956.1463551-1-djrscally@gmail.com>\n\t<20220303234956.1463551-10-djrscally@gmail.com>","In-Reply-To":"<20220303234956.1463551-10-djrscally@gmail.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH v5 9/9] ipa: ipu3: Send lens controls\n\tto pipeline handler","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Jean-Michel Hautbois via libcamera-devel\n\t","Reply-To":"Jean-Michel Hautbois ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]