[{"id":22242,"web_url":"https://patchwork.libcamera.org/comment/22242/","msgid":"<38b68977-1fc9-5610-24c6-c0c177f6536d@ideasonboard.com>","date":"2022-03-09T15:16:34","subject":"Re: [libcamera-devel] [PATCH v5 8/9] libcamera: ipu3: Pass lens\n\tcontrols to config info","submitter":{"id":97,"url":"https://patchwork.libcamera.org/api/people/97/","name":"Nicolas Dufresne via libcamera-devel","email":"libcamera-devel@lists.libcamera.org"},"content":"Hi !\n\nThanks for the patch !\n\nOn 04/03/2022 00:49, Daniel Scally wrote:\n> When configuring the pipeline we want to share the controls for any\n> VCM device against the sensor too - pass them to the lensControls\n> member of configInfo\n> \n> Reviewed-by: Laurent Pinchart \n> Signed-off-by: Daniel Scally \n\nReviewed-by: Jean-Michel Hautbois \n\n> ---\n> Changes in v5:\n> \n> \t- None\n> \n> Changes in v4:\n> \n> \t- None\n> \n> Changes in v3:\n> \n> \t- None\n> \n> src/libcamera/pipeline/ipu3/ipu3.cpp | 5 +++++\n> 1 file changed, 5 insertions(+)\n> \n> diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> index 6c5617cd..b3199aec 100644\n> --- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n> +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> @@ -660,6 +660,11 @@ int PipelineHandlerIPU3::configure(Camera *camera, CameraConfiguration *c)\n> \n> \tipa::ipu3::IPAConfigInfo configInfo;\n> \tconfigInfo.sensorControls = data->cio2_.sensor()->controls();\n> +\n> +\tCameraLens *lens = data->cio2_.sensor()->focusLens();\n> +\tif (lens)\n> +\t\tconfigInfo.lensControls = lens->controls();\n> +\n> \tconfigInfo.sensorInfo = sensorInfo;\n> \tconfigInfo.bdsOutputSize = config->imguConfig().bds;\n> \tconfigInfo.iif = config->imguConfig().iif;","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id ADC80BF415\n\tfor ;\n\tWed, 9 Mar 2022 15:16:39 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 66F346118B;\n\tWed, 9 Mar 2022 16:16:39 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0A8D460475\n\tfor ;\n\tWed, 9 Mar 2022 16:16:38 +0100 (CET)","from [IPV6:2a01:e0a:169:7140:3734:287e:1a7f:9772] (unknown\n\t[IPv6:2a01:e0a:169:7140:3734:287e:1a7f:9772])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B85258C4;\n\tWed, 9 Mar 2022 16:16:37 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1646838999;\n\tbh=BDUml0mRbnbrQNlIkMY5By/TJCDbSp+R2g2ZbSZhthA=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=RZrHb4urcSoVhSvw2YBod9hM6hEKiIMwYlm7s6qY6IUfHvSdf2RRomARWYoERRC0k\n\twJGS44yvl3+36woqsvtQi8BiBxsb5gC1MvUimGHA0GCRm97z0bhYFWo5oqOEqZdmor\n\txK3IQUPmGm0kWENYSQlPI3tjs/wcOa8sPRgXgABtup3IdKoX1qvkwKBVmweWFJNPit\n\tIqsLjSYfzMHJXQs87fIMRNhaLSK1rOzK7zS7ut1CoYduTLgiHFPqS5qRDfULYlcHDG\n\t3EdTj+EOoKwKaBiR8ZYOIsLl8lOERx/5zV4ZqQBTaJN7M+8O4yConXhv57m48wteVI\n\ti+4xLsTNsVqmQ==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1646838997;\n\tbh=BDUml0mRbnbrQNlIkMY5By/TJCDbSp+R2g2ZbSZhthA=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=fYfPaQqWcmO+U7ynMeILoPNbRygKbP4RaFUY3l6PpzghpixDkMUr2llRR2fHNmYdZ\n\tIcHZCIa6GfLseDAgzkcjRceQatCWEF9oLyJITgS1/Ekgh2RHGlsX0gwjDt/3nmNC1F\n\t9HqooWMe9xOqzYdcQnrnii20e5qpTIvhpEiQlJLc="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"fYfPaQqW\"; dkim-atps=neutral","Message-ID":"<38b68977-1fc9-5610-24c6-c0c177f6536d@ideasonboard.com>","Date":"Wed, 9 Mar 2022 16:16:34 +0100","MIME-Version":"1.0","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101\n\tThunderbird/91.5.0","Content-Language":"en-US","To":"Daniel Scally , libcamera-devel@lists.libcamera.org","References":"<20220303234956.1463551-1-djrscally@gmail.com>\n\t<20220303234956.1463551-9-djrscally@gmail.com>","In-Reply-To":"<20220303234956.1463551-9-djrscally@gmail.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH v5 8/9] libcamera: ipu3: Pass lens\n\tcontrols to config info","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Jean-Michel Hautbois via libcamera-devel\n\t","Reply-To":"Jean-Michel Hautbois ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]