{"id":15415,"url":"https://patchwork.libcamera.org/api/patches/15415/?format=json","web_url":"https://patchwork.libcamera.org/patch/15415/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20220303234956.1463551-9-djrscally@gmail.com>","date":"2022-03-03T23:49:55","name":"[libcamera-devel,v5,8/9] libcamera: ipu3: Pass lens controls to config info","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"1f8a95176183ecb5ff6ac7688592ddb3330fe5a5","submitter":{"id":90,"url":"https://patchwork.libcamera.org/api/people/90/?format=json","name":"Daniel Scally","email":"djrscally@gmail.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/15415/mbox/","series":[{"id":2950,"url":"https://patchwork.libcamera.org/api/series/2950/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2950","date":"2022-03-03T23:49:47","name":"Enumerate CameraLens by following sensor's ancillary links","version":5,"mbox":"https://patchwork.libcamera.org/series/2950/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/15415/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/15415/checks/","tags":{},"headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 37762C3261\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu,  3 Mar 2022 23:50:24 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D219D6118A;\n\tFri,  4 Mar 2022 00:50:23 +0100 (CET)","from mail-wr1-x42f.google.com (mail-wr1-x42f.google.com\n\t[IPv6:2a00:1450:4864:20::42f])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 573626118A\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri,  4 Mar 2022 00:50:18 +0100 (CET)","by mail-wr1-x42f.google.com with SMTP id u10so8512792wra.9\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 03 Mar 2022 15:50:18 -0800 (PST)","from localhost.localdomain\n\t(cpc141996-chfd3-2-0-cust928.12-3.cable.virginm.net. [86.13.91.161])\n\tby smtp.gmail.com with ESMTPSA id\n\ty4-20020adff144000000b001f022290737sm3079779wro.6.2022.03.03.15.50.17\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 03 Mar 2022 15:50:17 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"R6w+3yMG\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=+daEI5+GW8ZpSPL+i4m+9fBs1QBP6dqnssl9Ql77R8Q=;\n\tb=R6w+3yMGeyLDx1eYKAGv4i88527ewRrXR4SOt5sFEfAwjjBePqBac8uinj5+X/+s11\n\t3r1X0O+8y/H6vneD6mtnEP+3AluNzlrweKB++FKv5fdKAAd6jSAJ4b+N7MRNDSJtNRYd\n\ttkee4eSZCai17Q1JawiNLY1+RHKyIkiIIO6hFIYDzkiGH8X+EROJxZNgpVAGwQOcVGRQ\n\t78IzizntuMS/3wPF87556D71C/179nSCljKjO+0WXr4vfIjmCpXLmehYpwt9ZHTZya9n\n\t7P6AyeJgVczc7VGiqbM7Zdg7GTLcTpWfIk2hI0V6L7q5sKRKhPpkftkA5rNO2nv4wGTq\n\tgohw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=+daEI5+GW8ZpSPL+i4m+9fBs1QBP6dqnssl9Ql77R8Q=;\n\tb=DuWdo3nP2xkNgOWaEPd4fAe6bvQWkJVv8XjA53fq+PCOqKgJgfp0MhRsZUa4yfmTh9\n\tuxxrmtjdIoq9A5vAORkvST6uzAHWlGpoflD5MPGNQbhfA6InKG8VWmoA7blWF55S5GuG\n\tCDdIms0MsrtlcNsANRvYja2+Vi9DVpAvA8AIUM5Eo+6NA1fCiRiOSh+cnVtTnvjJNqCC\n\tAQBSmI4SR67o/zbcw9TMfgnss9fnVaDxlxBUgZ3YEcwEWPD6YlgMCGF564MDE+4lnWrv\n\tYIO9g8OI7+jRbHd5TwhU+r8m3qIWS9XBXEVb+MsygudbjG6fmjoUt9ZOr4sgkbrt4RZK\n\tRq0w==","X-Gm-Message-State":"AOAM53246h/PWbpVo7B9790INNFWRAR1f1oJuV78wambgv0wrnNmLGKL\n\tC0iIYgtLnjFcqwMyVS/Z5Q6KkvsEB676+Q==","X-Google-Smtp-Source":"ABdhPJxo1zLyH/LqNLukmKP7KvzndkeaaibTn6Le85J46YHUR9iMcTOjBUHrvyO6Zv9gQJj9Ub5nkw==","X-Received":"by 2002:a05:6000:1c01:b0:1ef:95c5:4dd6 with SMTP id\n\tba1-20020a0560001c0100b001ef95c54dd6mr19178732wrb.671.1646351418114; \n\tThu, 03 Mar 2022 15:50:18 -0800 (PST)","From":"Daniel Scally <djrscally@gmail.com>","To":"libcamera-devel@lists.libcamera.org","Date":"Thu,  3 Mar 2022 23:49:55 +0000","Message-Id":"<20220303234956.1463551-9-djrscally@gmail.com>","X-Mailer":"git-send-email 2.25.1","In-Reply-To":"<20220303234956.1463551-1-djrscally@gmail.com>","References":"<20220303234956.1463551-1-djrscally@gmail.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v5 8/9] libcamera: ipu3: Pass lens\n\tcontrols to config info","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"},"content":"When configuring the pipeline we want to share the controls for any\nVCM device against the sensor too - pass them to the lensControls\nmember of configInfo\n\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nSigned-off-by: Daniel Scally <djrscally@gmail.com>\n---\nChanges in v5:\n\n\t- None\n\nChanges in v4:\n\n\t- None\n\nChanges in v3:\n\n\t- None\n\n src/libcamera/pipeline/ipu3/ipu3.cpp | 5 +++++\n 1 file changed, 5 insertions(+)","diff":"diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\nindex 6c5617cd..b3199aec 100644\n--- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n+++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n@@ -660,6 +660,11 @@ int PipelineHandlerIPU3::configure(Camera *camera, CameraConfiguration *c)\n \n \tipa::ipu3::IPAConfigInfo configInfo;\n \tconfigInfo.sensorControls = data->cio2_.sensor()->controls();\n+\n+\tCameraLens *lens = data->cio2_.sensor()->focusLens();\n+\tif (lens)\n+\t\tconfigInfo.lensControls = lens->controls();\n+\n \tconfigInfo.sensorInfo = sensorInfo;\n \tconfigInfo.bdsOutputSize = config->imguConfig().bds;\n \tconfigInfo.iif = config->imguConfig().iif;\n","prefixes":["libcamera-devel","v5","8/9"]}