[{"id":22240,"web_url":"https://patchwork.libcamera.org/comment/22240/","msgid":"<8e095240-5402-b7c9-ecbe-aa2b6701c973@ideasonboard.com>","date":"2022-03-09T15:14:36","subject":"Re: [libcamera-devel] [PATCH v5 6/9] libcamera: ipa: Add lens\n\tcontrol member to ipu3 ipa interface","submitter":{"id":97,"url":"https://patchwork.libcamera.org/api/people/97/","name":"Nicolas Dufresne via libcamera-devel","email":"libcamera-devel@lists.libcamera.org"},"content":"Hi !\n\nThanks for the patch !\n\nOn 04/03/2022 00:49, Daniel Scally wrote:\n> Add further members to the ipu3 ipa interface that will hold lens\n> controls passed in by configInfo\n> \n> Reviewed-by: Laurent Pinchart \n> Signed-off-by: Daniel Scally \n\nReviewed-by: Jean-Michel Hautbois \n\n> ---\n> Changes in v5:\n> \n> \t- None\n> \n> Changes since v4:\n> \n> \t- None\n> \n> Changes in v3:\n> \n> \t- None\n> \n> include/libcamera/ipa/ipu3.mojom | 1 +\n> src/ipa/ipu3/ipu3.cpp | 3 +++\n> 2 files changed, 4 insertions(+)\n> \n> diff --git a/include/libcamera/ipa/ipu3.mojom b/include/libcamera/ipa/ipu3.mojom\n> index cc0d822f..18cdc744 100644\n> --- a/include/libcamera/ipa/ipu3.mojom\n> +++ b/include/libcamera/ipa/ipu3.mojom\n> @@ -37,6 +37,7 @@ struct IPU3Action {\n> struct IPAConfigInfo {\n> \tlibcamera.IPACameraSensorInfo sensorInfo;\n> \tlibcamera.ControlInfoMap sensorControls;\n> +\tlibcamera.ControlInfoMap lensControls;\n> \tlibcamera.Size bdsOutputSize;\n> \tlibcamera.Size iif;\n> };\n> diff --git a/src/ipa/ipu3/ipu3.cpp b/src/ipa/ipu3/ipu3.cpp\n> index b5149bcd..008f93a7 100644\n> --- a/src/ipa/ipu3/ipu3.cpp\n> +++ b/src/ipa/ipu3/ipu3.cpp\n> @@ -163,6 +163,7 @@ private:\n> \tstd::map buffers_;\n> \n> \tControlInfoMap ctrls_;\n> +\tControlInfoMap lensCtrls_;\n> \n> \tIPACameraSensorInfo sensorInfo_;\n> \n> @@ -450,6 +451,8 @@ int IPAIPU3::configure(const IPAConfigInfo &configInfo,\n> \n> \tsensorInfo_ = configInfo.sensorInfo;\n> \n> +\tlensCtrls_ = configInfo.lensControls;\n> +\n> \t/*\n> \t * Compute the sensor V4L2 controls to be used by the algorithms and\n> \t * to be set on the sensor.","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id DBC11BE08A\n\tfor ;\n\tWed, 9 Mar 2022 15:14:40 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7816D6118B;\n\tWed, 9 Mar 2022 16:14:40 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DF83B60475\n\tfor ;\n\tWed, 9 Mar 2022 16:14:38 +0100 (CET)","from [IPV6:2a01:e0a:169:7140:3734:287e:1a7f:9772] (unknown\n\t[IPv6:2a01:e0a:169:7140:3734:287e:1a7f:9772])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id AD3998C4;\n\tWed, 9 Mar 2022 16:14:38 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1646838880;\n\tbh=GqrXhlf3dwdSWPTZLUV7geuTiQy+NCn4Sbm45L3d+7M=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=nCr7gKWviz3SkL2vsO1DqDGu8f4yDQYbosWVSAiOhFnFyzj8tCZ7Bwakr35O6CBO+\n\tRJcIN4ZMueIisdTqHiSX2AzvvlGooGxkL1ZHp3E8fuWqdebYwMFui8lAIujqwF6+Mf\n\tyhLZJo8PsUUcyxXBwnJPIfpKiMzPgrPwJKPaAxWP1RTxHMF6MqtBk+wJzMNc9IJ0E7\n\t4CK+RQL+0TSNJlxVYzXQl/KZSSZdlxtYCLVm4mkfNno/rXgqQpRlI6MDwSEMX/Oa9N\n\t3XKJEAqWPFw23klEonjfxq4RjENAKH5yeAyGSFcAuWfl3SX2CCIfD85KTXzc5sg5Vj\n\ti4Q099rH7gSWg==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1646838878;\n\tbh=GqrXhlf3dwdSWPTZLUV7geuTiQy+NCn4Sbm45L3d+7M=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=HtCy2qBOSOEZH0XsfoJ/qfC0SmHE7Q1TpcHTVqbk77qnyN9vFZvxiGyvDKd2btZz7\n\t3hOGjtdAoix1wY4rql5HLoUQRZZmhtMOlGba3Jb8UEZsbvIkwm5Qw4gcBAikhXLaex\n\t+RgSs6StylDRno8HPKV2cMfz+MzkyMfTdyTEw+h8="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"HtCy2qBO\"; dkim-atps=neutral","Message-ID":"<8e095240-5402-b7c9-ecbe-aa2b6701c973@ideasonboard.com>","Date":"Wed, 9 Mar 2022 16:14:36 +0100","MIME-Version":"1.0","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101\n\tThunderbird/91.5.0","Content-Language":"en-US","To":"Daniel Scally , libcamera-devel@lists.libcamera.org","References":"<20220303234956.1463551-1-djrscally@gmail.com>\n\t<20220303234956.1463551-7-djrscally@gmail.com>","In-Reply-To":"<20220303234956.1463551-7-djrscally@gmail.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH v5 6/9] libcamera: ipa: Add lens\n\tcontrol member to ipu3 ipa interface","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Jean-Michel Hautbois via libcamera-devel\n\t","Reply-To":"Jean-Michel Hautbois ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]