{"id":15413,"url":"https://patchwork.libcamera.org/api/patches/15413/?format=json","web_url":"https://patchwork.libcamera.org/patch/15413/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20220303234956.1463551-7-djrscally@gmail.com>","date":"2022-03-03T23:49:53","name":"[libcamera-devel,v5,6/9] libcamera: ipa: Add lens control member to ipu3 ipa interface","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"9587ac2496d8a1e758e9122900e4c0e86fd78703","submitter":{"id":90,"url":"https://patchwork.libcamera.org/api/people/90/?format=json","name":"Daniel Scally","email":"djrscally@gmail.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/15413/mbox/","series":[{"id":2950,"url":"https://patchwork.libcamera.org/api/series/2950/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2950","date":"2022-03-03T23:49:47","name":"Enumerate CameraLens by following sensor's ancillary links","version":5,"mbox":"https://patchwork.libcamera.org/series/2950/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/15413/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/15413/checks/","tags":{},"headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A3015C3261\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu,  3 Mar 2022 23:50:22 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3EA0661191;\n\tFri,  4 Mar 2022 00:50:22 +0100 (CET)","from mail-wr1-x434.google.com (mail-wr1-x434.google.com\n\t[IPv6:2a00:1450:4864:20::434])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BAF286116B\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri,  4 Mar 2022 00:50:16 +0100 (CET)","by mail-wr1-x434.google.com with SMTP id d3so10170062wrf.1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 03 Mar 2022 15:50:16 -0800 (PST)","from localhost.localdomain\n\t(cpc141996-chfd3-2-0-cust928.12-3.cable.virginm.net. [86.13.91.161])\n\tby smtp.gmail.com with ESMTPSA id\n\ty4-20020adff144000000b001f022290737sm3079779wro.6.2022.03.03.15.50.15\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 03 Mar 2022 15:50:16 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"iSE2M/RI\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=WoqbY1BZWhs2mt4/JE/+3IHD5MvVw0hkaOsxP+mksXM=;\n\tb=iSE2M/RI6UXXOtAT0qriNzJViwbwHCJtrnNUVFZPmcPq2gqGF2y4R9qvmJDYehIiZl\n\t5irWq+80qZSmZQHIZNhBqbO1tBQK7HEsYHwkxeiaY6c5SrDPblrRXJRpdqganmld+VOH\n\tzNL6u0pBo2yNg8e1CTWgBfXLlHDvblqIRJQbGlPTXaDR5NSedLiriprORYP6KpzZGnE5\n\tb0eqoWB4NmH5XkUkuh4wOxBPiDbXKGoRpBUlxomZC594QxnrsJDhcKS2GUcUE/yLWgZ8\n\tazMbFlFqC4v4SyK/a9xvnnXR2Y7FuKw04nENGzxssrMjo65OZc1KDR281T4jL/weatqT\n\tyDJg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=WoqbY1BZWhs2mt4/JE/+3IHD5MvVw0hkaOsxP+mksXM=;\n\tb=Cy1X7oDuFRCq7yA5BXrskxoIwApFwQikAt5cH7FbNB4uRyPMzGJNOJD4iqZvGMYqmO\n\tASsOhwmVbTKHQIuaHOoGYb4hydd8Kj9efhkJkSY2FHsPTCDRXBJhoBtnSORP7iAsn41q\n\tilBeR8mallrCepQjG5zT/L/ywWxjDHtC3ApvNUXCJFIGuddY+ffV2yUtbJK9YVtRTkW1\n\tFXGp8WyporkJyCEebVh/7kIPGxsUcbbjsCzYJSXSRLIrcVN/uddyVqWhzmF3zoqnS95H\n\tdF0x+t3MX3GNm7/cAkrC+wVUvQw4k0Nu5nBx1vFyeyv6pcS7k/MhOr8k/88PrWsdN2iY\n\tHlTw==","X-Gm-Message-State":"AOAM5310HQ4RNre5yLMLm3WBCTahNtbzFd1pP2qtE/wdIEEW7CD3z6YT\n\tg0RE1Wk/RjNdLnMTmOSb3RxpBHI3bhCKag==","X-Google-Smtp-Source":"ABdhPJza977agO6u47q/dnxseFn17+15gwlAx/FOVSYxNySJZuGmaBhSUAPuAX7Qoqjxph+pMn4kNQ==","X-Received":"by 2002:a5d:6d4e:0:b0:1e3:3636:b104 with SMTP id\n\tk14-20020a5d6d4e000000b001e33636b104mr28480437wri.605.1646351416558; \n\tThu, 03 Mar 2022 15:50:16 -0800 (PST)","From":"Daniel Scally <djrscally@gmail.com>","To":"libcamera-devel@lists.libcamera.org","Date":"Thu,  3 Mar 2022 23:49:53 +0000","Message-Id":"<20220303234956.1463551-7-djrscally@gmail.com>","X-Mailer":"git-send-email 2.25.1","In-Reply-To":"<20220303234956.1463551-1-djrscally@gmail.com>","References":"<20220303234956.1463551-1-djrscally@gmail.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v5 6/9] libcamera: ipa: Add lens control\n\tmember to ipu3 ipa interface","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"},"content":"Add further members to the ipu3 ipa interface that will hold lens\ncontrols passed in by configInfo\n\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nSigned-off-by: Daniel Scally <djrscally@gmail.com>\n---\nChanges in v5:\n\n\t- None\n\nChanges since v4:\n\n\t- None\n\nChanges in v3:\n\n\t- None\n\n include/libcamera/ipa/ipu3.mojom | 1 +\n src/ipa/ipu3/ipu3.cpp            | 3 +++\n 2 files changed, 4 insertions(+)","diff":"diff --git a/include/libcamera/ipa/ipu3.mojom b/include/libcamera/ipa/ipu3.mojom\nindex cc0d822f..18cdc744 100644\n--- a/include/libcamera/ipa/ipu3.mojom\n+++ b/include/libcamera/ipa/ipu3.mojom\n@@ -37,6 +37,7 @@ struct IPU3Action {\n struct IPAConfigInfo {\n \tlibcamera.IPACameraSensorInfo sensorInfo;\n \tlibcamera.ControlInfoMap sensorControls;\n+\tlibcamera.ControlInfoMap lensControls;\n \tlibcamera.Size bdsOutputSize;\n \tlibcamera.Size iif;\n };\ndiff --git a/src/ipa/ipu3/ipu3.cpp b/src/ipa/ipu3/ipu3.cpp\nindex b5149bcd..008f93a7 100644\n--- a/src/ipa/ipu3/ipu3.cpp\n+++ b/src/ipa/ipu3/ipu3.cpp\n@@ -163,6 +163,7 @@ private:\n \tstd::map<unsigned int, MappedFrameBuffer> buffers_;\n \n \tControlInfoMap ctrls_;\n+\tControlInfoMap lensCtrls_;\n \n \tIPACameraSensorInfo sensorInfo_;\n \n@@ -450,6 +451,8 @@ int IPAIPU3::configure(const IPAConfigInfo &configInfo,\n \n \tsensorInfo_ = configInfo.sensorInfo;\n \n+\tlensCtrls_ = configInfo.lensControls;\n+\n \t/*\n \t * Compute the sensor V4L2 controls to be used by the algorithms and\n \t * to be set on the sensor.\n","prefixes":["libcamera-devel","v5","6/9"]}