[{"id":22236,"web_url":"https://patchwork.libcamera.org/comment/22236/","msgid":"<0cc6f2d5-bf63-dc06-c83e-84a2e3f3d4f3@ideasonboard.com>","date":"2022-03-09T15:11:29","subject":"Re: [libcamera-devel] [PATCH v5 2/9] include: linux: Add\n\tMEDIA_LNK_FL_ANCILLARY_LINK","submitter":{"id":97,"url":"https://patchwork.libcamera.org/api/people/97/","name":"Nicolas Dufresne via libcamera-devel","email":"libcamera-devel@lists.libcamera.org"},"content":"Hi !\n\nThanks for the patch !\n\nOn 04/03/2022 00:49, Daniel Scally wrote:\n> Add the new media link type macro to the header so we can use it to\n> identify the new links. This isn't handled as a sync to the upstream\n> header because the macro is not yet upstream itself. The latest\n> series attempting to add it being found here:\n> \n> https://lists.libcamera.org/pipermail/libcamera-devel/2022-March/029120.html\n> \n> Reviewed-by: Laurent Pinchart \n> Signed-off-by: Daniel Scally \n\nReviewed-by: Jean-Michel Hautbois \n\n> ---\n> Changes in v5:\n> \n> \t- None\n> \n> Changes in v4:\n> \n> \t- None\n> \n> Changes in v3:\n> \n> \t- New patch\n> \n> include/linux/media.h | 1 +\n> 1 file changed, 1 insertion(+)\n> \n> diff --git a/include/linux/media.h b/include/linux/media.h\n> index 17432318..e3123d1a 100644\n> --- a/include/linux/media.h\n> +++ b/include/linux/media.h\n> @@ -222,6 +222,7 @@ struct media_pad_desc {\n> #define MEDIA_LNK_FL_LINK_TYPE\t\t\t(0xf << 28)\n> # define MEDIA_LNK_FL_DATA_LINK\t\t(0 << 28)\n> # define MEDIA_LNK_FL_INTERFACE_LINK\t\t(1 << 28)\n> +# define MEDIA_LNK_FL_ANCILLARY_LINK\t\t(2 << 28)\n> \n> struct media_link_desc {\n> \tstruct media_pad_desc source;","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 31838BE08A\n\tfor ;\n\tWed, 9 Mar 2022 15:11:34 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id DD25C6118B;\n\tWed, 9 Mar 2022 16:11:33 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B979C60475\n\tfor ;\n\tWed, 9 Mar 2022 16:11:32 +0100 (CET)","from [IPV6:2a01:e0a:169:7140:3734:287e:1a7f:9772] (unknown\n\t[IPv6:2a01:e0a:169:7140:3734:287e:1a7f:9772])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 725388C4;\n\tWed, 9 Mar 2022 16:11:32 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1646838693;\n\tbh=TOItyC8qrsKQcmUPtAXI4VCjPfviagVJ8a/R0UXb9hQ=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=4ihNbhaH0eTz8SyYKwxIyRsUhyphkO3QJRku6P2uJUNXwBQaxyBRKU1EaKVNYs+UR\n\tPi7Qt9p/CFGKvjWb+qU7LrqvKuYJRPpOxtzTmIHqFOQ3X7mfGfv0MGMk0NgwZtpfMU\n\tABUM705XN/78LRV2jdh1ncVsrAP9/M3wB/3ssRZDgajFdr3bcIfREsCthWumElnKpK\n\tfH/sHsN9gkKUriiasQEXN1Mo/3CSXIJC5kWqReTLFwdJ17lNiq9Pv3fcmJ4jgWig6N\n\tIPcrlBpzkrUgI+M0XfUgzrifUXVkQLZGjVEDrMwCrEIlnlxryAbUqE+PxmaaXgF/2q\n\tnIkE24G3IULhg==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1646838692;\n\tbh=TOItyC8qrsKQcmUPtAXI4VCjPfviagVJ8a/R0UXb9hQ=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=woaC0ASn+k7Jh0eqigfVMe7XQgV+FbKGkTK1mW0SYNEMWx3NMh92cB2GMBzhkgzLk\n\tE4DhkULEj0k3vjhxrPT62aqfM/LNyPPhoUSM3IKODta+GD6Gl+mYfC1JaSwDonecxX\n\tjslCnrAOiDbHL9olmKzC2+UZ6rKp8mssu2/pRJ2Y="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"woaC0ASn\"; dkim-atps=neutral","Message-ID":"<0cc6f2d5-bf63-dc06-c83e-84a2e3f3d4f3@ideasonboard.com>","Date":"Wed, 9 Mar 2022 16:11:29 +0100","MIME-Version":"1.0","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101\n\tThunderbird/91.5.0","Content-Language":"en-US","To":"Daniel Scally , libcamera-devel@lists.libcamera.org","References":"<20220303234956.1463551-1-djrscally@gmail.com>\n\t<20220303234956.1463551-3-djrscally@gmail.com>","In-Reply-To":"<20220303234956.1463551-3-djrscally@gmail.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH v5 2/9] include: linux: Add\n\tMEDIA_LNK_FL_ANCILLARY_LINK","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Jean-Michel Hautbois via libcamera-devel\n\t","Reply-To":"Jean-Michel Hautbois ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]