[{"id":22235,"web_url":"https://patchwork.libcamera.org/comment/22235/","msgid":"<36355891-1cc8-936d-9584-c1dbb1d3da78@ideasonboard.com>","date":"2022-03-09T15:11:06","subject":"Re: [libcamera-devel] [PATCH v5 1/9] libcamera: Add members to\n\tMediaEntity to support ancillary entities","submitter":{"id":97,"url":"https://patchwork.libcamera.org/api/people/97/","name":"Nicolas Dufresne via libcamera-devel","email":"libcamera-devel@lists.libcamera.org"},"content":"Hi !\n\nThanks for the patch !\n\nOn 04/03/2022 00:49, Daniel Scally wrote:\n> With kernel support for ancillary links, we can describe the\n> relationship between two devices represented individually as instances\n> of MediaEntity. As the only property of that relationship is its\n> existence, describe those relationships in libcamera simply as a\n> vector of MediaEntity pointers to the ancillary devices.\n> \n> Reviewed-by: Laurent Pinchart \n> Signed-off-by: Daniel Scally \n\nReviewed-by: Jean-Michel Hautbois \n\n> ---\n> Changes in v5:\n> \n> \t- None\n> \n> Changes in v4:\n> \n> \t- Reordered addAncillaryEntity() in the .cpp to match the .h\n> \n> Changes in v3:\n> \n> \t- Fixed some style issues\n> \t- Made addAncillaryEntity() private\n> \n> include/libcamera/internal/media_object.h | 4 ++++\n> src/libcamera/media_object.cpp | 15 +++++++++++++++\n> 2 files changed, 19 insertions(+)\n> \n> diff --git a/include/libcamera/internal/media_object.h b/include/libcamera/internal/media_object.h\n> index 90c63598..b1572968 100644\n> --- a/include/libcamera/internal/media_object.h\n> +++ b/include/libcamera/internal/media_object.h\n> @@ -104,6 +104,7 @@ public:\n> \tunsigned int deviceMinor() const { return minor_; }\n> \n> \tconst std::vector &pads() const { return pads_; }\n> +\tconst std::vector ancillaryEntities() const { return ancillaryEntities_; }\n> \n> \tconst MediaPad *getPadByIndex(unsigned int index) const;\n> \tconst MediaPad *getPadById(unsigned int id) const;\n> @@ -120,6 +121,8 @@ private:\n> \n> \tvoid addPad(MediaPad *pad);\n> \n> +\tvoid addAncillaryEntity(MediaEntity *ancillaryEntity);\n> +\n> \tstd::string name_;\n> \tunsigned int function_;\n> \tunsigned int flags_;\n> @@ -129,6 +132,7 @@ private:\n> \tunsigned int minor_;\n> \n> \tstd::vector pads_;\n> +\tstd::vector ancillaryEntities_;\n> };\n> \n> } /* namespace libcamera */\n> diff --git a/src/libcamera/media_object.cpp b/src/libcamera/media_object.cpp\n> index f425d044..c78f4758 100644\n> --- a/src/libcamera/media_object.cpp\n> +++ b/src/libcamera/media_object.cpp\n> @@ -423,4 +423,19 @@ void MediaEntity::addPad(MediaPad *pad)\n> \tpads_.push_back(pad);\n> }\n> \n> +/**\n> + * \\brief Add a MediaEntity to the list of ancillary entities\n> + * \\param[in] ancillaryEntity The instance of MediaEntity to add\n> + */\n> +void MediaEntity::addAncillaryEntity(MediaEntity *ancillaryEntity)\n> +{\n> +\tancillaryEntities_.push_back(ancillaryEntity);\n> +}\n> +\n> +/**\n> + * \\fn MediaEntity::ancillaryEntities()\n> + * \\brief Retrieve all ancillary entities of the entity\n> + * \\return The list of the entity's ancillary entities\n> + */\n> +\n> } /* namespace libcamera */","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2F5D5BE08A\n\tfor ;\n\tWed, 9 Mar 2022 15:11:12 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6565D61189;\n\tWed, 9 Mar 2022 16:11:11 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2FFE860475\n\tfor ;\n\tWed, 9 Mar 2022 16:11:09 +0100 (CET)","from [IPV6:2a01:e0a:169:7140:3734:287e:1a7f:9772] (unknown\n\t[IPv6:2a01:e0a:169:7140:3734:287e:1a7f:9772])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B408B8C4;\n\tWed, 9 Mar 2022 16:11:08 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1646838671;\n\tbh=taQGKSUpHAKjcymxDw3kZKMtWWA0A4BZOU16Tf1biCU=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=dKVhVBuEO5r209q8JVKh4p7MWXROkN2mqaypZ7GTHZj6Ai1i2dGQLVA7Ljr/fO5sT\n\tGiuU8ftyTT1/vjvNp8xd6l5xu/awbxkkoVmBlz8DI831zqvT2ZmY4KCMzD5mJzcsBE\n\tkELDcaWD/eHjNNCJyd2UkmnwU+Q+VReZX/BaB3fololw1FMz1Zzioqwhx6wLdpOnQW\n\tAonviqDPLieOFbNuXUL9TdGaocTUbNGGzfkSsVqig+rLM0vfJSxH4f8aQh05HrPTCB\n\tJQMhl+CALUDGIFS3f4Cpp/WoJw197z4xjlkn8Dkf9Qntc4F5y8LR/I/a+vXcz4CCJW\n\t8h9JvX6YMvT+g==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1646838668;\n\tbh=taQGKSUpHAKjcymxDw3kZKMtWWA0A4BZOU16Tf1biCU=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=R5PvYbfWL0/nq9gCdJcFOTh4PAgY7eY9guS0AYXccilLeJExmZPTyqaoeSvNe9zmy\n\tyPviLEaOmpuj+/x11Ny3Dd60dP1/T+kl8uDKo24PeTHbAAPSeoDu60/T42fwlTvJXi\n\tgFSWtQVHJ0FDClML3LqJbVaQ6b2gfDLbnxR6QWSw="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"R5PvYbfW\"; dkim-atps=neutral","Message-ID":"<36355891-1cc8-936d-9584-c1dbb1d3da78@ideasonboard.com>","Date":"Wed, 9 Mar 2022 16:11:06 +0100","MIME-Version":"1.0","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101\n\tThunderbird/91.5.0","Content-Language":"en-US","To":"Daniel Scally , libcamera-devel@lists.libcamera.org","References":"<20220303234956.1463551-1-djrscally@gmail.com>\n\t<20220303234956.1463551-2-djrscally@gmail.com>","In-Reply-To":"<20220303234956.1463551-2-djrscally@gmail.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH v5 1/9] libcamera: Add members to\n\tMediaEntity to support ancillary entities","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Jean-Michel Hautbois via libcamera-devel\n\t","Reply-To":"Jean-Michel Hautbois ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]