[{"id":22214,"web_url":"https://patchwork.libcamera.org/comment/22214/","msgid":"","date":"2022-03-03T11:22:48","subject":"Re: [libcamera-devel] [PATCH] v4l2: camera_proxy: Fix header\n\tinclude order","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nThank you for the patch.\n\nOn Thu, Mar 03, 2022 at 11:06:39AM +0000, Kieran Bingham wrote:\n> The includes in the v4l2_camera_proxy do not match the code styel\n\nThey also don't match the coding style.\n\n> and trigger clang-format changes when running checkstyle.\n> \n> Update and fix the include order accordingly\n> \n> Signed-off-by: Kieran Bingham \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/v4l2/v4l2_camera_proxy.cpp | 11 ++++++-----\n> 1 file changed, 6 insertions(+), 5 deletions(-)\n> \n> Note, this might likely only apply on top of the pending V4L2 frame rate\n> patch.\n> \n> \n> diff --git a/src/v4l2/v4l2_camera_proxy.cpp b/src/v4l2/v4l2_camera_proxy.cpp\n> index 493c41c0ad0f..4427ae3302d8 100644\n> --- a/src/v4l2/v4l2_camera_proxy.cpp\n> +++ b/src/v4l2/v4l2_camera_proxy.cpp\n> @@ -10,22 +10,23 @@\n> #include \n> #include \n> #include \n> -#include \n> #include \n> #include \n> #include \n> #include \n> #include \n> \n> -#include \n> -#include \n> -#include \n> -#include \n> +#include \n> \n> #include \n> #include \n> #include \n> \n> +#include \n> +#include \n> +#include \n> +#include \n> +\n> #include \"libcamera/internal/formats.h\"\n> \n> #include \"v4l2_camera.h\"","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 66A0ABE08A\n\tfor ;\n\tThu, 3 Mar 2022 11:23:04 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id BEE6460475;\n\tThu, 3 Mar 2022 12:23:03 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E9A49601FF\n\tfor ;\n\tThu, 3 Mar 2022 12:23:01 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 5E4EA885;\n\tThu, 3 Mar 2022 12:23:01 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"WVUXvo5v\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1646306581;\n\tbh=pDaItBsE4i36w+kt24z+XsqR9KhairsPtA1+jWjC05g=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=WVUXvo5vV9aksg5K+kgXvpY5JMKE7fQEcbDdHvrP+QvOZBLGgfEfyDNp5tF8XBikF\n\tU10fOPzAkAhklIZOr0LK2kn/MQ8CwaWx+rGc+0X4mqaw098Ul/VgOSQSPKuLHTWmNN\n\tkdfUB1L/vmae48UWdd+SBU9l7m7kXHbcyQ3ge53M=","Date":"Thu, 3 Mar 2022 13:22:48 +0200","From":"Laurent Pinchart ","To":"Kieran Bingham ","Message-ID":"","References":"<20220303110639.3469390-1-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20220303110639.3469390-1-kieran.bingham@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH] v4l2: camera_proxy: Fix header\n\tinclude order","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":22218,"web_url":"https://patchwork.libcamera.org/comment/22218/","msgid":"","date":"2022-03-03T12:25:19","subject":"Re: [libcamera-devel] [PATCH] v4l2: camera_proxy: Fix header\n\tinclude order","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"content":"Hi,\n\n\nOn 3/3/22 16:52, Laurent Pinchart wrote:\n> Hi Kieran,\n>\n> Thank you for the patch.\n>\n> On Thu, Mar 03, 2022 at 11:06:39AM +0000, Kieran Bingham wrote:\n>> The includes in the v4l2_camera_proxy do not match the code styel\n> They also don't match the coding style.\n>\n>> and trigger clang-format changes when running checkstyle.\n>>\n>> Update and fix the include order accordingly\n>>\n>> Signed-off-by: Kieran Bingham \n> Reviewed-by: Laurent Pinchart \n\n\nReviewed-by: Umang Jain \n\n>\n>> ---\n>> src/v4l2/v4l2_camera_proxy.cpp | 11 ++++++-----\n>> 1 file changed, 6 insertions(+), 5 deletions(-)\n>>\n>> Note, this might likely only apply on top of the pending V4L2 frame rate\n>> patch.\n>>\n>>\n>> diff --git a/src/v4l2/v4l2_camera_proxy.cpp b/src/v4l2/v4l2_camera_proxy.cpp\n>> index 493c41c0ad0f..4427ae3302d8 100644\n>> --- a/src/v4l2/v4l2_camera_proxy.cpp\n>> +++ b/src/v4l2/v4l2_camera_proxy.cpp\n>> @@ -10,22 +10,23 @@\n>> #include \n>> #include \n>> #include \n>> -#include \n>> #include \n>> #include \n>> #include \n>> #include \n>> #include \n>> \n>> -#include \n>> -#include \n>> -#include \n>> -#include \n>> +#include \n>> \n>> #include \n>> #include \n>> #include \n>> \n>> +#include \n>> +#include \n>> +#include \n>> +#include \n>> +\n>> #include \"libcamera/internal/formats.h\"\n>> \n>> #include \"v4l2_camera.h\"","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 585CBBF415\n\tfor ;\n\tThu, 3 Mar 2022 12:25:27 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id BE2576115E;\n\tThu, 3 Mar 2022 13:25:26 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 57276601FF\n\tfor ;\n\tThu, 3 Mar 2022 13:25:25 +0100 (CET)","from [192.168.1.106] (unknown [103.251.226.47])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id CCA92101E;\n\tThu, 3 Mar 2022 13:25:23 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"mBVol50E\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1646310325;\n\tbh=+2uXVUNvigf6zWu5oL446GecvTLaoOKT7619EJkj8R0=;\n\th=Date:Subject:To:Cc:References:From:In-Reply-To:From;\n\tb=mBVol50Ec6qN/2MPSJSLVbv4FxI1IzGs90Av9LP6356O08ZU33jNP6QVvYShVuTqK\n\tgEI7Hjr2f23VLGIb3MPwbGFg0JtjxSC3IOH4zZjhqnIa/CELNNbqP6KnAv4woK0ka+\n\tuyzcka5ShHPL8aZDeGoxo7hQ4CrSxOVTdioakriE=","Message-ID":"","Date":"Thu, 3 Mar 2022 17:55:19 +0530","MIME-Version":"1.0","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101\n\tThunderbird/91.4.1","Content-Language":"en-US","To":"Laurent Pinchart ,\n\tKieran Bingham ","References":"<20220303110639.3469390-1-kieran.bingham@ideasonboard.com>\n\t","From":"Umang Jain ","In-Reply-To":"","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH] v4l2: camera_proxy: Fix header\n\tinclude order","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]