[{"id":22247,"web_url":"https://patchwork.libcamera.org/comment/22247/","msgid":"<4e5c35d7-8299-3973-8430-5f8155607c97@gmail.com>","date":"2022-03-09T15:44:00","subject":"Re: [libcamera-devel] [PATCH v3 3/5] media: entity: Add\n\tlink_type_name() helper","submitter":{"id":97,"url":"https://patchwork.libcamera.org/api/people/97/","name":"Nicolas Dufresne via libcamera-devel","email":"libcamera-devel@lists.libcamera.org"},"content":"Hi !\n\nThanks for the patch !\n\nOn 02/03/2022 23:03, Daniel Scally wrote:\n> Now we have three types of media link, printing the right name during\n> debug output is slightly more complicated. Add a helper function to\n> make it easier.\n> \n> Reviewed-by: Laurent Pinchart \n> Signed-off-by: Daniel Scally \n\nReviewed-by: Jean-Michel Hautbois \n\n> ---\n> \n> Changes since v2:\n> \n> \t- None\n> \n> Changes since v1:\n> \n> \t- renamed function to link_type_name() (Laurent)\n> \n> Changes since the rfc:\n> \n> \t- new patch\n> \n> drivers/media/mc/mc-entity.c | 18 +++++++++++++++---\n> 1 file changed, 15 insertions(+), 3 deletions(-)\n> \n> diff --git a/drivers/media/mc/mc-entity.c b/drivers/media/mc/mc-entity.c\n> index d0563ee4b28b..1a7d0a4fb9e8 100644\n> --- a/drivers/media/mc/mc-entity.c\n> +++ b/drivers/media/mc/mc-entity.c\n> @@ -44,6 +44,20 @@ static inline const char *intf_type(struct media_interface *intf)\n> \t}\n> };\n> \n> +static inline const char *link_type_name(struct media_link *link)\n> +{\n> +\tswitch (link->flags & MEDIA_LNK_FL_LINK_TYPE) {\n> +\tcase MEDIA_LNK_FL_DATA_LINK:\n> +\t\treturn \"data\";\n> +\tcase MEDIA_LNK_FL_INTERFACE_LINK:\n> +\t\treturn \"interface\";\n> +\tcase MEDIA_LNK_FL_ANCILLARY_LINK:\n> +\t\treturn \"ancillary\";\n> +\tdefault:\n> +\t\treturn \"unknown\";\n> +\t}\n> +}\n> +\n> __must_check int __media_entity_enum_init(struct media_entity_enum *ent_enum,\n> \t\t\t\t\t int idx_max)\n> {\n> @@ -89,9 +103,7 @@ static void dev_dbg_obj(const char *event_name, struct media_gobj *gobj)\n> \n> \t\tdev_dbg(gobj->mdev->dev,\n> \t\t\t\"%s id %u: %s link id %u ==> id %u\\n\",\n> -\t\t\tevent_name, media_id(gobj),\n> -\t\t\tmedia_type(link->gobj0) == MEDIA_GRAPH_PAD ?\n> -\t\t\t\t\"data\" : \"interface\",\n> +\t\t\tevent_name, media_id(gobj), link_type_name(link),\n> \t\t\tmedia_id(link->gobj0),\n> \t\t\tmedia_id(link->gobj1));\n> \t\tbreak;","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A8278BE08A\n\tfor ;\n\tWed, 9 Mar 2022 15:44:05 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 63AD36118B;\n\tWed, 9 Mar 2022 16:44:05 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 31ACE60475\n\tfor ;\n\tWed, 9 Mar 2022 16:44:04 +0100 (CET)","from [IPV6:2a01:e0a:169:7140:3734:287e:1a7f:9772] (unknown\n\t[IPv6:2a01:e0a:169:7140:3734:287e:1a7f:9772])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C2EC7A50;\n\tWed, 9 Mar 2022 16:44:03 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1646840645;\n\tbh=apbZz1qZdE8W/sj2AhfELyx1wGnYlOaPlywCJsW4exI=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=wSDHbLifsgsK7E5op6i4ymKLDOBO9w0ZPXRiRK6gG9nRVdqA06pCNPAzsZXMcOAIt\n\tN3Exj7v5ERJ/0z1iJ3hitHH6Y+W7u7uHQ5zSWB6LzYbt7JBMZod/sZ74NwE9Z/3RBk\n\tO3FN/YwqIUbdp6Ysw3FqzmIWakDZwl1KlCVP7ItlW0sGYHtEyLaVgh5FAXgIZgp1vx\n\thrcMrQxNXVZA2te5VcPQByJMYcmUYhBi+qC2tMjmyWASC0WOgYnaFnSWDUQGelQSI9\n\tfkbJHpPkpG8z3sxxBm6mhoNJPAQ/Ob7owdHuLq//slENRW+yCTtmR/VuDNWSiBBtV2\n\trT6n9CNYuO0ZQ==","Message-ID":"<4e5c35d7-8299-3973-8430-5f8155607c97@gmail.com>","Date":"Wed, 9 Mar 2022 16:44:00 +0100","MIME-Version":"1.0","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101\n\tThunderbird/91.5.0","Content-Language":"en-US","To":"Daniel Scally , linux-media@vger.kernel.org,\n\tlibcamera-devel@lists.libcamera.org","References":"<20220302220304.1327896-1-djrscally@gmail.com>\n\t<20220302220304.1327896-4-djrscally@gmail.com>","In-Reply-To":"<20220302220304.1327896-4-djrscally@gmail.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH v3 3/5] media: entity: Add\n\tlink_type_name() helper","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Jean-Michel Hautbois via libcamera-devel\n\t","Reply-To":"Jean-Michel Hautbois ","Cc":"sakari.ailus@linux.intel.com","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]