{"id":15400,"url":"https://patchwork.libcamera.org/api/patches/15400/?format=json","web_url":"https://patchwork.libcamera.org/patch/15400/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20220302220304.1327896-4-djrscally@gmail.com>","date":"2022-03-02T22:03:02","name":"[libcamera-devel,v3,3/5] media: entity: Add link_type_name() helper","commit_ref":null,"pull_url":null,"state":"not-applicable","archived":false,"hash":"0dbb692040381c718cbb0b38c1e53cbf7d955523","submitter":{"id":90,"url":"https://patchwork.libcamera.org/api/people/90/?format=json","name":"Daniel Scally","email":"djrscally@gmail.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/15400/mbox/","series":[{"id":2946,"url":"https://patchwork.libcamera.org/api/series/2946/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2946","date":"2022-03-02T22:02:59","name":"Introduce ancillary links","version":3,"mbox":"https://patchwork.libcamera.org/series/2946/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/15400/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/15400/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7FD35BE08A\n\tfor ;\n\tWed, 2 Mar 2022 22:03:20 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9148F61187;\n\tWed, 2 Mar 2022 23:03:19 +0100 (CET)","from mail-wr1-x42e.google.com (mail-wr1-x42e.google.com\n\t[IPv6:2a00:1450:4864:20::42e])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 170C76047A\n\tfor ;\n\tWed, 2 Mar 2022 23:03:17 +0100 (CET)","by mail-wr1-x42e.google.com with SMTP id ay10so4903260wrb.6\n\tfor ;\n\tWed, 02 Mar 2022 14:03:17 -0800 (PST)","from localhost.localdomain\n\t(cpc141996-chfd3-2-0-cust928.12-3.cable.virginm.net. [86.13.91.161])\n\tby smtp.gmail.com with ESMTPSA id\n\tl16-20020a05600c4f1000b0033383cdeea1sm229258wmq.10.2022.03.02.14.03.16\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 02 Mar 2022 14:03:16 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"WR0utUqO\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=ZZuRb6vJ4xL/T85VnKjF8jjubHhc9DkEkfgVG9uggJ4=;\n\tb=WR0utUqOYB7ZuyINcK/dNLS0PEbpJCuBuL4jurQW5+C1ApyrN3YJklICb+1aASRiIL\n\tkhiDGY62G/cE+1kZBySmNmwLxCey30zqxuLrX2LpqkQaSYQTE544eFatwTJcBlH1gWWF\n\twG8DbfB34kXC+N/y0gYF/4IHjonxbOUTC0uXR+1cgnWM9jhK+uzUb6gHBvTMgWXMGVK1\n\t393a8bkurpawowYeDTMbRUk9sffEty3wF7WamsIMEg6PGNBDTB5DqrQuUfkyfFm5loZf\n\tevTQ/uJ+w7mu3MIqAIleu87IURx9z1WpCUy1VHUS3uyy035XNnclUUnoOewulryWoC5w\n\tSEgw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=ZZuRb6vJ4xL/T85VnKjF8jjubHhc9DkEkfgVG9uggJ4=;\n\tb=ObFOYVR81WPyO1Pu3/dLcA+ZXxz+WOZnmgviIKyV8V0mW5b3b3MR9+VZjLo9og52kD\n\tKJJvrldipXtI+gea/hskGTVBhZv411vNk3V4Vp2Be2yoOB3TrKkufcztWUr9aVpC0Jb4\n\tRZp6gYzO1dBKgboBBT758R0oJ8m+OVwVQvxzcbnIMKEtRws+xQz0ZV6ZuQP2CLgMJBeM\n\tptAWzhe7h55W9d0a4a7Nby0wOgnDgQVQNrZzsNHWs5hOgxCHIgEI7eOsUabe+YeFQM4h\n\t3Vf+YLacjNStz3/FLrd4Rdpg4yZQ/b4ZWl2oMRdpU/Q+XwGdhZdIyLUhQY+if5uTrSHr\n\tNG6w==","X-Gm-Message-State":"AOAM5306sEnJSNUVvzehlp4UV+PY/9/FNScxJLVYC9k9Wj+7IFhHSxRI\n\tpxIzIq9rEFBYAS1IDusqH+LuqcKV52bYXQ==","X-Google-Smtp-Source":"ABdhPJwyIst7piDstEx9M7MU7dqS8Jcpe10l0k3knw9tQODBYPx5ugkivtEZE6GyRL7cJlO1TgQYRQ==","X-Received":"by 2002:a05:6000:15c7:b0:1f0:45e0:e40d with SMTP id\n\ty7-20020a05600015c700b001f045e0e40dmr2921118wry.343.1646258596840; \n\tWed, 02 Mar 2022 14:03:16 -0800 (PST)","From":"Daniel Scally ","To":"linux-media@vger.kernel.org,\n\tlibcamera-devel@lists.libcamera.org","Date":"Wed, 2 Mar 2022 22:03:02 +0000","Message-Id":"<20220302220304.1327896-4-djrscally@gmail.com>","X-Mailer":"git-send-email 2.25.1","In-Reply-To":"<20220302220304.1327896-1-djrscally@gmail.com>","References":"<20220302220304.1327896-1-djrscally@gmail.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v3 3/5] media: entity: Add\n\tlink_type_name() helper","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"sakari.ailus@linux.intel.com","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Now we have three types of media link, printing the right name during\ndebug output is slightly more complicated. Add a helper function to\nmake it easier.\n\nReviewed-by: Laurent Pinchart \nSigned-off-by: Daniel Scally \n---\n\nChanges since v2:\n\n\t- None\n\nChanges since v1:\n\n\t- renamed function to link_type_name() (Laurent)\n\nChanges since the rfc:\n\n\t- new patch\n\n drivers/media/mc/mc-entity.c | 18 +++++++++++++++---\n 1 file changed, 15 insertions(+), 3 deletions(-)","diff":"diff --git a/drivers/media/mc/mc-entity.c b/drivers/media/mc/mc-entity.c\nindex d0563ee4b28b..1a7d0a4fb9e8 100644\n--- a/drivers/media/mc/mc-entity.c\n+++ b/drivers/media/mc/mc-entity.c\n@@ -44,6 +44,20 @@ static inline const char *intf_type(struct media_interface *intf)\n \t}\n };\n \n+static inline const char *link_type_name(struct media_link *link)\n+{\n+\tswitch (link->flags & MEDIA_LNK_FL_LINK_TYPE) {\n+\tcase MEDIA_LNK_FL_DATA_LINK:\n+\t\treturn \"data\";\n+\tcase MEDIA_LNK_FL_INTERFACE_LINK:\n+\t\treturn \"interface\";\n+\tcase MEDIA_LNK_FL_ANCILLARY_LINK:\n+\t\treturn \"ancillary\";\n+\tdefault:\n+\t\treturn \"unknown\";\n+\t}\n+}\n+\n __must_check int __media_entity_enum_init(struct media_entity_enum *ent_enum,\n \t\t\t\t\t int idx_max)\n {\n@@ -89,9 +103,7 @@ static void dev_dbg_obj(const char *event_name, struct media_gobj *gobj)\n \n \t\tdev_dbg(gobj->mdev->dev,\n \t\t\t\"%s id %u: %s link id %u ==> id %u\\n\",\n-\t\t\tevent_name, media_id(gobj),\n-\t\t\tmedia_type(link->gobj0) == MEDIA_GRAPH_PAD ?\n-\t\t\t\t\"data\" : \"interface\",\n+\t\t\tevent_name, media_id(gobj), link_type_name(link),\n \t\t\tmedia_id(link->gobj0),\n \t\t\tmedia_id(link->gobj1));\n \t\tbreak;\n","prefixes":["libcamera-devel","v3","3/5"]}