[{"id":22232,"web_url":"https://patchwork.libcamera.org/comment/22232/","msgid":"","date":"2022-03-08T08:53:08","subject":"Re: [libcamera-devel] [PATCH v3 3/5] ipa: libipa: Histogram:\n\tConstify the constructor span","submitter":{"id":97,"url":"https://patchwork.libcamera.org/api/people/97/","name":"Nicolas Dufresne via libcamera-devel","email":"libcamera-devel@lists.libcamera.org"},"content":"Hi JM\n\nOn 2/24/22 17:03, Jean-Michel Hautbois wrote:\n> The Histogram constructor does not modify the data. Pass it a Span uint32_t> instead of a Span.\n>\n> Signed-off-by: Jean-Michel Hautbois \n\n\nLooks good to me,\n\nReviewed-by: Umang Jain \n\n> ---\n> src/ipa/libipa/histogram.cpp | 2 +-\n> src/ipa/libipa/histogram.h | 2 +-\n> 2 files changed, 2 insertions(+), 2 deletions(-)\n>\n> diff --git a/src/ipa/libipa/histogram.cpp b/src/ipa/libipa/histogram.cpp\n> index 4d94571f..d8ad1c89 100644\n> --- a/src/ipa/libipa/histogram.cpp\n> +++ b/src/ipa/libipa/histogram.cpp\n> @@ -32,7 +32,7 @@ namespace ipa {\n> * \\brief Create a cumulative histogram\n> * \\param[in] data A pre-sorted histogram to be passed\n> */\n> -Histogram::Histogram(Span data)\n> +Histogram::Histogram(Span data)\n> {\n> \tcumulative_.reserve(data.size());\n> \tcumulative_.push_back(0);\n> diff --git a/src/ipa/libipa/histogram.h b/src/ipa/libipa/histogram.h\n> index c40a366b..164d4603 100644\n> --- a/src/ipa/libipa/histogram.h\n> +++ b/src/ipa/libipa/histogram.h\n> @@ -22,7 +22,7 @@ namespace ipa {\n> class Histogram\n> {\n> public:\n> -\tHistogram(Span data);\n> +\tHistogram(Span data);\n> \tsize_t bins() const { return cumulative_.size() - 1; }\n> \tuint64_t total() const { return cumulative_[cumulative_.size() - 1]; }\n> \tuint64_t cumulativeFrequency(double bin) const;","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E1ED5BE08A\n\tfor ;\n\tTue, 8 Mar 2022 08:53:24 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4A636604EC;\n\tTue, 8 Mar 2022 09:53:15 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 16F59604E9\n\tfor ;\n\tTue, 8 Mar 2022 09:53:14 +0100 (CET)","from [192.168.1.106] (unknown [103.251.226.72])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id EFB1A488;\n\tTue, 8 Mar 2022 09:53:12 +0100 (CET)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1646729595;\n\tbh=Q64mmro5iwM2qshwVUFijYnDP7yxbyTaBtiWvt0pqt4=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=QD8WlztyEdvWRLjvTEnrlh+RwSwTr3UMDnOaWu3ZvD79JGfHxZi1lYLzeQm4l9ucF\n\tG52pIk1IsSSaEyLssvWL4hEpFTp9wciADU5Wg9sJg/xSIEoOEtUB9u6JN+KowDA3rM\n\tFXr7Qrj7alzT3naUkm7wCdbxgKCew9lKLYiay0gSDKI8e7WHo/T0Xi8mwbX3id7iZf\n\tgekRvYuHdJnih1Yq1/5/BiWTT8ewvCcWcF5lZ2eYd6VQJDU2kx9bF3LwUKYzOdcmnz\n\tQDZ0Bbvftu8TqVoSVv5WLMEulrKeoFkTj4C/gNf/K1KQcJz0DBpHZBXQGZOIn/kbSD\n\t8gZDWcPEfRAqg==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1646729593;\n\tbh=Q64mmro5iwM2qshwVUFijYnDP7yxbyTaBtiWvt0pqt4=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=RDPPp+cSv3DkyDe1vpE4Sqm1LJqj8dP5O48npUzY8rSjaWRm2sgMQHh2nkLeUGjXP\n\tTissn+JrjFXHWgZTN5jPZsNDgvwY+LlMjyuojDF6BjwyN/8K/bn0SfMOJTPvCvmEpN\n\te7cgYHIHWdxXsooUmemDTAJxRDruH4JHF06n4e14="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"RDPPp+cS\"; dkim-atps=neutral","Message-ID":"","Date":"Tue, 8 Mar 2022 14:23:08 +0530","MIME-Version":"1.0","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101\n\tThunderbird/91.4.1","Content-Language":"en-US","To":"Jean-Michel Hautbois ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20220224113347.80001-1-jeanmichel.hautbois@ideasonboard.com>\n\t<20220224113347.80001-4-jeanmichel.hautbois@ideasonboard.com>","In-Reply-To":"<20220224113347.80001-4-jeanmichel.hautbois@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH v3 3/5] ipa: libipa: Histogram:\n\tConstify the constructor span","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Umang Jain via libcamera-devel ","Reply-To":"Umang Jain ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":22462,"web_url":"https://patchwork.libcamera.org/comment/22462/","msgid":"","date":"2022-03-27T20:25:03","subject":"Re: [libcamera-devel] [PATCH v3 3/5] ipa: libipa: Histogram:\n\tConstify the constructor span","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jean-Michel,\n\nThank you for the patch.\n\nOn Thu, Feb 24, 2022 at 12:33:45PM +0100, Jean-Michel Hautbois wrote:\n> The Histogram constructor does not modify the data. Pass it a Span uint32_t> instead of a Span.\n\nYou may want to avoid the line break between const and uint32_t.\n\n> Signed-off-by: Jean-Michel Hautbois \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/ipa/libipa/histogram.cpp | 2 +-\n> src/ipa/libipa/histogram.h | 2 +-\n> 2 files changed, 2 insertions(+), 2 deletions(-)\n> \n> diff --git a/src/ipa/libipa/histogram.cpp b/src/ipa/libipa/histogram.cpp\n> index 4d94571f..d8ad1c89 100644\n> --- a/src/ipa/libipa/histogram.cpp\n> +++ b/src/ipa/libipa/histogram.cpp\n> @@ -32,7 +32,7 @@ namespace ipa {\n> * \\brief Create a cumulative histogram\n> * \\param[in] data A pre-sorted histogram to be passed\n> */\n> -Histogram::Histogram(Span data)\n> +Histogram::Histogram(Span data)\n> {\n> \tcumulative_.reserve(data.size());\n> \tcumulative_.push_back(0);\n> diff --git a/src/ipa/libipa/histogram.h b/src/ipa/libipa/histogram.h\n> index c40a366b..164d4603 100644\n> --- a/src/ipa/libipa/histogram.h\n> +++ b/src/ipa/libipa/histogram.h\n> @@ -22,7 +22,7 @@ namespace ipa {\n> class Histogram\n> {\n> public:\n> -\tHistogram(Span data);\n> +\tHistogram(Span data);\n> \tsize_t bins() const { return cumulative_.size() - 1; }\n> \tuint64_t total() const { return cumulative_[cumulative_.size() - 1]; }\n> \tuint64_t cumulativeFrequency(double bin) const;","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7B7B4C0F1B\n\tfor ;\n\tSun, 27 Mar 2022 20:25:07 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3D24965631;\n\tSun, 27 Mar 2022 22:25:07 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 97D75600AB\n\tfor ;\n\tSun, 27 Mar 2022 22:25:05 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 363FA2F7;\n\tSun, 27 Mar 2022 22:25:05 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1648412707;\n\tbh=pABdA2xJ2gDYJevAp5e+SAk7E5L8BoLHmzotvdrF2+s=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=MOZJnJVZ7hyrzC1f8SPWbXolveXnoFKfD6oMZSL0X2gNzy+JsRQO5KWQk+MgIGKpH\n\tqwGaFj4pi0YrEXaFQeywokUCqsT+4U9rqQQodBD7GYV+2slzM6iMTyTgVTZeAG1M5z\n\tTiBTpx9M2NCSrMv8xpocDeDtChI1RW/Qo69wCIfwUEIyeklIjAHnyir/6MQ4wxHqzH\n\tLbzk9G/GFCSRoZmV3BcWXLhAMdJNvhdO0MmjajhWcgOyg0gCQCdOR2cnnwljSpuLhr\n\tJis7y9EhnkWSex1vXUMi3WwNW7/iNLRfMsX1RZYMdmzBaTWpp6s/GjvATrxIKwN5O9\n\txe6gHCuZYlhfg==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1648412705;\n\tbh=pABdA2xJ2gDYJevAp5e+SAk7E5L8BoLHmzotvdrF2+s=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=Jx9aKgbOnJh94hhfk66SFe6lTp5Md8+jWjVTpqv1WkXek7mm+3e7mVXGJUyklI+s0\n\tjf+GLi6Y/FoB5loB2x8LNlnTTa/EfH/fSkYWxvFZYu5+6LO9tWrwHayzAI4o22tf6p\n\tknWhKbfxmawpgXz8cPwWSeZJjd1e4igQCX6bF8GU="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"Jx9aKgbO\"; dkim-atps=neutral","Date":"Sun, 27 Mar 2022 23:25:03 +0300","To":"Jean-Michel Hautbois ","Message-ID":"","References":"<20220224113347.80001-1-jeanmichel.hautbois@ideasonboard.com>\n\t<20220224113347.80001-4-jeanmichel.hautbois@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20220224113347.80001-4-jeanmichel.hautbois@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v3 3/5] ipa: libipa: Histogram:\n\tConstify the constructor span","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]