[{"id":22183,"web_url":"https://patchwork.libcamera.org/comment/22183/","msgid":"<164545524235.3010406.8131749564541637135@Monstersaurus>","date":"2022-02-21T14:54:02","subject":"Re: [libcamera-devel] [PATCH] libcamera: Require gcc 8 or newer","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Laurent,\n\nQuoting Laurent Pinchart (2022-02-21 13:58:47)\n> gcc 7 has reached end of life and isn't used as a default compiler by\n> any of the major distributions. It has also been dropped from buildroot.\n> Drop its support in libcamera.\n> \n\nReducing outdated toolchains sounds good to me. Particularly as GCC-7\nisn't even in my compile-test-matrix.\n\nReviewed-by: Kieran Bingham \n\n\n> Signed-off-by: Laurent Pinchart \n> ---\n> meson.build | 11 +++++------\n> 1 file changed, 5 insertions(+), 6 deletions(-)\n> \n> diff --git a/meson.build b/meson.build\n> index 9684d562828d..29d8542dada2 100644\n> --- a/meson.build\n> +++ b/meson.build\n> @@ -81,11 +81,11 @@ if cc.get_id() == 'clang'\n> endif\n> \n> if cc.get_id() == 'gcc'\n> - if cc.version().version_compare('<7')\n> - error('gcc version is too old, libcamera requires 7.0 or newer')\n> + if cc.version().version_compare('<8')\n> + error('gcc version is too old, libcamera requires 8.0 or newer')\n> endif\n> \n> - # On gcc 7 and 8, the file system library is provided in a separate static\n> + # On gcc 8, the file system library is provided in a separate static\n> # library.\n> if cc.version().version_compare('<9')\n> cpp_arguments += [\n> @@ -95,9 +95,8 @@ if cc.get_id() == 'gcc'\n> \n> # gcc 7.1 introduced processor-specific ABI breakages related to parameter\n> # passing on ARM platforms. This generates a large number of messages\n> - # during compilation with gcc >=7.1. Silence them.\n> - if (host_machine.cpu_family() == 'arm' and\n> - cc.version().version_compare('>=7.1'))\n> + # during compilation. Silence them.\n> + if host_machine.cpu_family() == 'arm'\n> cpp_arguments += [\n> '-Wno-psabi',\n> ]\n> -- \n> Regards,\n> \n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9C6EDBF415\n\tfor ;\n\tMon, 21 Feb 2022 14:54:07 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0A39261127;\n\tMon, 21 Feb 2022 15:54:07 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 307E5610F8\n\tfor ;\n\tMon, 21 Feb 2022 15:54:05 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B89CF482;\n\tMon, 21 Feb 2022 15:54:04 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"U0LjG9RX\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1645455244;\n\tbh=x8U5+lhrQROQrvi+ozgwZarNNFov7aHJg7vxLv0ZmYw=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=U0LjG9RXXMovuXyP3YJUgDTPoMXAL8O11DLHPJhMY8k6QkzAi8iXDOC2fR8UvxO3H\n\tQbuGyThGpolKEA1iEEroxnzTopVsZIPjQV1z4N0kkzuErLa4Z6/HTSvj1rf536+9xI\n\tY8xpNSERUcir0/g+EaEQVm8v78JRuojLhV5hAW1Q=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20220221135847.19015-1-laurent.pinchart@ideasonboard.com>","References":"<20220221135847.19015-1-laurent.pinchart@ideasonboard.com>","From":"Kieran Bingham ","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Mon, 21 Feb 2022 14:54:02 +0000","Message-ID":"<164545524235.3010406.8131749564541637135@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH] libcamera: Require gcc 8 or newer","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":22185,"web_url":"https://patchwork.libcamera.org/comment/22185/","msgid":"<20220222073432.GA1498358@pyrite.rasen.tech>","date":"2022-02-22T07:34:32","subject":"Re: [libcamera-devel] [PATCH] libcamera: Require gcc 8 or newer","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"Hi Laurent,\n\nOn Mon, Feb 21, 2022 at 03:58:47PM +0200, Laurent Pinchart wrote:\n> gcc 7 has reached end of life and isn't used as a default compiler by\n> any of the major distributions. It has also been dropped from buildroot.\n> Drop its support in libcamera.\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Paul Elder \n\n> ---\n> meson.build | 11 +++++------\n> 1 file changed, 5 insertions(+), 6 deletions(-)\n> \n> diff --git a/meson.build b/meson.build\n> index 9684d562828d..29d8542dada2 100644\n> --- a/meson.build\n> +++ b/meson.build\n> @@ -81,11 +81,11 @@ if cc.get_id() == 'clang'\n> endif\n> \n> if cc.get_id() == 'gcc'\n> - if cc.version().version_compare('<7')\n> - error('gcc version is too old, libcamera requires 7.0 or newer')\n> + if cc.version().version_compare('<8')\n> + error('gcc version is too old, libcamera requires 8.0 or newer')\n> endif\n> \n> - # On gcc 7 and 8, the file system library is provided in a separate static\n> + # On gcc 8, the file system library is provided in a separate static\n> # library.\n> if cc.version().version_compare('<9')\n> cpp_arguments += [\n> @@ -95,9 +95,8 @@ if cc.get_id() == 'gcc'\n> \n> # gcc 7.1 introduced processor-specific ABI breakages related to parameter\n> # passing on ARM platforms. This generates a large number of messages\n> - # during compilation with gcc >=7.1. Silence them.\n> - if (host_machine.cpu_family() == 'arm' and\n> - cc.version().version_compare('>=7.1'))\n> + # during compilation. Silence them.\n> + if host_machine.cpu_family() == 'arm'\n> cpp_arguments += [\n> '-Wno-psabi',\n> ]","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E1FEABF415\n\tfor ;\n\tTue, 22 Feb 2022 07:34:41 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4C30961121;\n\tTue, 22 Feb 2022 08:34:41 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1F1E7601F5\n\tfor ;\n\tTue, 22 Feb 2022 08:34:39 +0100 (CET)","from pyrite.rasen.tech (h175-177-042-148.catv02.itscom.jp\n\t[175.177.42.148])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D940C47F;\n\tTue, 22 Feb 2022 08:34:37 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"GNM2QLcq\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1645515278;\n\tbh=tOigE/mGLhvucrVNZQezQMS79lYxbhF0OB3tCj5DF6w=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=GNM2QLcqxjdVgKuSzjm0lVAqTevbVZzffM/qcmbFz0wLHxdbwiaYrOwunRxccTnWC\n\t6Z1r5Pp0uP8eEqby0xI7rsyKHCLYjTk9WkP1uSLx+0sWovo6Vuoj3XezJivX4c/cBb\n\t9BHKiMI7tZa4+J/F1ekDcLumPQiMxXEwFDDq4xdI=","Date":"Tue, 22 Feb 2022 16:34:32 +0900","From":"paul.elder@ideasonboard.com","To":"Laurent Pinchart ","Message-ID":"<20220222073432.GA1498358@pyrite.rasen.tech>","References":"<20220221135847.19015-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20220221135847.19015-1-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH] libcamera: Require gcc 8 or newer","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]