{"id":15370,"url":"https://patchwork.libcamera.org/api/patches/15370/?format=json","web_url":"https://patchwork.libcamera.org/patch/15370/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20220221135847.19015-1-laurent.pinchart@ideasonboard.com>","date":"2022-02-21T13:58:47","name":"[libcamera-devel] libcamera: Require gcc 8 or newer","commit_ref":"a7ab5ef1d2f9b05056db450e631a99a73382d589","pull_url":null,"state":"accepted","archived":false,"hash":"fc33b770d0937e5d4a121d728a91f4c904ece3cb","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/15370/mbox/","series":[{"id":2935,"url":"https://patchwork.libcamera.org/api/series/2935/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2935","date":"2022-02-21T13:58:47","name":"[libcamera-devel] libcamera: Require gcc 8 or newer","version":1,"mbox":"https://patchwork.libcamera.org/series/2935/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/15370/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/15370/checks/","tags":{},"headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1C5ECBF415\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 21 Feb 2022 13:59:05 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 95C546113B;\n\tMon, 21 Feb 2022 14:59:04 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B5178610A1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 21 Feb 2022 14:59:03 +0100 (CET)","from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 3CF3C482\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 21 Feb 2022 14:59:03 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"iJFdi8MW\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1645451943;\n\tbh=6qZAZWVLRFEBTJDikctGjekh2UHwOMLzp/MACHGjGfs=;\n\th=From:To:Subject:Date:From;\n\tb=iJFdi8MWcC0Slpp73I6pXwh7WfzSzVfJN//GMz7quPr4lsOEgDzsYxrU099svrawy\n\tAssjwr15cx8l6/Ta2e6ugZMtQ3WkF5fG7XORdWONZOraOuE5QfuyNlHxVF3kVoc+Aa\n\t7SGzwlV2HEGIniq07g8DD52uq6nTmH3uXTQEI0cQ=","From":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","To":"libcamera-devel@lists.libcamera.org","Date":"Mon, 21 Feb 2022 15:58:47 +0200","Message-Id":"<20220221135847.19015-1-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.34.1","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH] libcamera: Require gcc 8 or newer","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"},"content":"gcc 7 has reached end of life and isn't used as a default compiler by\nany of the major distributions. It has also been dropped from buildroot.\nDrop its support in libcamera.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n meson.build | 11 +++++------\n 1 file changed, 5 insertions(+), 6 deletions(-)","diff":"diff --git a/meson.build b/meson.build\nindex 9684d562828d..29d8542dada2 100644\n--- a/meson.build\n+++ b/meson.build\n@@ -81,11 +81,11 @@ if cc.get_id() == 'clang'\n endif\n \n if cc.get_id() == 'gcc'\n-    if cc.version().version_compare('<7')\n-        error('gcc version is too old, libcamera requires 7.0 or newer')\n+    if cc.version().version_compare('<8')\n+        error('gcc version is too old, libcamera requires 8.0 or newer')\n     endif\n \n-    # On gcc 7 and 8, the file system library is provided in a separate static\n+    # On gcc 8, the file system library is provided in a separate static\n     # library.\n     if cc.version().version_compare('<9')\n         cpp_arguments += [\n@@ -95,9 +95,8 @@ if cc.get_id() == 'gcc'\n \n     # gcc 7.1 introduced processor-specific ABI breakages related to parameter\n     # passing on ARM platforms. This generates a large number of messages\n-    # during compilation with gcc >=7.1. Silence them.\n-    if (host_machine.cpu_family() == 'arm' and\n-        cc.version().version_compare('>=7.1'))\n+    # during compilation. Silence them.\n+    if host_machine.cpu_family() == 'arm'\n         cpp_arguments += [\n             '-Wno-psabi',\n         ]\n","prefixes":["libcamera-devel"]}