[{"id":22170,"web_url":"https://patchwork.libcamera.org/comment/22170/","msgid":"<20220215043548.GD174255@pyrite.rasen.tech>","date":"2022-02-15T04:35:48","subject":"Re: [libcamera-devel] [PATCH] v4l2: v4l2_camera_proxy: Fix\n\ttimestamp calculation","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"Hi Kieran,\n\nOn Mon, Feb 14, 2022 at 12:39:51PM +0000, Kieran Bingham wrote:\n> The V4L2 Compatibility layer is returning timestamps for buffers which\n> are incorrectly calculated from the frame metadata.\n> \n> The sec component of the timestamp is correct, but the nsec component is\n> out, leaving frame captures reporting non-monotonically increasing\n> timestamps, and incorrect frame rate calculations.\n\nOops :S\n\n> \n> Fix the usecs calculation reported by the V4L2 adaptation layer.\n> \n> Bug: https://bugs.libcamera.org/show_bug.cgi?id=118\n> Fixes: 0ce8f2390b52 (\"v4l2: v4l2_compat: Add V4L2 compatibility layer\")\n> Signed-off-by: Kieran Bingham \n\nReviewed-by: Paul Elder \n\n> ---\n> src/v4l2/v4l2_camera_proxy.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/v4l2/v4l2_camera_proxy.cpp b/src/v4l2/v4l2_camera_proxy.cpp\n> index 45822feff317..67b2c50c0f7e 100644\n> --- a/src/v4l2/v4l2_camera_proxy.cpp\n> +++ b/src/v4l2/v4l2_camera_proxy.cpp\n> @@ -234,7 +234,7 @@ void V4L2CameraProxy::updateBuffers()\n> \t\t\t\t\t\t\t});\n> \t\t\tbuf.field = V4L2_FIELD_NONE;\n> \t\t\tbuf.timestamp.tv_sec = fmd.timestamp / 1000000000;\n> -\t\t\tbuf.timestamp.tv_usec = fmd.timestamp % 1000000;\n> +\t\t\tbuf.timestamp.tv_usec = fmd.timestamp / 1000 % 1000000;\n> \t\t\tbuf.sequence = fmd.sequence;\n> \n> \t\t\tbuf.flags |= V4L2_BUF_FLAG_DONE;\n> -- \n> 2.32.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1AE57BE08A\n\tfor ;\n\tTue, 15 Feb 2022 04:36:00 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5954F6112E;\n\tTue, 15 Feb 2022 05:35:59 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 00996604EE\n\tfor ;\n\tTue, 15 Feb 2022 05:35:56 +0100 (CET)","from pyrite.rasen.tech (h175-177-042-148.catv02.itscom.jp\n\t[175.177.42.148])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 389F7315;\n\tTue, 15 Feb 2022 05:35:54 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"ii3tcBM7\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1644899756;\n\tbh=LY4b1T27TissCZzsPrwL/DRGXIZ2+vFKVumW9qtS8DQ=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=ii3tcBM7UYoleaXPApJHlHGPkEbBa845YzWsTYeBVi2IaHGIQmorr6Rqtvxz22W1L\n\tOz8p3wzVyxD2sYGz0a5DXJzJIW/LVtbosnOk/NLJrAP0ngUEs3NYfePIj7RF0PaZoQ\n\tA+jOhpW298Zd8AvT2SzXMdKzS8IlmZ4iRBsAqF1I=","Date":"Tue, 15 Feb 2022 13:35:48 +0900","From":"paul.elder@ideasonboard.com","To":"Kieran Bingham ","Message-ID":"<20220215043548.GD174255@pyrite.rasen.tech>","References":"<20220214123951.3919523-1-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20220214123951.3919523-1-kieran.bingham@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH] v4l2: v4l2_camera_proxy: Fix\n\ttimestamp calculation","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel , soyer@irl.hu","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":22172,"web_url":"https://patchwork.libcamera.org/comment/22172/","msgid":"","date":"2022-02-15T06:42:13","subject":"Re: [libcamera-devel] [PATCH] v4l2: v4l2_camera_proxy: Fix\n\ttimestamp calculation","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nThank you for the patch.\n\nOn Mon, Feb 14, 2022 at 12:39:51PM +0000, Kieran Bingham wrote:\n> The V4L2 Compatibility layer is returning timestamps for buffers which\n> are incorrectly calculated from the frame metadata.\n> \n> The sec component of the timestamp is correct, but the nsec component is\n\nDid you mean usec ?\n\n> out, leaving frame captures reporting non-monotonically increasing\n> timestamps, and incorrect frame rate calculations.\n> \n> Fix the usecs calculation reported by the V4L2 adaptation layer.\n> \n> Bug: https://bugs.libcamera.org/show_bug.cgi?id=118\n> Fixes: 0ce8f2390b52 (\"v4l2: v4l2_compat: Add V4L2 compatibility layer\")\n> Signed-off-by: Kieran Bingham \n> ---\n> src/v4l2/v4l2_camera_proxy.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/v4l2/v4l2_camera_proxy.cpp b/src/v4l2/v4l2_camera_proxy.cpp\n> index 45822feff317..67b2c50c0f7e 100644\n> --- a/src/v4l2/v4l2_camera_proxy.cpp\n> +++ b/src/v4l2/v4l2_camera_proxy.cpp\n> @@ -234,7 +234,7 @@ void V4L2CameraProxy::updateBuffers()\n> \t\t\t\t\t\t\t});\n> \t\t\tbuf.field = V4L2_FIELD_NONE;\n> \t\t\tbuf.timestamp.tv_sec = fmd.timestamp / 1000000000;\n> -\t\t\tbuf.timestamp.tv_usec = fmd.timestamp % 1000000;\n> +\t\t\tbuf.timestamp.tv_usec = fmd.timestamp / 1000 % 1000000;\n\nI'd have written\n\n\t\t\tbuf.timestamp.tv_usec = (fmd.timestamp / 1000) % 1000000;\n\nReviewed-by: Laurent Pinchart \n\neither way.\n\n> \t\t\tbuf.sequence = fmd.sequence;\n> \n> \t\t\tbuf.flags |= V4L2_BUF_FLAG_DONE;","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3141ABF415\n\tfor ;\n\tTue, 15 Feb 2022 06:42:22 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D834661123;\n\tTue, 15 Feb 2022 07:42:21 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1BCFE604EE\n\tfor ;\n\tTue, 15 Feb 2022 07:42:20 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 86C5C315;\n\tTue, 15 Feb 2022 07:42:19 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"t/edaW+b\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1644907339;\n\tbh=tL9Cx2+FjPKfReCnRO1NVVugGbIOThksn01rdmXKgSk=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=t/edaW+bNycjPyaJOOsvf8JPuqHuwC/BOeGt6PEjUU/t9PELPRtCDevai0jZBgQnV\n\ttKDEBeWO4ky+nb6afHvuU4zTQIJ1IKOYeVz1hXRZ15cBe4mYdkBitALNQH9Wr6k77t\n\tDzMvP1T7yWz4cQRVdTYSmAaN2QCxbci4wTuA6Z5U=","Date":"Tue, 15 Feb 2022 08:42:13 +0200","From":"Laurent Pinchart ","To":"Kieran Bingham ","Message-ID":"","References":"<20220214123951.3919523-1-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20220214123951.3919523-1-kieran.bingham@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH] v4l2: v4l2_camera_proxy: Fix\n\ttimestamp calculation","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel , soyer@irl.hu","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":22173,"web_url":"https://patchwork.libcamera.org/comment/22173/","msgid":"<164492343782.3903979.3349250662167174397@Monstersaurus>","date":"2022-02-15T11:10:37","subject":"Re: [libcamera-devel] [PATCH] v4l2: v4l2_camera_proxy: Fix\n\ttimestamp calculation","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Laurent Pinchart (2022-02-15 06:42:13)\n> Hi Kieran,\n> \n> Thank you for the patch.\n> \n> On Mon, Feb 14, 2022 at 12:39:51PM +0000, Kieran Bingham wrote:\n> > The V4L2 Compatibility layer is returning timestamps for buffers which\n> > are incorrectly calculated from the frame metadata.\n> > \n> > The sec component of the timestamp is correct, but the nsec component is\n> \n> Did you mean usec ?\n\nYes, it seems my commit message is out by the same order of magnitude as\nthe bug ...\n\nFixed,\n\n> > out, leaving frame captures reporting non-monotonically increasing\n> > timestamps, and incorrect frame rate calculations.\n> > \n> > Fix the usecs calculation reported by the V4L2 adaptation layer.\n> > \n> > Bug: https://bugs.libcamera.org/show_bug.cgi?id=118\n> > Fixes: 0ce8f2390b52 (\"v4l2: v4l2_compat: Add V4L2 compatibility layer\")\n> > Signed-off-by: Kieran Bingham \n> > ---\n> > src/v4l2/v4l2_camera_proxy.cpp | 2 +-\n> > 1 file changed, 1 insertion(+), 1 deletion(-)\n> > \n> > diff --git a/src/v4l2/v4l2_camera_proxy.cpp b/src/v4l2/v4l2_camera_proxy.cpp\n> > index 45822feff317..67b2c50c0f7e 100644\n> > --- a/src/v4l2/v4l2_camera_proxy.cpp\n> > +++ b/src/v4l2/v4l2_camera_proxy.cpp\n> > @@ -234,7 +234,7 @@ void V4L2CameraProxy::updateBuffers()\n> > });\n> > buf.field = V4L2_FIELD_NONE;\n> > buf.timestamp.tv_sec = fmd.timestamp / 1000000000;\n> > - buf.timestamp.tv_usec = fmd.timestamp % 1000000;\n> > + buf.timestamp.tv_usec = fmd.timestamp / 1000 % 1000000;\n> \n> I'd have written\n> \n> buf.timestamp.tv_usec = (fmd.timestamp / 1000) % 1000000;\n\naha, normally I expect you to suggest removing brackets ;-) But I can\nadd these.\n\n> \n> Reviewed-by: Laurent Pinchart \n> \n> either way.\n> \n\nThanks, will collect tags, fix the minors and push.\n\n> > buf.sequence = fmd.sequence;\n> > \n> > buf.flags |= V4L2_BUF_FLAG_DONE;\n> \n> -- \n> Regards,\n> \n> Laurent Pinchart","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id EF886BE08A\n\tfor ;\n\tTue, 15 Feb 2022 11:10:42 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2E4C261127;\n\tTue, 15 Feb 2022 12:10:42 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0E69B601FF\n\tfor ;\n\tTue, 15 Feb 2022 12:10:41 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 82035315;\n\tTue, 15 Feb 2022 12:10:40 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"JMddEO+a\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1644923440;\n\tbh=iTvcVuZyOkswLgdRvajkaybxFP62GEJly6jLOCp2ceI=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=JMddEO+am6r6Lc8rwAWlMfEEZBzsRNIqMKm9/rwaa9qf84MJ2IRWx7usOhSkPcM6Y\n\tJqpiauY7oto4KAtkECoz59zftK8QeK14zftUglEiNtklgtM2+qV7EWcmdl8ZogomrZ\n\tB74vfVPG130TkT+hP+REntW5aZp534tLSRAB6LNk=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"","References":"<20220214123951.3919523-1-kieran.bingham@ideasonboard.com>\n\t","From":"Kieran Bingham ","To":"Laurent Pinchart ","Date":"Tue, 15 Feb 2022 11:10:37 +0000","Message-ID":"<164492343782.3903979.3349250662167174397@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH] v4l2: v4l2_camera_proxy: Fix\n\ttimestamp calculation","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel , soyer@irl.hu","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]