[{"id":22182,"web_url":"https://patchwork.libcamera.org/comment/22182/","msgid":"","date":"2022-02-21T14:49:20","subject":"Re: [libcamera-devel] [PATCH] libcamera: camera_sensor: Do not\n\tinitialise unsupported test patterns","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"content":"Hi Kieran,\n\nThank you for your patch.\n\nOn Sat, 12 Feb 2022 at 23:34, Kieran Bingham <\nkieran.bingham@ideasonboard.com> wrote:\n\n> After the CameraSensor class has initialised properties, a default\n> setting is applied to ensure that test pattern modes are disabled unless\n> explicitly requested.\n>\n> This does not currently check to see if test patterns are supported on\n> the CameraSensor and the applyTestPatternMode call will report a failure\n> if it attempts to set a mode when not supported.\n>\n> Move the initialisation of the test pattern mode to the implementation\n> of the control mappings to ensure that it is correctly reset at start\n> up, while the code path will have already completed early if not\n> supported.\n>\n> Bug: https://github.com/raspberrypi/libcamera-apps/issues/249\n> Signed-off-by: Kieran Bingham \n>\n\nThis does reduce panic caused by the error message on startup for our\nimx477 users :-)\n\nReviewed-by: Naushir Patuck \n\n\n> ---\n> src/libcamera/camera_sensor.cpp | 5 ++++-\n> 1 file changed, 4 insertions(+), 1 deletion(-)\n>\n> diff --git a/src/libcamera/camera_sensor.cpp\n> b/src/libcamera/camera_sensor.cpp\n> index 345b4a170d47..3a6a1a6bca77 100644\n> --- a/src/libcamera/camera_sensor.cpp\n> +++ b/src/libcamera/camera_sensor.cpp\n> @@ -172,7 +172,7 @@ int CameraSensor::init()\n> if (ret)\n> return ret;\n>\n> - return\n> applyTestPatternMode(controls::draft::TestPatternModeEnum::TestPatternModeOff);\n> + return 0;\n> }\n>\n> int CameraSensor::validateSensorDriver()\n> @@ -372,6 +372,9 @@ void CameraSensor::initTestPatternModes()\n>\n> testPatternModes_.push_back(it->second);\n> }\n> +\n> + /* Initialise the sensor with test patterns disabled. */\n> +\n> applyTestPatternMode(controls::draft::TestPatternModeEnum::TestPatternModeOff);\n> }\n>\n> int CameraSensor::initProperties()\n> --\n> 2.32.0\n>\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D1A01BE08A\n\tfor ;\n\tMon, 21 Feb 2022 14:49:39 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4AD46610F8;\n\tMon, 21 Feb 2022 15:49:39 +0100 (CET)","from mail-lf1-x129.google.com (mail-lf1-x129.google.com\n\t[IPv6:2a00:1450:4864:20::129])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6F7C3610F8\n\tfor ;\n\tMon, 21 Feb 2022 15:49:37 +0100 (CET)","by mail-lf1-x129.google.com with SMTP id j15so19038090lfe.11\n\tfor ;\n\tMon, 21 Feb 2022 06:49:37 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"SlTGFKjq\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=SBup977A6JR5DcbT+yEwbOsgtrBW3Pq8lunIM8vrTzw=;\n\tb=SlTGFKjqR5F4OBEaZ9WQK4xIR4sDWCAHkRGtC9YYBw7LULBbV1/hOrvJjphJJvZ3Tr\n\tTBJWGzLg5qVxhi5+CvMBj+Lru+ctjQYDzQqujdpWUrQl0TTXKGUtp6dg0eOuLm0igWAC\n\tO7qL9s21eNXALvbhhffF/RyN892UqQVBII9QWxHkfjmuyL9/QnNRkCbBIkzuCVJAWz/Z\n\tZV2VX26jbk6CVGQkGDmu99tGpOuqWoo2phWm0mmAdBPiqQmORcHihHIiESskcsRknQeK\n\t6MxmsdoGgAGoLhNMwSx1pLW8ATbBOHRFTFWa+EBwdeu6y7pcDS4I16X4MzJRnDdhSH4n\n\t4GlA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=SBup977A6JR5DcbT+yEwbOsgtrBW3Pq8lunIM8vrTzw=;\n\tb=CJqFPgk/mhT0Wmph40WsAz9XDx7fUyjUGhqPaN5Yd4ZkAWlnQGZPCMwJe0Uz6O5HYb\n\tyjXELxYmbBurKcbNF4o8APGozpH807O6XYL224jZnAsHzj9vF4kdtIfpmeBR681B4u2g\n\t9TPXH+ubDUExM19m7GbtB+XtO0s8DwmIHqfu5K6KfkahDHptaJWTGu3YUAZKtElRcHX7\n\tS5ohyIMU94UsKn3kGF6TGroxBbKNWdJuJKcBK82z7+Rc4Ud9MOp3GTXm3Ob65f7GU+hf\n\tv9523BU+lWf2sG37jKfuUbnUpqgorchGVdLJI+sdPa+Aa8spGZkGzAodfF3m2LPuatoi\n\tf/dA==","X-Gm-Message-State":"AOAM533kJJhnYBNfXdT8nC9DCP8lAbe12ArGE4jV0f6CdF+L/6g1uVJq\n\tWjshDjOm4VpRlGaOD+4fMrTB9hlOUpnNTAQz4N0DCCX/46h4NA==","X-Google-Smtp-Source":"ABdhPJyIz4tznGmY7lbaQC1doffyP0G4q+78067sgaWFe7AsrB3QYyYKXubT+J/4klS9FRcrs7hLSNp8eWe1kikoE0c=","X-Received":"by 2002:a05:6512:b83:b0:443:161a:e467 with SMTP id\n\tb3-20020a0565120b8300b00443161ae467mr14094770lfv.315.1645454976574;\n\tMon, 21 Feb 2022 06:49:36 -0800 (PST)","MIME-Version":"1.0","References":"<20220212233407.3309708-1-kieran.bingham@ideasonboard.com>","In-Reply-To":"<20220212233407.3309708-1-kieran.bingham@ideasonboard.com>","From":"Naushir Patuck ","Date":"Mon, 21 Feb 2022 14:49:20 +0000","Message-ID":"","To":"Kieran Bingham ","Content-Type":"multipart/alternative; boundary=\"0000000000005f77ed05d88857d9\"","Subject":"Re: [libcamera-devel] [PATCH] libcamera: camera_sensor: Do not\n\tinitialise unsupported test patterns","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":22184,"web_url":"https://patchwork.libcamera.org/comment/22184/","msgid":"","date":"2022-02-22T06:11:31","subject":"Re: [libcamera-devel] [PATCH] libcamera: camera_sensor: Do not\n\tinitialise unsupported test patterns","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nThank you for the patch.\n\nOn Sat, Feb 12, 2022 at 11:34:07PM +0000, Kieran Bingham wrote:\n> After the CameraSensor class has initialised properties, a default\n> setting is applied to ensure that test pattern modes are disabled unless\n> explicitly requested.\n> \n> This does not currently check to see if test patterns are supported on\n> the CameraSensor and the applyTestPatternMode call will report a failure\n> if it attempts to set a mode when not supported.\n> \n> Move the initialisation of the test pattern mode to the implementation\n> of the control mappings to ensure that it is correctly reset at start\n> up, while the code path will have already completed early if not\n> supported.\n> \n> Bug: https://github.com/raspberrypi/libcamera-apps/issues/249\n> Signed-off-by: Kieran Bingham \n> ---\n> src/libcamera/camera_sensor.cpp | 5 ++++-\n> 1 file changed, 4 insertions(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/camera_sensor.cpp b/src/libcamera/camera_sensor.cpp\n> index 345b4a170d47..3a6a1a6bca77 100644\n> --- a/src/libcamera/camera_sensor.cpp\n> +++ b/src/libcamera/camera_sensor.cpp\n> @@ -172,7 +172,7 @@ int CameraSensor::init()\n> \tif (ret)\n> \t\treturn ret;\n> \n> -\treturn applyTestPatternMode(controls::draft::TestPatternModeEnum::TestPatternModeOff);\n> +\treturn 0;\n> }\n> \n> int CameraSensor::validateSensorDriver()\n> @@ -372,6 +372,9 @@ void CameraSensor::initTestPatternModes()\n> \n> \t\ttestPatternModes_.push_back(it->second);\n> \t}\n> +\n> +\t/* Initialise the sensor with test patterns disabled. */\n> +\tapplyTestPatternMode(controls::draft::TestPatternModeEnum::TestPatternModeOff);\n\nErrors when applyting the test pattern are not propagated up anymore.\n\nA different approach if you don't want to turn all void functions in the\ncall stack to return an int is to move the error message when\ntestPatternModes_.empty() from CameraSensor::applyTestPatternMode() to\nCameraSensor::setTestPatternMode(). You will need to keep the check in\nCameraSensor::applyTestPatternMode() in order to return 0, but\nCameraSensor::setTestPatternMode() could return a proper error code.\n\n> }\n> \n> int CameraSensor::initProperties()","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9A73DBE08A\n\tfor ;\n\tTue, 22 Feb 2022 06:11:43 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A4BB06113A;\n\tTue, 22 Feb 2022 07:11:42 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0FCB3601F5\n\tfor ;\n\tTue, 22 Feb 2022 07:11:42 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 7C21F47F;\n\tTue, 22 Feb 2022 07:11:41 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"uN3DhYuA\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1645510301;\n\tbh=+TbG7+MnpiqGiPAvnhipQtAwqABr+un848ON1qQHOP8=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=uN3DhYuAS7IMoqpBq9E3NLfkc4NbZZXzMeK8f+i5Ce96j43IZ1HVqmTz7WLSwcGTk\n\tkhyw8uyP2miZbcj69whyX1a/eG2jHX39oSDoKMTJvHjrGHPrDL65i3ldsShj3NrHdK\n\tPeIzENLveUOsfIMob5BIqkheTldqrY4VpZ/WTojc=","Date":"Tue, 22 Feb 2022 08:11:31 +0200","From":"Laurent Pinchart ","To":"Kieran Bingham ","Message-ID":"","References":"<20220212233407.3309708-1-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20220212233407.3309708-1-kieran.bingham@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH] libcamera: camera_sensor: Do not\n\tinitialise unsupported test patterns","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":23143,"web_url":"https://patchwork.libcamera.org/comment/23143/","msgid":"","date":"2022-05-25T11:05:49","subject":"Re: [libcamera-devel] [PATCH] libcamera: camera_sensor: Do not\n\tinitialise unsupported test patterns","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"content":"Hi all,\n\nOn Tue, 22 Feb 2022 at 06:11, Laurent Pinchart <\nlaurent.pinchart@ideasonboard.com> wrote:\n\n> Hi Kieran,\n>\n> Thank you for the patch.\n>\n> On Sat, Feb 12, 2022 at 11:34:07PM +0000, Kieran Bingham wrote:\n> > After the CameraSensor class has initialised properties, a default\n> > setting is applied to ensure that test pattern modes are disabled unless\n> > explicitly requested.\n> >\n> > This does not currently check to see if test patterns are supported on\n> > the CameraSensor and the applyTestPatternMode call will report a failure\n> > if it attempts to set a mode when not supported.\n> >\n> > Move the initialisation of the test pattern mode to the implementation\n> > of the control mappings to ensure that it is correctly reset at start\n> > up, while the code path will have already completed early if not\n> > supported.\n> >\n> > Bug: https://github.com/raspberrypi/libcamera-apps/issues/249\n> > Signed-off-by: Kieran Bingham \n> > ---\n> > src/libcamera/camera_sensor.cpp | 5 ++++-\n> > 1 file changed, 4 insertions(+), 1 deletion(-)\n> >\n> > diff --git a/src/libcamera/camera_sensor.cpp\n> b/src/libcamera/camera_sensor.cpp\n> > index 345b4a170d47..3a6a1a6bca77 100644\n> > --- a/src/libcamera/camera_sensor.cpp\n> > +++ b/src/libcamera/camera_sensor.cpp\n> > @@ -172,7 +172,7 @@ int CameraSensor::init()\n> > if (ret)\n> > return ret;\n> >\n> > - return\n> applyTestPatternMode(controls::draft::TestPatternModeEnum::TestPatternModeOff);\n> > + return 0;\n> > }\n> >\n> > int CameraSensor::validateSensorDriver()\n> > @@ -372,6 +372,9 @@ void CameraSensor::initTestPatternModes()\n> >\n> > testPatternModes_.push_back(it->second);\n> > }\n> > +\n> > + /* Initialise the sensor with test patterns disabled. */\n> > +\n> applyTestPatternMode(controls::draft::TestPatternModeEnum::TestPatternModeOff);\n>\n> Errors when applyting the test pattern are not propagated up anymore.\n>\n> A different approach if you don't want to turn all void functions in the\n> call stack to return an int is to move the error message when\n> testPatternModes_.empty() from CameraSensor::applyTestPatternMode() to\n> CameraSensor::setTestPatternMode(). You will need to keep the check in\n> CameraSensor::applyTestPatternMode() in order to return 0, but\n> CameraSensor::setTestPatternMode() could return a proper error code.\n>\n\nHave we come to a resolution on this? It's winding up some of our users,\nand we could do with suppressing these warnings :-)\n\nRegards,\nNaush\n\n\n\n>\n> > }\n> >\n> > int CameraSensor::initProperties()\n>\n> --\n> Regards,\n>\n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 662B0BD161\n\tfor ;\n\tWed, 25 May 2022 11:06:09 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7D58C65663;\n\tWed, 25 May 2022 13:06:08 +0200 (CEST)","from mail-lf1-x12a.google.com (mail-lf1-x12a.google.com\n\t[IPv6:2a00:1450:4864:20::12a])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D12EC60429\n\tfor ;\n\tWed, 25 May 2022 13:06:06 +0200 (CEST)","by mail-lf1-x12a.google.com with SMTP id l13so28775148lfp.11\n\tfor ;\n\tWed, 25 May 2022 04:06:06 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1653476768;\n\tbh=g15CQFmL48erf7GJwGzteBMz0TSiuMXKInl3P6yHg5c=;\n\th=References:In-Reply-To:Date:To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=Z6tOpH2Ogh6orV+A5/o/fWp12ptHU09Eke8Z1ELSHzGGSlNxg1Hc7zomEBwKzeIEx\n\to1gA2R4ig6zh4vhzugFDjJuNO/oUgYX8Yha4NkrvrG46Pd0CXTHbif2L1h+hZyhNG3\n\tyBrOPEeTXgQypaziLu7BQBbxJPpX7aXp1Jn2KtrRX1Fmu4VzqKeh2Zr8KZpC0T7IJs\n\tKltx0k4ker8rpm2r/QH3H1LTbkXQP3q9G4+Lay2L5ulWI/5BmjNqyF16lWNk5koVw7\n\tIR27D3KuOPxJ8FFSnJQEafxE21H9s+gfJlRD7S5FcfpDDq8MOIKaOkMYpof6ySIzC3\n\t4OKK7gLrUfEig==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=M1usPwiufCtrhAo01BuqlsX5yc3e2hyvq8Q4Ovh0Sew=;\n\tb=LWqU4Xnq0muC5sMKihrRMMa596lSqgjFFY1W2l40mLJrnkCyef8pgBjablGGobvmCG\n\tlcFLRk4foeMpiRfON8lgT/qRSxFr+1/dAQZALxavCYai/AK42U07FpdpigHHaM5QSdpx\n\td2qWFb3+ckB0LbXl0IS85MhfBFqaAz7e85VAQyXbB3qnzjxZM4FTSyxa8uo9WZp2dVso\n\tu6NqjbjDVFhIqVosLEKeMMc2i1JcgE2BIGV84RAWsQV5q/vw2UEA3eq1ukV9FcoGlssr\n\tSrE8gUiRUbUGVYvMbYiPsOFO+SGq5dQb4fXHOFnYExONWxsfoitzHvEAoD+/gxMFWvUT\n\tHQkA=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=raspberrypi.com\n\theader.i=@raspberrypi.com\n\theader.b=\"LWqU4Xnq\"; dkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=M1usPwiufCtrhAo01BuqlsX5yc3e2hyvq8Q4Ovh0Sew=;\n\tb=ilMXeEMV/lQtZDnHJbRarzdQWUkBn2O/mQ0fvims8c0EsmiWtJPAtepgyTdYXEWcx3\n\tRxoFlvJ/HEK/p1Nnqgv02FCmbGmMH2DQnB+eJ9JYi5FuKLFvX8Vu4t+7kccHtMd9NSt9\n\tq9br6pM4s+NJUYgRAl96y2Vibq36KEm5OQpRQ6SB+S3OEHxOSqJlIiIok8IIHCaISmrn\n\t/oKYAHPlYOOntwNX+YyFZXi2UtsdpiFoub1hMJ6LSvuK+Xpzcu/8VlgP5sLzIzszGxUh\n\twnawUtRVa8fcnG6UANomrG3L6C9vc8x6oLjUBiO51nFCdio1lxkGZb9iUvouSWYOMrWK\n\t7kLQ==","X-Gm-Message-State":"AOAM5307RvQ2w5Q/DHRIcQG3jZybBV30akCzjDd3L9mjUHqtq8HHlBgI\n\tfeShs9AiFY2gfBKGsMOsYOm/uRxaHIzFz7ogRTkNvg==","X-Google-Smtp-Source":"ABdhPJww8/1zOaBiVl/RoNtL9B26890sRTM/ugXtw+/c/2haYrEORSw8PpBqv1KC+Rt2abZamSnU3ODeFnP3sYbbzn0=","X-Received":"by 2002:a05:6512:131d:b0:477:9d81:7f17 with SMTP id\n\tx29-20020a056512131d00b004779d817f17mr23239143lfu.63.1653476765652;\n\tWed, 25 May 2022 04:06:05 -0700 (PDT)","MIME-Version":"1.0","References":"<20220212233407.3309708-1-kieran.bingham@ideasonboard.com>\n\t","In-Reply-To":"","Date":"Wed, 25 May 2022 12:05:49 +0100","Message-ID":"","To":"Laurent Pinchart ","Content-Type":"multipart/alternative; boundary=\"00000000000042e98005dfd40f49\"","Subject":"Re: [libcamera-devel] [PATCH] libcamera: camera_sensor: Do not\n\tinitialise unsupported test patterns","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Naushir Patuck via libcamera-devel\n\t","Reply-To":"Naushir Patuck ","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":23206,"web_url":"https://patchwork.libcamera.org/comment/23206/","msgid":"<165377836762.2093890.12722156888997873242@Monstersaurus>","date":"2022-05-28T22:52:47","subject":"Re: [libcamera-devel] [PATCH] libcamera: camera_sensor: Do not\n\tinitialise unsupported test patterns","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Naushir Patuck (2022-05-25 12:05:49)\n> Hi all,\n> \n> On Tue, 22 Feb 2022 at 06:11, Laurent Pinchart <\n> laurent.pinchart@ideasonboard.com> wrote:\n> \n> > Hi Kieran,\n> >\n> > Thank you for the patch.\n> >\n> > On Sat, Feb 12, 2022 at 11:34:07PM +0000, Kieran Bingham wrote:\n> > > After the CameraSensor class has initialised properties, a default\n> > > setting is applied to ensure that test pattern modes are disabled unless\n> > > explicitly requested.\n> > >\n> > > This does not currently check to see if test patterns are supported on\n> > > the CameraSensor and the applyTestPatternMode call will report a failure\n> > > if it attempts to set a mode when not supported.\n> > >\n> > > Move the initialisation of the test pattern mode to the implementation\n> > > of the control mappings to ensure that it is correctly reset at start\n> > > up, while the code path will have already completed early if not\n> > > supported.\n> > >\n> > > Bug: https://github.com/raspberrypi/libcamera-apps/issues/249\n> > > Signed-off-by: Kieran Bingham \n> > > ---\n> > > src/libcamera/camera_sensor.cpp | 5 ++++-\n> > > 1 file changed, 4 insertions(+), 1 deletion(-)\n> > >\n> > > diff --git a/src/libcamera/camera_sensor.cpp\n> > b/src/libcamera/camera_sensor.cpp\n> > > index 345b4a170d47..3a6a1a6bca77 100644\n> > > --- a/src/libcamera/camera_sensor.cpp\n> > > +++ b/src/libcamera/camera_sensor.cpp\n> > > @@ -172,7 +172,7 @@ int CameraSensor::init()\n> > > if (ret)\n> > > return ret;\n> > >\n> > > - return\n> > applyTestPatternMode(controls::draft::TestPatternModeEnum::TestPatternModeOff);\n> > > + return 0;\n> > > }\n> > >\n> > > int CameraSensor::validateSensorDriver()\n> > > @@ -372,6 +372,9 @@ void CameraSensor::initTestPatternModes()\n> > >\n> > > testPatternModes_.push_back(it->second);\n> > > }\n> > > +\n> > > + /* Initialise the sensor with test patterns disabled. */\n> > > +\n> > applyTestPatternMode(controls::draft::TestPatternModeEnum::TestPatternModeOff);\n> >\n> > Errors when applyting the test pattern are not propagated up anymore.\n> >\n> > A different approach if you don't want to turn all void functions in the\n> > call stack to return an int is to move the error message when\n> > testPatternModes_.empty() from CameraSensor::applyTestPatternMode() to\n> > CameraSensor::setTestPatternMode(). You will need to keep the check in\n> > CameraSensor::applyTestPatternMode() in order to return 0, but\n> > CameraSensor::setTestPatternMode() could return a proper error code.\n> >\n> \n> Have we come to a resolution on this? It's winding up some of our users,\n> and we could do with suppressing these warnings :-)\n\nI have pretty low availabilty for the next couple of weeks with\nholiday.\n\nWould you be able to send a patch with Laurents suggestion above?\nHopefully that could be merged quicker.\n\nOf course adding the test pattern controls to the IMX477 is another\noption too?\n--\nRegards\n\nKieran\n\n\n> \n> Regards,\n> Naush\n> \n> \n> \n> >\n> > > }\n> > >\n> > > int CameraSensor::initProperties()\n> >\n> > --\n> > Regards,\n> >\n> > Laurent Pinchart\n> >","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2D298BD161\n\tfor ;\n\tSat, 28 May 2022 22:52:53 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 71BF465633;\n\tSun, 29 May 2022 00:52:52 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 50519633A1\n\tfor ;\n\tSun, 29 May 2022 00:52:50 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D0FC1730;\n\tSun, 29 May 2022 00:52:49 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1653778372;\n\tbh=oXtdEPJ86gBCpynd+utA6onBJWyni9MejkLwevcIiiE=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=MHqGlJaF/F8YbF8p6KQIQThCcJRJQMAfWn3XOTy5iHaLM+Lxq5UMyFXA66IlcGFtV\n\tu9Tc0Fib333D4Y+ynSvRddhdslGkUWcnz2ERG/xV5mY5NlToymuxms/+xgx0U2d8W/\n\t2GObwVEdeFwC7r6xDf1OweQ1tzHxhUCfoluaAGLdaiHmKSS+xLu99580lvivBh5RPs\n\tWFs4JOfvaaQRR6kmcDJflDiVbM017/UgMvSfiwOaafyLcx8oFUFth8F7E1DFxH4uvQ\n\t9UU8RGUREKkMxLxdxMkfcWdm6NNJuqgSlxAehpFMd1ls1yi3Cj7Q3EDxmoaWDa/HgS\n\tHGXGM9aB3b+mg==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1653778369;\n\tbh=oXtdEPJ86gBCpynd+utA6onBJWyni9MejkLwevcIiiE=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=at4gP2rZ3gDqaInKenwM7a4RW8fUpI0R8Glv1pzmW6ZSx2idsWK7V1gWbU3F3LH6C\n\tXYQ7fRTq6P+lqMk2FATRoHBOAEsicARHRuIS3ysq8QPHU/5OTb3GKKEiVEcHgSM6a6\n\tMl6pTjbh4X5wEdZ+258jYt6bswmZx/QcTz60gcXg="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"at4gP2rZ\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"","References":"<20220212233407.3309708-1-kieran.bingham@ideasonboard.com>\n\t\n\t","To":"Laurent Pinchart ,\n\tNaushir Patuck ","Date":"Sat, 28 May 2022 23:52:47 +0100","Message-ID":"<165377836762.2093890.12722156888997873242@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH] libcamera: camera_sensor: Do not\n\tinitialise unsupported test patterns","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kieran Bingham via libcamera-devel\n\t","Reply-To":"Kieran Bingham ","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":23223,"web_url":"https://patchwork.libcamera.org/comment/23223/","msgid":"","date":"2022-05-30T07:54:24","subject":"Re: [libcamera-devel] [PATCH] libcamera: camera_sensor: Do not\n\tinitialise unsupported test patterns","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"content":"Hi Kieran,\n\nOn Sat, 28 May 2022 at 23:52, Kieran Bingham <\nkieran.bingham@ideasonboard.com> wrote:\n\n> Quoting Naushir Patuck (2022-05-25 12:05:49)\n> > Hi all,\n> >\n> > On Tue, 22 Feb 2022 at 06:11, Laurent Pinchart <\n> > laurent.pinchart@ideasonboard.com> wrote:\n> >\n> > > Hi Kieran,\n> > >\n> > > Thank you for the patch.\n> > >\n> > > On Sat, Feb 12, 2022 at 11:34:07PM +0000, Kieran Bingham wrote:\n> > > > After the CameraSensor class has initialised properties, a default\n> > > > setting is applied to ensure that test pattern modes are disabled\n> unless\n> > > > explicitly requested.\n> > > >\n> > > > This does not currently check to see if test patterns are supported\n> on\n> > > > the CameraSensor and the applyTestPatternMode call will report a\n> failure\n> > > > if it attempts to set a mode when not supported.\n> > > >\n> > > > Move the initialisation of the test pattern mode to the\n> implementation\n> > > > of the control mappings to ensure that it is correctly reset at start\n> > > > up, while the code path will have already completed early if not\n> > > > supported.\n> > > >\n> > > > Bug: https://github.com/raspberrypi/libcamera-apps/issues/249\n> > > > Signed-off-by: Kieran Bingham \n> > > > ---\n> > > > src/libcamera/camera_sensor.cpp | 5 ++++-\n> > > > 1 file changed, 4 insertions(+), 1 deletion(-)\n> > > >\n> > > > diff --git a/src/libcamera/camera_sensor.cpp\n> > > b/src/libcamera/camera_sensor.cpp\n> > > > index 345b4a170d47..3a6a1a6bca77 100644\n> > > > --- a/src/libcamera/camera_sensor.cpp\n> > > > +++ b/src/libcamera/camera_sensor.cpp\n> > > > @@ -172,7 +172,7 @@ int CameraSensor::init()\n> > > > if (ret)\n> > > > return ret;\n> > > >\n> > > > - return\n> > >\n> applyTestPatternMode(controls::draft::TestPatternModeEnum::TestPatternModeOff);\n> > > > + return 0;\n> > > > }\n> > > >\n> > > > int CameraSensor::validateSensorDriver()\n> > > > @@ -372,6 +372,9 @@ void CameraSensor::initTestPatternModes()\n> > > >\n> > > > testPatternModes_.push_back(it->second);\n> > > > }\n> > > > +\n> > > > + /* Initialise the sensor with test patterns disabled. */\n> > > > +\n> > >\n> applyTestPatternMode(controls::draft::TestPatternModeEnum::TestPatternModeOff);\n> > >\n> > > Errors when applyting the test pattern are not propagated up anymore.\n> > >\n> > > A different approach if you don't want to turn all void functions in\n> the\n> > > call stack to return an int is to move the error message when\n> > > testPatternModes_.empty() from CameraSensor::applyTestPatternMode() to\n> > > CameraSensor::setTestPatternMode(). You will need to keep the check in\n> > > CameraSensor::applyTestPatternMode() in order to return 0, but\n> > > CameraSensor::setTestPatternMode() could return a proper error code.\n> > >\n> >\n> > Have we come to a resolution on this? It's winding up some of our users,\n> > and we could do with suppressing these warnings :-)\n>\n> I have pretty low availabilty for the next couple of weeks with\n> holiday.\n>\n> Would you be able to send a patch with Laurents suggestion above?\n> Hopefully that could be merged quicker.\n>\n\nSure, I can give it a go. It will probably have to wait for next week as I\nam\noff for the week after today. I'll post a patch when it's done.\n\nRegards,\nNaush\n\n\n>\n> Of course adding the test pattern controls to the IMX477 is another\n> option too?\n>\n--\n> Regards\n>\n> Kieran\n>\n>\n> >\n> > Regards,\n> > Naush\n> >\n> >\n> >\n> > >\n> > > > }\n> > > >\n> > > > int CameraSensor::initProperties()\n> > >\n> > > --\n> > > Regards,\n> > >\n> > > Laurent Pinchart\n> > >\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 481A7BD160\n\tfor ;\n\tMon, 30 May 2022 07:54:43 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A757765636;\n\tMon, 30 May 2022 09:54:42 +0200 (CEST)","from mail-lj1-x22c.google.com (mail-lj1-x22c.google.com\n\t[IPv6:2a00:1450:4864:20::22c])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2456561FB7\n\tfor ;\n\tMon, 30 May 2022 09:54:41 +0200 (CEST)","by mail-lj1-x22c.google.com with SMTP id k20so2160760ljc.1\n\tfor ;\n\tMon, 30 May 2022 00:54:41 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1653897282;\n\tbh=TBzuBLx2vQJqkygPeZ1ql5B0CelSvoqD65Gw0WpuQTg=;\n\th=References:In-Reply-To:Date:To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=tCoYGkkr6BELjbXxkzgdI/xVAx8jiufy011bSKFpf1YFTlEroxCCtn08sKk+w1tgC\n\tsBQi4kRuU0Vvd8MnToVSLuaIL4cGpeIKLUsDcRyXk7iG6/bU0meHR+IxIG0iWYj73E\n\tHwZamzTBpxOgCERKHrq53tXwExRdKY4OjG82PbEGTk6aXKiue2i3MnenOJ0DxQY44a\n\tUraUVz6fE2HEuenCWeQTqI/rKRAGllFrrgCDQyWEsrWmzxgKod4VathFb6kL+yK6VN\n\tp2FK7iQIeqamsyKGTqDhshvibIVoIOidlMgFTw65a3sHOk8pHA7pLcpKSlX3bnKhU0\n\tnNSH+YQOsP8Dg==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=y8saN1epYIMHOfrzth7TT+Ykv3dgcnGYxDupobGQyGA=;\n\tb=kd4XpTzUK/1y8HBXSpkUyHaRkOQHKJtX59tivltSQ7P9HpxLgRzidOOCTs1sa3Mm/F\n\tBiIzzXurxoBSnHnL2t6oTqluPzrc7Ghu68FEjU1vUUC8vjQMTzUOwvlrWpmB5A9zvoIq\n\tsMd2yWvwIhXjkAaP/PY99/k9z3t1XvpFdQZKvfdUQc6bi1P28yZyYFfiP712ir2OSkYb\n\tGjqcYuR1llbYcEpqkyZhOEnaH9gHs43Rkjfy82l2Q/moQ1jje5QV9mIrEjDZ4jn0g+Mf\n\t6sdW1iigar+ydkm330Af4znsgpjuh2tJFS2JOz3ABgIEagfYUK84mA+erht+UCdqNAW/\n\tUqUA=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=raspberrypi.com\n\theader.i=@raspberrypi.com\n\theader.b=\"kd4XpTzU\"; dkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=y8saN1epYIMHOfrzth7TT+Ykv3dgcnGYxDupobGQyGA=;\n\tb=fWPxvaAtttA8yv1/ms7Y7YlSdMBPIvpV+Wo3X7p/ZROziJxx+v9FS6qDV8dH6mrpvi\n\tQH8xpkeojv2sF0RLRge0ZXgjCgjVJ1nCstuPtrAsZ2mnqZDsAzNzJ1VT8xnA9ZMZtk2Y\n\ti01bfPnTZDmPU6r4y8fRT0OFnP/LmSz18ZS4MlBlllsexRq2mGAgaPWBBB3R+RDM6UYt\n\th91xlMd1KnDKsJHtaPvqxPS9HSEITrFuo/kJOGioqoYy7cuhhv4e75kODhAmU4ss7jjm\n\tMUZC8hVpxKqMvpN91NClO0DLC7/ItrmmSSnyZm0ucVMfCmyOsgcymjh7k88PO7tJ9tVf\n\tfpow==","X-Gm-Message-State":"AOAM530gyKvBXzy1H43t8OC3ZVuK9IKGag8kBw1dZnDmWBjj91ZjubP1\n\tHNFHVV7c2bpMmqbNpN9Xp2FGUHgsG+KH9US96pQeOA==","X-Google-Smtp-Source":"ABdhPJw05jfWymyaflcN1MkD73Kmi1JTEfKK7o0pCYf7iPvCqSNte4LA1zvVVvLmZZp2CTIsKwapK1EBLZgYircYMZY=","X-Received":"by 2002:a2e:9ed9:0:b0:253:ccfa:e608 with SMTP id\n\th25-20020a2e9ed9000000b00253ccfae608mr32633454ljk.380.1653897280305;\n\tMon, 30 May 2022 00:54:40 -0700 (PDT)","MIME-Version":"1.0","References":"<20220212233407.3309708-1-kieran.bingham@ideasonboard.com>\n\t\n\t\n\t<165377836762.2093890.12722156888997873242@Monstersaurus>","In-Reply-To":"<165377836762.2093890.12722156888997873242@Monstersaurus>","Date":"Mon, 30 May 2022 08:54:24 +0100","Message-ID":"","To":"Kieran Bingham ","Content-Type":"multipart/alternative; boundary=\"000000000000e350ba05e035f7af\"","Subject":"Re: [libcamera-devel] [PATCH] libcamera: camera_sensor: Do not\n\tinitialise unsupported test patterns","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Naushir Patuck via libcamera-devel\n\t","Reply-To":"Naushir Patuck ","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]