{"id":15354,"url":"https://patchwork.libcamera.org/api/patches/15354/?format=json","web_url":"https://patchwork.libcamera.org/patch/15354/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20220209120804.21352-1-david.plowman@raspberrypi.com>","date":"2022-02-09T12:08:04","name":"[libcamera-devel] libcamera: pipeline: raspberrypi: Fix scaler crop when sensor is configured","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"2fc2f2ded79d2b6cee84b92aebe2634cd62da610","submitter":{"id":42,"url":"https://patchwork.libcamera.org/api/people/42/?format=json","name":"David Plowman","email":"david.plowman@raspberrypi.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/15354/mbox/","series":[{"id":2924,"url":"https://patchwork.libcamera.org/api/series/2924/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=2924","date":"2022-02-09T12:08:04","name":"[libcamera-devel] libcamera: pipeline: raspberrypi: Fix scaler crop when sensor is configured","version":1,"mbox":"https://patchwork.libcamera.org/series/2924/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/15354/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/15354/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 66B9DBDCBF\n\tfor ;\n\tWed, 9 Feb 2022 12:08:15 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A29C661092;\n\tWed, 9 Feb 2022 13:08:14 +0100 (CET)","from mail-wr1-x42d.google.com (mail-wr1-x42d.google.com\n\t[IPv6:2a00:1450:4864:20::42d])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5889F6106D\n\tfor ;\n\tWed, 9 Feb 2022 13:08:12 +0100 (CET)","by mail-wr1-x42d.google.com with SMTP id s18so3657174wrv.7\n\tfor ;\n\tWed, 09 Feb 2022 04:08:12 -0800 (PST)","from pi4-davidp.pitowers.org\n\t([2a00:1098:3142:15:d2be:68f0:ab8:a2fb])\n\tby smtp.gmail.com with ESMTPSA id\n\tq2sm15288782wrw.14.2022.02.09.04.08.10\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 09 Feb 2022 04:08:11 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"Ce2jkWBJ\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=WgUz9i+6JmC+2yVWhj8LpLZnCUYdLr8/Iu3YV5UUSzs=;\n\tb=Ce2jkWBJ3mrxloE1XE0v9jZCSw6WcFsqTF6HljFkSIzVt3wITh7P9OOm86vXf17tdQ\n\tNnn+4UdqnOslgpHQgnj0N18lHDgF/dowYFqR6jQ7P6N3eEdZ1CbUgeRVm5+K2dFtjcnO\n\tlzfq25uDipBPpOJXZyf2o0HBDHSv18LJfjOMxS2coQXcVakYSID2J8yplOKqdlkXT96e\n\t/ZSZiJF/h3rRUq9lVbmAEOhMPatRtJYNCm4zVdrYeCXA5ucmMHrIjUfeuaTlQv4YezAQ\n\twfzWx3hxUsV9XEEB84dW7mSX804DjXCrKHKfMwCXl0hrG5P2afInHVzG6mPs4eJ6+Uz2\n\tYelA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=WgUz9i+6JmC+2yVWhj8LpLZnCUYdLr8/Iu3YV5UUSzs=;\n\tb=Bwiqcqm6Al5HiBTphnPKLQ3DMw3Gw+PNT7tAVOrXPQuS/OWGdam7HCs0oARsEZoLxc\n\tNFG6aHAmfLrxF7sgGLy1QnesrxMqgcqCSiU6MRC7sZSp1gjArYLuHsqV0tGr6UfjLoDi\n\tV0la07ThQxvDK0cro7ath4aqy3bpCQPun+VFj52GdnrLr9zvHyzQ8+AisqIvhFA0VXk4\n\tWo0KHCEYA6H6dyokszP1ZEYJ7GauSU5fn+0t9Tlrb0p/+H9IZH6pJCd3oV9BYHrP4zcH\n\tnTJRmfMHIBuyhLogdR1n6NFP/5nP4cYFdn4/o41gGlxABp889v3LBVn/jE6gGBTcuknT\n\tvBEQ==","X-Gm-Message-State":"AOAM5313nBjVwtoEftZ8i8vHwBuWxG2lLRXCBOId+IcDZmu682lnr6sN\n\tGesLSG0CYQykpFVE7tP4Im+aBDes9FE4N1IO","X-Google-Smtp-Source":"ABdhPJwt3XIM5JnNxUITIzeNzjwEmnHEIANAUyW2uY/tYX4ftBnt65gZB1zH6e+ALhKuzWTuk+pcsw==","X-Received":"by 2002:a5d:560a:: with SMTP id\n\tl10mr1861393wrv.290.1644408491768; \n\tWed, 09 Feb 2022 04:08:11 -0800 (PST)","From":"David Plowman ","To":"libcamera-devel@lists.libcamera.org","Date":"Wed, 9 Feb 2022 12:08:04 +0000","Message-Id":"<20220209120804.21352-1-david.plowman@raspberrypi.com>","X-Mailer":"git-send-email 2.30.2","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH] libcamera: pipeline: raspberrypi: Fix\n\tscaler crop when sensor is configured","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"We must calculate the initial scaler crop when the camera is\nconfigured, otherwise the metadata will report this rectangle as being\nall zeroes.\n\nSigned-off-by: David Plowman \n---\n src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 5 +++++\n 1 file changed, 5 insertions(+)","diff":"diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\nindex 583ee798..d6c57e7a 100644\n--- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n+++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n@@ -887,6 +887,11 @@ int PipelineHandlerRPi::configure(Camera *camera, CameraConfiguration *config)\n \tif (ret)\n \t\tLOG(RPI, Error) << \"Failed to configure the IPA: \" << ret;\n \n+\t/* Set the scaler crop to the value that we are using. */\n+\tdata->scalerCrop_ = data->ispCrop_.scaledBy(data->sensorInfo_.analogCrop.size(),\n+\t\t\t\t\t\t data->sensorInfo_.outputSize);\n+\tdata->scalerCrop_.translateBy(data->sensorInfo_.analogCrop.topLeft());\n+\n \t/*\n \t * Configure the Unicam embedded data output format only if the sensor\n \t * supports it.\n","prefixes":["libcamera-devel"]}