[{"id":22133,"web_url":"https://patchwork.libcamera.org/comment/22133/","msgid":"","date":"2022-02-07T23:41:59","subject":"Re: [libcamera-devel] [PATCH 3/3] ipa: raspberrypi: Reduce the\n\tcontroller rate to 30fps","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Naush,\n\nThank you for the patch.\n\nOn Mon, Feb 07, 2022 at 03:12:14PM +0000, Naushir Patuck wrote:\n> With the controller algorithms running at 60fps, there are some dropped frames\n> when running at very high famerates. Reducing this to 30fps eliminates all these\n> drops without any noticeable changes to the image quality.\n> \n> Signed-off-by: Naushir Patuck \n\nThis appears reasonable to me,\n\nReviewed-by: Laurent Pinchart \n\nA review from David would be nice too.\n\n> ---\n> src/ipa/raspberrypi/raspberrypi.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/ipa/raspberrypi/raspberrypi.cpp b/src/ipa/raspberrypi/raspberrypi.cpp\n> index a72d516f84ee..fd8fecb07f81 100644\n> --- a/src/ipa/raspberrypi/raspberrypi.cpp\n> +++ b/src/ipa/raspberrypi/raspberrypi.cpp\n> @@ -70,7 +70,7 @@ constexpr Duration defaultMaxFrameDuration = 250.0s;\n> * we rate-limit the controller Prepare() and Process() calls to lower than or\n> * equal to this rate.\n> */\n> -constexpr Duration controllerMinFrameDuration = 1.0s / 60.0;\n> +constexpr Duration controllerMinFrameDuration = 1.0s / 30.0;\n> \n> LOG_DEFINE_CATEGORY(IPARPI)\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id DDA06BF415\n\tfor ;\n\tMon, 7 Feb 2022 23:42:04 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2BBF861071;\n\tTue, 8 Feb 2022 00:42:04 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 33F86609B9\n\tfor ;\n\tTue, 8 Feb 2022 00:42:02 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 9244E97;\n\tTue, 8 Feb 2022 00:42:01 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"k4OMSh0R\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1644277321;\n\tbh=2JyGLNYwRk20RblEMk9TBcGKVC9tcT9IFTVkPgL29Co=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=k4OMSh0RWdFlu9nt7/lsMbfPYAR0v/xokyNLRvwi2vrPQO6US6y8HccFz58roF3vq\n\tpoVg3dfxPwrzyclulzykZsjAJRifOgX7ikUxlyoer9U4QDaP2mAmtUyok5j69kL60h\n\tYEqyGENvMp5mYu5bF0OU4jONwjRmJl5mzfOsZsBo=","Date":"Tue, 8 Feb 2022 01:41:59 +0200","From":"Laurent Pinchart ","To":"Naushir Patuck ","Message-ID":"","References":"<20220207151214.887140-1-naush@raspberrypi.com>\n\t<20220207151214.887140-3-naush@raspberrypi.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20220207151214.887140-3-naush@raspberrypi.com>","Subject":"Re: [libcamera-devel] [PATCH 3/3] ipa: raspberrypi: Reduce the\n\tcontroller rate to 30fps","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":22153,"web_url":"https://patchwork.libcamera.org/comment/22153/","msgid":"","date":"2022-02-09T09:35:22","subject":"Re: [libcamera-devel] [PATCH 3/3] ipa: raspberrypi: Reduce the\n\tcontroller rate to 30fps","submitter":{"id":42,"url":"https://patchwork.libcamera.org/api/people/42/","name":"David Plowman","email":"david.plowman@raspberrypi.com"},"content":"Hi Naush\n\nYes, I'm fine with this too.\n\nOn Mon, 7 Feb 2022 at 23:42, Laurent Pinchart\n wrote:\n>\n> Hi Naush,\n>\n> Thank you for the patch.\n>\n> On Mon, Feb 07, 2022 at 03:12:14PM +0000, Naushir Patuck wrote:\n> > With the controller algorithms running at 60fps, there are some dropped frames\n> > when running at very high famerates. Reducing this to 30fps eliminates all these\n> > drops without any noticeable changes to the image quality.\n> >\n> > Signed-off-by: Naushir Patuck \n>\n> This appears reasonable to me,\n>\n> Reviewed-by: Laurent Pinchart \n>\n> A review from David would be nice too.\n\nReviewed-by: David Plowman \n\nThanks!\n\nDavid\n\n>\n> > ---\n> > src/ipa/raspberrypi/raspberrypi.cpp | 2 +-\n> > 1 file changed, 1 insertion(+), 1 deletion(-)\n> >\n> > diff --git a/src/ipa/raspberrypi/raspberrypi.cpp b/src/ipa/raspberrypi/raspberrypi.cpp\n> > index a72d516f84ee..fd8fecb07f81 100644\n> > --- a/src/ipa/raspberrypi/raspberrypi.cpp\n> > +++ b/src/ipa/raspberrypi/raspberrypi.cpp\n> > @@ -70,7 +70,7 @@ constexpr Duration defaultMaxFrameDuration = 250.0s;\n> > * we rate-limit the controller Prepare() and Process() calls to lower than or\n> > * equal to this rate.\n> > */\n> > -constexpr Duration controllerMinFrameDuration = 1.0s / 60.0;\n> > +constexpr Duration controllerMinFrameDuration = 1.0s / 30.0;\n> >\n> > LOG_DEFINE_CATEGORY(IPARPI)\n> >\n>\n> --\n> Regards,\n>\n> Laurent Pinchart","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 79937BF415\n\tfor ;\n\tWed, 9 Feb 2022 09:35:35 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id DC81160E66;\n\tWed, 9 Feb 2022 10:35:34 +0100 (CET)","from mail-wr1-x436.google.com (mail-wr1-x436.google.com\n\t[IPv6:2a00:1450:4864:20::436])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 861B360202\n\tfor ;\n\tWed, 9 Feb 2022 10:35:33 +0100 (CET)","by mail-wr1-x436.google.com with SMTP id s18so2943708wrv.7\n\tfor ;\n\tWed, 09 Feb 2022 01:35:33 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"HlmDlZ/+\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=DZbzO6kan+S00RYtXf62mLGdJa/kNHj5Zxg/urLZcnM=;\n\tb=HlmDlZ/+i3TAvAiKXJ420ua9R/w14obJAfsBFESRBJLcJ7wg6ilB2Wq15aJen9ZV9E\n\tmb1O2nGdDkj+Cw+2vVnU2ngCGamSJqApOXN8GDQoUQW52hu1hPn6FFRdBstIj/oUS/PL\n\txfDiCv/kuF55g/6qmXD84g+vvbhfXxCb2ZCPYLEZ49yeG97exHT4wWB2/0oD7tUoKy2I\n\tGNM7fm7ggUqaB/ATPpG38+FFPCqyRh9t5LztmH7FW6Xy3ihU9h0j3hInU2b8xieJbzc8\n\tgW+YN707z1tkDKbaNQuoLAm4GrAV4SiCX5Sw8710F/S84P9eYOsdYofmPJLhXNT+tsIB\n\tJPFQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=DZbzO6kan+S00RYtXf62mLGdJa/kNHj5Zxg/urLZcnM=;\n\tb=2MI94snY+94y9sED5BbL6us5z7/xfDYyY8hTZSbLqv89bMkjOlySgG0rGn1f3H4V+e\n\tKnLOZBQjQ9dV6LmjEFZWJ1tWKasmDH7Y+OGBCdLqHTOHPLTFOUpbcnOPWcVubmfASTeo\n\tIOl6rkqubLYhcyJ0u5XVumUzT2et1cKeoNoB5r1GgDeBPoMKaXh9ooE71f+n6Wc+aAEw\n\t3/lNKjoL/S6bnvDHHgIZkxBzpaJDYLJ8rikIrNrfutCIApXIEJM1aksi+PT8i1jz0JBA\n\t//31P9//ZI1oZetsJj0ga4dY3ql8zLNWr3JrFeEM4wJ4fqJkMSJE7j3L1Vjsv3LOh6c/\n\tf8pw==","X-Gm-Message-State":"AOAM530X2bbL8oF1HGrycsBVWA5INDy2IcWyYbP21sOPvBS4r3hcLCFq\n\t0av8Jso834Rv8QoKDPUY4DD+3p+52E0OOeOHtUOabA==","X-Google-Smtp-Source":"ABdhPJzp8HEgH/h+sr8oHN+l1/3ylIk60gP4oyytvjQPZJ/Ua3ZunbmiqXaeqNlcvf1C7SlEP5u8+c0QiWcRkRyxaOY=","X-Received":"by 2002:a05:6000:178d:: with SMTP id\n\te13mr1293564wrg.317.1644399333046; \n\tWed, 09 Feb 2022 01:35:33 -0800 (PST)","MIME-Version":"1.0","References":"<20220207151214.887140-1-naush@raspberrypi.com>\n\t<20220207151214.887140-3-naush@raspberrypi.com>\n\t","In-Reply-To":"","From":"David Plowman ","Date":"Wed, 9 Feb 2022 09:35:22 +0000","Message-ID":"","To":"Laurent Pinchart ","Content-Type":"text/plain; charset=\"UTF-8\"","Subject":"Re: [libcamera-devel] [PATCH 3/3] ipa: raspberrypi: Reduce the\n\tcontroller rate to 30fps","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]